Re: [FFmpeg-devel] [PATCH v8 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-06-08 Thread Nicolas George
Jun Li (12019-06-07): > I think a complete validation should be creating a function like "atodigit" > , string to digit, instead of using atoi, The problem of validation is a common one, and as such it already has a solution. APPLICATION USAGE The atoi() function is subsumed by strtol() but

[FFmpeg-devel] [PATCH 3/4] avformat/wsddec: Fix undefined shift

2019-06-08 Thread Michael Niedermayer
Fixes: left shift of 1 by 31 places cannot be represented in type 'int' Fixes: 15123/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5738039235575808 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 1/4] avformat/tiertexseq: Move seq_read_close() up so it can be used for cleanup

2019-06-08 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/tiertexseq.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/libavformat/tiertexseq.c b/libavformat/tiertexseq.c index e861869ad3..a35e08ef50 100644 --- a/libavformat/tiertexseq.c +++ b/libavformat/tie

[FFmpeg-devel] [PATCH 2/4] avformat/tiertexseq: Cleanup on error

2019-06-08 Thread Michael Niedermayer
Fixes: memleak Fixes: 15122/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-568596463616 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/tiertexseq.c | 16 1 file ch

[FFmpeg-devel] [PATCH 4/4] avformat/icodec: Free ico->images on error paths

2019-06-08 Thread Michael Niedermayer
Fixes: 15116/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5715173567889408 Fixes: memleak Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/icodec.c | 10 -- 1 file changed, 8 i

[FFmpeg-devel] [PATCH v2] avcodec/h264_sei: Add acces to truncated SEI data

2019-06-08 Thread Antonin Gouzer
--- Some codecs editors had miss interpreted the H264 standart and have coded a wrong size in the SEI data. size = SEI size + 1. The SEI data is detected as "truncated" Ex: https://drive.google.com/file/d/1cNtLwnfPnyJnYqE7OYhU3SCoLRtuXIUM/view?usp=sharing Command: ffprobe -print_format xml -show_f

Re: [FFmpeg-devel] yuv420_bgr24_mmxext conversion taking significant time

2019-06-08 Thread Adrian Tong
On Fri, 7 Jun 2019 at 23:20, Lauri Kasanen wrote: > On Fri, 7 Jun 2019 08:38:35 -0700 > Adrian Tong wrote: > > > Hi > > > > I have a workload which spends a significant amount of time (~10%) in > > the yuv420_bgr24_mmxext function in FFMEPG. > > > > I looked at the assembly and profile and see M

[FFmpeg-devel] [PATCH V1 1/2] doc/formats: document f_strict/strict for AVFormatContext

2019-06-08 Thread Jun Zhao
From: Jun Zhao document f_strict/strict option for AVFormatContext Signed-off-by: Jun Zhao --- doc/formats.texi | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/doc/formats.texi b/doc/formats.texi index a992506..729c77b 100644 --- a/doc/formats.tex

[FFmpeg-devel] [PATCH V1 2/2] doc/fftools-common-opts: document ffmpeg -h bsf=bitstream_filter_name

2019-06-08 Thread Jun Zhao
From: Jun Zhao document ffmpeg -h bsf=bitstream_filter_name Signed-off-by: Jun Zhao --- doc/fftools-common-opts.texi |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi index 4c821ba..1234de8 100644 --- a/doc/f

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_sei: Add acces to truncated SEI data

2019-06-08 Thread Reimar Döffinger
looks good to me if maintainer has no objections... On 08.06.2019, at 15:21, Antonin Gouzer wrote: > --- > Some codecs editors had miss interpreted the H264 standart and > have coded a wrong size in the SEI data. > size = SEI size + 1. > The SEI data is detected as "truncated" > Ex: > https://d

Re: [FFmpeg-devel] [PATCH 3/4] avformat/wsddec: Fix undefined shift

2019-06-08 Thread Reimar Döffinger
On 08.06.2019, at 11:28, Michael Niedermayer wrote: > Fixes: left shift of 1 by 31 places cannot be represented in type 'int' > Fixes: > 15123/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5738039235575808 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/t

Re: [FFmpeg-devel] yuv420_bgr24_mmxext conversion taking significant time

2019-06-08 Thread Lauri Kasanen
On Sat, 8 Jun 2019 06:51:51 -0700 Adrian Tong wrote: > Hi Lauri. > > Thanks for the reply, any reason why this has not been implemented before ? > it seems to me that this would be a pretty important/hot function. Just the usual, nobody has had the interest. There are other places too where the

Re: [FFmpeg-devel] yuv420_bgr24_mmxext conversion taking significant time

2019-06-08 Thread Adrian Tong
On Sat, 8 Jun 2019 at 09:38, Lauri Kasanen wrote: > On Sat, 8 Jun 2019 06:51:51 -0700 > Adrian Tong wrote: > > > Hi Lauri. > > > > Thanks for the reply, any reason why this has not been implemented > before ? > > it seems to me that this would be a pretty important/hot function. > > Just the usu

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: log skipped initial non-keyframes

2019-06-08 Thread Moritz Barsnick
On Fri, Jun 07, 2019 at 22:35:03 +0200, Stephan Hilb wrote: > > Incorrect indentation. > > It's actually the same indentation as in other places in the same file, > what would be the correct way then? Sorry, my mind went flaky, you're corrent. > > I suggest this message should be at INFO level, b

Re: [FFmpeg-devel] [PATCH v3] libavfilter/vf_find_rect: convert the object image to gray8 format instead of failed directly

2019-06-08 Thread Michael Niedermayer
On Sat, Jun 08, 2019 at 06:53:58AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_find_rect.c | 40 +++- > 1 file changed, 27 insertions(+), 13 deletions(-) > > diff --git a/libavfilter/vf_find_re

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_sei: Add acces to truncated SEI data

2019-06-08 Thread Michael Niedermayer
On Sat, Jun 08, 2019 at 03:21:45PM +0200, Antonin Gouzer wrote: > --- > Some codecs editors had miss interpreted the H264 standart and > have coded a wrong size in the SEI data. > size = SEI size + 1. > The SEI data is detected as "truncated" This information does not end in the commit message, th

Re: [FFmpeg-devel] [PATCH v3] libavfilter/vf_find_rect: convert the object image to gray8 format instead of failed directly

2019-06-08 Thread Michael Niedermayer
On Sat, Jun 08, 2019 at 06:53:58AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_find_rect.c | 40 +++- > 1 file changed, 27 insertions(+), 13 deletions(-) > > diff --git a/libavfilter/vf_find_re

[FFmpeg-devel] [PATCH v4] libavfilter/vf_find_rect: convert the object image to gray8 format instead of failed directly

2019-06-08 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_find_rect.c | 39 --- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/libavfilter/vf_find_rect.c b/libavfilter/vf_find_rect.c index d7e6579..ee6c3f4 100644 --- a/libavfilter/vf_find

Re: [FFmpeg-devel] [PATCH v3] libavfilter/vf_find_rect: convert the object image to gray8 format instead of failed directly

2019-06-08 Thread Lance Wang
On Sun, Jun 9, 2019 at 5:41 AM Michael Niedermayer wrote: > On Sat, Jun 08, 2019 at 06:53:58AM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_find_rect.c | 40 +++- > > 1 file changed, 2

Re: [FFmpeg-devel] [PATCH v3] libavfilter/vf_find_rect: convert the object image to gray8 format instead of failed directly

2019-06-08 Thread Lance Wang
On Sun, Jun 9, 2019 at 4:38 AM Michael Niedermayer wrote: > On Sat, Jun 08, 2019 at 06:53:58AM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_find_rect.c | 40 +++- > > 1 file changed, 2

Re: [FFmpeg-devel] [PATCHv5 2/2] VP4 video decoder

2019-06-08 Thread Peter Ross
On Sat, Jun 08, 2019 at 08:49:15AM +0200, Reimar Döffinger wrote: > > > On 08.06.2019, at 03:08, Peter Ross wrote: > > > --- > > comments against v4 patch addressed. thanks. > > > > +#if CONFIG_VP4_DECODER > > +static int vp4_get_mb_count(Vp3DecodeContext *s, GetBitContext *gb) > > +{ > > +

[FFmpeg-devel] [PATCH v9 1/2] lavf/vf_transpose: add exif orientation support

2019-06-08 Thread Jun Li
Add exif orientation support and expose an option. --- libavfilter/hflip.h| 2 + libavfilter/transpose.h| 14 libavfilter/vf_hflip.c | 40 ++--- libavfilter/vf_transpose.c | 168 - 4 files changed, 192 insertions(+), 32 deletions(-)

[FFmpeg-devel] [PATCH v9 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-06-08 Thread Jun Li
Fix #6945 Rotate or/and flip frame according to frame's metadata orientation --- fftools/ffmpeg.c| 5 +++-- fftools/ffmpeg.h| 8 fftools/ffmpeg_filter.c | 40 +++- 3 files changed, 46 insertions(+), 7 deletions(-) diff --git a/fftools

Re: [FFmpeg-devel] [PATCH v8 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-06-08 Thread Jun Li
On Sat, Jun 8, 2019 at 2:25 AM Nicolas George wrote: > Jun Li (12019-06-07): > > I think a complete validation should be creating a function like > "atodigit" > > , string to digit, instead of using atoi, > > The problem of validation is a common one, and as such it already has a > solution. > >

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: log skipped initial non-keyframes

2019-06-08 Thread Michael Niedermayer
On Fri, Jun 07, 2019 at 10:35:03PM +0200, Stephan Hilb wrote: > >> -!ost->copy_initial_nonkeyframes) > >> +!ost->copy_initial_nonkeyframes) { > >> +av_log(NULL, AV_LOG_DEBUG, "skipping initial > >> non-keyframe\n"); return; > > > > Incorrect indentation. > > It's actuall