[FFmpeg-devel] [PATCH 3/3] avcodec/nvenc: add more sei support for SDR HLG

2019-05-22 Thread lance . lmwang
From: Limin Wang The testing command for the HLG output with nvenc: ./ffmpeg_g -y -i 4K.mp4 -c:v hevc_nvenc -g 7 -color_primaries bt2020 -colorspace bt2020_ncl -color_trc smpte2084 -sei hlg test.ts --- libavcodec/nvenc.c | 24 libavcodec/nvenc.h | 1 + libav

[FFmpeg-devel] [PATCH 1/3] avcodec/nvenc: add more sei data support

2019-05-22 Thread lance . lmwang
From: Limin Wang --- libavcodec/nvenc.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 3fe64bba8b..75dda6d689 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -1705,7 +1705,8 @@ s

[FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: add master display and light level sei for HDR10

2019-05-22 Thread lance . lmwang
From: Limin Wang The testing command for the HDR10 output with nvenc: $ ./ffmpeg_g -y -i 4K.mp4 -c:v hevc_nvenc -g 7 -color_primaries bt2020 -colorspace bt2020_ncl -color_trc smpte2084 -sei hdr10 \ -master_display "G(13250,34500)B(7500,3000)R(34000,16000)WP(15635,16450)L(1000,50)"

[FFmpeg-devel] [PATCH] avutil/file_open: log temp filename

2019-05-22 Thread Gyan
Helps users to identify temp files for a given instance. In the longer term, we should aim to clean up all temp files. Gyan From df7ff4b80ef424922236ac991b4664533e40b678 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Wed, 22 May 2019 12:34:19 +0530 Subject: [PATCH] avutil/file_open: log temp

Re: [FFmpeg-devel] [PATCH] avutil/file_open: log temp filename

2019-05-22 Thread Liu Steven
> 在 2019年5月22日,下午3:10,Gyan 写道: > > > Helps users to identify temp files for a given instance. > > In the longer term, we should aim to clean up all temp files. > > Gyan > <0001-avutil-file_open-log-temp-filename.patch>___ Why don’t use AV_LOG_DEBUG

Re: [FFmpeg-devel] [PATCH V1 2/2] doc/writing_filters: Use ff_filter_get_nb_threads() get number of threads

2019-05-22 Thread Paul B Mahol
On 5/22/19, Jun Zhao wrote: > From: Jun Zhao > > ff_filter_get_nb_threads() respect AVFilterContext.nb_threads and > graph->nb_threads both, in most case, we perfer this API than using > ctx->graph->nb_threads directly. > --- > doc/writing_filters.txt |2 +- > 1 files changed, 1 insertions(+

Re: [FFmpeg-devel] [PATCH V1 1/2] lavfi/lensfun: Use ff_filter_get_nb_threads() get number of threads

2019-05-22 Thread Paul B Mahol
On 5/22/19, Jun Zhao wrote: > From: Jun Zhao > > ff_filter_get_nb_threads() respect AVFilterContext.nb_threads and > graph->nb_threads both, in most case, we perfer this API than using > ctx->graph->nb_threads directly. > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_lensfun.c |4 ++-- >

Re: [FFmpeg-devel] [PATCH] avutil/file_open: log temp filename

2019-05-22 Thread Gyan
On 22-05-2019 01:41 PM, Liu Steven wrote: 在 2019年5月22日,下午3:10,Gyan 写道: Helps users to identify temp files for a given instance. In the longer term, we should aim to clean up all temp files. Gyan <0001-avutil-file_open-log-temp-filename.patch>__

Re: [FFmpeg-devel] [PATCH] avutil/file_open: log temp filename

2019-05-22 Thread Hendrik Leppkes
On Wed, May 22, 2019 at 10:53 AM Gyan wrote: > > > > On 22-05-2019 01:41 PM, Liu Steven wrote: > > > >> 在 2019年5月22日,下午3:10,Gyan 写道: > >> > >> > >> Helps users to identify temp files for a given instance. > >> > >> In the longer term, we should aim to clean up all temp files. > >> > >> Gyan > >>

Re: [FFmpeg-devel] [PATCH] avutil/file_open: log temp filename

2019-05-22 Thread Steven Liu
Hendrik Leppkes 于2019年5月22日周三 下午5:05写道: > > On Wed, May 22, 2019 at 10:53 AM Gyan wrote: > > > > > > > > On 22-05-2019 01:41 PM, Liu Steven wrote: > > > > > >> 在 2019年5月22日,下午3:10,Gyan 写道: > > >> > > >> > > >> Helps users to identify temp files for a given instance. > > >> > > >> In the longer t

Re: [FFmpeg-devel] [PATCH] avutil/file_open: log temp filename

2019-05-22 Thread Gyan
On 22-05-2019 02:29 PM, Hendrik Leppkes wrote: On Wed, May 22, 2019 at 10:53 AM Gyan wrote: On 22-05-2019 01:41 PM, Liu Steven wrote: 在 2019年5月22日,下午3:10,Gyan 写道: Helps users to identify temp files for a given instance. In the longer term, we should aim to clean up all temp files. Gya

[FFmpeg-devel] [PATCH] cbs_mpeg2: Fix storage type for frame_centre_*_offset

2019-05-22 Thread Andreas Rheinhardt
The frame_centre_horizontal/vertical_offset values contained in picture display extensions are actually signed values (i.e. it is possible to indicate that the display device should add black bars/pillars). The files sony-ct3.bs and tcela-6.bits (which are both used in fate tests for mpeg2_metadat

[FFmpeg-devel] [PATCH] cbs_mpeg2: Fix parsing of picture headers

2019-05-22 Thread Andreas Rheinhardt
MPEG-2 picture and slice headers can contain optional extra information; both use the same syntax for their extra information. And cbs_mpeg2's implementations of both were buggy until recently; the one for the picture headers still is and this is fixed in this commit. The extra information in pict

Re: [FFmpeg-devel] [PATCH] avutil/file_open: log temp filename

2019-05-22 Thread Hendrik Leppkes
On Wed, May 22, 2019 at 11:51 AM Gyan wrote: > > > > On 22-05-2019 02:29 PM, Hendrik Leppkes wrote: > > On Wed, May 22, 2019 at 10:53 AM Gyan wrote: > >> > >> > >> On 22-05-2019 01:41 PM, Liu Steven wrote: > 在 2019年5月22日,下午3:10,Gyan 写道: > > > Helps users to identify temp file

[FFmpeg-devel] [PATCH v4] Fix integer parameters size check in SDP fmtp line

2019-05-22 Thread Olivier Maignial
=== PROBLEM === I was trying to record h264 + aac streams from an RTSP server to mp4 file. using this command line: ffmpeg -v verbose -y -i "rtsp:///my_resources" -codec copy -bsf:a aac_adtstoasc test.mp4 FFmpeg then fail to record audio and output this logs: [rtsp @ 0xcda1f0] The profi

Re: [FFmpeg-devel] [PATCH V1 2/2] doc/writing_filters: Use ff_filter_get_nb_threads() get number of threads

2019-05-22 Thread myp...@gmail.com
On Wed, May 22, 2019 at 4:14 PM Paul B Mahol wrote: > > On 5/22/19, Jun Zhao wrote: > > From: Jun Zhao > > > > ff_filter_get_nb_threads() respect AVFilterContext.nb_threads and > > graph->nb_threads both, in most case, we perfer this API than using > > ctx->graph->nb_threads directly. > > --- >

Re: [FFmpeg-devel] [PATCH V1 1/2] lavfi/lensfun: Use ff_filter_get_nb_threads() get number of threads

2019-05-22 Thread myp...@gmail.com
On Wed, May 22, 2019 at 4:20 PM Paul B Mahol wrote: > > On 5/22/19, Jun Zhao wrote: > > From: Jun Zhao > > > > ff_filter_get_nb_threads() respect AVFilterContext.nb_threads and > > graph->nb_threads both, in most case, we perfer this API than using > > ctx->graph->nb_threads directly. > > > > Si

[FFmpeg-devel] [PATCH] cbs_mpeg2: Fix parsing of slice headers

2019-05-22 Thread Andreas Rheinhardt
1. The extra information in slice headers was parsed incorrectly: In the first reading pass to derive the length of the extra information, one should look at bits n, n + 9, n + 18, ... and check whether they equal one (further extra information) or zero (end of extra information), but instead bits

Re: [FFmpeg-devel] [PATCH] avutil/file_open: log temp filename

2019-05-22 Thread Gyan
On 22-05-2019 03:29 PM, Hendrik Leppkes wrote: On Wed, May 22, 2019 at 11:51 AM Gyan wrote: On 22-05-2019 02:29 PM, Hendrik Leppkes wrote: On Wed, May 22, 2019 at 10:53 AM Gyan wrote: On 22-05-2019 01:41 PM, Liu Steven wrote: 在 2019年5月22日,下午3:10,Gyan 写道: Helps users to identify temp

Re: [FFmpeg-devel] [PATCH v2 04/11] cbs: Add macros to support defining unit type tables

2019-05-22 Thread Andreas Rheinhardt
Mark Thompson: > --- > libavcodec/cbs_internal.h | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/libavcodec/cbs_internal.h b/libavcodec/cbs_internal.h > index 06a8f9b979..439fa7934b 100644 > --- a/libavcodec/cbs_internal.h > +++ b/libavcodec/cbs_internal.h > @@ -14

[FFmpeg-devel] [PATCH] lavu/time.c: Fix check for clock_gettime

2019-05-22 Thread Marvin Scholz
According to the documentation [1] when checking for a symbol it should be explicitly checked against NULL and the function pointer dereferenced. [1] https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/WeakLinking.html#//apple_ref/doc/uid/20002378-106

Re: [FFmpeg-devel] [PATCH v2 05/11] cbs_h264: Use table-based alloc/free

2019-05-22 Thread Andreas Rheinhardt
Mark Thompson: > --- > libavcodec/cbs_h2645.c | 156 + > 1 file changed, 64 insertions(+), 92 deletions(-) > > diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c > index 319202fc48..e10bb2c62b 100644 > --- a/libavcodec/cbs_h2645.c > +++ b/libavcod

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method

2019-05-22 Thread Ronald S. Bultje
Hi, On Wed, May 22, 2019 at 2:12 AM Yan, CenX wrote: > Hi, Ronald > > > > Sorry to reply late. > > > > For you question, “we lack per-block reference validity checks in the > block reconstruction code”, would you mean encode process need validity > checks? > No. The decoder needs validity check

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: Fix compilation for IOS < 11.0 and OSX, < 10.13

2019-05-22 Thread Thilo Borgmann
Am 22.05.19 um 01:41 schrieb Jan Ekström: > Hi, > > On Tue, May 14, 2019 at 4:16 PM Thilo Borgmann wrote: >> >> $Subject >> >> Tested compilation only, sanity test actually using it appreciated. >> > > Thanks for the patch. To be completely fair, this is not to fix > compilation for specific tar

Re: [FFmpeg-devel] [PATCH] avutil/file_open: log temp filename

2019-05-22 Thread Hendrik Leppkes
On Wed, May 22, 2019 at 12:14 PM Gyan wrote: > > > > On 22-05-2019 03:29 PM, Hendrik Leppkes wrote: > > On Wed, May 22, 2019 at 11:51 AM Gyan wrote: > >> > >> > >> On 22-05-2019 02:29 PM, Hendrik Leppkes wrote: > >>> On Wed, May 22, 2019 at 10:53 AM Gyan wrote: > > On 22-05-2019 01:41

Re: [FFmpeg-devel] [PATCH] avutil/file_open: log temp filename

2019-05-22 Thread Gyan
On 22-05-2019 06:02 PM, Hendrik Leppkes wrote: On Wed, May 22, 2019 at 12:14 PM Gyan wrote: On 22-05-2019 03:29 PM, Hendrik Leppkes wrote: On Wed, May 22, 2019 at 11:51 AM Gyan wrote: On 22-05-2019 02:29 PM, Hendrik Leppkes wrote: On Wed, May 22, 2019 at 10:53 AM Gyan wrote: On 22-05

[FFmpeg-devel] [PATCH] avformat/cache - delete cache file after closing handle

2019-05-22 Thread Gyan
The existing practice of unlinking path immediately after acquiring file handle was returning (unchecked) EPERM error on Windows. Switched to deletion after closing handle. Confirmed that cache protocol temp files are deleted in Windows 7 when ffmpeg exits. The cache protocol calls avutil/av

Re: [FFmpeg-devel] [PATCH] avformat/cache - delete cache file after closing handle

2019-05-22 Thread Nicolas George
Gyan (12019-05-22): > > The existing practice of unlinking path immediately after acquiring file > handle was returning (unchecked) EPERM error on Windows. Switched to > deletion after closing handle. > Confirmed that cache protocol temp files are deleted in Windows 7 when > ffmpeg exits. > > The

[FFmpeg-devel] Help: Get motion vector value from previous and next frame FFMPEG

2019-05-22 Thread Boris
Apologize me if this mailing list is not for such questions. I want help, then I think that here is the best place. Can you tells me how can I do to get motion vectors values (mvx, mvy) from previous and next Frame during transcoding with MPegEncContext structure, please? For current Frame, s->p_m

[FFmpeg-devel] [PATCH] libavfilter/dnn_native: Add support of dilated convolution in dnn_native.

2019-05-22 Thread Xuewei Meng
Add dilation parameter in dnn native to support dilated convolution. Signed-off-by: Xuewei Meng --- libavfilter/dnn_backend_native.c | 17 + libavfilter/dnn_backend_native.h | 1 + 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/libavfilter/dnn_backend_native.c b

Re: [FFmpeg-devel] Help: Get motion vector value from previous and next frame FFMPEG

2019-05-22 Thread Moritz Barsnick
On Wed, May 22, 2019 at 16:06:39 +0300, Boris wrote: > Apologize me if this mailing list is not for such questions. > I want help, then I think that here is the best place. No, this is exactly the wrong place. ffmpeg-devel is for discussing the development *of* the ffmpeg tools and libraries. Fo

Re: [FFmpeg-devel] [PATCH v4] Fix integer parameters size check in SDP fmtp line

2019-05-22 Thread Moritz Barsnick
On Wed, May 22, 2019 at 12:03:55 +0200, Olivier Maignial wrote: > In SDP provided by my RTSP server I had this fmtp line: > a=fmtp:98 streamType=5; profile-level-id=40; mode=AAC-hbr; config=1188; > sizeLength=13; indexLength=3; indexDeltaLength=3; > > In FFmpeg code, I found a check introduced

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: add master display and light level sei for HDR10

2019-05-22 Thread Timo Rothenpieler
On 22.05.2019 08:59, lance.lmw...@gmail.com wrote: From: Limin Wang The testing command for the HDR10 output with nvenc: $ ./ffmpeg_g -y -i 4K.mp4 -c:v hevc_nvenc -g 7 -color_primaries bt2020 -colorspace bt2020_ncl -color_trc smpte2084 -sei hdr10 \ -master_display "G(13250,34500)B(75

Re: [FFmpeg-devel] [PATCH, v2] lavc/qsvenc: Fix the memory leak for enc_ctrl.Payload

2019-05-22 Thread Li, Zhong
> From: Fu, Linjie > Sent: Wednesday, May 22, 2019 1:50 PM > To: Li, Zhong ; FFmpeg development discussions and > patches > Subject: RE: [FFmpeg-devel] [PATCH, v2] lavc/qsvenc: Fix the memory leak > for enc_ctrl.Payload > > > -Original Message- > > From: Li, Zhong > > Sent: Monday, April

[FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-05-22 Thread Andreas Håkon
Hi, Patch to generate aligned Teletext PES packets using the MPEG-TS muxer when the TS header contains data. Regards. A.H. ---From 5b476153e0fcced53afa1b77543c2e386f08c504 Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Wed, 22 May 2019 15:36:50 +0100 Subject: [PATCH] libavformat/mpegtsenc:

Re: [FFmpeg-devel] [PATCH] avformat/cache - delete cache file after closing handle

2019-05-22 Thread Gyan
On 22-05-2019 06:37 PM, Nicolas George wrote: Gyan (12019-05-22): The existing practice of unlinking path immediately after acquiring file handle was returning (unchecked) EPERM error on Windows. Switched to deletion after closing handle. Confirmed that cache protocol temp files are deleted in

[FFmpeg-devel] [PATCH v5] Fix integer parameters size check in SDP fmtp line

2019-05-22 Thread Olivier Maignial
=== PROBLEM === I was trying to record h264 + aac streams from an RTSP server to mp4 file. using this command line: ffmpeg -v verbose -y -i "rtsp:///my_resources" -codec copy -bsf:a aac_adtstoasc test.mp4 FFmpeg then fail to record audio and output this logs: [rtsp @ 0xcda1f0] The profi

Re: [FFmpeg-devel] [PATCH] avcodec/decode: Do not output subtitle frames if the packet is marked with `AV_PKT_FLAG_DISCARD`.

2019-05-22 Thread Darren Mo
Bump. > On Apr 29, 2019, at 3:45 PM, fumoboy007 wrote: > > One situation where a subtitle packet can be marked for discard is when > demuxing an MOV file that has an edit list. > --- > libavcodec/decode.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/libavc

Re: [FFmpeg-devel] [PATCH] avcodec/decode: Do not output subtitle frames if the packet is marked with `AV_PKT_FLAG_DISCARD`.

2019-05-22 Thread Derek Buitenhuis
On 29/04/2019 23:45, fumoboy007 wrote: > One situation where a subtitle packet can be marked for discard is when > demuxing an MOV file that has an edit list. > --- > libavcodec/decode.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) Will this work properly if a given subtitl

Re: [FFmpeg-devel] [PATCH v2 03/11] cbs: Describe allocate/free methods in tabular form

2019-05-22 Thread Andreas Rheinhardt
Mark Thompson: > Unit types are split into three categories, depending on how their > content is managed: > * POD structure - these require no special treatment. > * Structure containing references to refcounted buffers - these can use > a common free function when the offsets of all the internal

Re: [FFmpeg-devel] [PATCH] avcodec/decode: Do not output subtitle frames if the packet is marked with `AV_PKT_FLAG_DISCARD`.

2019-05-22 Thread Darren Mo
Good question. The subtitle would be discarded if it overlaps an edit boundary. The root cause is the MOV demuxer currently marks boundary packets for discard. However, due to subtitle frames not being discarded (fixed by this patch), the root cause is hidden. A potential fix for the root cause

Re: [FFmpeg-devel] [PATCH v2 06/11] cbs: Add support functions for handling unit content references

2019-05-22 Thread Andreas Rheinhardt
Mark Thompson: > Use the unit type table to determine what we need to do to clone the > internals of the unit content when making copies for refcounting or > writeability. (This will still fail for units with complex content > if they do not have a defined clone function.) > > Setup and naming fr

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-22 Thread Reimar Döffinger
On Tue, May 21, 2019 at 09:30:54PM +0200, Reimar Döffinger wrote: > > +#define SHIFT(v, shift) ((v) >> (shift)) > > +#define ABS_SHIFT(v, shift) ((v) > 0 ? SHIFT(v, shift) : -SHIFT(-v, shift)) > > Don't we have something like that already? Seems we don't > I think this should rather be: > (v - (v

Re: [FFmpeg-devel] [FFMPEG DEVEL] [PATCH v4] fftools/ffprobe: Add S12M Timecode output as side data (such as SEI TC)

2019-05-22 Thread Antonin Gouzer
Hello sorry for the delay. Yes you're right. There is 3 timecodes data for one frame. One SEI data with 3 timecodes would represented by 3 side data. As far as I know there is only one timecode in the SEI data. In order to keep coherence with the schema (No simple element) , we could implement thi

[FFmpeg-devel] [FFMPEG DEVEL] [PATCH v5] fftools/ffprobe: Add S12M Timecode output as side data (such as SEI TC)

2019-05-22 Thread Antonin Gouzer
--- Change structure to conserve one SEI data=one side data with multiple timecode elements --- fftools/ffprobe.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index dea489d02e..c9c15fc205 100644 --- a/fftools/ffprobe.c +

[FFmpeg-devel] [PATCH] avcodec/ffv1dec_template: Optimize common case in run mode

2019-05-22 Thread Michael Niedermayer
Fixes: Timeout (14sec -> 9sec) Fixes: 13398/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFV1_fuzzer-5664106709778432 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ffv1dec_template.c |

Re: [FFmpeg-devel] [PATCH V2] lavfi/colorlevels: Add slice threading support

2019-05-22 Thread myp...@gmail.com
On Wed, May 22, 2019 at 12:24 PM Li, Zhong wrote: > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of Jun Zhao > > Sent: Tuesday, May 21, 2019 7:21 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Jun Zhao > > Subject: [FFmpeg-devel] [PATCH V2] lavfi/colorlevels: Add slic

Re: [FFmpeg-devel] native mode in FFmpeg DNN module

2019-05-22 Thread Guo, Yejun
> > > > > > Option 2) > > > > > > Write c code in FFmpeg to convert tensorflow file format (format 1) > > directly > > > > > into memory representation (format 3), and so we controls everything > > > > > in > > > > > ffmpeg community. And the conversion can be extended to import more > > file >

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method

2019-05-22 Thread 严小复
Hi, Ronald Sorry to reply late. For you question, “we lack per-block reference validity checks in the block reconstruction code”, I'm little confused about the red word,would you mean encode process need validity checks or there need to check the reference id of each frame? And this patch wi

[FFmpeg-devel] [PATCH] avformat/rtsp: Add -first_rtcp_ntp_time_path option to write the first NTP time to a file.

2019-05-22 Thread Jonathan Viney
Hi, The NTP time from the first RTCP packet is currently extracted in libavformat/rtsp.c and stored in AVFormatContext.start_time_realtime. However, there is no way to access this value when using ffmpeg from the commandline. This patch adds an option when using an RTSP input to write the value t

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: Add -first_rtcp_ntp_time_path option to write the first NTP time to a file.

2019-05-22 Thread Jonathan Viney
Apologies, here is the patch in text/plain. On Thu, May 23, 2019 at 4:44 PM Jonathan Viney wrote: > Hi, > > The NTP time from the first RTCP packet is currently extracted in > libavformat/rtsp.c and stored in AVFormatContext.start_time_realtime. > However, there is no way to access this value wh