Re: [FFmpeg-devel] [PATCH 1/4] swscale/ppc: VSX-optimize hScale8To19_vsx

2019-05-07 Thread Lauri Kasanen
On Tue, 30 Apr 2019 14:43:52 +0300 Lauri Kasanen wrote: > ./ffmpeg -f lavfi -i yuvtestsrc=duration=1:size=1200x1440 \ > -s 2400x720 -f rawvideo -y -vframes 5 -pix_fmt yuv420p16le -nostats > test.raw > > 2.26 speedup (x86 SSE2 is 2.32): > 23772 UNITS in hscale,4096 runs, 0 skips >

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-07 Thread Paul B Mahol
On 5/6/19, Marton Balint wrote: > > > On Mon, 6 May 2019, Marton Balint wrote: > >> >> >> On Mon, 6 May 2019, Paul B Mahol wrote: >> >>> On 5/6/19, Marton Balint wrote: On Sat, 4 May 2019, John Warburton wrote: > On Sat, May 4, 2019 at 3:34 PM Nicolas George wrote: >

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-07 Thread Moritz Barsnick
On Tue, May 07, 2019 at 01:33:08 +0200, Lynne wrote: > May 6, 2019, 11:41 PM by barsn...@gmx.net: > > Would there be a desire for a static implementation as well, for those > > using "-enable-hardcoded-tables" (CONFIG_HARDCODED_TABLES)? Just > > wondering whether that's esoteric, optional, or reall

Re: [FFmpeg-devel] [PATCH v3 1/2] fftools/ffmpeg_filter, ffplay: Add flip support to rotation

2019-05-07 Thread Moritz Barsnick
On Mon, May 06, 2019 at 22:36:41 -0700, Jun Li wrote: > +double av_display_rotation_hflip_get(const int32_t matrix[9], int *hflip) > +{ > +int32_t m[9]; > +*hflip = 0; > +memcpy(m, matrix, sizeof(int32_t) * 9); You were asked to avoid this (at another code location though). BTW, sizeof

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/mediacodecdec: try to receive a frame after signaling EOF to the codec

2019-05-07 Thread Aman Gupta
On Thu, May 2, 2019 at 1:20 AM Matthieu Bouron wrote: > On Wed, Apr 24, 2019 at 09:59:28AM +0200, Matthieu Bouron wrote: > > Avoids returning EAGAIN after signaling EOF to the codec in > > ff_mediacodec_dec_send() so we can try to receive a frame before > > returning in mediacodec_receive_frame()

Re: [FFmpeg-devel] [PATCH] avutil: Add NV24 and NV42 pixel formats

2019-05-07 Thread Manoj Bonda
Thanks philip for taking this up. LGTM. Thanks, ManojGupta. > -Original Message- > From: ffmpeg-devel On Behalf Of Philip > Langdale > Sent: Tuesday, May 7, 2019 10:03 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Philip Langdale > Subject: [FFmpeg-devel] [PATCH] avutil: Add NV24 and NV42 pi

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-07 Thread Swaraj Hota
On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote: > Hello! > Nothing major, but a few comments on things that might make > sense to polish below. > > On Sat, May 04, 2019 at 06:42:40PM +0530, Swaraj Hota wrote: > > +#define IFV_MAGIC "\x11\xd2\xd3\xab\xba\xa9\xcf\x11\ > > +\x8e\xe6

[FFmpeg-devel] [PATCH] avfilter/xstack: set better error msg for missing layout

2019-05-07 Thread Gyan
Set a better error msg than the current failure to configure output pad. From 119516fe777e1e026503a6ba176a662680d711bd Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Tue, 7 May 2019 16:00:40 +0530 Subject: [PATCH] avfilter/xstack: set better error msg for missing layout --- libavfilter/vf_stac

Re: [FFmpeg-devel] [PATCH] avfilter/xstack: set better error msg for missing layout

2019-05-07 Thread Paul B Mahol
On 5/7/19, Gyan wrote: > Set a better error msg than the current failure to configure output pad. > Please apply, but with: avfilter/vf_xstack: set better error msg for missing layout ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

Re: [FFmpeg-devel] [PATCH] avfilter/xstack: set better error msg for missing layout

2019-05-07 Thread Gyan
On 07-05-2019 04:38 PM, Paul B Mahol wrote: On 5/7/19, Gyan wrote: Set a better error msg than the current failure to configure output pad. Please apply, but with: avfilter/vf_xstack: set better error msg for missing layout Will do. Thanks, Gyan ___

Re: [FFmpeg-devel] [PATCH] avfilter/xstack: set better error msg for missing layout

2019-05-07 Thread Gyan
On 07-05-2019 04:42 PM, Gyan wrote: On 07-05-2019 04:38 PM, Paul B Mahol wrote: On 5/7/19, Gyan wrote: Set a better error msg than the current failure to configure output pad. Please apply, but with: avfilter/vf_xstack: set better error msg for missing layout Will do. Thanks, Gyan P

Re: [FFmpeg-devel] [PATCH] avfilter/xstack: set better error msg for missing layout

2019-05-07 Thread Moritz Barsnick
On Tue, May 07, 2019 at 16:26:01 +0530, Gyan wrote: > { "inputs", "set number of inputs", OFFSET(nb_inputs), AV_OPT_TYPE_INT, > {.i64=2}, 2, INT_MAX, .flags = FLAGS }, > -{ "layout", "set custom layout", OFFSET(layout), AV_OPT_TYPE_STRING, > {.str="0_0|w0_0"}, 0, 0, .flags = FLAGS }, > +

Re: [FFmpeg-devel] [PATCH V5 1/2] configure: sort decoder/encoder/filter/... names in alphabet order

2019-05-07 Thread avih
> patch1 (awk) configure: print_in_columns: replace pr with awk version: > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-May/243380.html > patch2 (shell) configure: sort decoder/encoder/filter/... names in alphabet > order (v5 as posted in this thread) > > - Why do you prefer patch1 over patch2?

Re: [FFmpeg-devel] [PATCH] avfilter/xstack: set better error msg for missing layout

2019-05-07 Thread Gyan
On 07-05-2019 05:45 PM, Moritz Barsnick wrote: On Tue, May 07, 2019 at 16:26:01 +0530, Gyan wrote: { "inputs", "set number of inputs", OFFSET(nb_inputs), AV_OPT_TYPE_INT, {.i64=2}, 2, INT_MAX, .flags = FLAGS }, -{ "layout", "set custom layout", OFFSET(layout), AV_OPT_TYPE_STRING, {

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-07 Thread Lynne
May 6, 2019, 10:26 PM by mich...@niedermayer.cc: > > also i agree with paul, the API looks good > implementation not really reviewed > > thanks > Updated the patch with the suggestions. I've changed the API to instead have a function which gives you a function pointer which you then call with th

Re: [FFmpeg-devel] [PATCH] avcodec/mlp_parser: split off shared code to its own file

2019-05-07 Thread James Almer
On 5/4/2019 4:36 PM, James Almer wrote: > On 5/4/2019 4:04 PM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/Makefile | 4 +- >> libavcodec/mlp_parse.c | 213 +++ >> libavcodec/{mlp_parser.h => mlp_parse.h} | 15

Re: [FFmpeg-devel] [PATCH] avutil: Add NV24 and NV42 pixel formats

2019-05-07 Thread Carl Eugen Hoyos
Am Di., 7. Mai 2019 um 06:33 Uhr schrieb Philip Langdale : > > These are the 4:4:4 variants of the semi-planar NV12/NV21 formats. > > I'm surprised we've not had a reason to add them until now, but > they are the format that VDPAU uses when doing interop for 4:4:4 > surfaces. Is there already a (l

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-07 Thread Michael Niedermayer
On Sun, May 05, 2019 at 08:41:28PM -0700, Jun Li wrote: > Fix #6945 > Exif extension has 'Orientaion' field for image flip and rotation. > This change is to add the first frame's exif into stream so that > autorotation would use the info to adjust the frames. > --- > fftools/ffmpeg.c | 52

Re: [FFmpeg-devel] [PATCH v2 1/2] fftools/ffmpeg_filter, ffplay: Add flip support to rotation

2019-05-07 Thread Jun Li
On Tue, May 7, 2019 at 3:10 PM Michael Niedermayer wrote: > On Sun, May 05, 2019 at 08:41:27PM -0700, Jun Li wrote: > > Current implemantion for autoratation does not support flip. > > That is, if the matrix contains flip info, the API get_rotation > > only reflects partial information. This chan

Re: [FFmpeg-devel] [PATCH v2 1/2] fftools/ffmpeg_filter, ffplay: Add flip support to rotation

2019-05-07 Thread Michael Niedermayer
On Sun, May 05, 2019 at 08:41:27PM -0700, Jun Li wrote: > Current implemantion for autoratation does not support flip. > That is, if the matrix contains flip info, the API get_rotation > only reflects partial information. This change is for adding > support for hflip (vflip can be achieved by rotat

Re: [FFmpeg-devel] [PATCH] avutil: Add NV24 and NV42 pixel formats

2019-05-07 Thread Philip Langdale
On 2019-05-07 14:43, Carl Eugen Hoyos wrote: Am Di., 7. Mai 2019 um 06:33 Uhr schrieb Philip Langdale : These are the 4:4:4 variants of the semi-planar NV12/NV21 formats. I'm surprised we've not had a reason to add them until now, but they are the format that VDPAU uses when doing interop for

Re: [FFmpeg-devel] [PATCH v2 1/2] fftools/ffmpeg_filter, ffplay: Add flip support to rotation

2019-05-07 Thread Michael Niedermayer
On Tue, May 07, 2019 at 03:15:33PM -0700, Jun Li wrote: > On Tue, May 7, 2019 at 3:10 PM Michael Niedermayer > wrote: > > > On Sun, May 05, 2019 at 08:41:27PM -0700, Jun Li wrote: > > > Current implemantion for autoratation does not support flip. > > > That is, if the matrix contains flip info, t

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-07 Thread Reimar Döffinger
On 07.05.2019, at 01:33, Lynne wrote: > May 6, 2019, 11:41 PM by barsn...@gmx.net: > >> On Mon, May 06, 2019 at 02:23:26 +0200, Lynne wrote: >> >>> This allowed for the exptabs to be computed just once on startup and >>> stored in a global array. >>> >> >> I have no real understanding of this

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-07 Thread Michael Niedermayer
On Tue, May 07, 2019 at 02:03:22AM +0200, Marton Balint wrote: > > > On Tue, 7 May 2019, Michael Niedermayer wrote: > > >On Sun, May 05, 2019 at 08:51:08PM +0200, Marton Balint wrote: > >>This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. > >> > >>I don't think it is a good idea to dr

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-07 Thread Reimar Döffinger
On 07.05.2019, at 12:00, Swaraj Hota wrote: > On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote: >> >> >>> +/*read video index*/ >>> +avio_seek(s->pb, 0xf8, SEEK_SET); >> [...] >>> +avio_skip(s->pb, ifv->vid_index->frame_offset - avio_tell(s->pb)); >> >> Why use avio

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: offset all output timestamps by same amount of first input timestamp

2019-05-07 Thread Pavel Koshevoy
On 5/7/19 8:41 PM, Pavel Koshevoy wrote: On 5/6/19 6:41 AM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- Makes ffplay display correct timestamps when seeking. ---   libavfilter/af_atempo.c | 8 +++-   1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_atempo.c

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: offset all output timestamps by same amount of first input timestamp

2019-05-07 Thread Pavel Koshevoy
On 5/6/19 6:41 AM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- Makes ffplay display correct timestamps when seeking. --- libavfilter/af_atempo.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c index bfdad7d76

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: offset all output timestamps by same amount of first input timestamp

2019-05-07 Thread Pavel Koshevoy
On 5/7/19 9:02 PM, Pavel Koshevoy wrote: On 5/7/19 8:41 PM, Pavel Koshevoy wrote: On 5/6/19 6:41 AM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- Makes ffplay display correct timestamps when seeking. ---   libavfilter/af_atempo.c | 8 +++-   1 file changed, 7 insertions(+), 1 deletio

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: offset all output timestamps by same amount of first input timestamp

2019-05-07 Thread Pavel Koshevoy
btw, I don't know if there is already a way to do this with an existing utility function... there probably is and I just don't know about it. I wrote this debugging helper to help me verify input/output PTS in atempo, I can send a patch if it's useful.  Alternatively, I'd like to know what the

[FFmpeg-devel] [PATCH] avfilter/af_atempo: Make ffplay display correct timestamps when seeking

2019-05-07 Thread Pavel Koshevoy
NOTE: this is a refinement of the patch from Paul B Mahol offset all output timestamps by same amount of first input timestamp --- libavfilter/af_atempo.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c index bfdad7d

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-07 Thread Carl Eugen Hoyos
Am Mi., 8. Mai 2019 um 00:52 Uhr schrieb Reimar Döffinger : > > On 07.05.2019, at 12:00, Swaraj Hota wrote: > > > On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote: > >> > >> > >>> +/*read video index*/ > >>> +avio_seek(s->pb, 0xf8, SEEK_SET); > >> [...] > >>> +avio_skip

Re: [FFmpeg-devel] [PATCH] avutil: Add NV24 and NV42 pixel formats

2019-05-07 Thread Carl Eugen Hoyos
Am Mi., 8. Mai 2019 um 00:20 Uhr schrieb Philip Langdale : > > On 2019-05-07 14:43, Carl Eugen Hoyos wrote: > > Am Di., 7. Mai 2019 um 06:33 Uhr schrieb Philip Langdale > > : > >> > >> These are the 4:4:4 variants of the semi-planar NV12/NV21 formats. > >> > >> I'm surprised we've not had a reason

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-07 Thread Reimar Döffinger
On 08.05.2019, at 08:01, Carl Eugen Hoyos wrote: > Am Mi., 8. Mai 2019 um 00:52 Uhr schrieb Reimar Döffinger > : >> >> On 07.05.2019, at 12:00, Swaraj Hota wrote: >> >>> On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote: > +/*read video index*/ > +avi

[FFmpeg-devel] [PATCH v4 1/2] fftools/ffmpeg_filter, ffplay: Add flip support to rotation

2019-05-07 Thread Jun Li
Current implemantion for autoratation does not support flip. That is, if the matrix contains flip info, the API get_rotation only reflects partial information. This change is for adding support for hflip (vflip can be achieved by rotation+hflip). --- fftools/cmdutils.c| 4 ++-- fftools/cm

[FFmpeg-devel] [PATCH v4 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-07 Thread Jun Li
Fix #6945 Exif extension has 'Orientaion' field for image flip and rotation. This change is to add the first frame's exif into stream so that autorotation would use the info to adjust the frames. --- fftools/ffmpeg.c | 57 +++- 1 file changed, 56 inserti

Re: [FFmpeg-devel] [PATCH v3 1/2] fftools/ffmpeg_filter, ffplay: Add flip support to rotation

2019-05-07 Thread Jun Li
On Tue, May 7, 2019 at 2:04 AM Moritz Barsnick wrote: > On Mon, May 06, 2019 at 22:36:41 -0700, Jun Li wrote: > > +double av_display_rotation_hflip_get(const int32_t matrix[9], int > *hflip) > > +{ > > +int32_t m[9]; > > +*hflip = 0; > > +memcpy(m, matrix, sizeof(int32_t) * 9); > > Yo

Re: [FFmpeg-devel] [PATCH v4 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-07 Thread Gyan
On 08-05-2019 11:54 AM, Jun Li wrote: Fix #6945 Exif extension has 'Orientaion' field for image flip and rotation. This change is to add the first frame's exif into stream so that autorotation would use the info to adjust the frames. Suggest commit msg should be " 'Orientation' field from E

Re: [FFmpeg-devel] [PATCH v4 1/2] fftools/ffmpeg_filter, ffplay: Add flip support to rotation

2019-05-07 Thread Jun Li
On Tue, May 7, 2019 at 11:24 PM Jun Li wrote: > Current implemantion for autoratation does not support flip. > That is, if the matrix contains flip info, the API get_rotation > only reflects partial information. This change is for adding > support for hflip (vflip can be achieved by rotation+hfli

Re: [FFmpeg-devel] [PATCH v4 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-07 Thread Jun Li
On Tue, May 7, 2019 at 11:40 PM Gyan wrote: > > > On 08-05-2019 11:54 AM, Jun Li wrote: > > Fix #6945 > > Exif extension has 'Orientaion' field for image flip and rotation. > > This change is to add the first frame's exif into stream so that > > autorotation would use the info to adjust the frame