[FFmpeg-devel] [PATCH v3] avcodec: add AV_CODEC_FLAG_DROPCHANGED to flags

2019-04-16 Thread Gyan
Patch revised as per http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-April/242591.html Gyan From d97a89d0335cc6d11f111a7a6bebc891501837d2 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sun, 14 Apr 2019 22:12:25 +0530 Subject: [PATCH v3] avcodec: add AV_CODEC_FLAG_DROPCHANGED to flags Discar

Re: [FFmpeg-devel] [PATCH V1 2/2] lavf: bump version/add Changelog entry when cleanup applehttp

2019-04-16 Thread Paul B Mahol
On 4/16/19, Jun Zhao wrote: > From: Jun Zhao > > commit abfeba9 "lavf/hls: Cleanup the applehttp" missed > the version bump and Changelog entry. > > Signed-off-by: Jun Zhao > --- > Changelog |1 + > libavformat/version.h |2 +- > 2 files changed, 2 insertions(+), 1 deletions

Re: [FFmpeg-devel] [PATCH V1 2/2] lavf: bump version/add Changelog entry when cleanup applehttp

2019-04-16 Thread Hendrik Leppkes
On Tue, Apr 16, 2019 at 7:57 AM Jun Zhao wrote: > > From: Jun Zhao > > commit abfeba9 "lavf/hls: Cleanup the applehttp" missed > the version bump and Changelog entry. > > Signed-off-by: Jun Zhao > --- > Changelog |1 + > libavformat/version.h |2 +- > 2 files changed, 2 inse

Re: [FFmpeg-devel] [PATCH V1 2/2] lavf: bump version/add Changelog entry when cleanup applehttp

2019-04-16 Thread myp...@gmail.com
On Tue, Apr 16, 2019 at 4:42 PM Hendrik Leppkes wrote: > > On Tue, Apr 16, 2019 at 7:57 AM Jun Zhao wrote: > > > > From: Jun Zhao > > > > commit abfeba9 "lavf/hls: Cleanup the applehttp" missed > > the version bump and Changelog entry. > > > > Signed-off-by: Jun Zhao > > --- > > Changelog

Re: [FFmpeg-devel] [PATCH V1 2/2] lavf: bump version/add Changelog entry when cleanup applehttp

2019-04-16 Thread Carl Eugen Hoyos
2019-04-16 10:52 GMT+02:00, myp...@gmail.com : > On Tue, Apr 16, 2019 at 4:42 PM Hendrik Leppkes wrote: >> >> On Tue, Apr 16, 2019 at 7:57 AM Jun Zhao wrote: >> > >> > From: Jun Zhao >> > >> > commit abfeba9 "lavf/hls: Cleanup the applehttp" missed >> > the version bump and Changelog entry. >> >

Re: [FFmpeg-devel] [PATCH V1 2/2] lavf: bump version/add Changelog entry when cleanup applehttp

2019-04-16 Thread Hendrik Leppkes
On Tue, Apr 16, 2019 at 10:58 AM Carl Eugen Hoyos wrote: > > 2019-04-16 10:52 GMT+02:00, myp...@gmail.com : > > On Tue, Apr 16, 2019 at 4:42 PM Hendrik Leppkes wrote: > >> > >> On Tue, Apr 16, 2019 at 7:57 AM Jun Zhao wrote: > >> > > >> > From: Jun Zhao > >> > > >> > commit abfeba9 "lavf/hls: C

Re: [FFmpeg-devel] [PATCH V1 2/2] lavf: bump version/add Changelog entry when cleanup applehttp

2019-04-16 Thread Carl Eugen Hoyos
2019-04-16 11:32 GMT+02:00, Hendrik Leppkes : > On Tue, Apr 16, 2019 at 10:58 AM Carl Eugen Hoyos > wrote: >> >> 2019-04-16 10:52 GMT+02:00, myp...@gmail.com : >> > On Tue, Apr 16, 2019 at 4:42 PM Hendrik Leppkes >> > wrote: >> >> >> >> On Tue, Apr 16, 2019 at 7:57 AM Jun Zhao wrote: >> >> > >>

Re: [FFmpeg-devel] [PATCH v2] lavfi: add colorkey_opencl filter

2019-04-16 Thread Timo Rothenpieler
More a general question regarding OpenCL filters than related to this specific one. We are not integrating OpenCL acceleration into the relevant native filter anymore, like the very old original OpenCL infra worked, are we? So that vf_colorkey would just use OpenCL acceleration on its own whenev

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: Disable streaming for webm output

2019-04-16 Thread Jeyapal, Karthick via ffmpeg-devel
On 4/10/19 12:09 PM, Karthick J wrote: > Currently streaming for webm output doesn't work. > Disabling explicitly will make sure that the manifest will get generated > correctly. > --- > libavformat/dashenc.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/dashenc.c b/l

Re: [FFmpeg-devel] [PATCH 1/8] libavfilter/dnn_backend_tf.c: set layer_add_res for input layer

2019-04-16 Thread Steven Liu
> 在 2019年4月2日,22:28,Guo, Yejun 写道: > > otherwise, the following check will return error if layer_add_res > is randomly initialized. > > Signed-off-by: Guo, Yejun > --- > libavfilter/dnn_backend_tf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/dnn_backend_tf.c b/libavf

Re: [FFmpeg-devel] [PATCH 4/8] libavfilter/dnn: determine dnn output during execute_model instead of set_input_output

2019-04-16 Thread Steven Liu
> 在 2019年4月2日,22:29,Guo, Yejun 写道: > > Currently, within interface set_input_output, the dims/memory of the > tensorflow > dnn model output is determined by executing the model with zero input, > actually, the output dims might vary with different input data for networks > such as object detec

Re: [FFmpeg-devel] [PATCH 4/8] libavfilter/dnn: determine dnn output during execute_model instead of set_input_output

2019-04-16 Thread Steven Liu
> 在 2019年4月2日,22:29,Guo, Yejun 写道: > > Currently, within interface set_input_output, the dims/memory of the > tensorflow > dnn model output is determined by executing the model with zero input, > actually, the output dims might vary with different input data for networks > such as object detec

Re: [FFmpeg-devel] [PATCH] mxfdec: Constrain run-in to 64k

2019-04-16 Thread Tomas Härdin
tis 2019-04-16 klockan 00:41 +0200 skrev Carl Eugen Hoyos: > > 2019-04-16 0:00 GMT+02:00, Tomas Härdin : > > mån 2019-04-15 klockan 12:40 +0200 skrev Carl Eugen Hoyos: > > > > > > > > 2019-04-15 10:30 GMT+02:00, Tomas Härdin : > > > > This isn't likely to be a huge problem, but it allows us to reas

Re: [FFmpeg-devel] [PATCH] mxfdec: Constrain run-in to 64k

2019-04-16 Thread Paul B Mahol
On 4/16/19, Tomas Härdin wrote: > tis 2019-04-16 klockan 00:41 +0200 skrev Carl Eugen Hoyos: >> > 2019-04-16 0:00 GMT+02:00, Tomas Härdin : >> > mån 2019-04-15 klockan 12:40 +0200 skrev Carl Eugen Hoyos: >> > > > > > > > 2019-04-15 10:30 GMT+02:00, Tomas Härdin >> > > > > > > > : >> > > > This isn

Re: [FFmpeg-devel] [PATCH] mxfdec: Constrain run-in to 64k

2019-04-16 Thread Carl Eugen Hoyos
2019-04-16 14:44 GMT+02:00, Tomas Härdin : > tis 2019-04-16 klockan 00:41 +0200 skrev Carl Eugen Hoyos: >> > 2019-04-16 0:00 GMT+02:00, Tomas Härdin : >> > mån 2019-04-15 klockan 12:40 +0200 skrev Carl Eugen Hoyos: >> > > > > > > > 2019-04-15 10:30 GMT+02:00, Tomas Härdin >> > > > > > > > : >> > >

[FFmpeg-devel] [PATCH 4/4] avcodec/jpeg2000dec: Check PLT data somewhat

2019-04-16 Thread Michael Niedermayer
Fixes: Timeout (21sec -> 0.6sec) Fixes: 14134/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5768371078955008 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpeg2000dec.c |

[FFmpeg-devel] [PATCH 1/4] avutil/avstring: Fix bug and undefined behavior in av_strncasecmp()

2019-04-16 Thread Michael Niedermayer
The function in case of n=0 would read more bytes than 0. The end pointer could be beyond the allocated space, which is undefined. Signed-off-by: Michael Niedermayer --- libavutil/avstring.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavutil/avstring.c b/libavutil

[FFmpeg-devel] [PATCH 2/4] avcodec/jpeg2000: Check stepsize before using it

2019-04-16 Thread Michael Niedermayer
Fixes: value 1.87633e+10 is outside the range of representable values of type 'int' Fixes: Undefined behavior Fixes: 14246/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5758393601490944 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/proje

[FFmpeg-devel] [PATCH 3/4] avcodec/jpeg2000dec: Replace the step_x/y assert by a check in the CPRL case as with the PCRL case

2019-04-16 Thread Michael Niedermayer
Fixes: assertion failure Fixes: 14246/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5758393601490944 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpeg2000dec.c | 5 -

Re: [FFmpeg-devel] [PATCH] mxfdec: Constrain run-in to 64k

2019-04-16 Thread Tomas Härdin
tis 2019-04-16 klockan 15:29 +0200 skrev Carl Eugen Hoyos: > > 2019-04-16 14:44 GMT+02:00, Tomas Härdin : > > tis 2019-04-16 klockan 00:41 +0200 skrev Carl Eugen Hoyos: > > > > > > > > 2019-04-16 0:00 GMT+02:00, Tomas Härdin : > > > > mån 2019-04-15 klockan 12:40 +0200 skrev Carl Eugen Hoyos: > > >

Re: [FFmpeg-devel] [PATCH 1/4] avutil/avstring: Fix bug and undefined behavior in av_strncasecmp()

2019-04-16 Thread Paul B Mahol
On 4/16/19, Michael Niedermayer wrote: > The function in case of n=0 would read more bytes than 0. > The end pointer could be beyond the allocated space, which > is undefined. > > Signed-off-by: Michael Niedermayer > --- > libavutil/avstring.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 dele

[FFmpeg-devel] [PATCH] libavfilter/f_select: response file support

2019-04-16 Thread Jonathan Gilbert
Hello :-) I had a project recently where I wanted to externally specify a list of specific frame numbers to drop. I understand this can be done with select expressions like "not(eq(n,45)+eq(n,47)+eq(n,75))", but in my case I wanted to drop nearly 16,000 frames, which would have required a command-

Re: [FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

2019-04-16 Thread James Almer
On 4/11/2019 12:10 AM, James Almer wrote: > On 4/10/2019 3:30 PM, James Almer wrote: >> The spec defines the valid range of values to be INT32_MIN + 1 to INT32_MAX, >> inclusive. >> >> Signed-off-by: James Almer >> --- >> A good example of why making offsets and sizes of structs like this tied to

[FFmpeg-devel] Need help with FFmpeg javacpp-presets

2019-04-16 Thread sourabh jain
Hi , can someone here , help me with Impossible to convert between the formats supported by the filter 'Parsed_ebur128_0' and the filter 'auto_resampler_0 explained my situation here : https://github.com/bytedeco/javacpp-presets/issues/715 issue comes when try to call avfilter_graph_config(fil

Re: [FFmpeg-devel] Need help with FFmpeg javacpp-presets

2019-04-16 Thread Lou Logan
On Tue, Apr 16, 2019, at 10:27 AM, sourabh jain wrote: > Hi , > > can someone here , help me with > Impossible to convert between the formats supported by the filter > 'Parsed_ebur128_0' and the filter 'auto_resampler_0 > explained my situation here : > > https://github.com/bytedeco/javacpp-prese

[FFmpeg-devel] [PATCH] avfilter: add audio soft clip filter

2019-04-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 22 libavfilter/Makefile | 1 + libavfilter/af_asoftclip.c | 206 + libavfilter/allfilters.c | 1 + 4 files changed, 230 insertions(+) create mode 100644 libavfilter/af_asoftclip.c

Re: [FFmpeg-devel] [PATCH V2 2/2] lavfi/opencl: add nlmeans_opencl filter

2019-04-16 Thread Mark Thompson
On 12/04/2019 16:09, Ruiling Song wrote: > Signed-off-by: Ruiling Song I can't work out where the problem is, but there is something really weirdly nondeterministic going on here. E.g. $ ./ffmpeg_g -y -init_hw_device opencl:0.0 -i ~/video/test/jellyfish-120-mbps-4k-uhd-hevc-10bit.mkv -an -fil

Re: [FFmpeg-devel] [PATCH V2 1/2] lavfi/opencl: add more opencl helper macro

2019-04-16 Thread Mark Thompson
On 12/04/2019 16:09, Ruiling Song wrote: > Signed-off-by: Ruiling Song > --- > libavfilter/opencl.h | 38 ++ > 1 file changed, 38 insertions(+) > > diff --git a/libavfilter/opencl.h b/libavfilter/opencl.h > index 0b06232ade..0fa5b49d3f 100644 > --- a/libavfilt

Re: [FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

2019-04-16 Thread Mark Thompson
On 11/04/2019 04:10, James Almer wrote: > On 4/10/2019 3:30 PM, James Almer wrote: >> The spec defines the valid range of values to be INT32_MIN + 1 to INT32_MAX, >> inclusive. >> >> Signed-off-by: James Almer >> --- >> A good example of why making offsets and sizes of structs like this tied to

Re: [FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

2019-04-16 Thread James Almer
On 4/16/2019 6:48 PM, Mark Thompson wrote: > On 11/04/2019 04:10, James Almer wrote: >> On 4/10/2019 3:30 PM, James Almer wrote: >>> The spec defines the valid range of values to be INT32_MIN + 1 to >>> INT32_MAX, inclusive. >>> >>> Signed-off-by: James Almer >>> --- >>> A good example of why mak

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: add support for Scalability Metadata

2019-04-16 Thread Mark Thompson
On 14/04/2019 23:04, James Almer wrote: > Signed-off-by: James Almer > --- > This will make the AV1RawObu struct weigh about ~3kb instead of ~1kb. > > libavcodec/av1.h | 33 > libavcodec/cbs_av1.h | 15 +- > libavcodec/cbs_av1_synt

Re: [FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

2019-04-16 Thread Baptiste Coudurier
> On Apr 16, 2019, at 3:01 PM, James Almer wrote: > > On 4/16/2019 6:48 PM, Mark Thompson wrote: >> On 11/04/2019 04:10, James Almer wrote: >>> On 4/10/2019 3:30 PM, James Almer wrote: The spec defines the valid range of values to be INT32_MIN + 1 to INT32_MAX, inclusive. Si

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Skip stsd adjustment without chunks

2019-04-16 Thread Michael Niedermayer
Fixes: Assertion failure Fixes: clusterfuzz-testcase-minimized-media_pipeline_integration_fuzzer-5683096400822272 Found-by: Clusterfuzz Reported-by: Dan Sanders Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/li

[FFmpeg-devel] [PATCH 2/2] avformat/aadec: Check for scanf() failure

2019-04-16 Thread Michael Niedermayer
Fixes: use of uninitialized variables Fixes: blank.aa Found-by: Chamal De Silva Signed-off-by: Michael Niedermayer --- libavformat/aadec.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/aadec.c b/libavformat/aadec.c index dc94061dcf..b9dd51ebfc 100644 ---

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: add support for Scalability Metadata

2019-04-16 Thread James Almer
On 4/16/2019 7:05 PM, Mark Thompson wrote: > On 14/04/2019 23:04, James Almer wrote: >> Signed-off-by: James Almer >> --- >> This will make the AV1RawObu struct weigh about ~3kb instead of ~1kb. >> >> libavcodec/av1.h | 33 >> libavcodec/cbs_av1.h

Re: [FFmpeg-devel] [PATCH] mxfdec: Constrain run-in to 64k

2019-04-16 Thread Michael Niedermayer
On Tue, Apr 16, 2019 at 12:03:48AM +0200, Tomas Härdin wrote: > mån 2019-04-15 klockan 23:03 +0200 skrev Marton Balint: > > > > On Mon, 15 Apr 2019, Tomas Härdin wrote: > > > > > This isn't likely to be a huge problem, but it allows us to reason more > > > about run-in. It also exposes my gripe a

Re: [FFmpeg-devel] [PATCH V1] lavf/oggparsevorbis: Fix change the case of metadata keys issue

2019-04-16 Thread Michael Niedermayer
On Tue, Apr 16, 2019 at 09:33:08AM +0800, myp...@gmail.com wrote: > On Tue, Apr 16, 2019 at 5:51 AM Michael Niedermayer > wrote: > > > > On Mon, Apr 15, 2019 at 09:58:30AM +0800, Jun Zhao wrote: > > > From: Jun Zhao > > > > > > The spec in https://xiph.org/vorbis/doc/v-comment.html states that >

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

2019-04-16 Thread Mark Thompson
On 15/04/2019 22:17, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs.c | 79 +++ > libavcodec/cbs_internal.h | 20 +- > 2 files changed, 98 insertions(+), 1 deletion(-) Looks like a sensible addition, some comments below

Re: [FFmpeg-devel] [PATCH] libavfilter/f_select: response file support

2019-04-16 Thread Michael Niedermayer
On Tue, Apr 16, 2019 at 12:14:13PM -0500, Jonathan Gilbert wrote: > Hello :-) > > I had a project recently where I wanted to externally specify a list > of specific frame numbers to drop. I understand this can be done with > select expressions like "not(eq(n,45)+eq(n,47)+eq(n,75))", but in my > ca

Re: [FFmpeg-devel] [PATCH] libavfilter/f_select: response file support

2019-04-16 Thread Carl Eugen Hoyos
2019-04-16 19:14 GMT+02:00, Jonathan Gilbert : > Hello :-) > > I had a project recently where I wanted to externally specify a list > of specific frame numbers to drop. I understand this can be done with > select expressions like "not(eq(n,45)+eq(n,47)+eq(n,75))", but in my > case I wanted to drop

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

2019-04-16 Thread James Almer
On 4/16/2019 7:45 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/cbs.c | 79 +++ >> libavcodec/cbs_internal.h | 20 +- >> 2 files changed, 98 insertions(+), 1 deletion(-) >

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cbs_h2645: add helper macros for signed values

2019-04-16 Thread Mark Thompson
On 15/04/2019 22:17, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs_h2645.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c > index e74f8dce81..a205293b3c 100644 > --- a/libavcodec/cbs_h2645.c

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/cbs_h264: fix storage type for time_offset in Pic Timing SEI

2019-04-16 Thread Mark Thompson
On 15/04/2019 22:17, James Almer wrote: > The spec defines it as a signed value. > > Signed-off-by: James Almer > --- > The only sample i could find with time_offset values it's in the fate suite, > and in all cases it's 0. > > libavcodec/cbs_h264.h | 2 +- > libavcodec/cbs_h264

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cbs_h2645: add helper macros for signed values

2019-04-16 Thread James Almer
On 4/16/2019 7:57 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_h2645.c | 20 >> 1 file changed, 20 insertions(+) >> >> diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c >> index e74f8dce81

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-16 Thread Michael Niedermayer
On Wed, Apr 10, 2019 at 06:54:53PM -0300, James Almer wrote: > On 4/10/2019 6:26 PM, Baptiste Coudurier wrote: > >> On Apr 9, 2019, at 6:27 PM, James Almer wrote: > >> > >> On 4/9/2019 9:40 PM, Baptiste Coudurier wrote: > >>> > On Apr 9, 2019, at 5:24 PM, James Almer wrote: > > On

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/cbs_h265: fix storage type for time_offset_value in Time Code SEI

2019-04-16 Thread Mark Thompson
On 15/04/2019 22:17, James Almer wrote: > The spec defines it as an array of signed values, inferred to 0 when not > present. > > Signed-off-by: James Almer > --- > Couldn't find any sample using it. > > libavcodec/cbs_h265.h | 2 +- > libavcodec/cbs_h265_syntax_template.c | 7 +

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/cbs_av1: use the new signed value read/write functions

2019-04-16 Thread Mark Thompson
On 15/04/2019 22:17, James Almer wrote: > Signed-off-by: James Almer > --- > The sample https://0x0.st/sljR.webm appears to be parsed the exact same way > after this patch. > > libavcodec/cbs_av1.c | 68 ++-- > 1 file changed, 8 insertions(+), 60 deletions

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cbs_h2645: add helper macros for signed values

2019-04-16 Thread Mark Thompson
On 17/04/2019 00:01, James Almer wrote: > On 4/16/2019 7:57 PM, Mark Thompson wrote: >> On 15/04/2019 22:17, James Almer wrote: >>> Signed-off-by: James Almer >>> --- >>> libavcodec/cbs_h2645.c | 20 >>> 1 file changed, 20 insertions(+) >>> >>> diff --git a/libavcodec/cbs_h26

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

2019-04-16 Thread Mark Thompson
On 16/04/2019 23:54, James Almer wrote: > On 4/16/2019 7:45 PM, Mark Thompson wrote: >> On 15/04/2019 22:17, James Almer wrote: >>> Signed-off-by: James Almer >>> --- >>> libavcodec/cbs.c | 79 +++ >>> libavcodec/cbs_internal.h | 20 +- >>> 2 f

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/cbs_h264: fix storage type for time_offset in Pic Timing SEI

2019-04-16 Thread James Almer
On 4/16/2019 8:00 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> The spec defines it as a signed value. >> >> Signed-off-by: James Almer >> --- >> The only sample i could find with time_offset values it's in the fate suite, >> and in all cases it's 0. >> >> libavcodec/cbs_h

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cbs_h2645: add helper macros for signed values

2019-04-16 Thread James Almer
On 4/16/2019 8:24 PM, Mark Thompson wrote: > On 17/04/2019 00:01, James Almer wrote: >> On 4/16/2019 7:57 PM, Mark Thompson wrote: >>> On 15/04/2019 22:17, James Almer wrote: Signed-off-by: James Almer --- libavcodec/cbs_h2645.c | 20 1 file changed, 20 in

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

2019-04-16 Thread James Almer
On 4/16/2019 8:27 PM, Mark Thompson wrote: > On 16/04/2019 23:54, James Almer wrote: >> On 4/16/2019 7:45 PM, Mark Thompson wrote: >>> On 15/04/2019 22:17, James Almer wrote: Signed-off-by: James Almer --- libavcodec/cbs.c | 79 +++

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/cbs_h265: fix storage type for time_offset_value in Time Code SEI

2019-04-16 Thread James Almer
On 4/16/2019 8:03 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> The spec defines it as an array of signed values, inferred to 0 when not >> present. >> >> Signed-off-by: James Almer >> --- >> Couldn't find any sample using it. >> >> libavcodec/cbs_h265.h |

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/cbs_av1: use the new signed value read/write functions

2019-04-16 Thread James Almer
On 4/16/2019 8:10 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> Signed-off-by: James Almer >> --- >> The sample https://0x0.st/sljR.webm appears to be parsed the exact same way >> after this patch. >> >> libavcodec/cbs_av1.c | 68 ++-

Re: [FFmpeg-devel] [PATCH 4/8] libavfilter/dnn: determine dnn output during execute_model instead of set_input_output

2019-04-16 Thread Guo, Yejun
> -Original Message- > From: Steven Liu [mailto:l...@chinaffmpeg.org] > Sent: Tuesday, April 16, 2019 8:04 PM > To: FFmpeg development discussions and patches > Cc: Steven Liu ; Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH 4/8] libavfilter/dnn: determine dnn output > during execute_m

Re: [FFmpeg-devel] [PATCH V1] lavf/oggparsevorbis: Fix change the case of metadata keys issue

2019-04-16 Thread myp...@gmail.com
On Wed, Apr 17, 2019 at 6:41 AM Michael Niedermayer wrote: > > On Tue, Apr 16, 2019 at 09:33:08AM +0800, myp...@gmail.com wrote: > > On Tue, Apr 16, 2019 at 5:51 AM Michael Niedermayer > > wrote: > > > > > > On Mon, Apr 15, 2019 at 09:58:30AM +0800, Jun Zhao wrote: > > > > From: Jun Zhao > > > >

[FFmpeg-devel] [PATCH v3] lavfi: add colorkey_opencl filter

2019-04-16 Thread Jarek Samic
This is a direct port of the CPU filter. Signed-off-by: Jarek Samic --- More fixes based on the comments from the second version of the patch (moving sampler declaration into the program scope, `f`-suffixing constants, attaching the `*` sigil to the variable name rather than the data type). c

Re: [FFmpeg-devel] [PATCH V2 2/2] lavfi/opencl: add nlmeans_opencl filter

2019-04-16 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Mark Thompson > Sent: Wednesday, April 17, 2019 5:28 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V2 2/2] lavfi/opencl: add nlmeans_opencl > filter > > On 12/04/2019

[FFmpeg-devel] [PATCH 1/3] avcodec/cbs_h2645: add macros to read and write fields with no custom range of values

2019-04-16 Thread James Almer
Signed-off-by: James Almer --- Better macro names welcome. I used the same convention as in cbs_av1. fate-cbs passes, but i'm sure a bunch of these are not tested by it, so help double checking i didn't screw up is welcome. libavcodec/cbs_h2645.c| 10 +- libavcodec/cbs_h264_syn

[FFmpeg-devel] [PATCH 2/3] avcodec/cbs_h2645: use the fixed() macro for forbidden_zero_bit

2019-04-16 Thread James Almer
This follows the spec definition, and removes a field from the relevant structs. Signed-off-by: James Almer --- libavcodec/cbs_h264.h | 1 - libavcodec/cbs_h264_syntax_template.c | 2 +- libavcodec/cbs_h265.h | 1 - libavcodec/cbs_h265_syntax_template.c | 2 +- 4

[FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h2645: rename macros to read and write fields with custom range of values

2019-04-16 Thread James Almer
These are more in line with the new ones introduced in the previous commit. Signed-off-by: James Almer --- No more i() macro :p Figured I'd leave all the byte and checksum fields using the custom range macro, to have the explicit hex values visible. That's why they were not changed in the first

Re: [FFmpeg-devel] [PATCH] avutil/colorspace: add macros for RGB->YUV BT.709

2019-04-16 Thread Gyan
On 13-04-2019 05:23 PM, Gyan wrote: Will be helpful for correct result in filters that paint like fillborders/drawbox or those using drawutils. Ping. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-de

[FFmpeg-devel] [PATCH V2] *** SUBJECT HERE ***

2019-04-16 Thread Jun Zhao
V2: -Fix logic error and use av_strncasecmp, Tks Michael's comments Jun Zhao (1): lavf/oggparsevorbis: Fix change the case of metadata keys issue libavformat/oggparsevorbis.c |9 - tests/ref/fate/limited_input_seek|2 +- tests/ref/fate/limited_input_seek-cop

[FFmpeg-devel] [PATCH V2] lavf/oggparsevorbis: Fix change the case of metadata keys issue

2019-04-16 Thread Jun Zhao
From: Jun Zhao The spec in https://xiph.org/vorbis/doc/v-comment.html states that the metadata keys are case-insensitive, so don't change the case and update the fate test case. Fix #7784 Signed-off-by: Jun Zhao --- libavformat/oggparsevorbis.c |9 - tests/ref/fate/lim

[FFmpeg-devel] [PATCH V2] lavf: bump version/add APIchanges entry when cleanup applehttp

2019-04-16 Thread Jun Zhao
From: Jun Zhao commit abfeba9 "lavf/hls: Cleanup the applehttp" missed the version bump and APIchanges entry. Signed-off-by: Jun Zhao --- doc/APIchanges|3 +++ libavformat/version.h |2 +- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/doc/APIchanges b/doc/APIch

[FFmpeg-devel] [PATCH] avformat/dashenc: Fix a bug with writing "final" manifest

2019-04-16 Thread Karthick J via ffmpeg-devel
This bug was introduced in the commit 951561b64ee6c11f01daedd9dcf73276cc1e765b --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 5f1333e436..b88d4b3496 100644 --- a/libavformat/dashenc.c +++ b/libavform