Re: [FFmpeg-devel] [PATCH] avcodec/packet: initialize payload size to zero

2019-04-03 Thread Ben Hutchinson
How do I unsubscribe from ffmpeg-devel? On Tue, Apr 2, 2019 at 8:57 PM Andriy Gelman wrote: > From: Andriy Gelman > > --- > libavcodec/avpacket.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c > index 8f0603df78..6ae092ed31 100644 > --- a

[FFmpeg-devel] [PATCH V1] doc/examples/metadata: fix the example can't dump FLV metadata

2019-04-03 Thread Jun Zhao
From: Jun Zhao fix the example can't dump FLV metadata. Signed-off-by: Jun Zhao --- doc/examples/metadata.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/doc/examples/metadata.c b/doc/examples/metadata.c index e330d07..b6cfa6b 100644 --- a/doc/examples/metadata.c

Re: [FFmpeg-devel] [PATCH] avcodec/agm: More completely check size before using it

2019-04-03 Thread Paul B Mahol
On 4/3/19, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 13997/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5701427252428800 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niede

Re: [FFmpeg-devel] [Patch] beautified + accelerated vf_fillborders – Please review

2019-04-03 Thread Ulf Zibis
Am 03.04.19 um 00:32 schrieb Carl Eugen Hoyos: >> So please throw away the old one and use the new >> patch 11. > That patch does not apply: At my machine  all patches work fine: ich@T500:~/Projects/ffmpeg/test$ git clone git://source.ffmpeg.org/ffmpeg . Klone nach '.' ... remote: Counting object

[FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-03 Thread Baptiste Coudurier
--- libavformat/mxf.h| 1 + libavformat/mxfenc.c | 197 --- 2 files changed, 147 insertions(+), 51 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index 4394450dea..f32124f772 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -

[FFmpeg-devel] [PATCH 1/2] avcodec/h264_parse: change prefix to avpriv for usage in avformat mxf muxer

2019-04-03 Thread Baptiste Coudurier
--- libavcodec/cbs_h2645.c | 28 ++-- libavcodec/extract_extradata_bsf.c | 4 ++-- libavcodec/h2645_parse.c | 6 +++--- libavcodec/h2645_parse.h | 6 +++--- libavcodec/h264_parse.c| 4 ++-- libavcodec/h264_parser.c |

Re: [FFmpeg-devel] [Patch] beautified + accelerated vf_fillborders – Please review

2019-04-03 Thread Paul B Mahol
On 4/3/19, Ulf Zibis wrote: > > Am 03.04.19 um 00:32 schrieb Carl Eugen Hoyos: >>> So please throw away the old one and use the new >>> patch 11. >> That patch does not apply: > At my machine all patches work fine: > > ich@T500:~/Projects/ffmpeg/test$ git clone git://source.ffmpeg.org/ffmpeg . >

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

2019-04-03 Thread Baptiste Coudurier
Hi Thomas, > On Apr 1, 2019, at 4:10 PM, Thomas Mundt wrote: > > Am Sa., 30. März 2019 um 17:52 Uhr schrieb Baptiste Coudurier < > baptiste.coudur...@gmail.com >: > >> Hi Thomas, >> >>> On Mar 29, 2019, at 1:11 PM, Thomas Mundt wrote: >>> >>> >>> […] >>>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_parse: change prefix to avpriv for usage in avformat mxf muxer

2019-04-03 Thread Hendrik Leppkes
On Wed, Apr 3, 2019 at 11:22 AM Baptiste Coudurier wrote: > > --- > libavcodec/cbs_h2645.c | 28 ++-- > libavcodec/extract_extradata_bsf.c | 4 ++-- > libavcodec/h2645_parse.c | 6 +++--- > libavcodec/h2645_parse.h | 6 +++--- > libavcode

Re: [FFmpeg-devel] [PATCH] lavf/movenc: fix tmcd writing for non-MP4/MOV modes

2019-04-03 Thread Tomas Härdin
ons 2019-04-03 klockan 12:17 +0530 skrev Gyan: > > On 02-04-2019 05:31 PM, Gyan wrote: > > > > > > On 01-04-2019 02:54 PM, Tomas Härdin wrote: > > > sön 2019-03-31 klockan 00:11 +0530 skrev Gyan: > > > > Regression since, I believe, 42cb050a05 > > > > > > Sounds like there should be a test case

Re: [FFmpeg-devel] [Patch] beautified + accelerated vf_fillborders – Please review

2019-04-03 Thread Ulf Zibis
Am 03.04.19 um 11:13 schrieb Ulf Zibis: > At my machine  all patches work fine: > > ich@T500:~/Projects/ffmpeg/test$ git clone git://source.ffmpeg.org/ffmpeg . > Klone nach '.' ... > remote: Counting objects: 565208, done. > remote: Compressing objects: 100% (117011/117011), done. > remote: Total

Re: [FFmpeg-devel] [PATCH] lavf/movenc: fix tmcd writing for non-MP4/MOV modes

2019-04-03 Thread Gyan
On 03-04-2019 03:12 PM, Tomas Härdin wrote: ons 2019-04-03 klockan 12:17 +0530 skrev Gyan: On 02-04-2019 05:31 PM, Gyan wrote: On 01-04-2019 02:54 PM, Tomas Härdin wrote: sön 2019-03-31 klockan 00:11 +0530 skrev Gyan: Regression since, I believe, 42cb050a05 Sounds like there should be a t

[FFmpeg-devel] [PATCH] avformat/utils: use AVIOContext.read_seek for seeks if available

2019-04-03 Thread Aman Gupta
From: Aman Gupta Currently only flv and asf decoders attempt to use pb->read_seek, by calling avio_read_seek() expliclity. This change allows avformat users to specify a custom AVIOContext with a read_seek callback, and have it be used with any format whenever av_seek_frame() is invoked. Signed

Re: [FFmpeg-devel] [Patch] beautified + accelerated vf_fillborders – Please review

2019-04-03 Thread Carl Eugen Hoyos
2019-04-03 11:13 GMT+02:00, Ulf Zibis : > vf_fillborders_1.patch As explained, this patch is not ok, therefore the patchset as-is can not be applied. There are two possibilities: Either you rebase your remaining patchset and wait for a review from Paul. Or only send the patch that improves t

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_parse: change prefix to avpriv for usage in avformat mxf muxer

2019-04-03 Thread Baptiste Coudurier
Hey Hendrik > On Apr 3, 2019, at 11:37 AM, Hendrik Leppkes wrote: > > On Wed, Apr 3, 2019 at 11:22 AM Baptiste Coudurier > wrote: >> >> --- >> libavcodec/cbs_h2645.c | 28 ++-- >> libavcodec/extract_extradata_bsf.c | 4 ++-- >> libavcodec/h2645_parse.c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_parse: change prefix to avpriv for usage in avformat mxf muxer

2019-04-03 Thread Carl Eugen Hoyos
2019-04-03 11:37 GMT+02:00, Hendrik Leppkes : > We prefer not to expose huge modules like this as avpriv, > as it makes it part of the ABI (I am sure there are cases that are difficult to avoid, we also prefer not to duplicate functions.) > and as such impossible to change without > deprecation

[FFmpeg-devel] [PATCH] lavc/qsvenc: enable hevc gpb option

2019-04-03 Thread Zhong Li
GPB is the default type, just contains forward references but the slice_type is B slice with higher encoding efficiency than regular P slice, but lower performance. Add an option to allow user to set regular P slice. Fix ticket#6870 Test data on Intel Kabylake (i7-7567U CPU @ 3.50GHz): 1. ffmpeg

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_parse: change prefix to avpriv for usage in avformat mxf muxer

2019-04-03 Thread Hendrik Leppkes
On Wed, Apr 3, 2019 at 2:28 PM Carl Eugen Hoyos wrote: > > 2019-04-03 11:37 GMT+02:00, Hendrik Leppkes : > > > We prefer not to expose huge modules like this as avpriv, > > as it makes it part of the ABI > > (I am sure there are cases that are difficult to avoid, > we also prefer not to duplicate

Re: [FFmpeg-devel] [PATCH] ffmpeg: add -drop_deviant_frames option

2019-04-03 Thread Gyan
On 02-04-2019 09:56 AM, Gyan wrote: On 01-04-2019 10:23 AM, Gyan wrote: On 27-03-2019 08:26 PM, Gyan wrote: Weird. Attached corrected patch. Thanks. Ping. Plan to push tomorrow evening. Plan to push in ~2 hours. Gyan ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_parse: change prefix to avpriv for usage in avformat mxf muxer

2019-04-03 Thread James Almer
On 4/3/2019 9:25 AM, Baptiste Coudurier wrote: > Hey Hendrik > >> On Apr 3, 2019, at 11:37 AM, Hendrik Leppkes wrote: >> >> On Wed, Apr 3, 2019 at 11:22 AM Baptiste Coudurier >> wrote: >>> >>> --- >>> libavcodec/cbs_h2645.c | 28 ++-- >>> libavcodec/extract_ext

Re: [FFmpeg-devel] [PATCH] ffmpeg: add -drop_deviant_frames option

2019-04-03 Thread Paul B Mahol
On 4/3/19, Gyan wrote: > > > On 02-04-2019 09:56 AM, Gyan wrote: >> >> >> On 01-04-2019 10:23 AM, Gyan wrote: >>> >>> >>> On 27-03-2019 08:26 PM, Gyan wrote: Weird. Attached corrected patch. Thanks. >>> >>> Ping. >> >> Plan to push tomorrow evening. > > Plan to push in ~2 hours. Pl

Re: [FFmpeg-devel] [Patch] beautified + accelerated vf_fillborders – Please review

2019-04-03 Thread Ulf Zibis
Am 03.04.19 um 14:25 schrieb Carl Eugen Hoyos: >> vf_fillborders_1.patch > As explained, this patch is not ok, I would say "determined". > There are two possibilities: > Either you rebase your remaining patchset and wait for a > review from Paul. In consideration of his in my judgement impol

Re: [FFmpeg-devel] [Patch] beautified + accelerated vf_fillborders – Please review

2019-04-03 Thread Paul B Mahol
On 4/3/19, Ulf Zibis wrote: > > Am 03.04.19 um 14:25 schrieb Carl Eugen Hoyos: >>> vf_fillborders_1.patch >> As explained, this patch is not ok, > I would say "determined". > >> There are two possibilities: >> Either you rebase your remaining patchset and wait for a >> review from Paul. > > In

Re: [FFmpeg-devel] [Patch] beautified + accelerated vf_fillborders – Please review

2019-04-03 Thread Nicolas George
Ulf Zibis (12019-04-03): > In consideration of his in my judgement impolite 1-line comments it > seems unlikely to me that rebasing would be worth the effort. You are right, these comments are completely unacceptable. But that does not mean you should not strive to improve your patches. Regards,

[FFmpeg-devel] [PATCH] avformat/mxfdec: export operational pattern UL as file metadata

2019-04-03 Thread Marton Balint
Can be useful for API users as ffmpeg/libavformat can't properly support some operational patterns. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 7 +++ tests/ref/fate/mxf-probe-d10 | 1 + tests/ref/fate/mxf-probe-dnxhd | 1 + tests/ref/fate/mxf-probe-dv25 | 1 + 4 fil

[FFmpeg-devel] [PATCH] avformat/file: add seekable option to disallow seeking

2019-04-03 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/protocols.texi | 9 + libavformat/file.c | 5 + 2 files changed, 14 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index e1caa049a5..34967ff5e2 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -199,6 +199,15 @@ If se

Re: [FFmpeg-devel] [PATCH] avformat/file: add seekable option to disallow seeking

2019-04-03 Thread Hendrik Leppkes
On Wed, Apr 3, 2019 at 10:42 PM Marton Balint wrote: > > Signed-off-by: Marton Balint > --- > doc/protocols.texi | 9 + > libavformat/file.c | 5 + > 2 files changed, 14 insertions(+) > > diff --git a/doc/protocols.texi b/doc/protocols.texi > index e1caa049a5..34967ff5e2 100644 > ---

Re: [FFmpeg-devel] [PATCH] ffmpeg: add -drop_deviant_frames option

2019-04-03 Thread Michael Niedermayer
On Wed, Mar 27, 2019 at 08:26:36PM +0530, Gyan wrote: > Weird. Attached corrected patch. > > Thanks. > > On 27-03-2019 08:19 PM, Moritz Barsnick wrote: > >On Wed, Mar 27, 2019 at 18:05:32 +0530, Gyan wrote: > >>+@item -drop_deviant_frames (@emph{input,per-stream}) > >>+Allows discarding decoded f

Re: [FFmpeg-devel] [PATCH] avformat/file: add seekable option to disallow seeking

2019-04-03 Thread Marton Balint
On Wed, 3 Apr 2019, Hendrik Leppkes wrote: On Wed, Apr 3, 2019 at 10:42 PM Marton Balint wrote: Signed-off-by: Marton Balint --- doc/protocols.texi | 9 + libavformat/file.c | 5 + 2 files changed, 14 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index e1

Re: [FFmpeg-devel] [PATCH V2] lavf/flvdec: Fix AMF NUMBER type to metadata lost precision

2019-04-03 Thread Michael Niedermayer
On Thu, Mar 28, 2019 at 09:23:29PM +0800, Jun Zhao wrote: > From: Jun Zhao > > Use %.12g replace %.f when save AMF NUMBER(double) type to > metadata. And update fate ref. > > before this fix, we get FLV metadata like: > > Metadata: > lasttimestamp : 113 > lastkeyframetimestamp: 112 >

[FFmpeg-devel] [PATCH] tests: don't include TARGET_PATH in the sample path needlessly

2019-04-03 Thread Hendrik Leppkes
The transcode() helper function will already prepend the TARGET_PATH to the sample path, if its a relative path. This avoids an issue on Windows, where the relative path check could fail. --- tests/fate/ffmpeg.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/ffmpe

Re: [FFmpeg-devel] [PATCH, RFC 2/2] lavc/vaapi_decode: find exact va_profile for HEVC_REXT

2019-04-03 Thread Michael Niedermayer
On Wed, Apr 03, 2019 at 12:10:22PM +0800, Linjie Fu wrote: > Use the profile constraint flags to determine the exact va_profile for > HEVC_REXT. > > Directly cast PTLCommon to H265RawProfileTierLevel, and use > ff_h265_get_profile > to get the exact profile. > > Signed-off-by: Linjie Fu > --- >

Re: [FFmpeg-devel] [PATCH, RFC 2/2] lavc/vaapi_decode: find exact va_profile for HEVC_REXT

2019-04-03 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Michael Niedermayer > Sent: Thursday, April 4, 2019 06:38 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, RFC 2/2] lavc/vaapi_decode: f

[FFmpeg-devel] Patch for Reproducing Issue 7827

2019-04-03 Thread Peter Belkner
This patch does not improve or fix something instead it is meant for easily reproducing issue 7827 (as requested, cf. https://trac.ffmpeg.org/ticket/7827). I've to admit that I don't know how to produce a patch by "git format-patch" instead it was made by "git diff > muxing.patch". diff --git

Re: [FFmpeg-devel] [PATCH V2] lavf/flvdec: Fix AMF NUMBER type to metadata lost precision

2019-04-03 Thread myp...@gmail.com
On Thu, Apr 4, 2019 at 5:21 AM Michael Niedermayer wrote: > > On Thu, Mar 28, 2019 at 09:23:29PM +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > Use %.12g replace %.f when save AMF NUMBER(double) type to > > metadata. And update fate ref. > > > > before this fix, we get FLV metadata like: > > >

Re: [FFmpeg-devel] [PATCH v2 2/6] lavu/frame: Expand ROI documentation

2019-04-03 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Wednesday, March 13, 2019 8:18 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v2 2/6] lavu/frame: Expand ROI > documentation > > Clarify and add exam

Re: [FFmpeg-devel] Patch for Reproducing Issue 7827

2019-04-03 Thread myp...@gmail.com
On Thu, Apr 4, 2019 at 2:33 PM Peter Belkner wrote: > > This patch does not improve or fix something instead it is meant for > easily reproducing issue 7827 (as requested, cf. > https://trac.ffmpeg.org/ticket/7827). I've to admit that I don't know > how to produce a patch by "git format-patch" ins