Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpegvideo_enc: Use av_assert1() instead of assert()

2019-02-17 Thread Michael Niedermayer
On Fri, Feb 01, 2019 at 11:33:35PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegvideo_enc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/htmlsubtitles: Fixes denial of service due to use of sscanf in inner loop for tag scaning

2019-02-17 Thread Michael Niedermayer
On Wed, Feb 13, 2019 at 01:22:37AM +0100, Michael Niedermayer wrote: > From: Kevin Backhouse via RT > > Fixes: [Semmle Security Reports #19438] > Fixes: dos_sscanf1.mkv > > Signed-off-by: Michael Niedermayer > --- > libavcodec/htmlsubtitles.c | 30 +- > 1 file chang

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Do not leak queued packets on sync errors

2019-02-17 Thread Michael Niedermayer
On Fri, Feb 08, 2019 at 10:53:52PM +0100, Michael Niedermayer wrote: > Fixes: memleak > Fixes: clusterfuzz-testcase-minimized-audio_decoder_fuzzer-5649187601121280 > > Reported-by: Chris Cunningham > Tested-by: Chris Cunningham > Signed-off-by: Michael Niedermayer > --- > libavformat/matroskad

Re: [FFmpeg-devel] [PATCH 1/3] avformat/ftp: Fix Out-of-Bounds Access and Information Leak in ftp.c:393

2019-02-17 Thread Michael Niedermayer
On Wed, Feb 13, 2019 at 10:31:32AM +0100, Michael Niedermayer wrote: > From: Wenxiang Qian > > Signed-off-by: Michael Niedermayer > --- > libavformat/ftp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply patchset [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BAD

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Check parents remaining length

2019-02-17 Thread Michael Niedermayer
On Wed, Feb 13, 2019 at 01:41:31PM +0100, Michael Niedermayer wrote: > Reported-by: Steve Lhomme > This was found through the Hacker One program on VLC but is not a security > issue in libavformat > Signed-off-by: Michael Niedermayer > --- > libavformat/matroskadec.c | 21 + >

[FFmpeg-devel] [PATCH] Makefile: delete unneeded escape

2019-02-17 Thread Reto Kromer
Best regards, Reto 0001-Makefile-delete-unneeded-escape.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Makefile: delete unneeded escape

2019-02-17 Thread Michael Niedermayer
On Sun, Feb 17, 2019 at 09:44:52AM +0100, Reto Kromer wrote: > Best regards, Reto > Makefile |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ed5a95e331e302563d0859bd3b514d88376696e6 > 0001-Makefile-delete-unneeded-escape.patch > From 764d9459caecc259952984258ae19ed0906c1176 Mon Sep

Re: [FFmpeg-devel] [PATCH] Makefile: delete unneeded escape

2019-02-17 Thread Reto Kromer
Michael Niedermayer wrote: >if someone adds a line after this he would have to change the >previous line (adding the \ back) >that would make such a patch less tidy (2 lines changed instead >of 1) >i suspect that was the reason why all lines have a \ Possibly. The two other similar instances are

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

2019-02-17 Thread Mathieu Duponchelle
> It would be better to test against a decoder from a unrelated codebase > Otherwise its a bit like testing your new language skills by talking with > yourself. I have just tested with gstreamer's mpegvideoparse element, it detects the closed captions as expected: 0:00:00.602266814 27833  

Re: [FFmpeg-devel] [PATCH]lavf/mxfdec: Export EIA608 Closed Captions by default

2019-02-17 Thread Marton Balint
On Sun, 17 Feb 2019, Carl Eugen Hoyos wrote: 2019-02-17 1:40 GMT+01:00, Marton Balint : On Sat, 16 Feb 2019, Carl Eugen Hoyos wrote: I am not sure why there is an option to disable Closed Captions export, but disabling the export by default seems like a bad idea to me. SMPTE 436M can be

Re: [FFmpeg-devel] [PATCH]lavf/mxfdec: Export EIA608 Closed Captions by default

2019-02-17 Thread Marton Balint
On Sun, 17 Feb 2019, Marton Balint wrote: On Sun, 17 Feb 2019, Carl Eugen Hoyos wrote: 2019-02-17 1:40 GMT+01:00, Marton Balint : On Sat, 16 Feb 2019, Carl Eugen Hoyos wrote: I am not sure why there is an option to disable Closed Captions export, but disabling the export by default see

[FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add some assertions to ensure pkt->data is not null if pkt->size > 0

2019-02-17 Thread Marton Balint
This should fix the following Coverity false positives: Coverity CID #1405450. Coverity CID #1430930. Signed-off-by: Marton Balint --- libavcodec/avpacket.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 11ac4e80cd..8f0603df78 100644 -

[FFmpeg-devel] [PATCH 3/3] avcodec/get_bits: add assertion to limit ouptut value of get_bits

2019-02-17 Thread Marton Balint
Should fix the following Coverity false positives: Coverity CID #1415651. Coverity CID #1420392. Coverity CID #1420473. Coverity CID #1433770. Coverity CID #1435320. Coverity CID #1439573. Coverity CID #1439580. Coverity CID #1439588. Signed-off-by: Marton Balint --- libavcodec/get_bits.h | 1 +

[FFmpeg-devel] [PATCH 2/3] avcodec/get_bits: use unsigned integers in show_bits and get_bits

2019-02-17 Thread Marton Balint
The return value is also unsigned. --- libavcodec/get_bits.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h index 26a5b3e54f..2e2adc29c2 100644 --- a/libavcodec/get_bits.h +++ b/libavcodec/get_bits.h @@ -380,7 +380,7 @@ static

[FFmpeg-devel] [PATCH 1/4] doc/formats: add reference to ffmpeg(1) stream specifiers as that docs is more complete

2019-02-17 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/formats.texi | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/doc/formats.texi b/doc/formats.texi index 52a5ff8371..a992506ac1 100644 --- a/doc/formats.texi +++ b/doc/formats.texi @@ -234,30 +234,10 @@ At present, a

[FFmpeg-devel] [PATCH 4/4] avformat/utils: fix indentation

2019-02-17 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/utils.c | 236 ++-- 1 file changed, 118 insertions(+), 118 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 81f72bbf83..db2dfac3b4 100644 --- a/libavformat/utils.c +++ b/libavfor

[FFmpeg-devel] [PATCH 3/4] avformat/utils: be even more strict about stream specifiers

2019-02-17 Thread Marton Balint
After this change we always parse the full specifier even if we know the result in the middle of the parsing. Sligtly slower, but this is needed to consistently reject incorrect specifiers in both matching and non-matching cases. Signed-off-by: Marton Balint --- libavformat/utils.c | 26

[FFmpeg-devel] [PATCH 2/4] avformat/utils: be more strict about stream specifiers

2019-02-17 Thread Marton Balint
This reworks the code to be more strict about accepting stream specifiers. From now on we strictly enforce the syntax in the documentation up until the decisive part of the stream specifier. Therefore matching stream specifiers always need to be correct, non matching specifiers only need to be corr

Re: [FFmpeg-devel] [PATCH 2/4] avformat/utils: be more strict about stream specifiers

2019-02-17 Thread Carl Eugen Hoyos
2019-02-17 20:55 GMT+01:00, Marton Balint : > This reworks the code to be more strict about accepting > stream specifiers. From now on we strictly enforce the > syntax in the documentation up until the decisive part of > the stream specifier. Therefore matching stream specifiers > always need to be

[FFmpeg-devel] [PATCH 1/2] avcodec: add AC-4 codec id and description

2019-02-17 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 0ce22ec4fa..13eb241c77 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -648,6 +648,7

[FFmpeg-devel] [PATCH 2/2] avformat: add mapping for AC-4 in MP4

2019-02-17 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/isom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/isom.c b/libavformat/isom.c index 0a4d901be5..0052db539e 100644 --- a/libavformat/isom.c +++ b/libavformat/isom.c @@ -368,6 +368,7 @@ const AVCodecTag ff_codec_movaudio_tags[] = {

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add mapping for AC-4 in MP4

2019-02-17 Thread Carl Eugen Hoyos
2019-02-17 21:25 GMT+01:00, Paul B Mahol : > Signed-off-by: Paul B Mahol > --- > libavformat/isom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/isom.c b/libavformat/isom.c > index 0a4d901be5..0052db539e 100644 > --- a/libavformat/isom.c > +++ b/libavformat/isom.c > +

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add mapping for AC-4 in MP4

2019-02-17 Thread Paul B Mahol
On 2/17/19, Carl Eugen Hoyos wrote: > 2019-02-17 21:25 GMT+01:00, Paul B Mahol : >> Signed-off-by: Paul B Mahol >> --- >> libavformat/isom.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavformat/isom.c b/libavformat/isom.c >> index 0a4d901be5..0052db539e 100644 >> --- a/libavfo

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add mapping for AC-4 in MP4

2019-02-17 Thread Carl Eugen Hoyos
2019-02-17 21:50 GMT+01:00, Paul B Mahol : > On 2/17/19, Carl Eugen Hoyos wrote: >> 2019-02-17 21:25 GMT+01:00, Paul B Mahol : >>> Signed-off-by: Paul B Mahol >>> --- >>> libavformat/isom.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/libavformat/isom.c b/libavformat/isom.c >>>

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add mapping for AC-4 in MP4

2019-02-17 Thread Paul B Mahol
On 2/17/19, Carl Eugen Hoyos wrote: > 2019-02-17 21:50 GMT+01:00, Paul B Mahol : >> On 2/17/19, Carl Eugen Hoyos wrote: >>> 2019-02-17 21:25 GMT+01:00, Paul B Mahol : Signed-off-by: Paul B Mahol --- libavformat/isom.c | 1 + 1 file changed, 1 insertion(+) diff --gi

Re: [FFmpeg-devel] Lossy GIF encoding

2019-02-17 Thread Tomas Härdin
fre 2019-02-15 klockan 16:45 + skrev Kornel: > > > Alternatively, would it be OK to create a separate codec just for > > > lossy compression? I would create a new GIF codec, define it under a > > > new name, and declare it always takes AV_PIX_FMT_RGB24 or > > > AV_PIX_FMT_RGBA. Is that a good a

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add mapping for AC-4 in MP4

2019-02-17 Thread James Almer
On 2/17/2019 6:14 PM, Paul B Mahol wrote: > On 2/17/19, Carl Eugen Hoyos wrote: >> 2019-02-17 21:50 GMT+01:00, Paul B Mahol : >>> On 2/17/19, Carl Eugen Hoyos wrote: 2019-02-17 21:25 GMT+01:00, Paul B Mahol : > Signed-off-by: Paul B Mahol > --- > libavformat/isom.c | 1 + >

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add mapping for AC-4 in MP4

2019-02-17 Thread Paul B Mahol
On 2/17/19, James Almer wrote: > On 2/17/2019 6:14 PM, Paul B Mahol wrote: >> On 2/17/19, Carl Eugen Hoyos wrote: >>> 2019-02-17 21:50 GMT+01:00, Paul B Mahol : On 2/17/19, Carl Eugen Hoyos wrote: > 2019-02-17 21:25 GMT+01:00, Paul B Mahol : >> Signed-off-by: Paul B Mahol >> --

Re: [FFmpeg-devel] [PATCH] palettegen: Fill with last color, not black

2019-02-17 Thread Tomas Härdin
tor 2019-01-17 klockan 11:14 +0100 skrev Michael Niedermayer: > On Thu, Jan 17, 2019 at 09:44:47AM +0100, Clément Bœsch wrote: > > On Wed, Jan 16, 2019 at 01:40:20PM +0100, Tomas Härdin wrote: > > > Hi > > > > > > I was helping the fine folks at peppercarrot.com with web video > > > nonsense, and

[FFmpeg-devel] [PATCH 1/2] avcodec/mjpegdec: Fix stereo3d memleak

2019-02-17 Thread Michael Niedermayer
Fixes: 12937/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THP_fuzzer-5714945346371584 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mjpegdec.c | 1 + 1 file changed, 1 insertion(+) dif

[FFmpeg-devel] [PATCH 2/2] avcodec/arbc: Check nb_tiles against dimensions

2019-02-17 Thread Michael Niedermayer
Fixes: Timeout Fixes: 12967/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ARBC_fuzzer-5639021454163968 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/arbc.c | 6 ++ 1 file changed, 6

Re: [FFmpeg-devel] [Patch] lavf/mpeg: fix indent

2019-02-17 Thread Morris Stock
On 2/17/19 2:06 AM, Michael Niedermayer wrote: > On Fri, Feb 15, 2019 at 01:48:04AM +, Morris Stock wrote: >> mpeg.c | 56 >> 1 file changed, 28 insertions(+), 28 deletions(-) >> 2c6d9fc35eaf3f348761d553ec3029275709acba 0001-lavf-mpeg

Re: [FFmpeg-devel] [PATCH, RFC] lavf/deinterlace_qsv: set TFF or BFF together with progressive

2019-02-17 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Friday, February 15, 2019 20:46 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, RFC] lavf/deinterlace_qsv: set

Re: [FFmpeg-devel] [PATCH v5] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-02-17 Thread Wang, Shaofei
Thanks. Seems I need to cover external samples either > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > Sent: Saturday, February 16, 2019 5:22 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-d

Re: [FFmpeg-devel] [PATCH v2] ffmpeg: Add option to force a specific decode format

2019-02-17 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Fu, Linjie > Sent: Friday, November 16, 2018 16:37 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2] ffmpeg: Add option to force a > s

Re: [FFmpeg-devel] [PATCH, RFC] lavf/deinterlace_qsv: set TFF or BFF together with progressive

2019-02-17 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Linjie Fu > Sent: Saturday, February 16, 2019 3:50 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH, RFC] lavf/deinterlace_qsv: set TFF or BFF > together with progressive > > Currently,

Re: [FFmpeg-devel] [PATCH] libavformat/cdg: unset duration on packets

2019-02-17 Thread Guillaume Desmottes
On 13/02/2019 16:28, Carl Eugen Hoyos wrote: Thanks for testing my patch. I wasn't aware of this specific test, sorry about that. What would be the proper way to address this? Should the fate reference be updated? Yes, unless the change is wrong. Ok thanks. So, who should I ask to review this