Re: [FFmpeg-devel] [PATCH v2 01/11] vaapi_encode: Support more RC modes

On 28/01/2019 04:23, Eoff, Ullysses A wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Mark Thompson >> Sent: Sunday, January 27, 2019 3:47 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: [FFmpeg-devel] [PATCH v2 01/11] vaapi_encode:

Re: [FFmpeg-devel] [PATCH v2 09/11] vaapi_encode: Add support for VFR mode

On 28/01/2019 20:45, Michael Niedermayer wrote: > On Sun, Jan 27, 2019 at 11:47:05PM +, Mark Thompson wrote: >> Use the frame-skip feature to maintain a specified framerate from the >> point of view of the driver. >> --- >> doc/encoders.texi | 7 +++ >> libavcodec/vaapi_encode.c | 11

Re: [FFmpeg-devel] [PATCH v2 01/11] vaapi_encode: Support more RC modes

On 28/01/2019 02:19, Fu, Linjie wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Mark Thompson >> Sent: Monday, January 28, 2019 07:47 >> To: ffmpeg-devel@ffmpeg.org >> Subject: [FFmpeg-devel] [PATCH v2 01/11] vaapi_encode: Support

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: update notes to explain the scale chosen for ROI encoding

On 29/01/2019 10:14, Guo, Yejun wrote: > Signed-off-by: Guo, Yejun > --- > libavcodec/libx264.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > index a3493f3..8c96728 100644 > --- a/libavcodec/libx264.c > +++ b/libavcodec/

Re: [FFmpeg-devel] [PATCH] amfenc: Add support for pict_type field

On 15/01/2019 22:05, michael.di...@xaymar.com wrote: > From: Michael Fabian 'Xaymar' Dirks > > Adds support for the pict_type field in AVFrame to amf_h264 and amf_h265 > simultaneously. This field is needed in cases where the application wishes to > override the frame type with another one, suc

[FFmpeg-devel] [PATCH] doc/examples: port muxing example to new send/receive API

Hi Noticed that the example code for muxing uses depricated API. This is my attempt to port the doc/examples/muxing.c to use the avcodec_send_frame() and avcodec_receive_packet() API. Regards, Lennart From 2dce8373cb7adfd3228759bfa5ff80ebcd9116db Mon Sep 17 00:00:00 2001 From: Lennart Blanco Dat

Re: [FFmpeg-devel] [PATCH] amfenc: Add support for pict_type field

On 04.02.2019 11:05, Mark Thompson wrote: Can you explain what this "skip frame" actually does in the encoder? The concept does not exist in H.264 or H.265, as far as I know. I believe this has to do with the pic_struct flag which has a value of 7 for frame doubling and 8 for frame tripling,

Re: [FFmpeg-devel] Access to the dolby vision decoder info

Hello Hendrik, I fully agree with your approach and already thought about this. Parsing this directly to a structure would the correct approach for a final future patch. Unfortunately at this point in development, i need the most flexibility possible, with simultaneously minimal reaction time.

Re: [FFmpeg-devel] Access to the dolby vision decoder info

On Mon, Feb 4, 2019 at 5:04 PM Gresserman Dmitrij wrote: > > I fully agree with your approach and already thought about this. Parsing this > directly to a structure would the correct approach for a final future patch. > Unfortunately at this point in development, i need the most flexibility > p

Re: [FFmpeg-devel] Access to the dolby vision decoder info

Once again you are right. I just wanted to show my approach to this community, to let you know, maybe it could help someone else. I don't insist on adding this approach to your repositories. Best Regards [Ein einzigartiges Sounderlebnis mit Loewe und Mimi Defined™] ___

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself to the PPC section

On Sun, Jan 27, 2019 at 08:51:19PM +0200, Lauri Kasanen wrote: > Signed-off-by: Lauri Kasanen > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no place

Re: [FFmpeg-devel] [PATCH] lavf/mov: fix hang while seek on a kind of fragmented mp4.

On Sat, Feb 02, 2019 at 05:03:25PM +0100, Marton Balint wrote: > > > On Sat, 2 Feb 2019, Charles Liu wrote: > > >Binary searching would hang if the fragment items do NOT have timestamp for > >the specified stream. > > > >For example, a fmp4 consists of separated 'moof' boxes for each track, and

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpeg4_unpack_bframes_bsf: Improve DivX userdata check

On Sat, Feb 02, 2019 at 08:34:12PM +0100, Andreas Rheinhardt wrote: > The earlier version didn't really check that the 'p' of a "p\0" is > actually part of a DivX user_data section, instead it treated the first > "p\0" after the start of a user_data section as end of a DivX user_data > section if i

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/mpeg4videodec: Fix nonsense warning

On Sat, Feb 02, 2019 at 08:34:10PM +0100, Andreas Rheinhardt wrote: > Since db772308941a2a338c7809f90d347219a6a93074 parsing of > mpeg4-extradata lead to a "Failed to parse extradata" warning, because > ff_mpeg4_decode_picture_header returns AVERROR_INVALIDDATA in case that > no VOP was found. This

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mpeg4_unpack_bframes_bsf: Use avpriv_find_start_code

On Sat, Feb 02, 2019 at 08:34:11PM +0100, Andreas Rheinhardt wrote: > instead of an ad-hoc function to search for start codes in order to > remove code duplication and to improve performance. > > Improved performance of finding startcodes from 52606 decicycles to > 9543 decicycles based upon 26214

[FFmpeg-devel] [PATCH 0/1] Seeking disabled unconditionally in DASH demuxer

Hello, any reason why this commit: https://github.com/FFmpeg/FFmpeg/commit/d54ae9b782c85e626a1e49a8ee204728746227d1#diff-ce2d1d31314e57cff2d1f3eb78988c88R1903 disables seeking in dash demuxer? Seeking works fine for my dash manifests when I remove the highlighted line. -- Paweł Wegner Paweł W

[FFmpeg-devel] [PATCH 1/1] libavformat/dashdec: disable seeking only for live streams.

Signed-off-by: Paweł Wegner --- libavformat/dashdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index f4f4e935de..89acd5807d 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -2000,8 +2000,6 @@ static int

Re: [FFmpeg-devel] [PATCH] lavf/mov: fix hang while seek on a kind of fragmented mp4.

On Mon, 4 Feb 2019, Michael Niedermayer wrote: On Sat, Feb 02, 2019 at 05:03:25PM +0100, Marton Balint wrote: On Sat, 2 Feb 2019, Charles Liu wrote: Binary searching would hang if the fragment items do NOT have timestamp for the specified stream. For example, a fmp4 consists of separate

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpegts: cache PID discard values

On Sat, 2 Feb 2019, Michael Niedermayer wrote: On Fri, Feb 01, 2019 at 10:29:13PM +0100, Marton Balint wrote: On Fri, 25 Jan 2019, Marton Balint wrote: On Fri, 25 Jan 2019, Michael Niedermayer wrote: On Thu, Jan 24, 2019 at 09:38:00PM +0100, Marton Balint wrote: discard_pid can be qu

Re: [FFmpeg-devel] [PATCH] avformat/async: fix assertion condition when draining buffer

On Sun, 27 Jan 2019, Marton Balint wrote: Fixes some random assertion failures with ffprobe -show_packets async:samples/ffmpeg-bugs/trac/ticket6132/Samsung_HDR_-_Chasing_the_Light.ts > /dev/null Signed-off-by: Marton Balint --- libavformat/async.c | 2 +- 1 file changed, 1 insertion(+), 1

[FFmpeg-devel] [PATCH 1/3] ffplay: use different decoder names for each media type

Signed-off-by: Marton Balint --- fftools/ffplay.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 6a195e5542..97009f322d 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -2103,10 +2103,10 @@ static int audio_thread(vo

[FFmpeg-devel] [PATCH 2/3] ffplay: add missing avfilter_graph_alloc result check

Also do not allocate a graph at start, we will reallocate it anyway. Signed-off-by: Marton Balint --- fftools/ffplay.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 97009f322d..f84052a89b 100644 --- a/fftools/ffpl

[FFmpeg-devel] [PATCH 3/3] ffplay: add support for setting the number of filter threads

Signed-off-by: Marton Balint --- doc/ffplay.texi | 6 ++ fftools/ffplay.c | 4 2 files changed, 10 insertions(+) diff --git a/doc/ffplay.texi b/doc/ffplay.texi index 99e1d7468a..c305465078 100644 --- a/doc/ffplay.texi +++ b/doc/ffplay.texi @@ -195,6 +195,12 @@ input as soon as possible

Re: [FFmpeg-devel] [PATCH] avformat/isom.h: use usnigned types in MOVStsc

On Sat, Feb 2, 2019 at 3:37 AM Michael Niedermayer wrote: > Is this change needed by some valid file ? > No, just a drive by fix since I happened to be looking at these types and the spec. > The change taken on its own is probably correct but its increasing the > range > of values without actu

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

2019-02-03 16:24 GMT+01:00, Marton Balint : > > > On Sun, 3 Feb 2019, Carl Eugen Hoyos wrote: > >> 2019-01-28 2:00 GMT+01:00, Marton Balint : >>> If we enable a component but a dependant library is disabled, then the >>> enabled >>> component get silently disabled. Requesting all explicitly enabled

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

On Tue, 5 Feb 2019, Carl Eugen Hoyos wrote: 2019-02-03 16:24 GMT+01:00, Marton Balint : On Sun, 3 Feb 2019, Carl Eugen Hoyos wrote: 2019-01-28 2:00 GMT+01:00, Marton Balint : If we enable a component but a dependant library is disabled, then the enabled component get silently disabled. R

Re: [FFmpeg-devel] [PATCH 0/1] Seeking disabled unconditionally in DASH demuxer

2019-02-04 21:27 GMT+01:00, Paweł Wegner : > any reason why this commit: > https://github.com/FFmpeg/FFmpeg/commit/d54ae9b782c85e626a1e49a8ee204728746227d1#diff-ce2d1d31314e57cff2d1f3eb78988c88R1903 > disables seeking in dash demuxer? Seeking works fine > for my dash manifests when I remove the hi

Re: [FFmpeg-devel] [PATCH 0/2] ARIB STD-B24 caption decoding using libaribb24

2019-02-02 15:21 GMT+01:00, Jan Ekström : > On Sat, Feb 2, 2019 at 3:55 PM Carl Eugen Hoyos wrote: >> >> 2019-02-02 14:31 GMT+01:00, Jan Ekström : >> >> > I will proceed to making a FATE test >> >> You cannot add fate tests for external libraries. >> > > Ouch. I was asked by Clement to make one wh

Re: [FFmpeg-devel] [PATCH] libavcodec: vp8 neon optimizations for aarch64

On 1/31/2019 4:23 PM, Carl Eugen Hoyos wrote: > 2019-01-31 17:04 GMT+01:00, Magnus Röös : >> Partial port of the ARM Neon for aarch64. > > Reproduced a >20% speedup for fate-vp8 and applied. > > Thank you, Carl Eugen This seems to have broken builds with Clang on aarch64. GCC seems fine. http:/

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

2019-02-05 0:53 GMT+01:00, Marton Balint : > > > On Tue, 5 Feb 2019, Carl Eugen Hoyos wrote: > >> 2019-02-03 16:24 GMT+01:00, Marton Balint : >>> >>> >>> On Sun, 3 Feb 2019, Carl Eugen Hoyos wrote: >>> 2019-01-28 2:00 GMT+01:00, Marton Balint : > If we enable a component but a dependant li

Re: [FFmpeg-devel] [PATCH] libavcodec: vp8 neon optimizations for aarch64

2019-02-05 0:59 GMT+01:00, James Almer : > On 1/31/2019 4:23 PM, Carl Eugen Hoyos wrote: >> 2019-01-31 17:04 GMT+01:00, Magnus Röös : >>> Partial port of the ARM Neon for aarch64. >> >> Reproduced a >20% speedup for fate-vp8 and applied. >> >> Thank you, Carl Eugen > > This seems to have broken bui

Re: [FFmpeg-devel] [PATCH] libavcodec: vp8 neon optimizations for aarch64

2019-02-05 0:59 GMT+01:00, James Almer : > On 1/31/2019 4:23 PM, Carl Eugen Hoyos wrote: >> 2019-01-31 17:04 GMT+01:00, Magnus Röös : >>> Partial port of the ARM Neon for aarch64. >> >> Reproduced a >20% speedup for fate-vp8 and applied. >> >> Thank you, Carl Eugen > > This seems to have broken bui

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

On Tue, Feb 5, 2019 at 1:01 AM Carl Eugen Hoyos wrote: > > 2019-02-05 0:53 GMT+01:00, Marton Balint : > > > > > > On Tue, 5 Feb 2019, Carl Eugen Hoyos wrote: > > > >> 2019-02-03 16:24 GMT+01:00, Marton Balint : > >>> > >>> > >>> On Sun, 3 Feb 2019, Carl Eugen Hoyos wrote: > >>> > 2019-01-28 2

Re: [FFmpeg-devel] [PATCH] avformat/mov: validate chunk_count vs stsc_data

On Sat, Feb 2, 2019 at 3:55 AM Michael Niedermayer wrote: > > static inline int64_t mov_get_stsc_samples(MOVStreamContext *sc, > unsigned int index) > > { > > -int chunk_count; > > +unsigned int chunk_count = 0; > > > > if (mov_stsc_index_valid(index, sc->stsc_count)) > >

[FFmpeg-devel] [PATCH] avformat/mov: validate chunk_count vs stsc_data

Bad content may contain stsc boxes with a first_chunk index that exceeds stco.entries (chunk_count). This ammends the existing check to include cases where chunk_count == 0. --- libavformat/mov.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavfo

Re: [FFmpeg-devel] [PATCH] avcodec/gsm_parser: return -1 on parse error

> > The underlined bit above seems like the root cause. Where should we be > updating st->internal->avctx->codec_id? > Friendly ping for review ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avformat/movenc: Add more error checking when writing sample entries.

Fixes a problem where a sample entry which cannot be written correctly appears to succeed, but produces an invalid file. For example, this command: ffmpeg -f lavfi -i sine=frequency=1000:duration=5 -codec:a ac3 -movflags +empty_moov -frag_duration 500 /tmp/foo.mp4 produced a file with the ac-

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Add more error checking when writing sample entries.

Hi Nikolas, > On Feb 4, 2019, at 5:02 PM, Nikolas Bowe > wrote: > > Fixes a problem where a sample entry which cannot be written correctly > appears to succeed, but produces an invalid file. > For example, this command: > ffmpeg -f lavfi -i sine=frequency=1000:duration=5 -codec:a ac3 -movflags

[FFmpeg-devel] [PATCH] avformat/utils: parse some stream specifiers recursively

This removes lots of code duplication and also allows more complex specifiers, for example you can use p:204:a:m:language:eng to select the English language audio stream from program 204. Signed-off-by: Marton Balint --- doc/fftools-common-opts.texi | 30 +++- libavformat/utils.c |

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

2019-02-05 1:13 GMT+01:00, Hendrik Leppkes : > On Tue, Feb 5, 2019 at 1:01 AM Carl Eugen Hoyos wrote: >> >> 2019-02-05 0:53 GMT+01:00, Marton Balint : >> > >> > >> > On Tue, 5 Feb 2019, Carl Eugen Hoyos wrote: >> > >> >> 2019-02-03 16:24 GMT+01:00, Marton Balint : >> >>> >> >>> >> >>> On Sun, 3 Fe

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Add more error checking when writing sample entries.

Hi Baptiste. I agree. This patch does cause it to fail in mov_write_header in the given example, by propagating the errors returned from mov_write_ac3_tag. It is not always extradata related. Eg EAC3 parses the packets during muxing to build the dec3 atom. Perhaps this should be made extradata, bu

[FFmpeg-devel] [PATCH] avformat/movenc: Fix muxing EAC3 with delay_moov

When using delay_moov mov_write_moov_tag gets called multiple times. Therefore we need to keep eac3_priv around for subsequent calls. Signed-off-by: Nikolas Bowe --- libavformat/movenc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/mo

Re: [FFmpeg-devel] [PATCH] movenc: Fix VPCC bitdepth for hardware pixel formats

My apologies. I realized I applied my patch incorrectly before sending this. I will send a corrected version tomorrow On Thu, Jan 31, 2019 at 4:28 PM Nikolas Bowe wrote: > If a hardware encoder is used, the pixel format may be a hardware pixel > format. > This leads to invalid VPCC atom being

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix muxing EAC3 with delay_moov

2019-02-05 3:11 GMT+01:00, Nikolas Bowe : > +if (mov->tracks[i].eac3_priv) > +av_freep(&mov->tracks[i].eac3_priv); I would have expected that the if() is unneeded, no? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] lavf/mov: fix hang while seek on a kind of fragmented mp4.

I also think it would be better if we store pts-es in different lists for each track. However, it does NOT match the original design of data structures. Several boxes will be affected. So I am trying to commit this patch to discuss with maintainers. At present, I prefer the last version patch(fall

Re: [FFmpeg-devel] [PATCH] avutil/ppc/cpu: Fix power8 linux detection

On Tue, 8 Jan 2019 11:08:04 +0200 Lauri Kasanen wrote: > The existing code was in no released kernel that I can see. The corrected code > was added in 3.9. > > Signed-off-by: Lauri Kasanen > --- > libavutil/ppc/cpu.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Applying.

Re: [FFmpeg-devel] [PATCH v6] libswscale/ppc: VSX-optimize 9-16 bit yuv2planeX

On Sun, 13 Jan 2019 10:26:20 +0200 Lauri Kasanen wrote: > ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt > yuv420p16be \ > -s 1920x1728 -f null -vframes 100 -v error -nostats - > > 9-14 bit funcs get about 6x speedup, 16-bit gets about 15x. > Fate passes, each format test