Re: [FFmpeg-devel] [PATCH] swscale/output: Altivec-optimize float yuv2plane1

2018-12-16 Thread Lauri Kasanen
On Sun, 16 Dec 2018 00:22:00 +0100 Michael Niedermayer wrote: > On Sat, Dec 15, 2018 at 06:32:31PM +0200, Lauri Kasanen wrote: > > Tested on POWER8 LE. Testing on earlier ppc and/or BE appreciated. > > > > libswscale/ppc/swscale_altivec.c | 139 > > ++- > >

[FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize float yuv2plane1

2018-12-16 Thread Lauri Kasanen
This function wouldn't benefit from VSX instructions, so I put it under altivec. ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt grayf32le \ -f null -vframes 100 -v error -nostats - 3743 UNITS in planar1, 65495 runs, 41 skips -cpuflags 0 23511 UNITS in planar1, 65

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/rasc: Check that the number of moves is less than or equal the number of pixels

2018-12-16 Thread Michael Niedermayer
On Sat, Dec 15, 2018 at 09:31:21AM +0100, Paul B Mahol wrote: > On 12/15/18, Michael Niedermayer wrote: > > Fixes: OOM > > Fixes: > > 10307/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RASC_fuzzer-5393974559244288 > > > > Found-by: continuous fuzzing process > > https://github.com/google/oss-

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp7: Check for end of input in vp78_decode_mv_mb_modes()

2018-12-16 Thread Michael Niedermayer
On Sat, Dec 15, 2018 at 01:21:52PM +1100, Peter Ross wrote: > On Sat, Dec 15, 2018 at 02:44:43AM +0100, Michael Niedermayer wrote: > > Fixes: Timeout > > Fixes: > > 10313/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP7_fuzzer-5637719389110272 > > > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avformat/nutenc: Document trailer index assert better

2018-12-16 Thread Michael Niedermayer
On Fri, Dec 14, 2018 at 09:59:25PM +0100, Paul B Mahol wrote: > On 12/14/18, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/nutenc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/nutenc.c b/libavformat/nutenc

Re: [FFmpeg-devel] [PATCH] lavf/mov: ensure only one tkhd per trak

2018-12-16 Thread Michael Niedermayer
On Sat, Dec 15, 2018 at 11:48:27AM -0800, Baptiste Coudurier wrote: > Hi Chris, > > > On Dec 14, 2018, at 3:12 PM, Chris Cunningham > > wrote: > > > >> > >> from a quick look, i did not find a file this breaks > >> > > > > Woot. Baptiste, I'm happy with this last patch if you are. > > Yes,

[FFmpeg-devel] [PATCH 2/2] avcodec/fft_template: reindent after the previous commit

2018-12-16 Thread Steven Liu
Signed-off-by: Steven Liu --- libavcodec/fft_template.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavcodec/fft_template.c b/libavcodec/fft_template.c index 2d97534505..657f07b487 100644 --- a/libavcodec/fft_template.c +++ b/libavcodec/f

[FFmpeg-devel] [PATCH 1/2] avcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-16 Thread Steven Liu
move the two if condition out of the loop, that can less n-1 times than condition in loop. Signed-off-by: Steven Liu --- libavcodec/fft_template.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavcodec/fft_template.c b/libavcodec/fft_template.c index 762

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-16 Thread Moritz Barsnick
On Sun, Dec 16, 2018 at 21:19:17 +0800, Steven Liu wrote: > move the two if condition out of the loop, that can less n-1 times than > condition > in loop. [...] > k = -split_radix_permutation(i, n, s->inverse) & (n-1); > -if (s->revtab) > s->revtab[k] = j;

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-16 Thread Steven Liu
> On Dec 16, 2018, at 21:47, Moritz Barsnick wrote: > > On Sun, Dec 16, 2018 at 21:19:17 +0800, Steven Liu wrote: >> move the two if condition out of the loop, that can less n-1 times than >> condition >> in loop. > [...] >> k = -split_radix_permutation(i, n, s->inverse) & (n-1); >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/g723_1: add support for stereo files

2018-12-16 Thread Carl Eugen Hoyos
2018-12-15 13:24 GMT+01:00, Paul B Mahol : [...] Can you share an existing sample? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/g723_1: add support for stereo files

2018-12-16 Thread Paul B Mahol
On 12/16/18, Carl Eugen Hoyos wrote: > 2018-12-15 13:24 GMT+01:00, Paul B Mahol : > > [...] > > Can you share an existing sample? I'm afraid not. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/g723_1: add support for stereo files

2018-12-16 Thread Carl Eugen Hoyos
2018-12-16 16:02 GMT+01:00, Paul B Mahol : > On 12/16/18, Carl Eugen Hoyos wrote: >> 2018-12-15 13:24 GMT+01:00, Paul B Mahol : >> >> [...] >> >> Can you share an existing sample? > > I'm afraid not. Which product encodes / decodes such files? Carl Eugen _

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/g723_1: add support for stereo files

2018-12-16 Thread Paul B Mahol
On 12/16/18, Carl Eugen Hoyos wrote: > 2018-12-16 16:02 GMT+01:00, Paul B Mahol : >> On 12/16/18, Carl Eugen Hoyos wrote: >>> 2018-12-15 13:24 GMT+01:00, Paul B Mahol : >>> >>> [...] >>> >>> Can you share an existing sample? >> >> I'm afraid not. > > Which product encodes / decodes such files? O

[FFmpeg-devel] [PATCH] avfilter/af_apad: add pad_dur and whole_dur options

2018-12-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 18 +++--- libavfilter/af_apad.c | 23 +-- 2 files changed, 36 insertions(+), 5 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index e3415630ec..ac4c9b44d8 100644 --- a/doc/filters.texi +++ b/d

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/g723_1: add support for stereo files

2018-12-16 Thread Carl Eugen Hoyos
2018-12-16 16:37 GMT+01:00, Paul B Mahol : > On 12/16/18, Carl Eugen Hoyos wrote: >> 2018-12-16 16:02 GMT+01:00, Paul B Mahol : >>> On 12/16/18, Carl Eugen Hoyos wrote: 2018-12-15 13:24 GMT+01:00, Paul B Mahol : [...] Can you share an existing sample? >>> >>> I'm afraid n

Re: [FFmpeg-devel] [PATCH] lavf/id3v2: fail read_apic on EOF reading mimetype

2018-12-16 Thread Tomas Härdin
fre 2018-12-14 klockan 13:44 -0800 skrev chcunningham: > avio_read may return EOF, leaving the mimetype array unitialized. > fail > early when this occurs to avoid using the array in an unitialized > state. > --- >  libavformat/id3v2.c | 6 -- >  1 file changed, 4 insertions(+), 2 deletions(-) >

[FFmpeg-devel] [PATCH 1/3] avcodec/rpza: Move frame allocation to a later point

2018-12-16 Thread Michael Niedermayer
This will allow performing some fast checks before the slow allocation Signed-off-by: Michael Niedermayer --- libavcodec/rpza.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavcodec/rpza.c b/libavcodec/rpza.c index b71ebd1cbe..cffbfe4416 100644 --- a/libav

[FFmpeg-devel] [PATCH 3/3] avcodec/fic: Fail on invalid slice size/off

2018-12-16 Thread Michael Niedermayer
Fixes: Timeout Fixes: 11486/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FIC_fuzzer-5677133863583744 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/fic.c | 2 ++ 1 file changed, 2 insert

[FFmpeg-devel] [PATCH 2/3] avcodec/rpza: Check that there is enough data for all the blocks

2018-12-16 Thread Michael Niedermayer
Fixes: Timeout Fixes: 11547/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RPZA_fuzzer-5678435842654208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/rpza.c | 3 +++ 1 file changed, 3 ins

Re: [FFmpeg-devel] [PATCH] avformat: add vividas demuxer

2018-12-16 Thread Tomas Härdin
lör 2018-12-15 klockan 20:06 +0100 skrev Paul B Mahol: > > Signed-off-by: Paul B Mahol > + > +static void put_v(uint8_t *p, int v) This should take unsigned > +{ > +if (v>>28) > +*p++ = ((v>>28)&0x7f)|0x80; > +if (v>>21) > +*p++ = ((v>>21)&0x7f)|0x80; > +if (v>>14) >

[FFmpeg-devel] [PATCH] avformat/vorbiscomment: add support for writing chapters

2018-12-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/flacenc.c | 4 +-- libavformat/matroskaenc.c | 4 +-- libavformat/oggenc.c| 22 +++--- libavformat/vorbiscomment.c | 59 +++-- libavformat/vorbiscomment.h | 8 +++-- 5 files changed, 78 insertio

[FFmpeg-devel] [PATCH] avformat: add vividas demuxer

2018-12-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/vividas.c| 715 +++ 3 files changed, 717 insertions(+) create mode 100644 libavformat/vividas.c diff --git a/libavformat/Makefile b/libavformat

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize float yuv2plane1

2018-12-16 Thread Carl Eugen Hoyos
2018-12-16 10:06 GMT+01:00, Lauri Kasanen : > This function wouldn't benefit from VSX instructions, so I put it > under altivec. > > ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt > grayf32le \ > -f null -vframes 100 -v error -nostats - > > 3743 UNITS in planar1, 65495 runs

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-16 Thread Carl Eugen Hoyos
2018-12-16 14:19 GMT+01:00, Steven Liu : > move the two if condition out of the loop, that can less > n-1 times than condition in loop. Please add some benchmarks to the commit message. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org ht

Re: [FFmpeg-devel] [PATCH]configure: Default to clang for Android

2018-12-16 Thread Carl Eugen Hoyos
2018-12-07 3:06 GMT+01:00, Carl Eugen Hoyos : > I believe the Android documentation indicates that gcc will be removed > from ndk. Attached patch changes the default to "clang" for > --target-os=android. > > Now with patch. Patch applied. Carl Eugen __

Re: [FFmpeg-devel] [PATCH 1/3] lavc/options_table: Change some options location in opt table.

2018-12-16 Thread myp...@gmail.com
On Sun, Dec 16, 2018 at 8:03 AM Michael Niedermayer wrote: > > On Sat, Dec 15, 2018 at 07:31:35PM +0800, Jun Zhao wrote: > > Change the some options location in avcodec_options to make code more > > readable. > > > > Signed-off-by: Jun Zhao > > --- > > libavcodec/options_table.h | 48 > >

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-16 Thread Jan Ekström
On Mon, Dec 10, 2018 at 12:13 AM Michael Niedermayer wrote: > > On Fri, Dec 07, 2018 at 07:34:43PM +0200, Jan Ekström wrote: > > On Wed, Dec 5, 2018 at 7:13 PM Jan Ekström wrote: > > > > > > On Mon, Dec 3, 2018 at 3:19 AM Jan Ekström wrote: > > > > > > > > From: Rodger Combs > > > > > > > > The

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-16 Thread Carl Eugen Hoyos
2018-12-17 1:58 GMT+01:00, Jan Ekström : > On Mon, Dec 10, 2018 at 12:13 AM Michael Niedermayer > wrote: >> >> On Fri, Dec 07, 2018 at 07:34:43PM +0200, Jan Ekström wrote: >> > On Wed, Dec 5, 2018 at 7:13 PM Jan Ekström wrote: >> > > >> > > On Mon, Dec 3, 2018 at 3:19 AM Jan Ekström wrote: >> >

[FFmpeg-devel] [PATCH]lsws/utils: Split "emms_c(); " call in two lines

2018-12-16 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a useless warning when compiling with clang on arm. Please comment, Carl Eugen From b2773d1ca9473380b99400c2bbd5a6729622f51a Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 17 Dec 2018 02:12:13 +0100 Subject: [PATCH] lsws/utils: Split "emms_c();" in two lines.

[FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t *

2018-12-16 Thread Carl Eugen Hoyos
Hi! The Opus struct RawBitsContext is used in both the decoder and the encoder. The fact that *position is const avoids warnings in the decoder where it points into the bitstream. The encoder writes into the same pointer, attached cast silences the warning on targets where AV_WB32() does not inter

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-16 Thread Steven Liu
Carl Eugen Hoyos 于2018年12月17日周一 上午8:29写道: > > 2018-12-16 14:19 GMT+01:00, Steven Liu : > > move the two if condition out of the loop, that can less > > n-1 times than condition in loop. > > Please add some benchmarks to the commit message. Hi Folks, I tested the performance of the modify, before

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-16 Thread Steven Liu
Aleksey Skripka 于2018年12月14日周五 下午10:58写道: > > > From e85edcc4d8b0312c7871f78ed0859ec7436be460 Mon Sep 17 00:00:00 2001 > From: Aleksey Skripka > Date: Fri, 14 Dec 2018 14:48:31 + > Subject: [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file > > 1. fix addressing '->flags' while assi

Re: [FFmpeg-devel] [PATCH 1/2] configure: use custom allocator extralibs when testing memalign and posix_memalign

2018-12-16 Thread Peter Ross
On Sun, Dec 09, 2018 at 09:27:54AM +1100, Peter Ross wrote: > the memalign and posix_memalign tests currently fail when using a custom > allocator, > because configure does not include the custom allocator library. is any one using custom allocators? should i just apply these? -- Peter (A907 E02

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Added support for Low-latency HLS(Experimental)

2018-12-16 Thread Jeyapal, Karthick
On 12/12/18 9:50 PM, Karthick J wrote: > Apple doesn't have an official spec for LHLS. Meanwhile hls.js player folks > are > trying to standardize a open LHLS spec. The draft spec is available in > https://github.com/video-dev/hlsjs-rfcs/blob/lhls-spec/proposals/0001-lhls.md > This option will a

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-16 Thread Jan Ekström
On Mon, Dec 17, 2018, 03:02 Carl Eugen Hoyos 2018-12-17 1:58 GMT+01:00, Jan Ekström : > > On Mon, Dec 10, 2018 at 12:13 AM Michael Niedermayer > > wrote: > >> > >> On Fri, Dec 07, 2018 at 07:34:43PM +0200, Jan Ekström wrote: > >> > On Wed, Dec 5, 2018 at 7:13 PM Jan Ekström wrote: > >> > > > >>

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize float yuv2plane1

2018-12-16 Thread Lauri Kasanen
On Mon, 17 Dec 2018 01:03:36 +0100 Carl Eugen Hoyos wrote: > 2018-12-16 10:06 GMT+01:00, Lauri Kasanen : > > This function wouldn't benefit from VSX instructions, so I put it > > under altivec. > > > > ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt > > grayf32le \ > > -f nu

Re: [FFmpeg-devel] [PATCH 1/2 v3] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-12-16 Thread Jan Ekström
On Mon, Dec 17, 2018, 08:58 Jan Ekström > > On Mon, Dec 17, 2018, 03:02 Carl Eugen Hoyos >> 2018-12-17 1:58 GMT+01:00, Jan Ekström : >> > On Mon, Dec 10, 2018 at 12:13 AM Michael Niedermayer >> > wrote: >> >> >> >> On Fri, Dec 07, 2018 at 07:34:43PM +0200, Jan Ekström wrote: >> >> > On Wed, Dec