[FFmpeg-devel] [PATCH] avcodec/libopenh264enc.c: Handle sample_aspect_ratio in libopenh264 encoder

2018-10-12 Thread Valery Kot
When using libx264 (GPL) encoder, sample aspect ratio gets stored on both container and frame levels. For libopenh264 (LGPL) encoder, aspect ratio on codec/frame level currently is ignored, which results in weird display aspect ratio for non-square pixels on some players. Proposed patch fixes that

Re: [FFmpeg-devel] avcodec/libopenh264enc.c

2018-10-12 Thread Valery Kot
I sent a (hopefully valid) patch along with a proper commit message. It resulted in a new thread, sorry. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] ffv1enc: question about "Cannot allocate worst case packet size, the encoding could fail"

2018-10-12 Thread Carl Eugen Hoyos
2018-10-11 14:01 GMT+02:00, Jerome Martinez : > - why is having a number > INT_MAX an issue? modern machines > are 64-bit and have 8+ GB of RAM So where is the issue? If above is true for you, can can simply remove the check locally, no? (I hope you agree that what you write is not generally true

Re: [FFmpeg-devel] [PATCH 3/3] h264/pic_timing: support multiple timecodes

2018-10-12 Thread Carl Eugen Hoyos
2018-10-11 15:04 GMT+02:00, Joshua de Kock : > On 9 October 2018 at 21:03, Carl Eugen Hoyos wrote: >> 2018-10-09 15:32 GMT+02:00, jos...@ob-encoder.com : >>> From: Josh de Kock >> >>> [...] >> >> If the first patch gets committed as-is, please split this one >> in a functional and a cosmetic patc

Re: [FFmpeg-devel] [PATCH] lavf/vc1test: fix vc1test can't probe some RCV file.

2018-10-12 Thread Carl Eugen Hoyos
2018-10-12 4:37 GMT+02:00, Jun Zhao : > case 1: > use the hexdump -C SMM0005.rcv get: > size skip (size - 4) > || > VV > 18 00 00 c5 05 00 00 00 4d f1 0a 11 00 e0

Re: [FFmpeg-devel] ffv1enc: question about "Cannot allocate worst case packet size, the encoding could fail"

2018-10-12 Thread Jerome Martinez
On 12/10/2018 11:15, Carl Eugen Hoyos wrote: 2018-10-11 14:01 GMT+02:00, Jerome Martinez : - why is having a number > INT_MAX an issue? modern machines are 64-bit and have 8+ GB of RAM So where is the issue? The issue is that vanilla FFmpeg shows a warning in the scenario I indicate (a 128

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc_hevc: correction for QSV HEVC default plugin selection on Windows

2018-10-12 Thread Maxym Dmytrychenko
On Tue, Oct 9, 2018 at 3:50 AM Landgraph wrote: > 1. Old logic meaned: everywhere, except Windows, ffmpeg has to use HW > acceleration, but on Windows ffmpeg has to use (unavailable) software > encode by default > 2. Software encode is available only if you provide corresponding > software MediaS

[FFmpeg-devel] [PATCH] avformat: add SER demuxer

2018-10-12 Thread Paul B Mahol
Fixes #6821. Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/serdec.c | 138 +++ 3 files changed, 140 insertions(+) create mode 100644 libavformat/serdec.c diff --git a/libavformat/Makefile

[FFmpeg-devel] [PATCH] avformat: add SER demuxer

2018-10-12 Thread Paul B Mahol
Fixes #6821. Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/serdec.c | 138 +++ 3 files changed, 140 insertions(+) create mode 100644 libavformat/serdec.c diff --git a/libavformat/Makefile

Re: [FFmpeg-devel] ffv1enc: question about "Cannot allocate worst case packet size, the encoding could fail"

2018-10-12 Thread Jan Ekström
On Fri, Oct 12, 2018 at 12:59 PM Jerome Martinez wrote: > I kindly request more details about how hard coding 2 GB in the code > helps, for both machines having 1 GB & machines having 8 GB. Looks like > I am personally not smart enough for understanding that alone. > > Jérôme > `git gui blame --

Re: [FFmpeg-devel] [PATCH] lavf/vc1test: fix vc1test can't probe some RCV file.

2018-10-12 Thread myp...@gmail.com
On Fri, Oct 12, 2018 at 5:19 PM Carl Eugen Hoyos wrote: > 2018-10-12 4:37 GMT+02:00, Jun Zhao : > > case 1: > > use the hexdump -C SMM0005.rcv get: > > size skip (size - 4) > > || > > V

[FFmpeg-devel] [PATCH] fate: add api-h264-slice test

2018-10-12 Thread joshdk
From: Josh de Kock This test ensures that you are able to send N number of slice NALUs in slice threaded mode to be decoded simultaneously --- tests/api/Makefile | 1 + tests/api/api-h264-slice-test.c | 213 ++ tests/fate/api.mak | 4 + tests/re

Re: [FFmpeg-devel] ffv1enc: question about "Cannot allocate worst case packet size, the encoding could fail"

2018-10-12 Thread Jan Ekström
On Thu, Oct 11, 2018 at 4:04 PM Jerome Martinez wrote: > > In this case, the ratio (148 times the size of input) is proportional to > the input frame size, and the test is on a fixed value (MAX_INT). > I get now the reason to reserve more than the size of the input frame. > I don't get the relatio

[FFmpeg-devel] [PATCH v2 1/4] lavc/h264: create AVFrame side data from H.264 timecodes

2018-10-12 Thread joshdk
From: Devin Heitmueller Create SMPTE ST 12-1 timecodes based on H.264 SEI picture timing info. For framerates > 30 FPS, the field flag is used in conjunction with pairs of frames which contain the same frame timestamp in S12M. Ensure the field is properly set per the spec. --- libavcodec/h264_s

[FFmpeg-devel] [PATCH v4 2/4] h264/pic_timing: support multiple timecodes

2018-10-12 Thread joshdk
From: Josh de Kock --- There are no cosmetic changes which are not functional here. libavcodec/h264_sei.c | 21 --- libavcodec/h264_sei.h | 28 +-- libavcodec/h264_slice.c | 59 +++-- 3 files changed, 65 insertions(+), 43 dele

[FFmpeg-devel] [PATCH 3/4] lavfi/vf_showinfo: support displaying S12M timecode sidedata

2018-10-12 Thread joshdk
From: Josh de Kock --- libavfilter/vf_showinfo.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index d1d1415c0b..689b5399db 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -32,6 +32,7 @@ #include "

[FFmpeg-devel] [PATCH v2 4/4] fate: add h264 timecode test

2018-10-12 Thread joshdk
From: Josh de Kock --- tests/fate/h264.mak | 2 + tests/ref/fate/h264-timecode | 305 +++ 2 files changed, 307 insertions(+) create mode 100644 tests/ref/fate/h264-timecode diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak index 1839b9b44e..f14b4

[FFmpeg-devel] [PATCH V2 1/2] lavf/vc1test: fix vc1test can't probe some RCV file.

2018-10-12 Thread Jun Zhao
case 1: use the hexdump -C SMM0005.rcv get: size skip (size - 4) || VV 18 00 00 c5 05 00 00 00 4d f1 0a 11 00 e0 01 00 0010 00 d0 02 00 00 0c 00 00 00 88 13

[FFmpeg-devel] [PATCH v3] fate: add api-h264-slice test

2018-10-12 Thread joshdk
From: Josh de Kock This test ensures that you are able to send N number of slice NALUs in slice threaded mode to be decoded simultaneously --- Ignore the previous patch, had some dead code in it. This now works in MinGW as well. tests/api/Makefile | 1 + tests/api/api-h264-sl

[FFmpeg-devel] [PATCH V2 2/2] lavf/vc1test: add rcv to vc1test demuxer extensions

2018-10-12 Thread Jun Zhao
rcv is commonly used as extension for vc1 test stream files. Signed-off-by: Jun Zhao --- libavformat/vc1test.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavformat/vc1test.c b/libavformat/vc1test.c index 82e155a..a252bf0 100644 --- a/libavformat/vc1test.c +++ b/li

Re: [FFmpeg-devel] ffv1enc: question about "Cannot allocate worst case packet size, the encoding could fail"

2018-10-12 Thread Jerome Martinez
On 12/10/2018 15:30, Jan Ekström wrote: And while it seems like we're focusing on the arbitrary limit in av_malloc (which is an issue of its own), I do note that for this specific case this "worst case packed frame size" allocation heuristic might have to be modified? Or at least explained if pos

Re: [FFmpeg-devel] [PATCH V2 1/2] lavf/vc1test: fix vc1test can't probe some RCV file.

2018-10-12 Thread Carl Eugen Hoyos
2018-10-12 15:41 GMT+02:00, Jun Zhao : > case 1: > use the hexdump -C SMM0005.rcv get: > size skip (size - 4) > || > VV > 18 00 00 c5 05 00 00 00 4d f1 0a 11 00 e

Re: [FFmpeg-devel] ffv1enc: question about "Cannot allocate worst case packet size, the encoding could fail"

2018-10-12 Thread Paul B Mahol
On 10/12/18, Jerome Martinez wrote: > On 12/10/2018 15:30, Jan Ekstroem wrote: >> And while it seems like we're focusing on the arbitrary limit in >> av_malloc (which is an issue of its own), I do note that for this >> specific case this "worst case packed frame size" allocation heuristic >> might

Re: [FFmpeg-devel] ffv1enc: question about "Cannot allocate worst case packet size, the encoding could fail"

2018-10-12 Thread Carl Eugen Hoyos
2018-10-12 11:59 GMT+02:00, Jerome Martinez : > On 12/10/2018 11:15, Carl Eugen Hoyos wrote: >> 2018-10-11 14:01 GMT+02:00, Jerome Martinez : >> >>> - why is having a number > INT_MAX an issue? modern machines >>> are 64-bit and have 8+ GB of RAM >> So where is the issue? > > The issue is that vani

Re: [FFmpeg-devel] [PATCH V2 1/2] lavf/vc1test: fix vc1test can't probe some RCV file.

2018-10-12 Thread myp...@gmail.com
On Fri, Oct 12, 2018 at 10:35 PM Carl Eugen Hoyos wrote: > > 2018-10-12 15:41 GMT+02:00, Jun Zhao : > > case 1: > > use the hexdump -C SMM0005.rcv get: > > size skip (size - 4) > > || > > V

Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsvenc_jpeg: add async_depth support

2018-10-12 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Zhong Li > Sent: Thursday, October 11, 2018 2:30 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Li, Zhong > Subject: [FFmpeg-devel] [PATCH 1/2] lavc/qsvenc_jpeg: add async_depth support > > Currentl

Re: [FFmpeg-devel] [PATCH 02/12] avformat/mxfenc: write index delta entry array needed by sony vegas pro 11

2018-10-12 Thread Baptiste Coudurier
On Thu, Jul 12, 2018 at 12:44 PM Baptiste Coudurier < baptiste.coudur...@gmail.com> wrote: > Hey Thomas, > > On Thu, Jul 12, 2018 at 12:29 PM, Tomas Härdin wrote: > >> Is this the latest/correct patch series for these things? I saw some >> other patches conflicted with Marton's work >> > > Yes, t

Re: [FFmpeg-devel] [PATCH 05/12] avformat/mxfenc: correctly set content package rate in system element

2018-10-12 Thread Baptiste Coudurier
On Thu, Jul 19, 2018 at 8:37 AM Baptiste Coudurier < baptiste.coudur...@gmail.com> wrote: > On Wed, Jul 4, 2018 at 11:35 AM, Baptiste Coudurier < > baptiste.coudur...@gmail.com> wrote: > >> --- >> libavformat/mxf.c| 17 + >> libavformat/mxf.h| 2 ++ >> libavformat/mxfenc.

Re: [FFmpeg-devel] [PATCH 03/12] avformat/mxfenc: add mpeg-2 specific metadata, fix compatibility with sony content browser

2018-10-12 Thread Baptiste Coudurier
On Thu, Jul 19, 2018 at 8:42 AM Baptiste Coudurier < baptiste.coudur...@gmail.com> wrote: > On Wed, Jul 4, 2018 at 11:35 AM, Baptiste Coudurier < > baptiste.coudur...@gmail.com> wrote: > >> --- >> libavformat/mxfenc.c| 46 ++--- >> tests/ref/lavf/mxf

Re: [FFmpeg-devel] [PATCH 04/12] avformat/mxfenc: update body partition with footer offset

2018-10-12 Thread Baptiste Coudurier
On Thu, Jul 19, 2018 at 8:40 AM Baptiste Coudurier < baptiste.coudur...@gmail.com> wrote: > On Wed, Jul 4, 2018 at 11:35 AM, Baptiste Coudurier < > baptiste.coudur...@gmail.com> wrote: > >> --- >> libavformat/mxfenc.c| 9 +++-- >> tests/ref/lavf/mxf | 6 +++--- >> tes

Re: [FFmpeg-devel] [PATCH v2] lavf/mxfenc: support creating s436m data tracks

2018-10-12 Thread Baptiste Coudurier
On Mon, Sep 24, 2018 at 1:55 PM Baptiste Coudurier < baptiste.coudur...@gmail.com> wrote: > On Thu, Jul 19, 2018 at 2:32 PM Michael Niedermayer > wrote: > >> On Wed, Jul 04, 2018 at 03:06:54PM -0700, Baptiste Coudurier wrote: >> > --- >> > libavformat/mxf.c| 1 + >> > libavformat/mxfdec.c |

Re: [FFmpeg-devel] [PATCH 10/12] lavf/mxfdec: demux s436m as eia608 subtitle track

2018-10-12 Thread Baptiste Coudurier
On Wed, Jul 4, 2018 at 1:50 PM Marton Balint wrote: > > > On Wed, 4 Jul 2018, Baptiste Coudurier wrote: > > > --- > > libavformat/mxfdec.c | 102 +++ > > 1 file changed, 102 insertions(+) > > > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > > i

Re: [FFmpeg-devel] [PATCH 02/12] avformat/mxfenc: write index delta entry array needed by sony vegas pro 11

2018-10-12 Thread Baptiste Coudurier
On Fri, Oct 12, 2018 at 12:16 PM Baptiste Coudurier < baptiste.coudur...@gmail.com> wrote: > On Thu, Jul 12, 2018 at 12:44 PM Baptiste Coudurier < > baptiste.coudur...@gmail.com> wrote: > >> Hey Thomas, >> >> On Thu, Jul 12, 2018 at 12:29 PM, Tomas Härdin >> wrote: >> >>> Is this the latest/corre

[FFmpeg-devel] [PATCH 2/2] avformat/rpl: Support files containing 8 bit PCM or VIDC audio

2018-10-12 Thread Cameron Cawley
Signed-off-by: Cameron Cawley --- libavformat/rpl.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/libavformat/rpl.c b/libavformat/rpl.c index d373600478..6b45b35c30 100644 --- a/libavformat/rpl.c +++ b/libavformat/rpl.c @@ -119,6 +119,8 @@ static int rpl_re

[FFmpeg-devel] [PATCH 1/2] avcodec: Implement Archimedes VIDC encoder/decoder

2018-10-12 Thread Cameron Cawley
Signed-off-by: Cameron Cawley --- doc/general.texi | 2 ++ libavcodec/Makefile | 2 ++ libavcodec/allcodecs.c| 2 ++ libavcodec/avcodec.h | 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/pcm.c | 15 +++ libavcodec/pcm_tablegen.c | 2 ++ l

Re: [FFmpeg-devel] [PATCH V2 1/2] lavf/vc1test: fix vc1test can't probe some RCV file.

2018-10-12 Thread myp...@gmail.com
On Sat, Oct 13, 2018 at 12:55 AM myp...@gmail.com wrote: > > On Fri, Oct 12, 2018 at 10:35 PM Carl Eugen Hoyos wrote: > > > > 2018-10-12 15:41 GMT+02:00, Jun Zhao : > > > case 1: > > > use the hexdump -C SMM0005.rcv get: > > > size skip (size - 4) > > >

Re: [FFmpeg-devel] ffv1enc: question about "Cannot allocate worst case packet size, the encoding could fail"

2018-10-12 Thread Michael Niedermayer
On Fri, Oct 12, 2018 at 04:23:43PM +0200, Jerome Martinez wrote: > On 12/10/2018 15:30, Jan Ekström wrote: > >And while it seems like we're focusing on the arbitrary limit in > >av_malloc (which is an issue of its own), I do note that for this > >specific case this "worst case packed frame size" al

[FFmpeg-devel] [PATCH] avformat/utils: Never store negative values in last_IP_duration

2018-10-12 Thread Michael Niedermayer
Fixes: integer overflow compute_pkt_fields() Fixes: compute_pkt_usan Reported-by: Thomas Guilbert Signed-off-by: Michael Niedermayer --- libavformat/utils.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index fa3699daef..93e58

[FFmpeg-devel] Fixing rotation metadata override

2018-10-12 Thread Gilles
Hi, here is a fix for issue: https://trac.ffmpeg.org/ticket/4560 Background: since FFmpeg 3.3, it is not possible to force the rotation metadata to 0, when video is being converted. It only work in -c:v copy mode. Can you please have a look at it ? Thanks 0001-Fix-rotation-metadata-override-wh