Re: [FFmpeg-devel] avcodec/proresenc_aw : add support for prores 444

2018-07-22 Thread Martin Vignali
> > > > Speed (from prores 422 HQ file -> Prores 444) > > > > ./ffmpeg -i prores422hqfile.mov -pix_fmt yuv444p10 -c:v prores -an > > -profile:v 4 res_aw.mov -y > > ==> 25 fps > > > > ./ffmpeg -i prores422hqfile.mov -pix_fmt yuv444p10 -c:v prores_ks -an > > -profile:v 4 res_ks.mov -y > > ==> 10 fps

Re: [FFmpeg-devel] avcodec/proresenc_aw improvements

2018-07-22 Thread Martin Vignali
> > > 001 : use scantable in prores_data instead of a duplicate one. > > This could negativly affect the performance of the changed inner loop > have you checked that the changed function does not become slower ? > > > No, i will make some tests. > > -*buf++ = 6; > > +*buf++ = pict->color_

Re: [FFmpeg-devel] [PATCH 3/3] lavfi/motion_estimation: use pixelutils API for sad.

2018-07-22 Thread Marton Balint
On Tue, 17 Jul 2018, myp...@gmail.com wrote: On Sun, Jul 15, 2018 at 1:03 AM Michael Niedermayer wrote: On Sat, Jul 14, 2018 at 12:04:46PM +0200, Marton Balint wrote: > > > On Sat, 14 Jul 2018, Michael Niedermayer wrote: > > >On Fri, Jul 13, 2018 at 10:51:00AM +0200, Marton Balint wrote: >

[FFmpeg-devel] [PATCH 2/5] avcodec/dirac_dwt_template: Fix several integer overflows in horizontal_compose_daub97i()

2018-07-22 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int' Fixes: 8926/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-6047609228623872 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Micha

[FFmpeg-devel] [PATCH 5/5] avcodec/diracdec: Check bytes count in else branch in decode_lowdelay() too

2018-07-22 Thread Michael Niedermayer
Fixes: signed integer overflow: 8 * 340018243 cannot be represented in type 'int' Fixes: 9441/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5194665207791616 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michae

[FFmpeg-devel] [PATCH 1/5] avcodec/diracdec: Prevent integer overflow in intermediate in global_mv()

2018-07-22 Thread Michael Niedermayer
Fixes: signed integer overflow: -393471 * 5460 cannot be represented in type 'int' Fixes: 8890/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-6299775379963904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Micha

[FFmpeg-devel] [PATCH 4/5] avcodec/diracdec: Check slice numbers for overflows in relation to picture dimensions

2018-07-22 Thread Michael Niedermayer
Fixes: signed integer overflow: 88 * 33685506 cannot be represented in type 'int' Fixes: 9433/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5725943535501312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michae

[FFmpeg-devel] [PATCH 3/5] avcodec/diracdec: Change frame_number to 64bit as its a 32bit from the bitstream and we also have a -1 special case

2018-07-22 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int' Fixes: 9291/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-6324345860259840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Micha

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/tscc: Move reading the side data palette before other checks

2018-07-22 Thread Michael Niedermayer
On Sun, Jul 15, 2018 at 03:13:39PM +0200, Michael Niedermayer wrote: > We do not want to loose the side data in case of errors > > Signed-off-by: Michael Niedermayer > --- > libavcodec/tscc.c | 23 ++- > 1 file changed, 14 insertions(+), 9 deletions(-) will apply [...] --

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/tscc: Do not duplicate images

2018-07-22 Thread Michael Niedermayer
On Sun, Jul 15, 2018 at 03:13:40PM +0200, Michael Niedermayer wrote: > This improves speed > > Fixes: Timeout > Fixes: > 9010/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TSCC_fuzzer-6042614817095680 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/cdgraphics: Clear first frame only once

2018-07-22 Thread Michael Niedermayer
On Sun, Jul 15, 2018 at 03:13:41PM +0200, Michael Niedermayer wrote: > frame_number will not increase if nothing is output > > Fixes: Timeout > Fixes: > 9057/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CDGRAPHICS_fuzzer-4844661498707968 > > Found-by: continuous fuzzing process > https://g

Re: [FFmpeg-devel] avcodec/proresenc_aw improvements

2018-07-22 Thread Michael Niedermayer
On Sun, Jul 22, 2018 at 01:04:29PM +0200, Martin Vignali wrote: > > > > > 001 : use scantable in prores_data instead of a duplicate one. > > > > This could negativly affect the performance of the changed inner loop > > have you checked that the changed function does not become slower ? > > > > > >