Re: [FFmpeg-devel] [PATCH] libswresample: Use channel count if channel layout is undefined

2018-07-20 Thread Tobias Rapp
On 19.07.2018 23:37, Michael Niedermayer wrote: On Thu, Jul 19, 2018 at 01:53:09PM +0200, Tobias Rapp wrote: On 18.07.2018 19:31, Marcin Gorzel wrote: Rematrixing supports up to 64 channels. However, there is only a limited number of channel layouts defined. Since the in/out channel count is o

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: fix undefined behavior with rc_max_rate=0

2018-07-20 Thread Thomas Guillem
On Thu, Jul 19, 2018, at 18:27, Aman Gupta wrote: > On Fri, Jul 6, 2018 at 10:55 PM Thomas Guillem wrote: > > > > > > > On Thu, Jul 5, 2018, at 20:49, Aman Gupta wrote: > > > On Wed, Jul 4, 2018 at 3:05 AM Thomas Guillem wrote: > > > > > > > On macOS, a zero rc_max_rate cause an error from > >

Re: [FFmpeg-devel] [PATCH] libavcodec/escape130: fixes and improvements

2018-07-20 Thread Michael Chaban
2018-07-19 21:28 GMT+03:00 Carl Eugen Hoyos : > The first commit breaks fate, you have to (confirm the fix and) > change the reference values in the same patch. The first commit fixes the wrong decoding which was error in first place for FFmpeg Escape130 implementation. The decoded frame examples

Re: [FFmpeg-devel] [PATCH] avutil/pixfmt: Document chroma plane size for odd resolutions

2018-07-20 Thread Michael Niedermayer
On Thu, Jul 19, 2018 at 12:15:02AM +0200, Carl Eugen Hoyos wrote: > 2018-07-18 22:23 GMT+02:00, Michael Niedermayer : > > Signed-off-by: Michael Niedermayer > > --- > > libavutil/pixfmt.h | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h >

Re: [FFmpeg-devel] [PATCH] Optimize libavformat/metadata.c

2018-07-20 Thread Shlomi Fish
On Wed, 11 Jul 2018 19:42:09 +0300 Shlomi Fish wrote: > On Wed, 4 Jul 2018 23:10:46 +0300 > Shlomi Fish wrote: > > Ping! Can this patch be reviewed please? > Ping! > -- - Shlomi Fish http://www.shlomifish.org/ Summer

Re: [FFmpeg-devel] [PATCH 3/5] Renamed reinterlace to tinterlace

2018-07-20 Thread Vasile Toncu
Hi, Did you have the time to take a look at patches 2 and 3? It's everything fine? Regards, Vasile On Mon, Jul 16, 2018 at 5:51 PM, Vasile Toncu wrote: > Hello, > > I have updated patch 3, it shall work now. > > Thank you, > Vasile Toncu > ___ ffmpeg

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/bink: add 'k' version support

2018-07-20 Thread Paul B Mahol
On 7/19/18, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/bink.c | 21 + > 1 file changed, 21 insertions(+) > Will apply. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listin

[FFmpeg-devel] [PATCH 1/2] docs/filters: add documentation to all existing OpenCL filters

2018-07-20 Thread Danil Iashchenko
docs/filters: add documentation to all existing OpenCL filters --- doc/filters.texi | 458 +++ 1 file changed, 458 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 705d48e..d206972 100644 --- a/doc/filters.texi +++ b/doc/fil

[FFmpeg-devel] [PATCH 2/2] moved program_opencl and openclsrc filters to OpenCL section

2018-07-20 Thread Danil Iashchenko
moved program_opencl and openclsrc filters to OpenCL section --- doc/filters.texi | 404 +++ 1 file changed, 202 insertions(+), 202 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index d206972..d9458cd 100644 --- a/doc/filters.te

[FFmpeg-devel] [PATCH] doc/filters: update info about avgblur filter to make it more understandable

2018-07-20 Thread Danil Iashchenko
doc/filters: update info about avgblur filter to make it more understandable --- doc/filters.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 705d48e..e3005c3 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -5431,13 +54

Re: [FFmpeg-devel] [PATCH] ffv1dec: Ensure that pixel format constraints are respected

2018-07-20 Thread Michael Niedermayer
On Thu, Jul 19, 2018 at 05:06:09PM +0200, Vittorio Giovara wrote: > On Wed, Jul 18, 2018 at 10:37 PM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > > On Wed, Jul 18, 2018 at 11:03:47AM -0400, Derek Buitenhuis wrote: > > > On Wed, Jul 18, 2018 at 10:01 AM, Vittorio Giovara > > > wrote

Re: [FFmpeg-devel] [PATCH 3/5] Renamed reinterlace to tinterlace

2018-07-20 Thread Paul B Mahol
On 7/20/18, Vasile Toncu wrote: > Hi, > > Did you have the time to take a look at patches 2 and 3? It's everything > fine? Yes and no, patches have tabs. Please fix that. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/li

Re: [FFmpeg-devel] [PATCH] libswresample: Use channel count if channel layout is undefined

2018-07-20 Thread Michael Niedermayer
On Fri, Jul 20, 2018 at 09:51:49AM +0200, Tobias Rapp wrote: > On 19.07.2018 23:37, Michael Niedermayer wrote: > >On Thu, Jul 19, 2018 at 01:53:09PM +0200, Tobias Rapp wrote: > >>On 18.07.2018 19:31, Marcin Gorzel wrote: > >>>Rematrixing supports up to 64 channels. However, there is only a limited

Re: [FFmpeg-devel] [PATCH] avcodec/decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext

2018-07-20 Thread Michael Niedermayer
On Thu, Jul 19, 2018 at 10:54:23PM -0300, James Almer wrote: > Certain AVCodecParameters, like the contents of the extradata, may be changed > by the init() function of any of the bitstream filters in the chain. > > Signed-off-by: James Almer > --- > Things worked fine without this until now by p

Re: [FFmpeg-devel] [PATCH] avcodec/decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext

2018-07-20 Thread James Almer
On 7/20/2018 8:23 PM, Michael Niedermayer wrote: > On Thu, Jul 19, 2018 at 10:54:23PM -0300, James Almer wrote: >> Certain AVCodecParameters, like the contents of the extradata, may be changed >> by the init() function of any of the bitstream filters in the chain. >> >> Signed-off-by: James Almer