Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-07 Thread Karsten Otto
> Am 06.07.2018 um 23:32 schrieb Michael Niedermayer : > > Signierter PGP-Teil > On Fri, Jul 06, 2018 at 10:49:46AM +0200, Karsten Otto wrote: >> >>> Am 04.07.2018 um 23:54 schrieb Michael Niedermayer : >>> >>> Signierter PGP-Teil >>> On Wed, Jul 04, 2018 at 09:32:32AM +0200, Karsten Otto wrote

Re: [FFmpeg-devel] [PATCH 3/3] libavcodec/vp8: Do not compute line pointers per pixel in fade()

2018-07-07 Thread Michael Niedermayer
On Sun, Jun 24, 2018 at 04:46:23AM +0200, Michael Niedermayer wrote: > 72->60 seconds > Testcase: > 8680/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP7_fuzzer-5861504418054144 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp8.c | 6 -- > 1 file changed, 4 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] tests/fate/demux: Add test for d25c945247979a88fac6bb3b7a26370262b96ef1

2018-07-07 Thread Michael Niedermayer
On Tue, Jun 26, 2018 at 09:53:15PM +0200, Michael Niedermayer wrote: > Sample provided by Thierry for fate > > Signed-off-by: Michael Niedermayer > --- > tests/fate/demux.mak | 3 ++ > tests/ref/fate/ts-small-demux | 80 +++ > 2 files changed, 83 inserti

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vp8_parser: Do not leave data/size uninitialized

2018-07-07 Thread Michael Niedermayer
On Fri, Jul 06, 2018 at 12:34:42PM +0200, Michael Niedermayer wrote: > This is identical to what the VP9 parser does > > Fixes: > 9215/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVPX_VP8_fuzzer-5768227253649408 > Fixes: out of memory access > > This may also fix oss fuzz issue 9212 > >

Re: [FFmpeg-devel] [PATCH 1/2] tools/target_dec_fuzzer: set parser codec id to avoid assertion failure

2018-07-07 Thread Michael Niedermayer
On Fri, Jul 06, 2018 at 12:34:41PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 1 + > 1 file changed, 1 insertion(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have often repented

Re: [FFmpeg-devel] [PATCH 2/2] lavc/hevc_ps: use skip_bits instead of get_bits when skip bits.

2018-07-07 Thread Carl Eugen Hoyos
2018-07-07 7:48 GMT+02:00, Jun Zhao : > use skip_bits when want to skip some bits. > > Signed-off-by: Jun Zhao > --- > libavcodec/hevc_ps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c > index bc5406b..278b928 100644 > --- a/

Re: [FFmpeg-devel] [PATCH] avfilter/setpts: add FR shorthand for FRAME_RATE

2018-07-07 Thread Gyan Doshi
On 07-07-2018 11:03 AM, Gyan Doshi wrote: Plan to push tonight if no objections. Pushed as c71e1e60305669c225c696dd99f6db5dc550a56a ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH v4 0/3] libavformat/aadec: seek support

2018-07-07 Thread Karsten Otto
A patch series adding seek support to libavformat/aadec. This fourth version of the series addresses some more comments from the mailing list: Patch 2/3 now uses avpriv_set_pts_info(). Otherwise, it is still based on skipping through the content to collect chapter boundaries. This is not optimal,

[FFmpeg-devel] [PATCH v4 1/3] aadec: improve eof detection

2018-07-07 Thread Karsten Otto
Remember the end position of audio content in the file and check it during read_packet. There always seems to be other data beyond it, which could be misinterpreted as more audio. Also add some extra avio_read error checks, to bail early in case of a broken/truncated file. --- libavformat/aadec.c

[FFmpeg-devel] [PATCH v4 3/3] aadec: improve seeking in mp3 content

2018-07-07 Thread Karsten Otto
MP3 frames may not be aligned to aa chunk boundaries. When seeking, calculate the expected frame offset in the target chunk. Adjust the timestamp and truncate the next packet accordingly. This solution works for the majority of tested audio material. For some rare encodings with mp3 padding or emb

[FFmpeg-devel] [PATCH v4 2/3] aadec: add chapters and seeking

2018-07-07 Thread Karsten Otto
read_packet reads content in chunks. Thus seek must be clamped to valid chunk positions in the file, which in turn are relative to chapter start positions. So in read_header, scan for chapter headers once by skipping through the content. Set stream time_base based on bitrate in bytes/s, for easy t

[FFmpeg-devel] [PATCH] libavcodec/mpegaudiodecheader.c : prevent reserved id misinterpretation

2018-07-07 Thread Karsten Otto
Check the MPEG version ID for the reserved bit pattern 01, and abort header parsing in that case. This reduces the chance of misinterpreting arbitrary data as a valid frame start, and prevents the resulting audio artifacts. --- libavcodec/mpegaudiodecheader.c | 5 +++-- 1 file changed, 3 insertion

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: Check for odd progressive RGB

2018-07-07 Thread Michael Niedermayer
On Fri, Jul 06, 2018 at 05:24:30PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 9225/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEGLS_fuzzer-5684770334834688 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ff

[FFmpeg-devel] [PATCH] avformat/movenc: Write version 2 of audio atom if channels is not known

2018-07-07 Thread Michael Niedermayer
The version 1 needs the channel count and would divide by 0 Fixes: division by 0 Fixes: fpe_movenc.c_1108_1.ogg Fixes: fpe_movenc.c_1108_2.ogg Fixes: fpe_movenc.c_1108_3.wav Found-by: #CHEN HONGXU# Signed-off-by: Michael Niedermayer --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Check input sample count

2018-07-07 Thread Michael Niedermayer
On Sat, Jul 07, 2018 at 02:46:35AM +0200, Michael Niedermayer wrote: > On Fri, Jul 06, 2018 at 02:24:45PM -0700, Baptiste Coudurier wrote: > > Hi Michael, > > > > On Fri, Jul 6, 2018 at 2:09 PM, Michael Niedermayer > > wrote: > > > > > Fixes: division by 0 > > > Fixes: fpe_movenc.c_199_1.wav > >