Re: [FFmpeg-devel] [PATCH] avcodec/dxv: add support for "high" quality mode

2018-04-15 Thread Paul B Mahol
On 4/14/18, Rostislav Pehlivanov wrote: > On 14 April 2018 at 20:46, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/dxv.c | 815 ++ >> ++--- >> 1 file changed, 780 insertions(+), 35 deletions(-) >> > > LGTM Applied. Tha

Re: [FFmpeg-devel] [PATCH] avcodec/aac_ac3_parser: account for data already in the parsing buffer

2018-04-15 Thread Hendrik Leppkes
On Fri, Apr 13, 2018 at 11:54 AM, Paul B Mahol wrote: > On 4/13/18, Hendrik Leppkes wrote: >> On Wed, Apr 11, 2018 at 1:40 PM, Hendrik Leppkes >> wrote: >>> If a frame starts very close to a packet boundary, the start code may >>> already have been added to the parsing buffer, indicated by a sma

Re: [FFmpeg-devel] [PATCH] avcodec/nvdec: correctly set intra_pic_flag for h264/hevc

2018-04-15 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-15 Thread Timo Teräs
Calculate DAR with assumed SAR 1:1 when SAR is undefined. Same assumption is done in ffplay to create the play window. Usually DAR is more useful metadata than SAR when e.g. choosing which media of multiple versions to use to fit the display. Normally undefined SAR means 1:1. E.g. in mov/mp4 files

Re: [FFmpeg-devel] GSOC 2018 qualification task.

2018-04-15 Thread ANURAG SINGH IIT BHU
Hello Sir, I have implemented the adviced changes for the hellosubs filter for the qualification task which writes Hello World time on frames, now the filter does not uses libavformat, and it uses libfreetype to draw over video frames. I have attached the complete patch. libfretype and libfontcon

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-15 Thread Marton Balint
On Sun, 15 Apr 2018, Timo Teräs wrote: Calculate DAR with assumed SAR 1:1 when SAR is undefined. Same assumption is done in ffplay to create the play window. Usually DAR is more useful metadata than SAR when e.g. choosing which media of multiple versions to use to fit the display. Normally un

Re: [FFmpeg-devel] [PATCH] configure: fix clang-cl detection

2018-04-15 Thread Michael Niedermayer
On Fri, Apr 13, 2018 at 09:51:10PM +, Dale Curtis wrote: > lgtm, I was able to build ffmpeg for windows on Linux with this patch by > following my notes here: > > https://bugs.chromium.org/p/chromium/issues/detail?id=783021#c6 applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B

Re: [FFmpeg-devel] [PATCH 5/5] amfenc: Remove spurious initialisations

2018-04-15 Thread Mark Thompson
On 15/04/18 00:17, Alexander Kravchenko wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Mark Thompson >> Sent: Saturday, April 14, 2018 6:54 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: [FFmpeg-devel] [PATCH 5/5] amfenc: Remove s

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-15 Thread Martin Vignali
and when there is no silence i get completly empty display + > current volume in dB. > > You're right, my previous calc was wrong (doesn't display for level below -42 db) New patchs in attach use another calc for the log display : av_clipf(0.21 * log10(max) + 1, 0, 1); for the persistent max d

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-15 Thread Paul B Mahol
On 4/15/18, Martin Vignali wrote: > and when there is no silence i get completly empty display + > >> current volume in dB. >> >> > You're right, my previous calc was wrong (doesn't display for level below > -42 db) > > New patchs in attach > > use another calc for the log display : av_clipf(0.21

Re: [FFmpeg-devel] GSOC 2018 qualification task.

2018-04-15 Thread Michael Niedermayer
On Sun, Apr 15, 2018 at 07:36:09PM +0530, ANURAG SINGH IIT BHU wrote: > Hello Sir, > > I have implemented the adviced changes for the hellosubs filter for the > qualification task which writes Hello World time on frames, now the filter > does not uses libavformat, and it uses libfreetype to draw o

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-15 Thread Martin Vignali
> > Default white color is good decision ? Better use orange? > > Put { in own line like for every function: > > void its_me_function() > {<- have own line > > } > > Generally follow code style of file. > ___ > > New patchs in attach fix

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-15 Thread Paul B Mahol
On 4/15/18, Martin Vignali wrote: >> >> Default white color is good decision ? Better use orange? >> >> Put { in own line like for every function: >> >> void its_me_function() >> {<- have own line >> >> } >> >> Generally follow code style of file. >> __

Re: [FFmpeg-devel] [PATCH 5/5] amfenc: Remove spurious initialisations

2018-04-15 Thread Alexander Kravchenko
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark > Thompson > Sent: Sunday, April 15, 2018 7:31 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 5/5] amfenc: Remove spurious > initialisations > > > > I am waiting

[FFmpeg-devel] [PATCH] tests/checkasm/aacpsdsp: Increase EPS for interpolate so that the test passes on kfreebsd

2018-04-15 Thread Michael Niedermayer
The value is minimal, 0.11 fails Signed-off-by: Michael Niedermayer --- tests/checkasm/aacpsdsp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/aacpsdsp.c b/tests/checkasm/aacpsdsp.c index ea68b39fa9..9e30eaa497 100644 --- a/tests/checkasm/aacpsdsp.c +++

Re: [FFmpeg-devel] [PATCH] tests/checkasm/aacpsdsp: Increase EPS for interpolate so that the test passes on kfreebsd

2018-04-15 Thread James Almer
On 4/15/2018 5:51 PM, Michael Niedermayer wrote: > The value is minimal, 0.11 fails > > Signed-off-by: Michael Niedermayer > --- > tests/checkasm/aacpsdsp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tests/checkasm/aacpsdsp.c b/tests/checkasm/aacpsdsp.c > inde

[FFmpeg-devel] [PATCH]lavc/dxva2_internal: Cast dxva2 and d3d11 decoders and cfgs to (void *)

2018-04-15 Thread Carl Eugen Hoyos
Hi! Attached patch is supposed to silence several user-reported warnings, I cannot currently test here. Please review, Carl Eugen From 6fb20352568dc5abe61c28247bfce9e04e7494c1 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 15 Apr 2018 23:57:24 +0200 Subject: [PATCH] lavc/dxva2_intern

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-15 Thread Carl Eugen Hoyos
2018-04-15 16:42 GMT+02:00, Marton Balint : > > > On Sun, 15 Apr 2018, Timo Teräs wrote: > >> Calculate DAR with assumed SAR 1:1 when SAR is undefined. Same >> assumption is done in ffplay to create the play window. Usually >> DAR is more useful metadata than SAR when e.g. choosing which >> media o

[FFmpeg-devel] [PATCH]lavd/vfwcap: Pass pointers to int instead of long to av_parse_video_size().

2018-04-15 Thread Carl Eugen Hoyos
Hi! Attached patch is supposed to silence a user-reported warning, I cannot currently test. libavdevice/vfwcap.c: In function 'vfw_read_header': libavdevice/vfwcap.c:331:35: warning: passing argument 1 of 'av_parse_video_size' from incompatible pointer type [-Wincompatible-pointer-types]

[FFmpeg-devel] [PATCH]lavf/rtmpcrypt: Add a cast to silence a warning

2018-04-15 Thread Carl Eugen Hoyos
Hi! rtmpe_write() exploits knowledge about av_rc4_crypt() internals and passes the same pointer as src and dst. I assume this is intentional for performance reasons, the only way to silence the resulting warning is a cast afaict. Please comment, Carl Eugen From 397b209506beb6c5a2acbe19bba98393216

Re: [FFmpeg-devel] [PATCH] avcodec/dxv: add support for "high" quality mode

2018-04-15 Thread Carl Eugen Hoyos
2018-04-15 9:41 GMT+02:00, Paul B Mahol : > On 4/14/18, Rostislav Pehlivanov wrote: >> On 14 April 2018 at 20:46, Paul B Mahol wrote: >> >>> Signed-off-by: Paul B Mahol >>> --- >>> libavcodec/dxv.c | 815 ++ >>> ++--- >>> 1 file changed, 780 inser

Re: [FFmpeg-devel] [PATCH]lavd/vfwcap: Pass pointers to int instead of long to av_parse_video_size().

2018-04-15 Thread James Almer
On 4/15/2018 7:03 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch is supposed to silence a user-reported warning, I > cannot currently test. > > libavdevice/vfwcap.c: In function 'vfw_read_header': > libavdevice/vfwcap.c:331:35: warning: passing argument 1 of > 'av_parse_video_size' from inc

Re: [FFmpeg-devel] [PATCH]lavc/dxva2_internal: Cast dxva2 and d3d11 decoders and cfgs to (void *)

2018-04-15 Thread James Almer
On 4/15/2018 7:00 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch is supposed to silence several user-reported warnings, > I cannot currently test here. > > Please review, Carl Eugen > > > 0001-lavc-dxva2_internal-Cast-the-dxva2-and-d3d11-decoder.patch > > > From 6fb20352568dc5abe61c2824

Re: [FFmpeg-devel] [PATCH] tests/checkasm/aacpsdsp: Increase EPS for interpolate so that the test passes on kfreebsd

2018-04-15 Thread Michael Niedermayer
On Sun, Apr 15, 2018 at 06:16:52PM -0300, James Almer wrote: > On 4/15/2018 5:51 PM, Michael Niedermayer wrote: > > The value is minimal, 0.11 fails > > > > Signed-off-by: Michael Niedermayer > > --- > > tests/checkasm/aacpsdsp.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > >

[FFmpeg-devel] lavf/os_support: Only compile inet_aton() if getaddrinfo() is needed

2018-04-15 Thread Carl Eugen Hoyos
Hi! Attached patch is supposed to silence a user-reported warning when inet_aton() is missing but getaddrinfo() is supported. Untested. Please review, Carl Eugen From 9d31a8c99953a2144e2f24d79da4cbc57987f365 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 16 Apr 2018 01:28:47 +0200 Su

[FFmpeg-devel] [PATCH] configure: extend the check for bcrypt

2018-04-15 Thread James Almer
Some old mingw-w64 builds seem to provide an incomplete implementation of the API. Add an extra check to make sure it's disabled for those. Signed-off-by: James Almer --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index d22b93a2d3..83a76

Re: [FFmpeg-devel] [PATCH] avformat/hls: remove redundant code

2018-04-15 Thread Jun Zhao
On 2018/4/13 20:29, Steven Liu wrote: > 2018-04-13 16:19 GMT+08:00 Jun Zhao : >> >> On 2018/4/12 16:48, Steven Liu wrote: >>> Signed-off-by: Steven Liu >>> --- >>> libavformat/hls.c | 27 +-- >>> 1 file changed, 9 insertions(+), 18 deletions(-) >>> >>> diff --git a/libav

[FFmpeg-devel] [PATCH] avformat/movenc: forbid muxing AV1 streams until the spec is finished

2018-04-15 Thread James Almer
This prevents creating potentially broken files, as both the AV1 and the AV1 in ISOMBFF specs are unfinished. Signed-off-by: James Almer --- This is mainly so it's effective in ffmpeg 4.0, the first version to support libaom (including pre-bitstream freeze builds). Best to prevent muxing files th

[FFmpeg-devel] [PATCH v4 1/1] avformat/dashenc: replacing 'min_seg_duration' with 'seg_duration'

2018-04-15 Thread vdixit
From: Vishwanath Dixit There are use cases where average segment duration needs to be configured and muxer is expected to maintain the average segment duration. So, using the name 'min_seg_duration' will be misleading. So, changing the parameter name to 'seg_duration', where it can be minimum seg

[FFmpeg-devel] [PATCH] avformat/hlsenc: add error message for encrypt fmp4 mode

2018-04-15 Thread Steven Liu
hlsenc have not support encrypty fmp4 yet now. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index c7540166ab..5c9e646962 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -159

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add error message for encrypt fmp4 mode

2018-04-15 Thread Gyan Doshi
On 4/16/2018 11:14 AM, Steven Liu wrote: +av_log(s, AV_LOG_ERROR, "have not support encrypt fmp4 now\n"); Suggest "Encrypted fmp4 not yet supported\n" av_log(s, AV_LOG_WARNING, "Cannot use both -hls_key_info_file and -hls_enc," " will use -hls_k

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-15 Thread Timo Teras
On Sun, 15 Apr 2018 16:42:01 +0200 (CEST) Marton Balint wrote: > On Sun, 15 Apr 2018, Timo Teräs wrote: > > > Calculate DAR with assumed SAR 1:1 when SAR is undefined. Same > > assumption is done in ffplay to create the play window. Usually > > DAR is more useful metadata than SAR when e.g. choo

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add error message for encrypt fmp4 mode

2018-04-15 Thread Steven Liu
> On 16 Apr 2018, at 13:56, Gyan Doshi wrote: > > On 4/16/2018 11:14 AM, Steven Liu wrote: > >> +av_log(s, AV_LOG_ERROR, "have not support encrypt fmp4 now\n"); > > Suggest "Encrypted fmp4 not yet supported\n” ok > >> av_log(s, AV_LOG_WARNING, "Cannot use both -hls_k

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: add error message for encrypt fmp4 mode

2018-04-15 Thread Steven Liu
and refine the warning message when use both hls_key_info_file and hls_enc Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index c7540166ab..c27a66ea79 100644 --- a/libavforma

Re: [FFmpeg-devel] GSOC 2018 qualification task.

2018-04-15 Thread ANURAG SINGH IIT BHU
Hello sir, Okay I'll implement the suggested changes and make sure that the filter does not break build without libfreetype. Thanks and regards Anurag Singh. On Mon, Apr 16, 2018 at 12:49 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Sun, Apr 15, 2018 at 07:36:09PM +0530, ANURA

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: add error message for encrypt fmp4 mode

2018-04-15 Thread Gyan Doshi
On 4/16/2018 11:52 AM, Steven Liu wrote: +av_log(s, AV_LOG_ERROR, "Encrypted fmp4 not yet supported\n"); av_log(s, AV_LOG_WARNING, "Cannot use both -hls_key_info_file and -hls_enc," - " will use -hls_key_info_file priority\n"); +

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: add error message for encrypt fmp4 mode

2018-04-15 Thread Steven Liu
> On 16 Apr 2018, at 14:30, Gyan Doshi wrote: > > > > On 4/16/2018 11:52 AM, Steven Liu wrote: > >> +av_log(s, AV_LOG_ERROR, "Encrypted fmp4 not yet supported\n"); > > >> av_log(s, AV_LOG_WARNING, "Cannot use both -hls_key_info_file >> and -hls_enc," >> -

Re: [FFmpeg-devel] [PATCH] avcodec/dxv: add support for "high" quality mode

2018-04-15 Thread Paul B Mahol
On 4/16/18, Carl Eugen Hoyos wrote: > 2018-04-15 9:41 GMT+02:00, Paul B Mahol : >> On 4/14/18, Rostislav Pehlivanov wrote: >>> On 14 April 2018 at 20:46, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol --- libavcodec/dxv.c | 815 ++ ++