Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Use more specific error codes

2018-03-10 Thread James Almer
On 3/10/2018 6:15 PM, Michael Niedermayer wrote: > On Sat, Mar 10, 2018 at 03:33:33PM -0300, James Almer wrote: >> On 3/10/2018 2:34 PM, Michael Niedermayer wrote: >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/mpeg4videodec.c | 100 >>> +++-

[FFmpeg-devel] [PATCH] avformat/mov: Fix integer overflows related to sample_duration

2018-03-10 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: -9166684017437101870 + -2495066639299164439 cannot be represented in type Fixes: Chromium bug 791349 Reported-by: Matt Wolenetz Reviewed-by: Matt Wolenetz Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 20 +++- 1 file

[FFmpeg-devel] [PATCH] avcodec/extract_extradata: don't uninitialize the H2645Packet on every processed packet

2018-03-10 Thread James Almer
Based on hevc_parser code. This prevents repeated unnecessary allocations and frees on every packet processed by the bsf. Signed-off-by: James Almer --- libavcodec/extract_extradata_bsf.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/liba

Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata: don't allocate more space than needed when removing NALUs in h264/hevc

2018-03-10 Thread James Almer
On 3/10/2018 12:48 PM, James Almer wrote: > On 3/9/2018 2:40 PM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/extract_extradata_bsf.c | 12 +++- >> 1 file changed, 7 insertions(+), 5 deletions(-) >> > Will push this later today. > Pushed. ___

[FFmpeg-devel] [PATCH] avcodec/wmalosslessdec: Reset num_saved_bits on error path

2018-03-10 Thread Michael Niedermayer
Fixes: NULL pointer dereference Fixes: poc-201803.wav Found-by: GwanYeong Kim Signed-off-by: Michael Niedermayer --- libavcodec/wmalosslessdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 133a3e92d1..59e8929586 100644 ---

Re: [FFmpeg-devel] [PATCH] lavf/rtsp: fix the type of the timeout option.

2018-03-10 Thread wm4
On Sat, 10 Mar 2018 20:37:20 +0100 Nicolas George wrote: > A timeout is a duration of time, therefore the correct type for it > is AV_OPT_TYPE_DURATION. It has the benefit of offering a better > user interface, with units specification. > Unfortunately, ff46124b0df17a1d35249e09ae8eae9a61f16e04 wa

Re: [FFmpeg-devel] [PATCH] lavf/rtsp: fix the type of the timeout option.

2018-03-10 Thread wm4
On Sat, 10 Mar 2018 20:37:20 +0100 Nicolas George wrote: > A timeout is a duration of time, therefore the correct type for it > is AV_OPT_TYPE_DURATION. It has the benefit of offering a better > user interface, with units specification. > Unfortunately, ff46124b0df17a1d35249e09ae8eae9a61f16e04 wa

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_idct : update test bit depth from 8 9 and 10 to 8 10 and 12

2018-03-10 Thread Yingming Fan
Hi, there. Is there any comment? I think i did the right fix. Yingming Fan > On 8 Mar 2018, at 4:17 PM, Hendrik Leppkes wrote: > > On Thu, Mar 8, 2018 at 9:16 AM, Paul B Mahol wrote: >> On 3/8/18, Yingming Fan wrote: >>> From: Yingming Fan >>> >>> --- >>> We have 8 10 and 12 SIMD codes, but

Re: [FFmpeg-devel] [PATCH] avcodec/arm/hevcdsp_sao : add NEON optimization for sao

2018-03-10 Thread Yingming Fan
Hi, there. I have already pushed a patch which add hevc_sao checkasm and patch was adopted. You can verify this optimization by using checkasm under arm device, `checkasm --test=hevc_sao --bench`. hevc_sao_band speed up ~2x, hevc_sao_edge speed up ~4x. Also passed FATE under arm platform. Yingm

Re: [FFmpeg-devel] GSoC

2018-03-10 Thread Dylan Fernando
On Thu, Mar 8, 2018 at 8:57 AM, Mark Thompson wrote: > On 07/03/18 03:56, Dylan Fernando wrote: > > Thanks, it works now > > > > Would trying to implement an OpenCL version of vf_fade be a good idea > for a > > qualification task, or would it be a better idea to try a different > filter? > > That

[FFmpeg-devel] [PATCH] avcodec/mediacodecdec: add debug logging around hw buffer lifecycle

2018-03-10 Thread Aman Gupta
From: Aman Gupta Some Android devices are very finicky about how quicky output buffers are returned back to the decoder, especially when they are associated with a Surface. This commit adds a new counter that keeps track of exactly how many hw output buffers are being retained by the user, along

Re: [FFmpeg-devel] [PATCH] avfilter: add panorama filter

2018-03-10 Thread Paul B Mahol
On 3/9/18, Paul B Mahol wrote: > On 3/9/18, Hazem Ashmawy wrote: >> On 3/9/18, Paul B Mahol wrote: >>> On 3/9/18, Hazem Ashmawy wrote: Add filter to convert between various panorama projections. It supports Equirectangular and Cubemaps (3x2 and 6x1 cubemap layouts). commit a

[FFmpeg-devel] Regarding the removal of hacks

2018-03-10 Thread Jan Ekström
Hi, I would like to raise a question regarding how the community feels about removing hacks which most likely were done to work around deficiencies of API clients. Silently. Some weeks ago someone asked on #ffmpeg why he wasn't getting the time scale (time base in MOV/ISOBMFF speak) he wanted out

Re: [FFmpeg-devel] [PATCH v4] avformat/pcm: decrease delay when reading PCM streams.

2018-03-10 Thread Rostislav Pehlivanov
On 9 March 2018 at 23:33, Michael Niedermayer wrote: > On Fri, Mar 09, 2018 at 07:23:02PM +0100, Hendrik Leppkes wrote: > > On Fri, Mar 9, 2018 at 7:02 PM, Michael Niedermayer > > wrote: > > > On Fri, Mar 09, 2018 at 11:18:38AM +0100, Tomas Härdin wrote: > > >> On 2018-03-09 01:40, Michael Niede

[FFmpeg-devel] Type mismatch in ADPCM

2018-03-10 Thread Carlo Bramini
Hello, while working with ADPCM source code, I noticed that there is a type mismatch in ff_adpcm_afc_coeffs[2][16]. Inside libavcodec/adpcm_data.c it is declared as uint16_t: https://github.com/FFmpeg/FFmpeg/blob/d168e78effd170377ec57f67bca05c9f0de91bca/libavcodec/adpcm_data.c#L109 but into lib

Re: [FFmpeg-devel] Regarding the removal of hacks

2018-03-10 Thread Paul B Mahol
On 3/10/18, Jan Ekstroem wrote: > Hi, > > I would like to raise a question regarding how the community feels > about removing hacks which most likely were done to work around > deficiencies of API clients. Silently. > > Some weeks ago someone asked on #ffmpeg why he wasn't getting the time > scale

Re: [FFmpeg-devel] [PATCH] libavformat/movenc : Change MOV_TIMESCALE from 1000 to 600

2018-03-10 Thread Mark Burton
On 9 Mar 2018, at 01:26, Carl Eugen Hoyos wrote: > This breaks fate, our regression testing suite (my mistake). > To download the test-suite: > $ make SAMPLES=fate-suite fate-rsync > $ make SAMPLES=fate-suite GEN=1 fate > This changes the values for fate, then commit again with: > $ git commit tes

Re: [FFmpeg-devel] Type mismatch in ADPCM

2018-03-10 Thread wm4
On Sat, 10 Mar 2018 15:02:56 +0100 (CET) Carlo Bramini wrote: > and just add FFMPEG_EXTERN_C_BEGIN and FFMPEG_EXTERN_C_END to the top and to > the bottom of each include file. You could take it as a suggestion, allowing > compilation with both GCC and G++ may show you some defects you cannot se

Re: [FFmpeg-devel] [PATCH] vc2enc: replace quantization LUT with a smaller division LUT

2018-03-10 Thread Rostislav Pehlivanov
On 28 February 2018 at 23:38, Michael Niedermayer wrote: > On Tue, Feb 27, 2018 at 11:12:33PM +, Rostislav Pehlivanov wrote: > > This commit replaces the huge and impractical LUT which converted coeffs > > and a quantizer to bits to encode and instead uses a standard > multiplication > > and

Re: [FFmpeg-devel] Type mismatch in ADPCM

2018-03-10 Thread wm4
On Sat, 10 Mar 2018 15:02:56 +0100 (CET) Carlo Bramini wrote: > and just add FFMPEG_EXTERN_C_BEGIN and FFMPEG_EXTERN_C_END to the top and to > the bottom of each include file. You could take it as a suggestion, allowing > compilation with both GCC and G++ may show you some defects you cannot se

[FFmpeg-devel] [PATCH v5] avformat/pcm: decrease delay when reading PCM streams.

2018-03-10 Thread Philipp M. Scholl
Thanks for the discussion. Here's the next version, now with /25 and removed ff_log2(). The blocksize of the PCM decoder is hard-coded. This creates unnecessary delay when reading low-rate (<100Hz) streams. This creates issues when multiplexing multiple streams, since other inputs are only ope

Re: [FFmpeg-devel] [PATCH v5] avformat/pcm: decrease delay when reading PCM streams.

2018-03-10 Thread Paul B Mahol
On 3/10/18, Philipp M. Scholl wrote: > Thanks for the discussion. Here's the next version, now with /25 and > removed > ff_log2(). > > The blocksize of the PCM decoder is hard-coded. This creates > unnecessary delay when reading low-rate (<100Hz) streams. This creates > issues when multiplexin

Re: [FFmpeg-devel] [PATCH 6/7] avcodec/ffv1: support of more pix_fmt

2018-03-10 Thread Michael Niedermayer
On Fri, Mar 09, 2018 at 08:56:56PM +0100, Jerome Martinez wrote: > On 09/03/2018 18:30, Paul B Mahol wrote: > >On 3/7/18, Jerome Martinez wrote: > >>With some sources having specific pix_fmt (9/10/12/14 bit), the source > >>is padded to 16-bit when the pix_fmt is not supported natively by the > >>

Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata: don't allocate more space than needed when removing NALUs in h264/hevc

2018-03-10 Thread James Almer
On 3/9/2018 2:40 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/extract_extradata_bsf.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/extract_extradata_bsf.c > b/libavcodec/extract_extradata_bsf.c > index fbfd12aeef..4e2

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Use the correct offset to shift timestamp when seeking.

2018-03-10 Thread Michael Niedermayer
On Fri, Mar 09, 2018 at 01:30:21PM -0800, Sasi Inguva wrote: > Fixes seek for files with empty edits and files with negative ctts > (dts_shift > 0). Added fate samples and tests. > > Signed-off-by: Sasi Inguva > --- > libavformat/isom.h | 1 + > libavformat/mov.c

Re: [FFmpeg-devel] Regarding the removal of hacks

2018-03-10 Thread Michael Niedermayer
On Sat, Mar 10, 2018 at 03:08:16PM +0200, Jan Ekström wrote: > Hi, > > I would like to raise a question regarding how the community feels > about removing hacks which most likely were done to work around > deficiencies of API clients. Silently. Iam in favor of removing hacks and replacing them by

[FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Use more specific error codes

2018-03-10 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/mpeg4videodec.c | 100 +++-- 1 file changed, 51 insertions(+), 49 deletions(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index 19210d97fe..1357b357a8 100644 --- a/libavcodec/mpeg4

[FFmpeg-devel] [PATCH] doc/utils: document the "ms" and "us" suffixes for durations

2018-03-10 Thread Moritz Barsnick
These suffixes were recently introduced in 61c972384d311508d07f9360d196909e27195655 and completed in 8218249f1f04de65904f58519bde21948e5a0783. Signed-off-by: Moritz Barsnick --- I chose not to document the suffixes in the section describing the HH:MM:SS.mmm syntax, even though they work there (

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Use more specific error codes

2018-03-10 Thread James Almer
On 3/10/2018 2:34 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4videodec.c | 100 > +++-- > 1 file changed, 51 insertions(+), 49 deletions(-) > > diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4video

[FFmpeg-devel] [PATCH] lavf/rtsp: fix the type of the timeout option.

2018-03-10 Thread Nicolas George
A timeout is a duration of time, therefore the correct type for it is AV_OPT_TYPE_DURATION. It has the benefit of offering a better user interface, with units specification. Unfortunately, ff46124b0df17a1d35249e09ae8eae9a61f16e04 was pushed before that mistake could be corrected. Signed-off-by: Ni

Re: [FFmpeg-devel] Type mismatch in ADPCM

2018-03-10 Thread Carl Eugen Hoyos
2018-03-10 15:02 GMT+01:00 Carlo Bramini : > I noticed this thing because I compiled those sources with a more robust > syntax check, by using C++ rather that plain C. At pratical level, nothing > changed, except for the .h files that required to use the extern "C" keyword. > I was wondering if

[FFmpeg-devel] [PATCH]lavfi/deshake: Check alignment before calling asm init function

2018-03-10 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #7078 for me. Please comment, Carl Eugen From 75ead282c3aa3c214d37e766690e2edd037307c0 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 10 Mar 2018 20:46:21 +0100 Subject: [PATCH] lavfi/deshake: Check alignment before calling asm init function. Do this

[FFmpeg-devel] [PATCH] avcodec/h2645_parse: Replace RNXYA by RNXY in ff_h2645_extract_rbsp()

2018-03-10 Thread Michael Niedermayer
Fixes misaligned accesses Found-by: Matt Wolenetz Signed-off-by: Michael Niedermayer --- libavcodec/h2645_parse.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c index e6c40381b0..dbf2435677 100644 --- a/libavcodec/h

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Use more specific error codes

2018-03-10 Thread Michael Niedermayer
On Sat, Mar 10, 2018 at 03:33:33PM -0300, James Almer wrote: > On 3/10/2018 2:34 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/mpeg4videodec.c | 100 > > +++-- > > 1 file changed, 51 insertions(+), 49 deletion

[FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Use more specific error codes

2018-03-10 Thread Michael Niedermayer
Forward error codes where possible. Signed-off-by: Michael Niedermayer --- libavcodec/mpeg4video.h| 4 +- libavcodec/mpeg4videodec.c | 100 +++-- 2 files changed, 53 insertions(+), 51 deletions(-) diff --git a/libavcodec/mpeg4video.h b/libavcodec/mp