Re: [FFmpeg-devel] [PATCH] libavformat/network: Fixed wait timeout functionality to exit immediately when timeout is 0.

2018-02-16 Thread Hendrik Leppkes
On Fri, Feb 16, 2018 at 7:54 AM, wrote: > From: Ravindra > > Signed-off-by: Ravindra > --- > libavformat/network.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/network.c b/libavformat/network.c > index d5c82e9..542bd3e 100644 > --- a/libavformat/netwo

Re: [FFmpeg-devel] [PATCH] lavf/mpegts: add supplementary audio descriptor

2018-02-16 Thread Stefan Pöschel
Am 16.02.2018 um 05:10 schrieb Aman Gupta: > One option would be to re-use an existing flag. > > AV_DISPOSITION_CLEAN_EFFECTS seems to have a similar meaning, but is > already used for a different purpose in mpegts.c Right, so this would not be a distinct indicator. > Another option is AV_DISPOS

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: refactor to take advantage of new decoding api

2018-02-16 Thread Matthieu Bouron
On Thu, Feb 15, 2018 at 07:52:14PM -0800, Aman Gupta wrote: > From: Aman Gupta Hi, > > This refactor splits up the main mediacodec decode loop into two > send/receive helpers, which are then used to rewrite the receive_frame > callback and take full advantage of the new decoding api. Since we >

[FFmpeg-devel] [PATCH v3] avformat/pcm: decrease delay when reading PCM streams.

2018-02-16 Thread Philipp M. Scholl
Version 3 of the PCM delay patch with further feedback included. Still not sure about the ramifications of smaller blocksizes in fate. Hence the tests are also changed. cheers, -phil The blocksize of the PCM decoder is hard-coded. This creates unnecessary delay when reading low-rate (<100Hz)

Re: [FFmpeg-devel] [PATCH v3] avformat/pcm: decrease delay when reading PCM streams.

2018-02-16 Thread Tomas Härdin
On 2018-02-16 14:04, Philipp M. Scholl wrote: Version 3 of the PCM delay patch with further feedback included. Still not sure about the ramifications of smaller blocksizes in fate. Hence the tests are also changed. Code looks good. Can't say anything about the tests however /Tomas ___

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: refactor to take advantage of new decoding api

2018-02-16 Thread Aman Gupta
On Fri, Feb 16, 2018 at 4:01 AM Matthieu Bouron wrote: > On Thu, Feb 15, 2018 at 07:52:14PM -0800, Aman Gupta wrote: > > From: Aman Gupta > > Hi, > > > > > This refactor splits up the main mediacodec decode loop into two > > send/receive helpers, which are then used to rewrite the receive_frame

Re: [FFmpeg-devel] [PATCH] lavf/mpegts: add supplementary audio descriptor

2018-02-16 Thread Aman Gupta
On Thu, Feb 15, 2018 at 4:11 AM, Stefan Pöschel wrote: > The supplementary audio descriptor is defined in ETSI EN 300 468 and > provides more details regarding accessibility audio tracks, especially > the normative annex J contains a detailed description of its use. > > Its language code (if pres

[FFmpeg-devel] [PATCH] avformat/mpegts: set AV_DISPOSITION_DEPENDENT for mix_type=0 supplementary audio

2018-02-16 Thread Aman Gupta
From: Aman Gupta --- fftools/ffmpeg.c | 1 + libavformat/avformat.h | 1 + libavformat/dump.c | 2 ++ libavformat/mpegts.c | 3 +++ 4 files changed, 7 insertions(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index a37de2ff98..bea922b0aa 100644 --- a/fftools/ffmpeg.c +++ b/ffto

Re: [FFmpeg-devel] [PATCH] lavf/mpegts: add supplementary audio descriptor

2018-02-16 Thread Stefan Pöschel
Am 16.02.2018 um 20:01 schrieb Aman Gupta: >> +if(flags & 0x01) { > > Please add a space after "if" here. > >> +if(language[0]) > > Same, missing space. OK, I will add the spaces. And also add the respective field names as comments, as you did for the mix_type. _

[FFmpeg-devel] [PATCH v2] lavf/mpegts: add supplementary audio descriptor

2018-02-16 Thread Stefan Pöschel
The supplementary audio descriptor is defined in ETSI EN 300 468 and provides more details regarding accessibility audio tracks, especially the normative annex J contains a detailed description of its use. Its language code (if present) overrides the language code of an also present ISO 639 langua

[FFmpeg-devel] [PATCH 2/2] libavfilter/vf_fps: Rewrite using activate callback

2018-02-16 Thread Calvin Walton
The old version of the filter had a problem where it would queue up all of the duplicate frames required to fill a timestamp gap in a single call to filter_frame. In problematic files - I've hit this in webcam streams with large gaps due to network issues - this will queue up a potentially huge num

[FFmpeg-devel] [PATCH 1/2] libavfilter/vf_fps: Add more fate tests

2018-02-16 Thread Calvin Walton
These tests cover specific rounding behaviour, to ensure that I don't introduce any regressions with the rewritten "activate" callback based fps filter. --- tests/fate/filter-video.mak | 10 +- tests/ref/fate/filter-fps-down| 15 +++ tests/ref/fate/fil

[FFmpeg-devel] [PATCH 0/2] libavfilter/vf_fps: Rewrite using activate callback

2018-02-16 Thread Calvin Walton
I've run into some problems with the current fps filter memory usage, because of how it buffers all of the frames needed to fill in large timestamp gaps, rather than generate them on the fly. In order to fix this, I have rewritten the fps filter to use the newer "activate" api. I have also added

Re: [FFmpeg-devel] [PATCH 2/2] libavfilter/vf_fps: Rewrite using activate callback

2018-02-16 Thread calvin . walton
Oops, I forgot to remove this bit from the changelog: On Fri, 2018-02-16 at 15:02 -0500, Calvin Walton wrote: > TODO: This is still a work in progress. It may have different > behaviour > in some cases from the old fps filter. I have not yet implemented the > "eof_action" option, since I haven't f

Re: [FFmpeg-devel] Fix memset size on ctts_data in mov_read_trun()

2018-02-16 Thread Michael Niedermayer
On Thu, Feb 15, 2018 at 12:10:33PM -0800, Xiaohan Wang (王消寒) wrote: > > mov.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > 5597d0b095f8b15eb11503010a51c2bc2c022413 > 0001-ffmpeg-Fix-memset-size-on-ctts_data-in-mov_read_trun.patch > From 7c1e6b50ebe35b2a38c4f1d0a988e31eccbd0ea

Re: [FFmpeg-devel] [PATCH 1/2] swresample/rematrix: fix update of channel matrix if input or output layout is undefined

2018-02-16 Thread Michael Niedermayer
On Thu, Feb 15, 2018 at 09:34:55AM +0100, Tobias Rapp wrote: > Prefer direct in/out channel count values over channel layout, when > available. Fixes a pan filter bug (ticket #6790). > > Signed-off-by: Tobias Rapp > --- > libswresample/rematrix.c | 6 -- > 1 file changed, 4 insertions(+), 2

[FFmpeg-devel] [PATCH] build: restore using dlltool/lib.exe for creating Win32 .lib files

2018-02-16 Thread Hendrik Leppkes
The GCC generated import libraries don't work properly when being imported by MSVC, resulting in missing symbols at runtime. This reverts 5b5365fe9 and partially reverts changes from 98a9b1f0d --- configure | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/confi

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

2018-02-16 Thread Michael Niedermayer
On Thu, Feb 15, 2018 at 06:23:06PM +0530, Gyan Doshi wrote: > > On 2/15/2018 8:57 AM, Michael Niedermayer wrote: > >On Tue, Feb 13, 2018 at 12:33:56AM +0530, Gyan Doshi wrote: > > >>+if (st->codecpar->codec_id == AV_CODEC_ID_PCM_DVD) { > >>+if (size < 3) { > >>+av_log(ctx,

Re: [FFmpeg-devel] [PATCH] avutil/common: Fix integer overflow in av_clip_uint8_c() and av_clip_uint16_c()

2018-02-16 Thread Michael Niedermayer
On Thu, Feb 15, 2018 at 01:46:06PM +0100, Michael Niedermayer wrote: > Fixes: 5567/clusterfuzz-testcase-minimized-5769966247739392 > Fixes: runtime error: negation of -2147483648 cannot be represented in type > 'int'; cast to an unsigned type to negate this value to itself > > Found-by: continuou

Re: [FFmpeg-devel] [PATCH] avcodec/exr: Check remaining bits in last get code loop

2018-02-16 Thread Michael Niedermayer
On Wed, Feb 14, 2018 at 01:45:24PM +0100, Michael Niedermayer wrote: > Fixes: runtime error: shift exponent -7 is negative > Fixes: > 3902/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-6081926122176512 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/t

Re: [FFmpeg-devel] Fix memset size on ctts_data in mov_read_trun()

2018-02-16 Thread 王消寒
+jstebbins@ who wrote that code. On Fri, Feb 16, 2018 at 12:30 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Thu, Feb 15, 2018 at 12:10:33PM -0800, Xiaohan Wang (王消寒) wrote: > > > > > mov.c |3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > 5597d0b095f8b15eb115030

[FFmpeg-devel] [PATCH] avformat/flvdec: Set broken_sizes for FlixEngine.

2018-02-16 Thread Nikolas Bowe
--- libavformat/flvdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 0217cef842..b86451fcbf 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -598,7 +598,9 @@ static int amf_parse_object(AVFormatContext *s,

[FFmpeg-devel] [PATCH] avformat/matroskadec: ignore CodecPrivate if the stream is VP9

2018-02-16 Thread James Almer
Defined in a recent revision of https://www.webmproject.org/docs/container/ Signed-off-by: James Almer --- libavformat/matroskadec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index cda8df2213..edc4f5d476 100644 --- a/libavformat

[FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000dec: Use av_image_check_size2()

2018-02-16 Thread Michael Niedermayer
Fixes: OOM Fixes: 5733/clusterfuzz-testcase-minimized-4906757966004224 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpeg2000dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH 3/3] avcodec/h264: Increase field_poc to 64bit in ff_h264_init_poc() to detect overflows

2018-02-16 Thread Michael Niedermayer
Fixes: Integer overflow Fixes: 5746/clusterfuzz-testcase-minimized-6270097623613440 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/h264_parse.c | 6 +- libavcodec/h264_parser.c | 4 +++-

[FFmpeg-devel] [PATCH 1/3] avcodec/vp8: Check for bitstream end before vp7_fade_frame()

2018-02-16 Thread Michael Niedermayer
Fixes: Timeout Fixes: 5653/clusterfuzz-testcase-5497680018014208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vp8.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/vp8.c b/l

Re: [FFmpeg-devel] [PATCH] docs/codecs: remove dead codec debug options

2018-02-16 Thread Gyan Doshi
Ping. x3. On 1/15/2018 8:29 PM, Gyan Doshi wrote: ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel