[FFmpeg-devel] [PATCH] mpeg2dec: Fix motion vector rounding for chroma components

2018-02-11 Thread Nekopanda
In 16x8 motion compensation, for lower 16x8 region, the input to mpeg_motion() for motion_y was "motion_y + 16", which causes wrong rounding. For 4:2:0, chroma scaling for y is dividing by two and rounding toward zero. When motion_y < 0 and motion_y + 16 > 0, the rounding direction of "motion_y"

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpeg4videodec: Ignore multiple VOL headers

2018-02-11 Thread Michael Niedermayer
On Fri, Feb 09, 2018 at 10:24:58PM +0100, Michael Niedermayer wrote: > Fixes: Ticket7005 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4videodec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF1

Re: [FFmpeg-devel] [PATCH] mpeg2dec: Fix motion vector rounding for chroma components

2018-02-11 Thread Michael Niedermayer
On Sun, Feb 11, 2018 at 05:15:54PM +0900, Nekopanda wrote: > In 16x8 motion compensation, for lower 16x8 region, the input to > mpeg_motion() for motion_y was "motion_y + 16", which causes wrong rounding. > For 4:2:0, chroma scaling for y is dividing by two and rounding toward zero. > When motio

Re: [FFmpeg-devel] How to pass metadata between filters

2018-02-11 Thread wm4
On Fri, 9 Feb 2018 18:43:11 + Mujib Haider wrote: > Dear ffmpeg-devel, > > I have a general question about the capabilities of avfilter. > > Is it possible to send meta-data between avfilters? Specifically, I want to > create a filter to take a single input image, and produce a single outp

Re: [FFmpeg-devel] How to pass metadata between filters

2018-02-11 Thread James Almer
On 2/11/2018 9:31 AM, wm4 wrote: > On Fri, 9 Feb 2018 18:43:11 + > Mujib Haider wrote: > >> Dear ffmpeg-devel, >> >> I have a general question about the capabilities of avfilter. >> >> Is it possible to send meta-data between avfilters? Specifically, I want to >> create a filter to take a si

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: add ff_read_line_to_bprint and ff_read_line_to_bprint_overwrite functions

2018-02-11 Thread Nicolas George
Marton Balint (2018-02-10): > To be able to read lines longer than a static buffer size. > > Signed-off-by: Marton Balint > --- > libavformat/aviobuf.c | 46 ++ > libavformat/internal.h | 26 ++ > 2 files changed, 72 insertions

Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: add support for very long line sizes

2018-02-11 Thread Nicolas George
Marton Balint (2018-02-10): > Fixes ticket #6761. > > Signed-off-by: Marton Balint > --- > libavformat/concatdec.c | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c > index 178fac86cb..3e41a62a36 10064

[FFmpeg-devel] [PATCH 3/3] mpegvideo_parser: fix indentation of an if statement

2018-02-11 Thread Jan Ekström
From: Masaki Tanaka --- libavcodec/mpegvideo_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_parser.c b/libavcodec/mpegvideo_parser.c index 4f554b684e..ecf7c28e72 100644 --- a/libavcodec/mpegvideo_parser.c +++ b/libavcodec/mpegvideo_parser.c @@ -

[FFmpeg-devel] [PATCH 0/3] MPEG-2 video parser improvements

2018-02-11 Thread Jan Ekström
These were brought to my knowledge by Yusuke, and they seemed correct according to the specification, as well as the picture structure parsing patch apparently fixes the detected field order with field coded picture MPEG-2 video streams. Masaki Tanaka (3): mpegvideo_parser: implement parsing of

[FFmpeg-devel] [PATCH 1/3] mpegvideo_parser: implement parsing of the picture structure field

2018-02-11 Thread Jan Ekström
From: Masaki Tanaka Lets one receive the proper field order from pictures coded in field picture mode, until now forcibly set to BFF. --- libavcodec/mpegvideo_parser.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_parser.c b/libavcodec/

[FFmpeg-devel] [PATCH 2/3] mpegvideo_parser: parse the output picture number

2018-02-11 Thread Jan Ekström
From: Masaki Tanaka Utilizes the temporal_reference field from the picture header. --- libavcodec/mpegvideo_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/mpegvideo_parser.c b/libavcodec/mpegvideo_parser.c index 3406346a8b..4f554b684e 100644 --- a/libavcodec/mpegvideo_pa

Re: [FFmpeg-devel] [PATCH] avcodec/vp3: Error out on invalid num_coeffs in unpack_vlcs()

2018-02-11 Thread Michael Niedermayer
On Sun, Feb 11, 2018 at 03:38:54AM +0100, Michael Niedermayer wrote: > This fixes a hypothetical integer overflow > > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp3.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) will apply and backport soon and then make a new release f

Re: [FFmpeg-devel] [PATCH 1/3] mpegvideo_parser: implement parsing of the picture structure field

2018-02-11 Thread Michael Niedermayer
On Sun, Feb 11, 2018 at 04:37:50PM +0200, Jan Ekström wrote: > From: Masaki Tanaka > > Lets one receive the proper field order from pictures coded in > field picture mode, until now forcibly set to BFF. > --- > libavcodec/mpegvideo_parser.c | 16 +++- > 1 file changed, 15 insertions(

Re: [FFmpeg-devel] [PATCH 2/3] mpegvideo_parser: parse the output picture number

2018-02-11 Thread Michael Niedermayer
On Sun, Feb 11, 2018 at 04:37:51PM +0200, Jan Ekström wrote: > From: Masaki Tanaka > > Utilizes the temporal_reference field from the picture header. > --- > libavcodec/mpegvideo_parser.c | 1 + > 1 file changed, 1 insertion(+) should be ok unless its intended to also restore the MSB Theres no

Re: [FFmpeg-devel] [PATCH 2/3] mpegvideo_parser: parse the output picture number

2018-02-11 Thread Jan Ekström
On Sun, Feb 11, 2018 at 7:52 PM, Michael Niedermayer wrote: > > should be ok unless its intended to also restore the MSB > The value seemed to be 10bit and if the pointer is at the position right after the picture_start_code, then `buf[0] << 2` would move the 8 bits left of data two bits leftward

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpeg4videodec: Ignore multiple VOL headers

2018-02-11 Thread Carl Eugen Hoyos
2018-02-09 22:24 GMT+01:00 Michael Niedermayer : > Fixes: Ticket7005 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4videodec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c > index 756753e2fc..1

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-11 Thread Nicolas George
Hi. I had a look at the whole code. There are a few remarks below. Sorry for the delay, a lot of things on my place these days. Nablet Developer (2018-01-30): > protocol requires libsrt (https://github.com/Haivision/srt) to be > installed > > Signed-off-by: Nablet Developer > --- > MAINTAINER

Re: [FFmpeg-devel] [PATCH]lavf/rtpdec: Constify several pointers

2018-02-11 Thread Carl Eugen Hoyos
2018-02-11 0:32 GMT+01:00 Muhammad Faiz : > On Sat, Feb 10, 2018 at 8:57 AM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes two warnings. >> libavformat/rtpdec.c: In function ‘ff_rtp_handler_find_by_name’: >> libavformat/rtpdec.c:155:20: warning: return discards ‘const’ >> qualifier fro

[FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not allow -reserve_index_space 1

2018-02-11 Thread Carl Eugen Hoyos
Hi! Attached patch fixes an assertion failure with the following command line: $ ffmpeg -f lavfi -i testsrc -reserve_index_space 1 out.mkv Please comment, Carl Eugen From 4566d5f90f24bf2373175a8aad84c82be6b1a9eb Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 11 Feb 2018 20:16:02 +010

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not allow -reserve_index_space 1

2018-02-11 Thread Nicolas George
Carl Eugen Hoyos (2018-02-11): > Attached patch fixes an assertion failure with the following command line: > $ ffmpeg -f lavfi -i testsrc -reserve_index_space 1 out.mkv > > Please comment, Carl Eugen Reading the code, it is pretty obvious that 0 is a valid value and forbidding it would be bad.

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not allow -reserve_index_space 1

2018-02-11 Thread Carl Eugen Hoyos
2018-02-11 20:23 GMT+01:00 Nicolas George : > Carl Eugen Hoyos (2018-02-11): >> Attached patch fixes an assertion failure with the following command line: >> $ ffmpeg -f lavfi -i testsrc -reserve_index_space 1 out.mkv > Reading the code, it is pretty obvious that 0 is a valid value and > forbiddin

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not allow -reserve_index_space 1

2018-02-11 Thread Nicolas George
Carl Eugen Hoyos (2018-02-11): > 2018-02-11 20:23 GMT+01:00 Nicolas George : > > Carl Eugen Hoyos (2018-02-11): > >> Attached patch fixes an assertion failure with the following command line: > >> $ ffmpeg -f lavfi -i testsrc -reserve_index_space 1 out.mkv > > > Reading the code, it is pretty obvi

Re: [FFmpeg-devel] [PATCH 1/3] mpegvideo_parser: implement parsing of the picture structure field

2018-02-11 Thread Yusuke Nakamura
2018-02-11 23:37 GMT+09:00 Jan Ekström : > From: Masaki Tanaka > > Lets one receive the proper field order from pictures coded in > field picture mode, until now forcibly set to BFF. > --- > libavcodec/mpegvideo_parser.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) >

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract NTSC VANC

2018-02-11 Thread Marton Balint
On Mon, 5 Feb 2018, Ray Tiley wrote: This changes how NTSC VANC is extracted from the buffer. In NTSC the vanc data interleved between the uyvy and not just the luma as in high definition resolutions. In my testing this allows a decklink card encoding valid NTSC closed captions to pass the cap

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: add ff_read_line_to_bprint and ff_read_line_to_bprint_overwrite functions

2018-02-11 Thread Marton Balint
On Sun, 11 Feb 2018, Nicolas George wrote: Marton Balint (2018-02-10): To be able to read lines longer than a static buffer size. Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 46 ++ libavformat/internal.h | 26

Re: [FFmpeg-devel] [PATCH 1/3] mpegvideo_parser: implement parsing of the picture structure field

2018-02-11 Thread Michael Niedermayer
On Mon, Feb 12, 2018 at 05:37:32AM +0900, Yusuke Nakamura wrote: > 2018-02-11 23:37 GMT+09:00 Jan Ekström : > > > From: Masaki Tanaka > > > > Lets one receive the proper field order from pictures coded in > > field picture mode, until now forcibly set to BFF. > > --- > > libavcodec/mpegvideo_par

[FFmpeg-devel] Purely synthetic PTS and DTS...

2018-02-11 Thread Tony Di Croce
I have video frames in a buffer in memory... and I know their frame rate (and other information like resolution, etc)... I am attempting to mux this video into an mp4... But I don't know how to set PTS/DTS appropriately. I have two questions: 1) What should I set AVStream->time_base to? 2) How do

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpeg4videodec: Ignore multiple VOL headers

2018-02-11 Thread Michael Niedermayer
On Sun, Feb 11, 2018 at 08:01:36PM +0100, Carl Eugen Hoyos wrote: > 2018-02-09 22:24 GMT+01:00 Michael Niedermayer : > > Fixes: Ticket7005 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/mpeg4videodec.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff -

Re: [FFmpeg-devel] [PATCH]lavf/rtpdec: Constify several pointers

2018-02-11 Thread Muhammad Faiz
On Mon, Feb 12, 2018 at 2:05 AM, Carl Eugen Hoyos wrote: > 2018-02-11 0:32 GMT+01:00 Muhammad Faiz : >> On Sat, Feb 10, 2018 at 8:57 AM, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch fixes two warnings. >>> libavformat/rtpdec.c: In function ‘ff_rtp_handler_find_by_name’: >>> libavformat/

Re: [FFmpeg-devel] [PATCH] fate/libavcodec: add codec_desc test

2018-02-11 Thread Muhammad Faiz
On Sun, Feb 11, 2018 at 6:43 AM, Michael Niedermayer wrote: > On Sat, Feb 10, 2018 at 04:37:00PM +0700, Muhammad Faiz wrote: >> Remove runtime check at codec_desc.c >> >> Signed-off-by: Muhammad Faiz >> --- >> libavcodec/Makefile | 1 + >> libavcodec/codec_desc.c | 24 --

[FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract NTSC VANC

2018-02-11 Thread Ray Tiley
This changes how NTSC VANC is extracted from the buffer. In NTSC the vanc data interleved between the uyvy and not just the luma as in high definition resolutions. In my testing this allows a decklink card encoding valid NTSC closed captions to pass the caption data to the x264 encoder. Updated w

Re: [FFmpeg-devel] [PATCH 1/3] mpegvideo_parser: implement parsing of the picture structure field

2018-02-11 Thread Jan Ekström
On Mon, Feb 12, 2018 at 12:23 AM, Michael Niedermayer wrote: > > I think a better API is needed to export the picture_structure correctly. > I might be misunderstanding the problem at hand, but I'm not sure if a better API is required right now in the sense that if we define that: * the demuxer a

[FFmpeg-devel] [PATCH] avcodec: remove av_codec_init_static()

2018-02-11 Thread Muhammad Faiz
Modify the behavior of init_static_data(). Signed-off-by: Muhammad Faiz --- libavcodec/allcodecs.c | 16 libavcodec/avcodec.h | 4 +++- libavcodec/libvpxdec.c | 15 ++- libavcodec/libvpxenc.c | 15 ++- libavcodec/libx264.c | 11 ++- libavcode