Re: [FFmpeg-devel] [PATCH v1 1/3] avcodec: v4l2_m2m: fix races around freeing data on close

2018-01-22 Thread Jorge Ramirez-Ortiz
On 01/22/2018 12:25 AM, Mark Thompson wrote: On 19/01/18 16:40, Jorge Ramirez-Ortiz wrote: On 01/19/2018 12:30 AM, Michael Niedermayer wrote: On Thu, Jan 18, 2018 at 09:24:20AM +0100, Jorge Ramirez-Ortiz wrote: On 01/09/2018 11:56 PM, Jorge Ramirez-Ortiz wrote: From: Mark Thompson Refcount

Re: [FFmpeg-devel] [PATCH v1 1/3] avcodec: v4l2_m2m: fix races around freeing data on close

2018-01-22 Thread Jorge Ramirez-Ortiz
On 01/21/2018 01:46 AM, Mark Thompson wrote: On 09/01/18 22:56, Jorge Ramirez-Ortiz wrote: From: Mark Thompson Refcount all of the context information. This also fixes a potential segmentation fault when accessing freed memory (buffer returned after the codec has been closed). Tested-by: Jor

[FFmpeg-devel] [RFC] about av_init_packet

2018-01-22 Thread Jun Zhao
Hi, all: When I read the code about av_init_packet(), I found we use av_init_packet() in most cases like this:     av_init_packet(&enc_pkt);     enc_pkt.data = NULL;     enc_pkt.size = 0; my question is: is it have any special reason to put AVPakcet.date/size initialization outside av_init_packe

[FFmpeg-devel] [PATCH] lavc/qsv: skip the packet if decoding failure.

2018-01-22 Thread Ruiling, Song
MediaSDK may fail to decode some frame, just skip it. Otherwise, it will keep decoding the failure packet repeatedly without processing any packet afterwards. Signed-off-by: Ruiling, Song --- libavcodec/qsvdec_h2645.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/li

Re: [FFmpeg-devel] [RFC] about av_init_packet

2018-01-22 Thread Hendrik Leppkes
On Mon, Jan 22, 2018 at 8:55 AM, Jun Zhao wrote: > Hi, all: > > When I read the code about av_init_packet(), I found we use > av_init_packet() in most cases like this: > > av_init_packet(&enc_pkt); > enc_pkt.data = NULL; > enc_pkt.size = 0; > > my question is: is it have any special re

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-22 Thread Marton Balint
On Mon, 22 Jan 2018, Carl Eugen Hoyos wrote: 2018-01-22 3:35 GMT+01:00 Marton Balint : On Mon, 22 Jan 2018, Carl Eugen Hoyos wrote: 2018-01-21 23:48 GMT+01:00 Kieran Kunhya : On Sun, Jan 21, 2018 at 10:06 PM, Carl Eugen Hoyos wrote: 2018-01-21 22:45 GMT+01:00 Kieran Kunhya : > On Sun

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-22 Thread Carl Eugen Hoyos
2018-01-22 11:41 GMT+01:00 Marton Balint : > Your command line shows gcc 4.7. Maybe this is > some compiler issue then? I can also reproduce the issue with vanilla gcc 6.3.0, so I don't think this is a compiler issue. Carl Eugen ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-22 Thread Tobias Rapp
On 20.01.2018 20:17, Dmytro Humeniuk wrote: On 18 Jan 2018, at 17:32, Dmytro Humeniuk wrote: On 18 Jan 2018, at 08:56, Tobias Rapp wrote: On 15.01.2018 13:48, Dmytro Humeniuk wrote: On 15 Jan 2018, at 09:14, Tobias Rapp wrote: On 13.01.2018 23:52, Дмитрий Гуменюк wrote: Hi, On 13 Jan

Re: [FFmpeg-devel] [RFC] about av_init_packet

2018-01-22 Thread wm4
On Mon, 22 Jan 2018 09:58:56 +0100 Hendrik Leppkes wrote: > On Mon, Jan 22, 2018 at 8:55 AM, Jun Zhao wrote: > > Hi, all: > > > > When I read the code about av_init_packet(), I found we use > > av_init_packet() in most cases like this: > > > > av_init_packet(&enc_pkt); > > enc_pkt.data =

[FFmpeg-devel] [PATCH] libopus: support disabling phase inversion.

2018-01-22 Thread mrdegier
From: Menno Signed-off-by: Menno --- doc/encoders.texi | 5 + libavcodec/libopusenc.c | 14 ++ 2 files changed, 19 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 6a410a8cb6..5cd8b1a064 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -981

Re: [FFmpeg-devel] [PATCH] libopus: support disabling phase inversion.

2018-01-22 Thread Derek Buitenhuis
On 1/22/2018 3:16 PM, mrdeg...@gmail.com wrote: > From: Menno > > Signed-off-by: Menno > --- > doc/encoders.texi | 5 + > libavcodec/libopusenc.c | 14 ++ > 2 files changed, 19 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 6a410a8cb6..5cd8b

Re: [FFmpeg-devel] [PATCH] libopus: support disabling phase inversion.

2018-01-22 Thread Paul B Mahol
On 1/22/18, mrdeg...@gmail.com wrote: > From: Menno > > Signed-off-by: Menno > --- > doc/encoders.texi | 5 + > libavcodec/libopusenc.c | 14 ++ > 2 files changed, 19 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 6a410a8cb6..5cd8b1a064 10064

Re: [FFmpeg-devel] GSoC 2018

2018-01-22 Thread Thilo Borgmann
Hi again, > Like in the previous years, we've setup an ideas page in our wiki: > https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2018 > The application deadline is January 23th which is exactly two weeks from now. > Therefore, let's try to define new tasks soon. thank you all for your proj

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

2018-01-22 Thread Jacob Trimble
On Wed, Jan 10, 2018 at 5:08 PM, Jacob Trimble wrote: > > On Wed, Jan 10, 2018 at 1:51 PM, Michael Niedermayer > wrote: > > [...] > > > > This causes a crash: > > > > = > > ==4012==ERROR: AddressSanitizer: heap-buffer-overflow on add

Re: [FFmpeg-devel] [PATCH] libopus: support disabling phase inversion.

2018-01-22 Thread Derek Buitenhuis
On 1/22/2018 4:46 PM, Paul B Mahol wrote: > NACK. > > Option name is too loong, and its type is not boolean. Opinions on what to call it welcome. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-de

Re: [FFmpeg-devel] [PATCH] avformat: add option to parse/store ID3 PRIV tags in metadata.

2018-01-22 Thread Richard Shaffer
I wanted to push this thread to the top of the list one more time. wm4 was kind enough to make some comments on the original patch, which I think I've addressed. It would be good to know where it stands. If it might be useful to other people, it would be nice to have it accepted in ffmpeg, or to h

[FFmpeg-devel] [PATCH] avcodec/dxtory: Fix bits left checks

2018-01-22 Thread Michael Niedermayer
Fixes: Timeout Fixes: 4863/clusterfuzz-testcase-6347354178322432 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/dxtory.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] libopus: support disabling phase inversion.

2018-01-22 Thread Carl Eugen Hoyos
2018-01-22 16:16 GMT+01:00 : > +#ifdef OPUS_SET_PHASE_INVERSION_DISABLED_REQUEST > +{ "disable_phase_inversion", "Disable phase inversion", > OFFSET(disable_phase_inversion), > AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, FLAGS }, One possibility is an option "phase_inversion" t

Re: [FFmpeg-devel] [PATCH] libopus: support disabling phase inversion.

2018-01-22 Thread Rostislav Pehlivanov
On 22 January 2018 at 15:16, wrote: > From: Menno > > Signed-off-by: Menno > --- > doc/encoders.texi | 5 + > libavcodec/libopusenc.c | 14 ++ > 2 files changed, 19 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 6a410a8cb6..5cd8b1a064 100644

Re: [FFmpeg-devel] [PATCH] avformat: add option to parse/store ID3 PRIV tags in metadata.

2018-01-22 Thread wm4
On Wed, 17 Jan 2018 16:34:39 -0800 rshaf...@tunein.com wrote: > From: Richard Shaffer > > Enables getting access to ID3 PRIV tags from the command-line or metadata API > when demuxing. The PRIV owner is stored as the metadata key prepended with > "id3v2_priv.", and the data is stored as the meta

Re: [FFmpeg-devel] [PATCH] avformat: add option to parse/store ID3 PRIV tags in metadata.

2018-01-22 Thread Richard Shaffer
On Mon, Jan 22, 2018 at 3:18 PM, wm4 wrote: > On Wed, 17 Jan 2018 16:34:39 -0800 > rshaf...@tunein.com wrote: > > > From: Richard Shaffer > > > > Enables getting access to ID3 PRIV tags from the command-line or > metadata API > > when demuxing. The PRIV owner is stored as the metadata key prepen

[FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input

2018-01-22 Thread Mark Thompson
--- This allows passing OpenCL frames to AMF without a download/upload step to get around AMD's lack of support for D3D11 mapping. For example: ./ffmpeg -hwaccel dxva2 -hwaccel_output_format dxva2_vld -i input.mp4 -an -vf 'hwmap=derive_device=opencl,program_opencl=source=examples.cl:kernel=rota

Re: [FFmpeg-devel] [PATCH] avformat: add option to parse/store ID3 PRIV tags in metadata.

2018-01-22 Thread wm4
On Mon, 22 Jan 2018 15:48:07 -0800 Richard Shaffer wrote: > On Mon, Jan 22, 2018 at 3:18 PM, wm4 wrote: > > > On Wed, 17 Jan 2018 16:34:39 -0800 > > rshaf...@tunein.com wrote: > > > > > From: Richard Shaffer > > > > > > Enables getting access to ID3 PRIV tags from the command-line or > > m

[FFmpeg-devel] [PATCH] avformat: add option to parse/store ID3 PRIV tags in metadata.

2018-01-22 Thread rshaffer
From: Richard Shaffer Enables getting access to ID3 PRIV tags from the command-line or metadata API when demuxing. The PRIV owner is stored as the metadata key prepended with "id3v2_priv.", and the data is stored as the metadata value. As PRIV tags may contain arbitrary data, non-printable charac

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-22 Thread Devin Heitmueller
Hi Ray, Thanks for your patch. A few questions: Could you confirm whether you are capturing via SDI or analog (i.e. composite/component)? Also what is the capturing device and SDK version you are using? I’ve found various bugs in the numbering of VANC lines in some cards, particularly with

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

2018-01-22 Thread Michael Niedermayer
On Wed, Jan 10, 2018 at 05:08:09PM -0800, Jacob Trimble wrote: > On Wed, Jan 10, 2018 at 1:51 PM, Michael Niedermayer > wrote: > > [...] > > > > This causes a crash: > > > > = > > ==4012==ERROR: AddressSanitizer: heap-buffer-overflow

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-22 Thread Ray Tiley
On Mon, Jan 22, 2018 at 10:20 PM Devin Heitmueller < dheitmuel...@ltnglobal.com> wrote: > Hi Ray, > > Thanks for your patch. A few questions: > > Could you confirm whether you are capturing via SDI or analog (i.e. > composite/component)? Also what is the capturing device and SDK version > you ar

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-22 Thread Devin Heitmueller
Hi Ray, > On Jan 22, 2018, at 10:47 PM, Ray Tiley wrote: >> Could you confirm whether you are capturing via SDI or analog (i.e. >> composite/component)? Also what is the capturing device and SDK version >> you are using? I’ve found various bugs in the numbering of VANC lines in >> some cards, p

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-22 Thread Ray Tiley
On Mon, Jan 22, 2018 at 11:12 PM Devin Heitmueller < dheitmuel...@ltnglobal.com> wrote: > Hi Ray, > > > On Jan 22, 2018, at 10:47 PM, Ray Tiley wrote: > >> Could you confirm whether you are capturing via SDI or analog (i.e. > >> composite/component)? Also what is the capturing device and SDK ver

[FFmpeg-devel] [PATCH 2/4] lavfi/deinterlace_vaapi: fix typo and add check.

2018-01-22 Thread Jun Zhao
From 92294e97ffee609a2cac298f3ff0b51f3e3e37ef Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 23 Jan 2018 11:24:53 +0800 Subject: [PATCH 2/4] lavfi/deinterlace_vaapi: fix typo and add check. Signed-off-by: Jun Zhao --- libavfilter/vf_deinterlace_vaapi.c | 8 +--- 1 file changed, 5 inser

[FFmpeg-devel] [PATCH 3/4] lavfi/procamp_vaapi: fix the green output issue.

2018-01-22 Thread Jun Zhao
From ccfaaee784b2d2d25f3f71eda1e39a368d7611f5 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 23 Jan 2018 11:26:54 +0800 Subject: [PATCH 3/4] lavfi/procamp_vaapi: fix the green output issue. Fix the green output issue when use procamp_vaapi without any arguments, and fix the typo. Signed-off

[FFmpeg-devel] [PATCH 1/4] lavfi/scale_vaapi: fix the typo.

2018-01-22 Thread Jun Zhao
From cc7874334b33342bfc7c01982225e654cdb23f93 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 23 Jan 2018 11:24:17 +0800 Subject: [PATCH 1/4] lavfi/scale_vaapi: fix the typo. Signed-off-by: Jun Zhao --- libavfilter/vf_scale_vaapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH 4/4] lavfi/misc_vaapi: fix typo and add check for params buffer.

2018-01-22 Thread Jun Zhao
From 021278e2b1a5cee873fbc6c36e5666b2ca7a4e8d Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 23 Jan 2018 12:12:21 +0800 Subject: [PATCH 4/4] lavfi/misc_vaapi: fix typo and add check for params buffer. Signed-off-by: Jun Zhao --- libavfilter/vf_misc_vaapi.c | 68 +--

Re: [FFmpeg-devel] [RFC] about av_init_packet

2018-01-22 Thread Jun Zhao
On 2018/1/22 22:15, wm4 wrote: > On Mon, 22 Jan 2018 09:58:56 +0100 > Hendrik Leppkes wrote: > >> On Mon, Jan 22, 2018 at 8:55 AM, Jun Zhao wrote: >>> Hi, all: >>> >>> When I read the code about av_init_packet(), I found we use >>> av_init_packet() in most cases like this: >>> >>> av_init_p

[FFmpeg-devel] [PATCH v3 1/1] avformat/hlsenc: closed caption tags in the master playlist

2018-01-22 Thread vdixit
From: Vishwanath Dixit --- doc/muxers.texi | 37 +++ libavformat/dashenc.c | 2 +- libavformat/hlsenc.c | 155 +- libavformat/hlsplaylist.c | 5 +- libavformat/hlsplaylist.h | 2 +- 5 files changed, 196 insertions(+),

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat/hlsenc: closed caption tags in the master playlist

2018-01-22 Thread Dixit, Vishwanath
On 1/15/18 11:27 AM, Dixit, Vishwanath wrote: > > > On 1/14/18 8:38 PM, Liu Steven wrote: >> >>> 在 2018年1月9日,下午5:54,Dixit, Vishwanath 写道: >>> >>> >>> >>> On 1/9/18 3:05 PM, 刘歧 wrote: >>> >> >> >> I cannot sure use -cc_stream_map_ccgroup option is ok, because the >> ccgroup s

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/hlsenc: closed caption tags in the master playlist

2018-01-22 Thread Liu Steven
> 在 2018年1月23日,下午1:21,vdi...@akamai.com 写道: > > From: Vishwanath Dixit > > --- > doc/muxers.texi | 37 +++ > libavformat/dashenc.c | 2 +- > libavformat/hlsenc.c | 155 +- > libavformat/hlsplaylist.c | 5 +- > libavformat/h

Re: [FFmpeg-devel] [PATCH v3 1/3] avdevice/decklink: addition of copyts option

2018-01-22 Thread Dixit, Vishwanath
On 1/20/18 11:27 PM, Marton Balint wrote: > > > On Mon, 15 Jan 2018, vdi...@akamai.com wrote: > >> From: Vishwanath Dixit >> >> --- >> doc/indevs.texi | 5 + >> libavdevice/decklink_common_c.h | 1 + >> libavdevice/decklink_dec.cpp| 18 +++--- >> libavdevice/de