Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: hw device should be set

On Fri, 29 Dec 2017 15:06:09 +0800 Zhong Li wrote: > Add the flag "AV_CODEC_HW_CONFIG_METHOD_HW_DEVICE_CTX" to indicate > AVCodecContext.hw_device_ctx should be set before calling > avcodec_open2() for qsv decoding. > It is consistent with examples/qsvdec.c. > > It also can make function "hw_dev

Re: [FFmpeg-devel] PR new filter gltransition

On 12/29/17, Rostislav Pehlivanov wrote: > On 27 December 2017 at 23:13, Travis Fischer wrote: > >> Hello, >> >> This is my first time contributing to ffmpeg, so please go easy on me :) >> >> I have a git diff here >> which add a >> ne

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

On Fri, Dec 29, 2017 at 3:43 AM, Cyber Sinh wrote: > The attached patch changes the configure script for FFmpeg (and associated > shell scripts) to call MSVC tools including their extensions (cl.exe instead > of cl for example). This is necessary, because WSL can automatically launch > Windows pro

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/hlsenc, utils: Moved is_http_proto from hlsenc to utils for re-use

2017-12-27 15:25 GMT+08:00 Steven Liu : > 2017-12-27 6:22 GMT+08:00 Aman Gupta : >> On Sat, Dec 16, 2017 at 11:03 AM Karthick J wrote: >> >>> From: Karthick Jeyapal >>> >>> --- >>> libavformat/hlsenc.c | 12 +++- >>> libavformat/internal.h | 8 >>> libavformat/utils.c| 5

Re: [FFmpeg-devel] [PATCH v3 3/3] avformat/hlsenc: creation of variant streams in subdirectories

2017-12-26 19:17 GMT+08:00 : > From: Vishwanath Dixit > > --- > doc/muxers.texi | 33 - > libavformat/hlsenc.c | 68 > +--- > 2 files changed, 92 insertions(+), 9 deletions(-) > > diff --git a/doc/muxers.texi b/doc/mux

[FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: closed caption tags in the master playlist

From: Vishwanath Dixit --- doc/muxers.texi | 4 libavformat/dashenc.c | 2 +- libavformat/hlsenc.c | 14 +- libavformat/hlsplaylist.c | 5 - libavformat/hlsplaylist.h | 3 ++- 5 files changed, 24 insertions(+), 4 deletions(-) diff --git a/doc/muxers.t

[FFmpeg-devel] [PATCH 0/1] mpeg: add experimental support for PSMF audio.

From: Misty De Meo Thanks for pointing this out. I hadn't had a separate .at3 file to test with, and didn't realize that this broke regular ATRAC3P files. I've added a new fate test which detects this regression; it passes on master and fails in the MPEG-ATRAC3 branch. I'll keep working on my bra

[FFmpeg-devel] [PATCH 1/1] fate: add atrac3p conversion test

From: Misty De Meo --- tests/fate/atrac.mak | 4 1 file changed, 4 insertions(+) diff --git a/tests/fate/atrac.mak b/tests/fate/atrac.mak index acf79a539c..1707373890 100644 --- a/tests/fate/atrac.mak +++ b/tests/fate/atrac.mak @@ -31,6 +31,10 @@ FATE_ATRAC3P += fate-atrac3p-2 fate-atrac3

[FFmpeg-devel] [PATCH, V3] avformat/concat: Fix wrong wrapped timestamp

From: Wu Zhiqiang When using concat protocol, start from middle of file will generate non-zero wrap reference. If seek to time before the wrap reference, wrap control will generate wrong wrapped timestamp. Copy wrap related stream properties when reading header can fix this problem. Signed-off

[FFmpeg-devel] [PATCH v2 1/1] avformat/hlsenc: closed caption tags in the master playlist

From: Vishwanath Dixit --- doc/muxers.texi | 4 libavformat/dashenc.c | 2 +- libavformat/hlsenc.c | 14 +- libavformat/hlsplaylist.c | 5 - libavformat/hlsplaylist.h | 3 ++- 5 files changed, 24 insertions(+), 4 deletions(-) diff --git a/doc/muxers.t

Re: [FFmpeg-devel] [PATCH, V3] avformat/concat: Fix wrong wrapped timestamp

mymoey...@gmail.com (2017-12-29): > From: Wu Zhiqiang > > When using concat protocol, start from middle of file will generate non-zero > wrap reference. > If seek to time before the wrap reference, wrap control will generate wrong > wrapped timestamp. > Copy wrap related stream properties when

Re: [FFmpeg-devel] [WARNING! RECEIVED FROM EXTERNAL SENDER] [PATCH v2 1/1] avformat/hlsenc: closed caption tags in the master playlist

On 12/29/17 5:02 PM, vdi...@akamai.com wrote: From: Vishwanath Dixit --- doc/muxers.texi | 4 libavformat/dashenc.c | 2 +- libavformat/hlsenc.c | 14 +- libavformat/hlsplaylist.c | 5 - libavformat/hlsplaylist.h | 3 ++- 5 files changed, 24

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: closed caption tags in the master playlist

2017-12-29 18:44 GMT+08:00 : > From: Vishwanath Dixit > > --- > doc/muxers.texi | 4 > libavformat/dashenc.c | 2 +- > libavformat/hlsenc.c | 14 +- > libavformat/hlsplaylist.c | 5 - > libavformat/hlsplaylist.h | 3 ++- > 5 files changed, 24 insertion

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

Hi Aaron, - I were not aware of the Gilles Khouzam patch when I make the patch (I read its useful blog post). But feel free to give credits to anyone you want. Adding ".exe" to the end of Windows executables is not rocket science, as you said. - My patch is sufficient to build FFmpeg on bash on

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

On Fri, 29 Dec 2017 10:44:21 +0100 Hendrik Leppkes wrote: > On Fri, Dec 29, 2017 at 3:43 AM, Cyber Sinh wrote: > > The attached patch changes the configure script for FFmpeg (and associated > > shell scripts) to call MSVC tools including their extensions (cl.exe instead > > of cl for example). T

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: closed caption tags in the master playlist

On 12/29/17 5:11 PM, Steven Liu wrote: > 2017-12-29 18:44 GMT+08:00 : >> From: Vishwanath Dixit >> >> --- >> doc/muxers.texi | 4 >> libavformat/dashenc.c | 2 +- >> libavformat/hlsenc.c | 14 +- >> libavformat/hlsplaylist.c | 5 - >> libavformat/hlsp

Re: [FFmpeg-devel] PR new filter gltransition

On 29 December 2017 at 08:24, Paul B Mahol wrote: > On 12/29/17, Rostislav Pehlivanov wrote: > > On 27 December 2017 at 23:13, Travis Fischer > wrote: > > > >> Hello, > >> > >> This is my first time contributing to ffmpeg, so please go easy on me :) > >> > >> I have a git diff here > >>

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

Hi. Sorry for having missed your reply earlier. 吴志强 (2017-12-18): > I see wrap timestamp control is enable by pts_wrap_bits(default 33), > but mp4 demuxer will later set this to 64 (means disabled). > Now pts_wrap_bits are always tied to 33 without copy it, which seems > strange. I understand th

Re: [FFmpeg-devel] [PATCH, V3] avformat/concat: Fix wrong wrapped timestamp

I already answered: http://ffmpeg.org/pipermail/ffmpeg-devel/2017-December/222605.html I just refine coding style following your advice and re-submit it. Thanks. On Fri, Dec 29, 2017 at 7:33 PM, Nicolas George wrote: > mymoe

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: closed caption tags in the master playlist

2017-12-29 19:58 GMT+08:00 Dixit, Vishwanath : > > > On 12/29/17 5:11 PM, Steven Liu wrote: >> 2017-12-29 18:44 GMT+08:00 : >>> From: Vishwanath Dixit >>> >>> --- >>> doc/muxers.texi | 4 >>> libavformat/dashenc.c | 2 +- >>> libavformat/hlsenc.c | 14 +- >>>

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

Sorry for the diff instead of regular git patch. Here is the patch. -Message d'origine- De : ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] De la part de wm4 Envoyé : vendredi 29 décembre 2017 12:54 À : ffmpeg-devel@ffmpeg.org Objet : Re: [FFmpeg-devel] [MSVC toolchain] Patch to al

[FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

$subj I'm not to happy about the s->block2 stuff, there are many ways of trying to resolve this (e.g union), so review welcome. I will add DPCM support in a later (currently unfinished) patch. Kieran 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data _

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

On Fri, Dec 29, 2017 at 8:00 PM, Nicolas George wrote: > Hi. Sorry for having missed your reply earlier. > > 吴志强 (2017-12-18): > > I see wrap timestamp control is enable by pts_wrap_bits(default 33), > > but mp4 demuxer will later set this to 64 (means disabled). > > Now pts_wrap_bits are always

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

On Fri, 29 Dec 2017 12:41:07 +0100 "Cyber Sinh" wrote: > Hi Aaron, > > - I were not aware of the Gilles Khouzam patch when I make the patch (I read > its useful blog post). But feel free to give credits to anyone you want. > Adding ".exe" to the end of Windows executables is not rocket science

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

Wu Zhiqiang (2017-12-30): > Normally pts_wrap_reference is based on the first packet when calling > ff_read_packet, > which will call function update_wrap_reference , in libavformat/utils line > 734: > > if (ref == AV_NOPTS_VALUE) > ref = pkt->pts; > if (st->pts_wrap_reference !=

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

2017年12月30日 上午12:30，"Nicolas George" 写道： Wu Zhiqiang (2017-12-30): > Normally pts_wrap_reference is based on the first packet when calling > ff_read_packet, > which will call function update_wrap_reference , in libavformat/utils line > 734: > > if (ref == AV_NOPTS_VALUE) > ref = pkt->

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

Wu Zhiqiang (2017-12-30): > But how to decide wrap margin that concat see? > Though monotonic timestamp is always ok, > I do not want that sub-demuxer see unwrapped timestamp but concat see > wrapped one . > Or sub-demuxer disable wrap correction but concat enable it. I am sorry, I do not under

[FFmpeg-devel] h264: fix RTSP stream decoding

Hello, FFmpeg stop working with the latest model of camera that I work now. I've investigated it and found that "bad" commit is 98c97994c5b90bdae02accb155eeceeb5224b8ef. There was additional check for ret value and err_recognition, that was ignored while refactoring to h264_parse.c function.

[FFmpeg-devel] [PATCHv3 0/8] Decklink updates

This patch series provides a number of enhancements for both capture and output using the decklink module, including addressing comments from Marton Balint, Derek Buitenhuis, and James Almer. Devin Heitmueller (8): libavdevice/decklink: Add support for EIA-708 output over SDI decklink: Add sup

[FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

Implement support for including AFD in decklink output. This includes making sure the AFD data is preserved when going from an AVFrame to a V210 packet (needed for 10-bit support). Updated to reflect feedback from Marton Balint Signed-off-by: Devin Heitmueller --- libavcodec/avcodec.h

[FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

Hook in libklvanc and use it for output of EIA-708 captions over SDI. The bulk of this patch is just general support for ancillary data for the Decklink SDI module - the real work for construction of the EIA-708 CDP and VANC line construction is done by libklvanc. Libklvanc can be found at: https

[FFmpeg-devel] [PATCH 4/8] Preserve AFD side data when going from AVPacket to AVFrame

This is needed to ensure that AFD data continues to work when capturing V210 video with the Decklink libavdevice input. Signed-off-by: Devin Heitmueller --- libavcodec/decode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 3f5b086f7e..f906436

[FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

Add support for the ability to capture all audio pairs available to the capture hardware. Each pair is exposed as a different audio stream, which matches up with the most common use cases for the broadcast space (i.e. where there is one stereo pair per audio language). To support the existing use

[FFmpeg-devel] [PATCH 7/8] decklink: Add support for SCTE-104 to decklink capture

Make use of libklvanc to parse SCTE-104 packets and announce them as a new stream. Right now we just pass the payload straight through, but once this is hoooked into libklscte35 we'll be able to generate SCTE-35 messages in the MPEG TS stream. Note that this feature needs to be explicitly enabled

[FFmpeg-devel] [PATCH 5/8] Support encoding of Active Format Description (AFD) in libx264

If AFD side data is present, include it in an H.264 SEI payload when encoding with libx264. This is done in the same manner that we currently handle A53 closed captions (where the business logic for constructing the SEI is in libavcodec/utils.c), so it should be portable to the other encoder types

[FFmpeg-devel] [PATCH 6/8] Add suppoort for using libklvanc from within decklink capture module

Make use of libklvanc from within the decklink capture module, initially for EIA-708 and AFD. Support for other VANC types will come in subsequent patches. Incorporates feedback from Derek Buitenhuis and James Almer Signed-off-by: Devin Heitmueller --- libavdevice/decklink_dec.cpp | 133

[FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

Extend the decklink output to include support for compressed AC-3, encapsulated using the SMPTE ST 377:2015 standard. This functionality can be exercised by using the "copy" codec when the input audio stream is AC-3. For example: ./ffmpeg -i ~/foo.ts -codec:a copy -f decklink 'UltraStudio Mini M

Re: [FFmpeg-devel] h264: fix RTSP stream decoding

Hi, On Fri, Dec 29, 2017 at 12:43 PM, ser...@gavrushkin.com wrote: > Hello, > > FFmpeg stop working with the latest model of camera that I work now. I've > investigated it and found that "bad" commit is > 98c97994c5b90bdae02accb155eeceeb5224b8ef. There was additional check for ret > value and

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not blindly allocate stts entries

On 12/29/2017 1:10 AM, Carl Eugen Hoyos wrote: > New patch attached, only tested with fate. > +if (INT_MAX / sizeof(*sc->stts_data) <= entries) > return AVERROR(ENOMEM); Should probably be something thing AVERROR(EINVAL), I think. > +sc->stts_count = FFMIN(1024 * 1024, entries);

Re: [FFmpeg-devel] [PATCH] configure: check SDL2 function with a header

On 12/29/2017 6:36 AM, KO Myung-Hun wrote: > Sorry about that. > > SDL2 uses SDLCALL to specify a calling convention. On OS/2, it's defined > to `_System' which is similar to `_cdecl' but does not prepend '_'. > > After all, without a header, a function is used without `_System'. And > linker wil

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not blindly allocate stts entries

2017-12-29 20:47 GMT+01:00 Derek Buitenhuis : > On 12/29/2017 1:10 AM, Carl Eugen Hoyos wrote: >> New patch attached, only tested with fate. > >> +if (INT_MAX / sizeof(*sc->stts_data) <= entries) This is an arbitrary limit... >> return AVERROR(ENOMEM); > > Should probably be somethin

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not blindly allocate stts entries

On 12/29/2017 8:25 PM, Carl Eugen Hoyos wrote: > 2017-12-29 20:47 GMT+01:00 Derek Buitenhuis : >> On 12/29/2017 1:10 AM, Carl Eugen Hoyos wrote: >>> New patch attached, only tested with fate. >> >>> +if (INT_MAX / sizeof(*sc->stts_data) <= entries) > > This is an arbitrary limit... Yeah, true

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > +side_data = av_frame_get_side_data(pic, AV_FRAME_DATA_A53_CC); > +if (side_data && side_data->size) { > +uint8_t *buf = av_packet_new_side_data(pkt, AV_PKT_DATA_A53_CC, > side_data->size); > +if (buf) > +memcpy(

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not blindly allocate stts entries

2017-12-29 21:35 GMT+01:00 Derek Buitenhuis : > FFMIN(sc->stts_count * 2, entries) could in theory end up using > more memory for legitimate large files though, due to exponential > buffer growth. Is that something worth caring about? Sorry, I don't understand this sentence - could you try with o

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > +/* FIXME: Should really rely on the coded_width but seems like that > + is not accessible to libavdevice outputs */ > +if ((st->codecpar->width == 1280 && st->codecpar->height == 720) || > +(st->codecpar->width

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > +for (int i = 0; i < ctx->max_audio_channels / 2; i++) { > +st = avformat_new_stream(avctx, NULL); > +if (!st) { > +av_log(avctx, AV_LOG_ERROR, "Cannot add stream %d\n", i); > +ret = AV

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

Hi Carl, Thanks for your feedback. Comments inline> > On Dec 29, 2017, at 3:41 PM, Carl Eugen Hoyos wrote: > > 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > >> +side_data = av_frame_get_side_data(pic, AV_FRAME_DATA_A53_CC); >> +if (side_data && side_data->size) { >> +uint8_

Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > +uint8_t *outbuf = NULL; > +if (st->codecpar->codec_id == AV_CODEC_ID_AC3) > +av_free(outbuf); The "if()" should not be necessary, free() and av_free() may be called with argument "NULL". Carl Eugen ___

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

> On Dec 29, 2017, at 3:48 PM, Carl Eugen Hoyos wrote: > > 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > >> +/* FIXME: Should really rely on the coded_width but seems like that >> + is not accessible to libavdevice outputs */ >> +if ((st->codecpar->width == 1280 &&

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

2017-12-29 22:00 GMT+01:00 Devin Heitmueller : > I’m not discounting your concerns - just there isn’t much I can do about > them but continue to try to improve the quality of the code until it’s > reliable enough for wider adoption. :-) Thank you for the comments! Carl Eugen ___

Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

> On Dec 29, 2017, at 3:59 PM, Carl Eugen Hoyos wrote: > > 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > >> +uint8_t *outbuf = NULL; > >> +if (st->codecpar->codec_id == AV_CODEC_ID_AC3) >> +av_free(outbuf); > > The "if()" should not be necessary, free() and av_free() > may

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2017-12-29 22:02 GMT+01:00 Devin Heitmueller : > >> On Dec 29, 2017, at 3:48 PM, Carl Eugen Hoyos wrote: >> >> 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : >> >>> +/* FIXME: Should really rely on the coded_width but seems like that >>> + is not accessible to libavdevice outputs

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

Hi Carl, > On Dec 29, 2017, at 3:55 PM, Carl Eugen Hoyos wrote: > > 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > >> +for (int i = 0; i < ctx->max_audio_channels / 2; i++) { >> +st = avformat_new_stream(avctx, NULL); >> +if (!st) { >> +av_log(a

Re: [FFmpeg-devel] h264: fix RTSP stream decoding

2017-12-29 18:43 GMT+01:00 ser...@gavrushkin.com : > From e90ef7b56d4147ff6555468f0154321b55596846 Mon Sep 17 00:00:00 2001 > From: Sergey Gavrushkin > Date: Fri, 29 Dec 2017 20:03:50 +0300 > Subject: [PATCH] h264: fix RTSP stream decoding > > It is a regression fix for an issue that was introduc

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

2017-12-29 22:14 GMT+01:00 Devin Heitmueller : > Hi Carl, > >> On Dec 29, 2017, at 3:55 PM, Carl Eugen Hoyos wrote: >> >> 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : >> >>> +for (int i = 0; i < ctx->max_audio_channels / 2; i++) { >>> +st = avformat_new_stream(avctx, NULL); >

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

2017-12-29 18:38 GMT+01:00 Nicolas George : > I am sorry, I do not understand what you are saying at all. > > Maybe it would help if you were to give a fully detailed of the simplest > use case you are trying to fix Maybe ticket #6908? Carl Eugen ___ f

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

> On Dec 29, 2017, at 4:09 PM, Carl Eugen Hoyos wrote: > > 2017-12-29 22:02 GMT+01:00 Devin Heitmueller : >> >>> On Dec 29, 2017, at 3:48 PM, Carl Eugen Hoyos wrote: >>> >>> 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : >>> +/* FIXME: Should really rely on the coded_width but s

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

> On Dec 29, 2017, at 4:17 PM, Carl Eugen Hoyos wrote: > > 2017-12-29 22:14 GMT+01:00 Devin Heitmueller : >> Hi Carl, >> >>> On Dec 29, 2017, at 3:55 PM, Carl Eugen Hoyos wrote: >>> >>> 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : >>> +for (int i = 0; i < ctx->max_audio_channe

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not blindly allocate stts entries

On 12/29/2017 8:42 PM, Carl Eugen Hoyos wrote: > Sorry, I don't understand this sentence - could you try with > other words? Because the buffer is now grown exponentially (by a factor of 2 every time it is resizes), it's possible that it ends up with almost double the size of 'entries' after resiz

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not blindly allocate stts entries

On 12/29/2017 9:32 PM, Derek Buitenhuis wrote: > Because the buffer is now grown exponentially (by a factor of 2 every > time it is resizes), it's possible that it ends up with almost double > the size of 'entries' after resizes. > > For example, consider a valid MP4 file with (1024 * 1024 + 1) en

Re: [FFmpeg-devel] h264: fix RTSP stream decoding

> Please add "Fixes ticket #6422" to the commit message. > > And maybe remove "rtsp" from the commit title, the issue > is reproducible with files. Done. Please feel free to edit commit title/message as you wish for merge. Thank you, Sergey - From e90ef7

[FFmpeg-devel] [PATCH 1/2] avformat/avio: add new_http_request callback

From: Aman Gupta This callback is implemented on AVIOContext which are backed by an HTTP URLContext. This allows the owner of the IO context to both discover that it is capable of making additional http requests, and to make such requests without including http.h. In particular this avoids the us

[FFmpeg-devel] [PATCH 2/2] avformat/hls: use AVIOContext new_http_request callback

From: Aman Gupta This fixes a segfault when streaming from an HLS playlist which uses crypto, by ensuring ff_http_do_new_request will never be invoked on a non-http URLContext. Additionally it simplifies the demuxer by removing http.h and all the http specific code in open_url_keepalive. Signed

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not blindly allocate stts entries

2017-12-29 22:32 GMT+01:00 Derek Buitenhuis : > Completely Unrelated: Multiple types of atoms are similar to the stts atom, > in that they contain a coded number of entries we allocate - maybe we should > consistently apply this sort of allocation strategy to them, too (out of > scope of this patc

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not blindly allocate stts entries

2017-11-28 21:32 GMT+01:00 Michael Niedermayer : > On Mon, Nov 27, 2017 at 05:24:14AM +0100, Carl Eugen Hoyos wrote: >> for (i = 0; i < entries && !pb->eof_reached; i++) { >> -int sample_duration; >> +int sample_duration, ret; >> unsigned int sample_count; >> +

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: use AVIOContext new_http_request callback

Aman Gupta (2017-12-29): > From: Aman Gupta > > This fixes a segfault when streaming from an HLS playlist which uses > crypto, by ensuring ff_http_do_new_request will never be invoked on a > non-http URLContext. > > Additionally it simplifies the demuxer by removing http.h and all the > http spe

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: use AVIOContext new_http_request callback

On Fri, Dec 29, 2017 at 2:45 PM, Nicolas George wrote: > Aman Gupta (2017-12-29): > > From: Aman Gupta > > > > This fixes a segfault when streaming from an HLS playlist which uses > > crypto, by ensuring ff_http_do_new_request will never be invoked on a > > non-http URLContext. > > > > Additiona

[FFmpeg-devel] [PATCH 1/2] avformat/http: return EINVAL if ff_http_do_new_request is called with non-http URLContext

From: Aman Gupta Signed-off-by: Aman Gupta --- libavformat/http.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index a376f1a488..8f7e56de54 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -311,6 +311,11 @@ int ff_http_do_new_reques

[FFmpeg-devel] [PATCH 2/2] avformat/hls: ignore http_persistent for segments requring crypto

From: Aman Gupta Encrypted HLS segments have regular http:// urls, but open_input() actually prefixes them with crypto+ before calling open_url(), so they end up using the crypto protocol and not the http protocol. This means invoking ff_http_do_new_request will fail, so we avoid calling it in t

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

On 12/29/2017 1:20 PM, Devin Heitmueller wrote: On Dec 29, 2017, at 4:09 PM, Carl Eugen Hoyos wrote: 2017-12-29 22:02 GMT+01:00 Devin Heitmueller : On Dec 29, 2017, at 3:48 PM, Carl Eugen Hoyos wrote: 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : +/* FIXME: Should really rely

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

On 12/29/2017 10:12 AM, Devin Heitmueller wrote: Hook in libklvanc and use it for output of EIA-708 captions over SDI. The bulk of this patch is just general support for ancillary data for the Decklink SDI module - the real work for construction of the EIA-708 CDP and VANC line construction is d

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

On 12/29/2017 10:12 AM, Devin Heitmueller wrote: Add support for the ability to capture all audio pairs available to the capture hardware. Each pair is exposed as a different audio stream, which matches up with the most common use cases for the broadcast space (i.e. where there is one stereo pai

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

On Sat, Dec 30, 2017 at 5:19 AM, Carl Eugen Hoyos wrote: > 2017-12-29 18:38 GMT+01:00 Nicolas George : > > > I am sorry, I do not understand what you are saying at all. > > > > Maybe it would help if you were to give a fully detailed of the simplest > > use case you are trying to fix > > Maybe ti

Re: [FFmpeg-devel] [PATCH 5/8] Support encoding of Active Format Description (AFD) in libx264

On 12/29/2017 10:12 AM, Devin Heitmueller wrote: If AFD side data is present, include it in an H.264 SEI payload when encoding with libx264. This is done in the same manner that we currently handle A53 closed captions (where the business logic for constructing the SEI is in libavcodec/utils.c),

Re: [FFmpeg-devel] [PATCH 6/8] Add suppoort for using libklvanc from within decklink capture module

Patch title: "suppoort" -> "support", also "decklink" -> "DeckLink" On 12/29/2017 10:12 AM, Devin Heitmueller wrote: Make use of libklvanc from within the decklink capture module, initially for EIA-708 and AFD. Support for other VANC types will come in subsequent patches. Incorporates feedbac