Re: [FFmpeg-devel] On in-tree external headers

2017-11-01 Thread Nicolas George
Le primidi 11 brumaire, an CCXXVI, Carl Eugen Hoyos a écrit : > License-wise, it of course makes not difference if linking > is done at compile-time, at startup or at run-time. Yes it does. License-wise, what makes a difference is whether you distribute code for which you do not own the copyright

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc uni weighted hv mc msa functions

2017-11-01 Thread Manojkumar Bhosale
LGTM -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of kaustubh.ra...@imgtec.com Sent: Tuesday, October 31, 2017 6:31 PM To: ffmpeg-devel@ffmpeg.org Cc: Kaustubh Raste Subject: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc uni weighted hv mc

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Paul B Mahol
On 10/31/17, Michael Niedermayer wrote: > On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch makes sure the loas muxer does not try to write >> anything but aac and latm. >> >> Please comment, Carl Eugen > >> latmenc.c |4 >> 1 file changed, 4 i

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Hendrik Leppkes
On Wed, Nov 1, 2017 at 10:44 AM, Paul B Mahol wrote: > On 10/31/17, Michael Niedermayer wrote: >> On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch makes sure the loas muxer does not try to write >>> anything but aac and latm. >>> >>> Please comment,

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Paul B Mahol
On 11/1/17, Hendrik Leppkes wrote: > On Wed, Nov 1, 2017 at 10:44 AM, Paul B Mahol wrote: >> On 10/31/17, Michael Niedermayer wrote: >>> On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos wrote: Hi! Attached patch makes sure the loas muxer does not try to write anythi

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve avc avg mc 02, 12 and 32 msa functions

2017-11-01 Thread Manojkumar Bhosale
LGTM -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of kaustubh.ra...@imgtec.com Sent: Wednesday, November 1, 2017 11:36 AM To: ffmpeg-devel@ffmpeg.org Cc: Kaustubh Raste Subject: [FFmpeg-devel] [PATCH] avcodec/mips: Improve avc avg mc 02, 12 and

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Hendrik Leppkes
On Wed, Nov 1, 2017 at 11:09 AM, Paul B Mahol wrote: > On 11/1/17, Hendrik Leppkes wrote: >> On Wed, Nov 1, 2017 at 10:44 AM, Paul B Mahol wrote: >>> On 10/31/17, Michael Niedermayer wrote: On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached pat

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Paul B Mahol
On 11/1/17, Hendrik Leppkes wrote: > On Wed, Nov 1, 2017 at 11:09 AM, Paul B Mahol wrote: >> On 11/1/17, Hendrik Leppkes wrote: >>> On Wed, Nov 1, 2017 at 10:44 AM, Paul B Mahol wrote: On 10/31/17, Michael Niedermayer wrote: > On Mon, Oct 30, 2017 at 11:51:30PM +0100, Carl Eugen Hoyos

[FFmpeg-devel] [PATCH 1/3] avutil/softfloat: Add FLOAT_MIN

2017-11-01 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/softfloat.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/softfloat.h b/libavutil/softfloat.h index b13d728f30..a651406f74 100644 --- a/libavutil/softfloat.h +++ b/libavutil/softfloat.h @@ -43,6 +43,7 @@ static const SoftFloat FLOAT

[FFmpeg-devel] [PATCH 3/3] avcodec/sbrdsp_fixed: Fix integer overflow in shift in sbr_hf_g_filt_c()

2017-11-01 Thread Michael Niedermayer
Fixes: runtime error: shift exponent 66 is too large for 64-bit type 'long long' Fixes: 3642/clusterfuzz-testcase-minimized-5443853801750528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/sbrd

[FFmpeg-devel] [PATCH 2/3] avcodec/aacsbr_fixed: Fix division by zero in sbr_gain_calc()

2017-11-01 Thread Michael Niedermayer
Fixes: 3642/clusterfuzz-testcase-minimized-5443853801750528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aacsbr_fixed.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/aacsbr_

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 13:32 GMT+01:00 Paul B Mahol : > On 11/1/17, Hendrik Leppkes wrote: >> On Wed, Nov 1, 2017 at 11:09 AM, Paul B Mahol wrote: >>> On 11/1/17, Hendrik Leppkes wrote: On Wed, Nov 1, 2017 at 10:44 AM, Paul B Mahol wrote: > On 10/31/17, Michael Niedermayer wrote: >> On Mon, O

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Paul B Mahol
On 11/1/17, Carl Eugen Hoyos wrote: > 2017-11-01 13:32 GMT+01:00 Paul B Mahol : >> On 11/1/17, Hendrik Leppkes wrote: >>> On Wed, Nov 1, 2017 at 11:09 AM, Paul B Mahol wrote: On 11/1/17, Hendrik Leppkes wrote: > On Wed, Nov 1, 2017 at 10:44 AM, Paul B Mahol wrote: >> On 10/31/17,

[FFmpeg-devel] [PATCH] avformat: add TiVo ty demuxer

2017-11-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/ty.c | 775 +++ 3 files changed, 777 insertions(+) create mode 100644 libavformat/ty.c diff --git a/libavformat/Makefile b/libavfor

Re: [FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-11-01 Thread Derek Buitenhuis
On 11/1/2017 1:36 AM, Michael Niedermayer wrote: > The idea would be that there would only be one uint8_t buffer and the > 2000 entries from te pool would point into that. > So as a larger NAL shifts through the 2000 the pointers would get > distributed differently but the size would not grow > Any

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 14:39 GMT+01:00 Paul B Mahol : > On 11/1/17, Carl Eugen Hoyos wrote: >> 2017-11-01 13:32 GMT+01:00 Paul B Mahol : >>> On 11/1/17, Hendrik Leppkes wrote: On Wed, Nov 1, 2017 at 11:09 AM, Paul B Mahol wrote: > On 11/1/17, Hendrik Leppkes wrote: >> On Wed, Nov 1, 2017 at 10

[FFmpeg-devel] [PATCH]lavc/alac: Avoid allocating huge memory blocks for malicious alac input.

2017-11-01 Thread Carl Eugen Hoyos
Hi! It appears to me that the alac decoder can be used for DoS, the attached patch limits the maximum frame size to eight times the default value. (Higher values brake our encoder here.) Please comment and / or suggest another value, Carl Eugen From c2181c7ee83fcf93ba817cf6f9c3c9e1043a233c Mon Se

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread James Almer
On 11/1/2017 11:23 AM, Carl Eugen Hoyos wrote: > 2017-11-01 14:39 GMT+01:00 Paul B Mahol : >> On 11/1/17, Carl Eugen Hoyos wrote: >>> 2017-11-01 13:32 GMT+01:00 Paul B Mahol : On 11/1/17, Hendrik Leppkes wrote: > On Wed, Nov 1, 2017 at 11:09 AM, Paul B Mahol wrote: >> On 11/1/17, He

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 15:26 GMT+01:00 James Almer : > On 11/1/2017 11:23 AM, Carl Eugen Hoyos wrote: >> 2017-11-01 14:39 GMT+01:00 Paul B Mahol : >>> On 11/1/17, Carl Eugen Hoyos wrote: 2017-11-01 13:32 GMT+01:00 Paul B Mahol : > On 11/1/17, Hendrik Leppkes wrote: >> On Wed, Nov 1, 2017 at 11:0

Re: [FFmpeg-devel] [PATCH]lavc/alac: Avoid allocating huge memory blocks for malicious alac input.

2017-11-01 Thread Paul B Mahol
On 11/1/17, Carl Eugen Hoyos wrote: > Hi! > > It appears to me that the alac decoder can be used for DoS, the attached > patch > limits the maximum frame size to eight times the default value. > (Higher values brake our encoder here.) > > Please comment and / or suggest another value, Carl Eugen >

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread James Almer
On 11/1/2017 11:33 AM, Carl Eugen Hoyos wrote: > 2017-11-01 15:26 GMT+01:00 James Almer : >> On 11/1/2017 11:23 AM, Carl Eugen Hoyos wrote: >>> 2017-11-01 14:39 GMT+01:00 Paul B Mahol : On 11/1/17, Carl Eugen Hoyos wrote: > 2017-11-01 13:32 GMT+01:00 Paul B Mahol : >> On 11/1/17, Hend

Re: [FFmpeg-devel] [PATCH]lavc/alac: Avoid allocating huge memory blocks for malicious alac input.

2017-11-01 Thread Derek Buitenhuis
On 11/1/2017 2:25 PM, Carl Eugen Hoyos wrote: > It appears to me that the alac decoder can be used for DoS, the attached patch > limits the maximum frame size to eight times the default value. > (Higher values brake our encoder here.) Since the official ALAC encoder/decoder are open ource nowadays

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Paul B Mahol
On 11/1/17, Carl Eugen Hoyos wrote: > 2017-11-01 15:26 GMT+01:00 James Almer : >> On 11/1/2017 11:23 AM, Carl Eugen Hoyos wrote: >>> 2017-11-01 14:39 GMT+01:00 Paul B Mahol : On 11/1/17, Carl Eugen Hoyos wrote: > 2017-11-01 13:32 GMT+01:00 Paul B Mahol : >> On 11/1/17, Hendrik Leppke

Re: [FFmpeg-devel] [PATCH]lavc/alac: Avoid allocating huge memory blocks for malicious alac input.

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 15:40 GMT+01:00 Paul B Mahol : > On 11/1/17, Carl Eugen Hoyos wrote: >> Hi! >> >> It appears to me that the alac decoder can be used for DoS, >> the attached patch limits the maximum frame size to eight >> times the default value. >> (Higher values brake our encoder here.) >> >> Please

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 15:42 GMT+01:00 Paul B Mahol : > On 11/1/17, Carl Eugen Hoyos wrote: > Not creating broken webp files, see difference. How do you know that als-in-loas in invalid? >> Iirc, the practice used to be to first implement encoders / muxers, >> then decoders / demuxers... > > No, it is othe

Re: [FFmpeg-devel] [PATCH] avformat/mux: be less strict with bitstream filter failures

2017-11-01 Thread James Almer
On 10/31/2017 9:50 PM, Carl Eugen Hoyos wrote: > 2017-10-31 19:00 GMT+01:00 James Almer : >> This makes the autobsf feature behave the same as the manual >> bitstream filtering in ffmpeg.c >> >> Fixes ticket #6794 >> >> Signed-off-by: James Almer >> --- >> libavformat/mux.c | 4 +++- >> 1 file ch

Re: [FFmpeg-devel] Support for h264/SVC over RTP and SVC base layer decoding in h264

2017-11-01 Thread Breeden, Joshua
> Your patches contain a lot of trailing whitespace (afaict...) > that cannot be committed to our repository, please remove it. Thanks for pointing this out. I've attached new patches to fix this problem. patcheck complains about my non-doxy comments, and about possible unused variables. Variabl

Re: [FFmpeg-devel] Support for h264/SVC over RTP and SVC base layer decoding in h264

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 16:18 GMT+01:00 Breeden, Joshua : >> Your patches contain a lot of trailing whitespace (afaict...) >> that cannot be committed to our repository, please remove it. > > Thanks for pointing this out. I've attached new patches to fix this problem. > patcheck complains about my non-doxy com

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Paul B Mahol
On 11/1/17, Carl Eugen Hoyos wrote: > 2017-11-01 15:42 GMT+01:00 Paul B Mahol : >> On 11/1/17, Carl Eugen Hoyos wrote: > >> Not creating broken webp files, see difference. > > How do you know that als-in-loas in invalid? Because you do not claim it is valid. > >>> Iirc, the practice used to be

Re: [FFmpeg-devel] [PATCH]lavc/alac: Avoid allocating huge memory blocks for malicious alac input.

2017-11-01 Thread Paul B Mahol
On 11/1/17, Carl Eugen Hoyos wrote: > 2017-11-01 15:40 GMT+01:00 Paul B Mahol : >> On 11/1/17, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> It appears to me that the alac decoder can be used for DoS, >>> the attached patch limits the maximum frame size to eight >>> times the default value. >>> (Higher

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 16:59 GMT+01:00 Paul B Mahol : > On 11/1/17, Carl Eugen Hoyos wrote: >> 2017-11-01 15:42 GMT+01:00 Paul B Mahol : >>> On 11/1/17, Carl Eugen Hoyos wrote: >> >>> Not creating broken webp files, see difference. >> >> How do you know that als-in-loas in invalid? > > Because you do not cla

Re: [FFmpeg-devel] [PATCH]lavc/alac: Avoid allocating huge memory blocks for malicious alac input.

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 17:01 GMT+01:00 Paul B Mahol : > On 11/1/17, Carl Eugen Hoyos wrote: >> 2017-11-01 15:40 GMT+01:00 Paul B Mahol : >>> On 11/1/17, Carl Eugen Hoyos wrote: Hi! It appears to me that the alac decoder can be used for DoS, the attached patch limits the maximum frame size

[FFmpeg-devel] [PATCH]lavc/pcm-dvd: Do not use an incompatible pointer on big-endian.

2017-11-01 Thread Carl Eugen Hoyos
Hi! Attached patch silences a gcc warning, tested with Fever.vob Please comment, Carl Eugen From 3bd16ab2446bd2450bdbf4d333846a9c7ae45c6c Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 1 Nov 2017 17:10:12 +0100 Subject: [PATCH] lavc/pcm-dvd: Do not use an incompatible pointer on big

[FFmpeg-devel] [PATCH]lavc/pcm-bluray: Do not use incompatible pointers on big-endian.

2017-11-01 Thread Carl Eugen Hoyos
Hi! Attached patch silences two gcc warnings, no sample for odd channel count found. Please comment, Carl Eugen From 991b0d62b7ac005765dfe83ef6ffa63a2b7b6fae Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 1 Nov 2017 17:14:04 +0100 Subject: [PATCH] lavc/pcm-bluray: Do not use incompat

Re: [FFmpeg-devel] [PATCH] avformat/movenc: let avpriv_ac3_parse_header() allocate the AC3HeaderInfo struct

2017-11-01 Thread James Almer
On 10/31/2017 8:58 PM, Michael Niedermayer wrote: > On Tue, Oct 31, 2017 at 01:24:58AM -0300, James Almer wrote: >> This removes sizeof(AC3HeaderInfo) from the ABI. >> >> Signed-off-by: James Almer >> --- >> libavformat/movenc.c | 72 >> +++- >> 1

Re: [FFmpeg-devel] [PATCH]lavc/pcm-bluray: Do not use incompatible pointers on big-endian.

2017-11-01 Thread Hendrik Leppkes
On Wed, Nov 1, 2017 at 5:16 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch silences two gcc warnings, no sample for odd channel count > found. > > #if HAVE_BIGENDIAN > -bytestream2_get_buffer(&gb, dst16, avctx->channels * 2); > -dst16 += avctx->chann

Re: [FFmpeg-devel] [PATCH]lavc/pcm-dvd: Do not use an incompatible pointer on big-endian.

2017-11-01 Thread Hendrik Leppkes
On Wed, Nov 1, 2017 at 5:13 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch silences a gcc warning, tested with Fever.vob > > > @@ -163,10 +162,12 @@ static void *pcm_dvd_decode_samples(AVCodecContext > *avctx, const uint8_t *src, > switch (avctx->bits_per_coded_sample) { > case 16:

Re: [FFmpeg-devel] [PATCH]lavc/pcm-bluray: Do not use incompatible pointers on big-endian.

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 18:16 GMT+01:00 Hendrik Leppkes : > On Wed, Nov 1, 2017 at 5:16 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch silences two gcc warnings, no sample for odd channel count >> found. >> >> #if HAVE_BIGENDIAN >> -bytestream2_get_buffer(&gb, dst16, avctx->chann

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-01 Thread Teresa Johnson
On Tue, Oct 31, 2017 at 5:42 PM, Michael Niedermayer wrote: > Hi > > On Tue, Oct 31, 2017 at 04:29:18PM +, Teresa Johnson wrote: > > It's needed for the same reason the used attribute was already added to > the > > "static const" variables. For those, when building with just -O2, they > > cou

Re: [FFmpeg-devel] [PATCH]lavc/pcm-bluray: Do not use incompatible pointers on big-endian.

2017-11-01 Thread Hendrik Leppkes
On Wed, Nov 1, 2017 at 6:25 PM, Carl Eugen Hoyos wrote: > 2017-11-01 18:16 GMT+01:00 Hendrik Leppkes : >> On Wed, Nov 1, 2017 at 5:16 PM, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch silences two gcc warnings, no sample for odd channel count >>> found. >>> >>> #if HAVE_BIGENDIAN >>> -

Re: [FFmpeg-devel] [PATCH]lavc/pcm-dvd: Do not use an incompatible pointer on big-endian.

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 18:18 GMT+01:00 Hendrik Leppkes : > On Wed, Nov 1, 2017 at 5:13 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch silences a gcc warning, tested with Fever.vob >> >> >> @@ -163,10 +162,12 @@ static void *pcm_dvd_decode_samples(AVCodecContext >> *avctx, const uint8_t *src, >>

Re: [FFmpeg-devel] Support for h264/SVC over RTP and SVC base layer decoding in h264

2017-11-01 Thread Breeden, Joshua
> No but I wonder if the variables "y" and "t" can have more useful names > (that may or may not make the comment unneeded), I've made the variable names more self-explanatory and condensed the comments > Please do not remove the empty line. And fixed this as well. Thanks, Joshua BreedenFrom 6

Re: [FFmpeg-devel] [PATCH]lavc/pcm-bluray: Do not use incompatible pointers on big-endian.

2017-11-01 Thread Carl Eugen Hoyos
2017-11-01 18:31 GMT+01:00 Hendrik Leppkes : > On Wed, Nov 1, 2017 at 6:25 PM, Carl Eugen Hoyos wrote: >> 2017-11-01 18:16 GMT+01:00 Hendrik Leppkes : >>> On Wed, Nov 1, 2017 at 5:16 PM, Carl Eugen Hoyos wrote: Hi! Attached patch silences two gcc warnings, no sample for odd channel

Re: [FFmpeg-devel] [PATCH]lavf/latmenc: Error out for invalid codecs

2017-11-01 Thread Nicolas George
Le primidi 11 brumaire, an CCXXVI, James Almer a écrit : > I guess he's saying If you have to guess, then he is not saying it, he is hinting at it with half sentences containing only the draft of an argument. I wish he would start making full sentences with full arguments. Regards, -- Nicolas

Re: [FFmpeg-devel] [PATCH] avcodec/dca: return standard error codes in avpriv_dca_parse_core_frame_header()

2017-11-01 Thread foo86
On Tue, Oct 31, 2017 at 05:27:35PM -0300, James Almer wrote: > This prevents making the DCAParseError enum part of the ABI. > > Signed-off-by: James Almer > --- > Now actually paying attention to -Wempty-body warnings. > > libavcodec/dca.c | 11 --- > libavcodec/dca.h | 12 ++--

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fix base_output_dirname is null when basename_size is 0 bug

2017-11-01 Thread Marton Balint
On Sun, 29 Oct 2017, Liu Steven wrote: 在 2017年10月26日,上午7:54,Steven Liu 写道: fix ticket id: #6777 when use argument hls_segment_filename, the basename_size will be 0 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) di

[FFmpeg-devel] [PATCH] avcodec/gdv: Check compression before allocating frame

2017-11-01 Thread Michael Niedermayer
Fixes: 2926/clusterfuzz-testcase-4987110014582784 This reduces decoding time from 7 to 4 seconds The timeout should have been fixed in 0561bd2fc2bff0dbe651d5998e9f129c43d25eb3 but ossfuzz did not close this issue Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/mast

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/xan: Improve overlapping check

2017-11-01 Thread Michael Niedermayer
On Mon, Oct 30, 2017 at 11:21:40PM +0100, Michael Niedermayer wrote: > Fixes: memcpy-param-overlap > Fixes: 3612/clusterfuzz-testcase-minimized-6393461273001984 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niede

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fix base_output_dirname is null when basename_size is 0 bug

2017-11-01 Thread Marton Balint
On Wed, 1 Nov 2017, Marton Balint wrote: On Sun, 29 Oct 2017, Liu Steven wrote: 在 2017年10月26日,上午7:54,Steven Liu 写道: fix ticket id: #6777 when use argument hls_segment_filename, the basename_size will be 0 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 16 +++- 1 file c

[FFmpeg-devel] [PATCH] web/template_head2: Remove net neutrality script

2017-11-01 Thread Lou Logan
The popup is annoying and distracting. This reverts 0078c64257cd3d0a93403185acdcab33fa3d90b1. Signed-off-by: Lou Logan --- src/template_head2 | 1 - 1 file changed, 1 deletion(-) diff --git a/src/template_head2 b/src/template_head2 index d7bb7bd..a0b11ab 100644 --- a/src/template_head2 +++ b/s

[FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

2017-11-01 Thread Nicolas George
For now, check the image size. Inspired by a patch from Paul B Mahol. Invalid sizes would be detected later by allocation failures, detecting problems earlier is cleaner. Signed-off-by: Nicolas George --- libavfilter/avfiltergraph.c | 24 1 file changed, 24 insertions(+

[FFmpeg-devel] [PATCH 2/2] lavfi/framepool: use av_image_check_size2().

2017-11-01 Thread Nicolas George
Allow filter to handle larger frames. Signed-off-by: Nicolas George --- libavfilter/framepool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c index 42c0e58498..da2ac5cf69 100644 --- a/libavfilter/framepool.c +++ b/libavfilte

[FFmpeg-devel] [PATCH]tests/fate: Fix fitsdec-gbrap16 on big-endian hardware

2017-11-01 Thread Carl Eugen Hoyos
Hi! Attached patch fixes fate-fitsdec on big-endian. Please comment, Carl Eugen From 61032df04a35d7cc939fa41e71ee3f882c3658c3 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 1 Nov 2017 21:39:33 +0100 Subject: [PATCH] tests/fate: Fix fitsdec-gbrap16 test on big-endian hardware. --- t

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

2017-11-01 Thread Sasi Inguva
Forgot to attach the FATE ref file. sending the patch again. On Wed, Nov 1, 2017 at 2:23 PM, Sasi Inguva wrote: > Partially fixes t/6699. > --- > libavformat/mov.c | 32 +--- > tests/fate/mov.mak | 4 > 2 files changed, 25 insertions(+), 11 deletions(-) > > di

[FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

2017-11-01 Thread Sasi Inguva
Partially fixes t/6699. --- libavformat/mov.c | 32 --- tests/fate/mov.mak| 4 tests/ref/fate/mov-elst-ends-betn-b-and-i | 31 ++ 3 files changed, 56 insertions(+), 11 deletions(-) create

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

2017-11-01 Thread Sasi Inguva
Pls find attached, the FATE sample. On Wed, Nov 1, 2017 at 2:26 PM, Sasi Inguva wrote: > Partially fixes t/6699. > --- > libavformat/mov.c | 32 > --- > tests/fate/mov.mak| 4 > tests/ref/fate/mov-elst-ends-betn-

Re: [FFmpeg-devel] [PATCH] avcodec/dca: return standard error codes in avpriv_dca_parse_core_frame_header()

2017-11-01 Thread James Almer
On 11/1/2017 3:24 PM, foo86 wrote: > On Tue, Oct 31, 2017 at 05:27:35PM -0300, James Almer wrote: >> This prevents making the DCAParseError enum part of the ABI. >> >> Signed-off-by: James Almer >> --- >> Now actually paying attention to -Wempty-body warnings. >> >> libavcodec/dca.c | 11

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

2017-11-01 Thread Paul B Mahol
On 11/1/17, Nicolas George wrote: > For now, check the image size. > Inspired by a patch from Paul B Mahol. > > Invalid sizes would be detected later by allocation failures, > detecting problems earlier is cleaner. > > Signed-off-by: Nicolas George > --- > libavfilter/avfiltergraph.c | 24 ++

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/framepool: use av_image_check_size2().

2017-11-01 Thread Paul B Mahol
On 11/1/17, Nicolas George wrote: > Allow filter to handle larger frames. > > Signed-off-by: Nicolas George > --- > libavfilter/framepool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpe

Re: [FFmpeg-devel] [PATCH] avcodec/gdv: Check compression before allocating frame

2017-11-01 Thread Paul B Mahol
On 11/1/17, Michael Niedermayer wrote: > Fixes: 2926/clusterfuzz-testcase-4987110014582784 > > This reduces decoding time from 7 to 4 seconds > > The timeout should have been fixed in > 0561bd2fc2bff0dbe651d5998e9f129c43d25eb3 but ossfuzz did not close this > issue > > Found-by: continuous fuzzing

[FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

2017-11-01 Thread Sasi Inguva
Partially fixes t/6699. --- libavformat/mov.c | 32 +--- tests/fate/mov.mak | 4 2 files changed, 25 insertions(+), 11 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 60f0228e2d..e716e5ba9e 100644 --- a/libavformat/mov.c +++ b/libavformat/m

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

2017-11-01 Thread Clément Bœsch
On Wed, Nov 01, 2017 at 09:39:52PM +0100, Nicolas George wrote: > For now, check the image size. > Inspired by a patch from Paul B Mahol. > > Invalid sizes would be detected later by allocation failures, > detecting problems earlier is cleaner. > > Signed-off-by: Nicolas George > --- > libavfil

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

2017-11-01 Thread Nicolas George
Le primidi 11 brumaire, an CCXXVI, Clement Boesch a écrit : > nb_filters and nb_outputs are signed so the counters better be the same > type. I re-checked, I think you are mistaken. > I think we already had that discussion but I'd rather have the counters > signed so the compiler can exploit the

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

2017-11-01 Thread Clément Bœsch
On Wed, Nov 01, 2017 at 11:01:22PM +0100, Nicolas George wrote: > Le primidi 11 brumaire, an CCXXVI, Clement Boesch a écrit : > > nb_filters and nb_outputs are signed so the counters better be the same > > type. > > I re-checked, I think you are mistaken. > My bad, you're right, I was looking at

Re: [FFmpeg-devel] [PATCH] lavf/img2enc: remove redundant option 'updatefirst'

2017-11-01 Thread Lou Logan
On Sun, 29 Oct 2017 13:30:40 +0530 Gyan Doshi wrote: > From e845a4cc2d885db6bc27e3f69fbd7940b6131f52 Mon Sep 17 00:00:00 2001 > From: Gyan Doshi > Date: Sun, 29 Oct 2017 13:23:18 +0530 > Subject: [PATCH] lavf/img2enc: remove redundant option 'updatefirst' > > 'updatefirst' is an undocumented op

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve avc avg mc 02, 12 and 32 msa functions

2017-11-01 Thread Michael Niedermayer
On Wed, Nov 01, 2017 at 11:51:32AM +, Manojkumar Bhosale wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When you are offended at any man's fault, turn to yourself and study your own failings. Then you will forget your anger. --

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc uni weighted hv mc msa functions

2017-11-01 Thread Michael Niedermayer
On Wed, Nov 01, 2017 at 09:27:22AM +, Manojkumar Bhosale wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you think the mosad wants you dead since a long time then you are either wrong or dead since a long time. signature.as

Re: [FFmpeg-devel] [PATCH] avcodec/gdv: Check compression before allocating frame

2017-11-01 Thread Michael Niedermayer
On Wed, Nov 01, 2017 at 10:44:10PM +0100, Paul B Mahol wrote: > On 11/1/17, Michael Niedermayer wrote: > > Fixes: 2926/clusterfuzz-testcase-4987110014582784 > > > > This reduces decoding time from 7 to 4 seconds > > > > The timeout should have been fixed in > > 0561bd2fc2bff0dbe651d5998e9f129c43d2

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-01 Thread Michael Niedermayer
Hi On Wed, Nov 01, 2017 at 07:25:08AM -0700, Teresa Johnson wrote: > On Tue, Oct 31, 2017 at 5:42 PM, Michael Niedermayer > wrote: > > > Hi > > > > On Tue, Oct 31, 2017 at 04:29:18PM +, Teresa Johnson wrote: > > > It's needed for the same reason the used attribute was already added to > > th

Re: [FFmpeg-devel] [PATCH] web/template_head2: Remove net neutrality script

2017-11-01 Thread Michael Niedermayer
On Wed, Nov 01, 2017 at 12:33:34PM -0800, Lou Logan wrote: > The popup is annoying and distracting. The loss of net neutrality may also be annoying and distracting, and may be harder to fix than with a patch. The script should not show up again after being cicked away, seems it has a expiration a

[FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: reindent hlsenc code

2017-11-01 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 6d573db094..5ea9d216a4 100644 --- a/libavformat/hlsenc.c +++ b/libavforma

[FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: check hls segment mode for ignore the init filename

2017-11-01 Thread Steven Liu
ignore the fmp4_init_filename when in normal hls segment mode Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 0ea93480a5..6d573db094 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlse

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

2017-11-01 Thread Michael Niedermayer
On Wed, Nov 01, 2017 at 02:26:45PM -0700, Sasi Inguva wrote: > Partially fixes t/6699. > --- > libavformat/mov.c | 32 > --- > tests/fate/mov.mak| 4 > tests/ref/fate/mov-elst-ends-betn-b-and-i | 31

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fix base_output_dirname is null when basename_size is 0 bug

2017-11-01 Thread Liu Steven
> 在 2017年11月2日,上午3:18,Marton Balint 写道: > > > On Wed, 1 Nov 2017, Marton Balint wrote: > >> >> On Sun, 29 Oct 2017, Liu Steven wrote: >> >>> 在 2017年10月26日,上午7:54,Steven Liu 写道: fix ticket id: #6777 when use argument hls_segment_filename, the basename_size will be 0 Sign

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

2017-11-01 Thread Sasi Inguva
This patch is not an alternative. Both patches are required to fix t/6699 . Once one of the patches is submitted, i will update the fate tests in the other patch. On Wed, Nov 1, 2017 at 5:11 PM, Michael Niedermayer wrote: > On Wed, Nov 01, 2017 at 02:26:45PM -0700, Sasi Inguva wrote: > > Partial

[FFmpeg-devel] [PATCH] example/vaapi_transcode: Add a VA-VAPI transcode example.

2017-11-01 Thread Jun Zhao
From eb747cb25f86b4f3db5549ac5b0699927ee7c559 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Wed, 1 Nov 2017 14:46:14 +0800 Subject: [PATCH] example/vaapi_transcode: Add a VA-VAPI transcode example. Signed-off-by: Jun Zhao Signed-off-by: Liu, Kaixuan --- configure | 2 +

Re: [FFmpeg-devel] [PATCH] avformat: add TiVo ty demuxer

2017-11-01 Thread Michael Niedermayer
On Wed, Nov 01, 2017 at 02:40:27PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/ty.c | 775 > +++ > 3 files changed, 777 insertions(+) > cr

[FFmpeg-devel] [PATCH] lavfi/drawtext: change minimum value for timecode_rate

2017-11-01 Thread Gyan Doshi
Prompted by an issue reported at StackExchange, patch changes minimum value for timecode_rate to 1. The user-supplied value for timecode_rate is rounded to nearest integer. So, a supplied value of 0.49 or lower is rounded to 0. This throws a misleading error message that says "Timecode frame rat