[FFmpeg-devel] [PATCH] ffmpeg_opt: deprecate the hwaccel_lax_profile_check option

2017-10-13 Thread Jun Zhao
From 40c45849b5146688ce6f88ca4fe20b771fb2de46 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Fri, 13 Oct 2017 02:53:01 -0400 Subject: [PATCH] ffmpeg_opt: deprecate the hwaccel_lax_profile_check option deprecate hwaccel_lax_profile_check. This only was used for VAAPI hwaccel decoder, now use per-s

Re: [FFmpeg-devel] [PATCH] udp: added option to ignore empty UDP packets

2017-10-13 Thread Daniel Kučera
> > The good approach is to fix the bugs. You do not need to fix all of > them, just fix the one or two instances that break things for you: in > your use case, there is one line of code in the whole project that gets > ret=0 and thinks it means EOF: find it and fix it, and you should be > good. Ot

Re: [FFmpeg-devel] [PATCH 03/20] lavc: Add coded bitstream read/write API

2017-10-13 Thread Michael Niedermayer
On Thu, Oct 12, 2017 at 12:35:35AM +0100, Mark Thompson wrote: > On 11/10/17 23:34, Michael Niedermayer wrote: > > Hi > > > > On Mon, Oct 09, 2017 at 08:04:47PM +0100, Mark Thompson wrote: > > [...] > > > >> diff --git a/libavcodec/cbs.h b/libavcodec/cbs.h > >> new file mode 100644 > >> index 000

Re: [FFmpeg-devel] [PATCH 03/20] lavc: Add coded bitstream read/write API

2017-10-13 Thread Michael Niedermayer
On Thu, Oct 12, 2017 at 12:35:35AM +0100, Mark Thompson wrote: > On 11/10/17 23:34, Michael Niedermayer wrote: > > Hi > > > > On Mon, Oct 09, 2017 at 08:04:47PM +0100, Mark Thompson wrote: > > [...] > > > >> diff --git a/libavcodec/cbs.h b/libavcodec/cbs.h > >> new file mode 100644 > >> index 000

Re: [FFmpeg-devel] [PATCH 03/20] lavc: Add coded bitstream read/write API

2017-10-13 Thread Michael Niedermayer
On Fri, Oct 13, 2017 at 01:23:34PM +0200, Michael Niedermayer wrote: > On Thu, Oct 12, 2017 at 12:35:35AM +0100, Mark Thompson wrote: > > On 11/10/17 23:34, Michael Niedermayer wrote: [...] > > >> + > > >> +/** > > >> + * Coded bitstream unit structure. > > >> + * > > > > > >> + * A bitstream unit

Re: [FFmpeg-devel] [PATCH 03/20] lavc: Add coded bitstream read/write API

2017-10-13 Thread Mark Thompson
On 13/10/17 12:31, Michael Niedermayer wrote: > On Fri, Oct 13, 2017 at 01:23:34PM +0200, Michael Niedermayer wrote: >> On Thu, Oct 12, 2017 at 12:35:35AM +0100, Mark Thompson wrote: >>> On 11/10/17 23:34, Michael Niedermayer wrote: > [...] > + > +/** > + * Coded bitstream unit structur

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Added SCTE104 message decode from VANC

2017-10-13 Thread Devin Heitmueller
Hello Vishwanath, > On Oct 13, 2017, at 1:42 AM, Dixit, Vishwanath wrote: > > Hi, > > Please find the attached patch which adds support to decode SCTE-104 message > from VANC for decklink capture use case. > I’ve got a couple of concerns about this approach. Because I am doing a bunch of VA

Re: [FFmpeg-devel] [PATCH 03/20] lavc: Add coded bitstream read/write API

2017-10-13 Thread Mark Thompson
On 13/10/17 12:28, Michael Niedermayer wrote: > On Thu, Oct 12, 2017 at 12:35:35AM +0100, Mark Thompson wrote: >> On 11/10/17 23:34, Michael Niedermayer wrote: >>> Hi >>> >>> On Mon, Oct 09, 2017 at 08:04:47PM +0100, Mark Thompson wrote: >>> [...] >>> diff --git a/libavcodec/cbs.h b/libavcodec

Re: [FFmpeg-devel] [PATCH] configure: force erroring out in check_disable_warning() if an option doesn't exists

2017-10-13 Thread James Almer
On 10/12/2017 6:30 PM, James Almer wrote: > Should prevent some options from being added to cflags when they > don't exist and the compiler only warns about it. > > Signed-off-by: James Almer > --- > I figure this is safer than adding > -Werror=unused-command-line-argument -Werror=unknown-warning

Re: [FFmpeg-devel] [PATCH] configure: force erroring out in check_disable_warning() if an option doesn't exists

2017-10-13 Thread Hendrik Leppkes
On Fri, Oct 13, 2017 at 4:14 PM, James Almer wrote: > On 10/12/2017 6:30 PM, James Almer wrote: >> Should prevent some options from being added to cflags when they >> don't exist and the compiler only warns about it. >> >> Signed-off-by: James Almer >> --- >> I figure this is safer than adding >>

Re: [FFmpeg-devel] [PATCH] libavformat/wtvdec: return AVERROR_EOF on EOF

2017-10-13 Thread Daniel Kučera
bump. 2017-06-15 10:22 GMT+02:00 Nicolas George : > Le septidi 17 prairial, an CCXXV, Daniel Kucera a écrit : >> Signed-off-by: Daniel Kucera >> --- >> libavformat/wtvdec.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/wtvdec.c b/libavformat/wtvdec.c

Re: [FFmpeg-devel] [PATCH] libavformat/wtvdec: return AVERROR_EOF on EOF

2017-10-13 Thread wm4
On Fri, 13 Oct 2017 16:46:31 +0200 Daniel Kučera wrote: > bump. LGTM too. The maintainer is relatively inactive, and it's a small fix that doesn't even require the maintainer's approval, so I pushed the patch. ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] configure: force erroring out in check_disable_warning() if an option doesn't exists

2017-10-13 Thread wm4
On Fri, 13 Oct 2017 16:30:59 +0200 Hendrik Leppkes wrote: > On Fri, Oct 13, 2017 at 4:14 PM, James Almer wrote: > > On 10/12/2017 6:30 PM, James Almer wrote: > >> Should prevent some options from being added to cflags when they > >> don't exist and the compiler only warns about it. > >> > >> S

Re: [FFmpeg-devel] [PATCH] configure: force erroring out in check_disable_warning() if an option doesn't exists

2017-10-13 Thread James Almer
On 10/13/2017 11:30 AM, Hendrik Leppkes wrote: > On Fri, Oct 13, 2017 at 4:14 PM, James Almer wrote: >> On 10/12/2017 6:30 PM, James Almer wrote: >>> Should prevent some options from being added to cflags when they >>> don't exist and the compiler only warns about it. >>> >>> Signed-off-by: James

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '7cb1d9e2dbbe5bf4652be5d78cdd68e956fa3d63'

2017-10-13 Thread Reino Wijnsma
On 13-10-2017 0:27, James Almer wrote: > On 10/12/2017 6:42 PM, Reino Wijnsma wrote: >> On 12-10-2017 20:11, Helmut K. C. Tessarek wrote: >>> I'm not sure why you guys have to make all these changes to the build >>> process lately. >>> >>> All of a sudden ffmpeg does not compile anymore. During c

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '7cb1d9e2dbbe5bf4652be5d78cdd68e956fa3d63'

2017-10-13 Thread James Almer
On 10/13/2017 1:05 PM, Reino Wijnsma wrote: > On 13-10-2017 0:27, James Almer wrote: >> On 10/12/2017 6:42 PM, Reino Wijnsma wrote: >>> On 12-10-2017 20:11, Helmut K. C. Tessarek wrote: I'm not sure why you guys have to make all these changes to the build process lately. All o

[FFmpeg-devel] [PATCH 0/5] Cuvid/videotoolbox preparations

2017-10-13 Thread wm4
These commits are required to merge Libav's cuvid hwaccel, and to fix videotoolbox operation if frame threading is enabled. Anton Khirnov (4): decode: avoid leaks on failure in ff_get_buffer() decode: add a method for attaching lavc-internal data to frames decode: add a mechanism for perform

[FFmpeg-devel] [PATCH 3/5] decode: add a method for attaching lavc-internal data to frames

2017-10-13 Thread wm4
From: Anton Khirnov Use the AVFrame.opaque_ref field. The original user's opaque_ref is wrapped in the lavc struct and then unwrapped before the frame is returned to the caller. This new struct will be useful in the following commits. Merges Libav commit 359a8a3e2d1194b52b6c386f94fd0929567dfb67

[FFmpeg-devel] [PATCH 1/5] lavc/avrndec: remove AV_CODEC_CAP_DR1, as it's broken

2017-10-13 Thread wm4
In the is_mjpeg case, the user's get_buffer2 callback is not called, thus completely breaking the API. --- libavcodec/avrndec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/avrndec.c b/libavcodec/avrndec.c index c37f99661b..104ff2d904 100644 --- a/libavcodec/avrndec.c +++ b/libavc

[FFmpeg-devel] [PATCH 2/5] decode: avoid leaks on failure in ff_get_buffer()

2017-10-13 Thread wm4
From: Anton Khirnov If the get_buffer() call fails, the frame might have some side data already set. Make sure it gets freed. CC: libav-sta...@libav.org Merges Libav commit de77671438c24ffea93398c8dc885d4dd04477de. --- libavcodec/decode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/

[FFmpeg-devel] [PATCH 4/5] decode: add a mechanism for performing delayed processing on the decoded frames

2017-10-13 Thread wm4
From: Anton Khirnov This will be useful in the CUVID hwaccel. Merges Libav commit badf0951f54c1332e77455dc40398f3512540c1b. --- libavcodec/decode.c | 11 +++ libavcodec/decode.h | 15 +++ 2 files changed, 26 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode

[FFmpeg-devel] [PATCH 5/5] decode: add a per-frame private data for hwaccel use

2017-10-13 Thread wm4
From: Anton Khirnov This will be useful in the CUVID hwaccel. It should also eventually replace current decoder-specific mechanisms used by various other hwaccels. Merges Libav commit 704311b2946d74a80f65906961cd9baaa18683a3. --- libavcodec/decode.c | 3 +++ libavcodec/decode.h | 6 ++ 2 fi

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-13 Thread Michael Niedermayer
On Fri, Oct 06, 2017 at 01:48:14AM +0200, wm4 wrote: > On Fri, 6 Oct 2017 00:01:30 +0200 > Michael Niedermayer wrote: > > > The opaque_ref wraping is a really bad design. Iam not sure why > > people defend it. > > FFmpeg is full of this design. There are plenty of structs with > opaque/priv fiel

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-13 Thread Michael Niedermayer
On Fri, Oct 06, 2017 at 12:38:44AM +0100, Mark Thompson wrote: > On 05/10/17 23:59, Mark Thompson wrote: > > On 05/10/17 23:01, Michael Niedermayer wrote: > >> On Thu, Oct 05, 2017 at 09:03:40PM +0100, Mark Thompson wrote: > >>> On 05/10/17 17:47, Michael Niedermayer wrote: > On Wed, Oct 04, 2

[FFmpeg-devel] [PATCH] configure: use pkg-config for libilbc

2017-10-13 Thread James Almer
With this, the check will include the needed pthreads ldflags when pkg-config is invoked with the --static flag. Signed-off-by: James Almer --- Alternatively, i can keep the current check and add $pthreads_extralibs to it. configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '7cb1d9e2dbbe5bf4652be5d78cdd68e956fa3d63'

2017-10-13 Thread James Almer
On 10/13/2017 1:48 PM, James Almer wrote: > So in here it's including the libraries libopenmpt.pc said it needed > (using pkg-config --static). Are "-lshlwapi -lpthread -lcrypt32" > extralibs you added manually, or were they derived from dependencies > like libmpg123, vorbis, etc by pkg-config? >

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-13 Thread wm4
On Fri, 13 Oct 2017 20:03:12 +0200 Michael Niedermayer wrote: > I dont really know and as a maintainer of some of this code, i dont > really want to have to keep track of how exactly AVFrames can pass > through the code. You have to do that anyway. > And as the one taking care of a lot of secur

[FFmpeg-devel] [PATCH 3/3] libavformat/aviobuf: don't treat 0 as EOF

2017-10-13 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/aviobuf.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 636cb46161..0d4eb051e1 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -572,13 +57

[FFmpeg-devel] [PATCH 2/3] libavformat/cache: don't treat 0 as EOF

2017-10-13 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/cache.c b/libavformat/cache.c index 6aabca2e78..66bbbf54c9 100644 --- a/libavformat/cache.c +++ b/libavformat/cache.c @@ -201,7 +201,7 @@ static int cache_read(

[FFmpeg-devel] [PATCH 1/3] libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-10-13 Thread Daniel Kucera
transfer_func variable passed to retry_transfer_wrapper are h->prot->url_read and h->prot->url_write functions. These need to return EOF or other error properly. In case of returning >= 0, url_read/url_write is retried until error is returned. Signed-off-by: Daniel Kucera --- libavformat/avio.c

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-13 Thread wm4
On Fri, 13 Oct 2017 19:41:28 +0200 Michael Niedermayer wrote: > On Fri, Oct 06, 2017 at 01:48:14AM +0200, wm4 wrote: > > On Fri, 6 Oct 2017 00:01:30 +0200 > > Michael Niedermayer wrote: > > > > > The opaque_ref wraping is a really bad design. Iam not sure why > > > people defend it. > > >

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: Fallback to duration_dts, when duration_pts can't be determined.

2017-10-13 Thread Michael Niedermayer
On Thu, Oct 12, 2017 at 10:43:54AM +0200, Thomas Mundt wrote: > Hi Michael, > > 2017-10-12 1:28 GMT+02:00 Michael Niedermayer : > > > On Tue, Oct 10, 2017 at 10:26:13PM +0200, Thomas Mundt wrote: > > > 2017-10-10 19:36 GMT+02:00 Sasi Inguva : > > > > > > > This is required for FLV files, for whic

Re: [FFmpeg-devel] [PATCH] configure: force erroring out in check_disable_warning() if an option doesn't exists

2017-10-13 Thread James Almer
On 10/13/2017 12:37 PM, James Almer wrote: > On 10/13/2017 11:30 AM, Hendrik Leppkes wrote: >> On Fri, Oct 13, 2017 at 4:14 PM, James Almer wrote: >>> On 10/12/2017 6:30 PM, James Almer wrote: Should prevent some options from being added to cflags when they don't exist and the compiler o

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '7cb1d9e2dbbe5bf4652be5d78cdd68e956fa3d63'

2017-10-13 Thread Reino Wijnsma
On 13-10-2017 18:48, James Almer wrote: > Are "-lshlwapi -lpthread -lcrypt32" > extralibs you added manually, or were they derived from dependencies > like libmpg123, vorbis, etc by pkg-config? My configure line up until now with the manually added extra-libs: # ./configure --arch=x86 --target-os

Re: [FFmpeg-devel] [PATCH 3/3] libavformat/aviobuf: don't treat 0 as EOF

2017-10-13 Thread Michael Niedermayer
On Fri, Oct 13, 2017 at 09:03:49PM +0200, Daniel Kucera wrote: > Signed-off-by: Daniel Kucera > --- > libavformat/aviobuf.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) with this make -j12 fate-wtv-demux infinite loops [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 1/3] libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-10-13 Thread Michael Niedermayer
On Fri, Oct 13, 2017 at 09:03:47PM +0200, Daniel Kucera wrote: > transfer_func variable passed to retry_transfer_wrapper > are h->prot->url_read and h->prot->url_write functions. > These need to return EOF or other error properly. > In case of returning >= 0, url_read/url_write is retried > until e

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '7cb1d9e2dbbe5bf4652be5d78cdd68e956fa3d63'

2017-10-13 Thread James Almer
On 10/13/2017 6:30 PM, Reino Wijnsma wrote: > On 13-10-2017 18:48, James Almer wrote: >> Are "-lshlwapi -lpthread -lcrypt32" >> extralibs you added manually, or were they derived from dependencies >> like libmpg123, vorbis, etc by pkg-config? > My configure line up until now with the manually adde

Re: [FFmpeg-devel] [PATCH] configure: use pkg-config for libilbc

2017-10-13 Thread James Almer
On 10/13/2017 3:09 PM, James Almer wrote: > With this, the check will include the needed pthreads ldflags when > pkg-config is invoked with the --static flag. > > Signed-off-by: James Almer > --- > Alternatively, i can keep the current check and add $pthreads_extralibs > to it. Patch dropped. It

Re: [FFmpeg-devel] [PATCH] configure: force erroring out in check_disable_warning() if an option doesn't exists

2017-10-13 Thread Michael Niedermayer
On Fri, Oct 13, 2017 at 12:37:18PM -0300, James Almer wrote: > On 10/13/2017 11:30 AM, Hendrik Leppkes wrote: > > On Fri, Oct 13, 2017 at 4:14 PM, James Almer wrote: > >> On 10/12/2017 6:30 PM, James Almer wrote: > >>> Should prevent some options from being added to cflags when they > >>> don't ex

Re: [FFmpeg-devel] [PATCH] configure: force erroring out in check_disable_warning() if an option doesn't exists

2017-10-13 Thread James Almer
On 10/13/2017 8:54 PM, Michael Niedermayer wrote: > On Fri, Oct 13, 2017 at 12:37:18PM -0300, James Almer wrote: >> On 10/13/2017 11:30 AM, Hendrik Leppkes wrote: >>> On Fri, Oct 13, 2017 at 4:14 PM, James Almer wrote: On 10/12/2017 6:30 PM, James Almer wrote: > Should prevent some option

Re: [FFmpeg-devel] [PATCH 1/3] libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-10-13 Thread Daniel Kučera
breaks fate-indeo3-2 [...] -- You need to apply the whole set. It passed all fate tests on my machine. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel