Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-04 Thread wm4
On Tue, 3 Oct 2017 21:40:58 +0200 Michael Niedermayer wrote: > On Tue, Oct 03, 2017 at 03:15:13PM +0200, wm4 wrote: > > From: Anton Khirnov > > > > > Use the AVFrame.opaque_ref field. The original user's opaque_ref is > > wrapped in the lavc struct and then unwrapped before the frame is > >

Re: [FFmpeg-devel] [PATCH 1/2] lavc/v4l2: Remove use of lfind()

2017-10-04 Thread wm4
On Tue, 3 Oct 2017 21:08:13 +0100 Mark Thompson wrote: > This is not present in older bionic and therefore fails to build there, > and the code is much simpler without it anyway. > --- +1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ff

Re: [FFmpeg-devel] [PATCH 2/2] avformat/wavenc: skip writing peak-of-peaks position when writing peaks only

2017-10-04 Thread Tobias Rapp
On 30.09.2017 02:48, Michael Niedermayer wrote: On Fri, Sep 29, 2017 at 05:08:16PM +0200, Tobias Rapp wrote: Signed-off-by: Tobias Rapp --- libavformat/wavenc.c | 5 - tests/ref/lavf/wav_peak_only | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) The commit message does

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter/vf_fps: add eof_action filter option

2017-10-04 Thread Tobias Rapp
On 25.09.2017 13:31, Tobias Rapp wrote: Allows to specify the action to be performed when reading the last frame from the internal FIFO buffer. By default the last frame is written to filter output depending on the timestamp rounding method. When using "pass" action the last frame is passed throu

Re: [FFmpeg-devel] [PATCH v5 2/2] fate: add tests for psnr and ssim filter

2017-10-04 Thread Tobias Rapp
On 27.09.2017 17:20, Carl Eugen Hoyos wrote: 2017-09-27 15:30 GMT+02:00 Tobias Rapp : Metadata filter output is passed through an Awk script comparing floats Is awk needed on the host or the target system? Awk is started by fate-run.sh directly, so it is needed on the host system AFAICS. No

Re: [FFmpeg-devel] [PATCH 7/7] h264dec: add a CUVID hwaccel

2017-10-04 Thread wm4
On Tue, 3 Oct 2017 07:17:25 -0700 Philip Langdale wrote: > > I'd propose to use this as a chance to get in line with nvidias new > > naming, and call the new cuvid decoder/hwaccel nvdec. This is quite a > > deviation from libav, but we need to rename it anyways, so might as > > well pick an ent

[FFmpeg-devel] [PATCH] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread Jorge Ramirez-Ortiz
Some V4L2 drivers fail to allocate buffers when sizeimage is not set to a max value. This is indeed the case for sp5-mfc [1] Most drivers should be able to calculate this value from the frame dimensions and format - or at least have their own default. However since this work around should not imp

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-04 Thread Michael Niedermayer
On Wed, Oct 04, 2017 at 09:12:29AM +0200, wm4 wrote: > On Tue, 3 Oct 2017 21:40:58 +0200 > Michael Niedermayer wrote: > > > On Tue, Oct 03, 2017 at 03:15:13PM +0200, wm4 wrote: > > > From: Anton Khirnov > > > > > > > > Use the AVFrame.opaque_ref field. The original user's opaque_ref is > > >

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread wm4
On Wed, 4 Oct 2017 11:17:24 +0200 Jorge Ramirez-Ortiz wrote: > Some V4L2 drivers fail to allocate buffers when sizeimage is not set > to a max value. This is indeed the case for sp5-mfc [1] > > Most drivers should be able to calculate this value from the frame > dimensions and format - or at le

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-04 Thread wm4
On Wed, 4 Oct 2017 11:22:37 +0200 Michael Niedermayer wrote: > On Wed, Oct 04, 2017 at 09:12:29AM +0200, wm4 wrote: > > On Tue, 3 Oct 2017 21:40:58 +0200 > > Michael Niedermayer wrote: > > > > > On Tue, Oct 03, 2017 at 03:15:13PM +0200, wm4 wrote: > > > > From: Anton Khirnov > > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread Jorge Ramirez-Ortiz
On 10/04/2017 11:23 AM, wm4 wrote: On Wed, 4 Oct 2017 11:17:24 +0200 Jorge Ramirez-Ortiz wrote: Some V4L2 drivers fail to allocate buffers when sizeimage is not set to a max value. This is indeed the case for sp5-mfc [1] Most drivers should be able to calculate this value from the frame dime

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-04 Thread Michael Niedermayer
On Wed, Oct 04, 2017 at 11:34:18AM +0200, wm4 wrote: > On Wed, 4 Oct 2017 11:22:37 +0200 > Michael Niedermayer wrote: > > > On Wed, Oct 04, 2017 at 09:12:29AM +0200, wm4 wrote: > > > On Tue, 3 Oct 2017 21:40:58 +0200 > > > Michael Niedermayer wrote: > > > > > > > On Tue, Oct 03, 2017 at 03:15

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-04 Thread wm4
On Wed, 4 Oct 2017 11:47:39 +0200 Michael Niedermayer wrote: > On Wed, Oct 04, 2017 at 11:34:18AM +0200, wm4 wrote: > > On Wed, 4 Oct 2017 11:22:37 +0200 > > Michael Niedermayer wrote: > > > > > On Wed, Oct 04, 2017 at 09:12:29AM +0200, wm4 wrote: > > > > On Tue, 3 Oct 2017 21:40:58 +0200 >

Re: [FFmpeg-devel] [PATCH] Videotoolbox encoder: Enable Videotoolbox encoder

2017-10-04 Thread pon pon
Thank you for pointing out. >i t doesn't belong in this list. Doesn't this mean videotoolbox_encoder belongs to EXTERNAL_AUTODETECT_LIBRARY_LIST, also? If so, I think the integrated modifications of videotoolbox"enc".c and videotoolbox.c are nee

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-04 Thread Michael Niedermayer
On Fri, Sep 29, 2017 at 08:54:08AM -0700, John Stebbins wrote: > When keyframe intervals of dash segments are not perfectly aligned, > fragments in the stream can overlap in time. Append new "trun" index > entries to the end of the index instead of sorting by timestamp. > Sorting by timestamp cause

[FFmpeg-devel] [PATCH] avcodec/v4l2_context: Replace "0 in case of success" by "non negative in case of success"

2017-10-04 Thread Michael Niedermayer
This makes the return code consistent with most of FFmpeg Signed-off-by: Michael Niedermayer --- libavcodec/v4l2_context.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/v4l2_context.h b/libavcodec/v4l2_context.h index 503cc36dc4..63e01dfb89 10064

Re: [FFmpeg-devel] [PATCH] build: make h264 VT encoder select the VT encoder dependency

2017-10-04 Thread Clément Bœsch
On Fri, Sep 29, 2017 at 11:11:46AM +0200, Clément Bœsch wrote: > From: Clément Bœsch > > Otherwise, it's never enabled unless the user explicitely enables it. > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 8e4775be8c..6

Re: [FFmpeg-devel] [PATCH] Videotoolbox encoder: Enable Videotoolbox encoder

2017-10-04 Thread Clément Bœsch
On Wed, Oct 04, 2017 at 07:45:50PM +0900, pon pon wrote: > Thank you for pointing out. > > >i t doesn't belong in this list. > Doesn't this mean videotoolbox_encoder belongs to > EXTERNAL_AUTODETECT_LIBRARY_LIST, > also? My point was that it doesn't belong in these lists. I applied my patch (8be3

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_context: Replace "0 in case of success" by "non negative in case of success"

2017-10-04 Thread wm4
On Wed, 4 Oct 2017 12:51:42 +0200 Michael Niedermayer wrote: > This makes the return code consistent with most of FFmpeg > > Signed-off-by: Michael Niedermayer > --- That's a bit redundant because the FFmpeg convention is guaranteed to work on the caller site anyway. _

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-04 Thread Tobias Rapp
On 04.10.2017 11:34, wm4 wrote: On Wed, 4 Oct 2017 11:22:37 +0200 Michael Niedermayer wrote: On Wed, Oct 04, 2017 at 09:12:29AM +0200, wm4 wrote: On Tue, 3 Oct 2017 21:40:58 +0200 Michael Niedermayer wrote: On Tue, Oct 03, 2017 at 03:15:13PM +0200, wm4 wrote: From: Anton Khirnov

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-04 Thread wm4
On Wed, 4 Oct 2017 13:37:31 +0200 Tobias Rapp wrote: > On 04.10.2017 11:34, wm4 wrote: > > On Wed, 4 Oct 2017 11:22:37 +0200 > > Michael Niedermayer wrote: > > > >> On Wed, Oct 04, 2017 at 09:12:29AM +0200, wm4 wrote: > >>> On Tue, 3 Oct 2017 21:40:58 +0200 > >>> Michael Niedermayer wrote:

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-04 Thread John Stebbins
On 10/04/2017 03:50 AM, Michael Niedermayer wrote: > On Fri, Sep 29, 2017 at 08:54:08AM -0700, John Stebbins wrote: >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. Append new "trun" index >> entries to the end of the index inst

Re: [FFmpeg-devel] [PATCH 1/2 v2] configure: disable libxcb dependent features if libxcb is not enabled

2017-10-04 Thread James Almer
On 9/28/2017 7:56 PM, James Almer wrote: > Signed-off-by: James Almer > --- > configure | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configure b/configure > index c2f5fc2c98..ebcf48de20 100755 > --- a/configure > +++ b/configure > @@ -6215,6 +6215,8 @@ if enabled libxcb; then > >

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread Jorge Ramirez-Ortiz
On 10/04/2017 11:28 AM, Jorge Ramirez-Ortiz wrote: On 10/04/2017 11:23 AM, wm4 wrote: On Wed,  4 Oct 2017 11:17:24 +0200 Jorge Ramirez-Ortiz wrote: Some V4L2 drivers fail to allocate buffers when sizeimage is not set to a max value. This is indeed the case for sp5-mfc [1] Most drivers should

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread wm4
On Wed, 4 Oct 2017 17:48:25 +0200 Jorge Ramirez-Ortiz wrote: > On 10/04/2017 11:28 AM, Jorge Ramirez-Ortiz wrote: > > On 10/04/2017 11:23 AM, wm4 wrote: > >> On Wed,  4 Oct 2017 11:17:24 +0200 > >> Jorge Ramirez-Ortiz wrote: > >> > >>> Some V4L2 drivers fail to allocate buffers when sizeimag

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread Jorge Ramirez-Ortiz
On 10/04/2017 05:59 PM, wm4 wrote: diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c index 297792f..2707ef5 100644 --- a/libavcodec/v4l2_context.c +++ b/libavcodec/v4l2_context.c @@ -92,6 +92,8 @@ static inline int v4l2_type_supported(V4L2Context *ctx)     static inline void v4l

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread wm4
On Wed, 4 Oct 2017 18:13:24 +0200 Jorge Ramirez-Ortiz wrote: > On 10/04/2017 05:59 PM, wm4 wrote: > > diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c > > index 297792f..2707ef5 100644 > > --- a/libavcodec/v4l2_context.c > > +++ b/libavcodec/v4l2_context.c >

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread Mark Thompson
On 04/10/17 16:48, Jorge Ramirez-Ortiz wrote: > On 10/04/2017 11:28 AM, Jorge Ramirez-Ortiz wrote: >> On 10/04/2017 11:23 AM, wm4 wrote: >>> On Wed,  4 Oct 2017 11:17:24 +0200 >>> Jorge Ramirez-Ortiz wrote: >>> Some V4L2 drivers fail to allocate buffers when sizeimage is not set to a max

Re: [FFmpeg-devel] [PATCH 7/7] h264dec: add a CUVID hwaccel

2017-10-04 Thread Timo Rothenpieler
Am 04.10.2017 um 11:05 schrieb wm4: On Tue, 3 Oct 2017 07:17:25 -0700 Philip Langdale wrote: I'd propose to use this as a chance to get in line with nvidias new naming, and call the new cuvid decoder/hwaccel nvdec. This is quite a deviation from libav, but we need to rename it anyways, so migh

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread Jorge Ramirez-Ortiz
On 10/04/2017 06:23 PM, Mark Thompson wrote: On 04/10/17 16:48, Jorge Ramirez-Ortiz wrote: On 10/04/2017 11:28 AM, Jorge Ramirez-Ortiz wrote: On 10/04/2017 11:23 AM, wm4 wrote: On Wed,  4 Oct 2017 11:17:24 +0200 Jorge Ramirez-Ortiz wrote: Some V4L2 drivers fail to allocate buffers when size

[FFmpeg-devel] [PATCHv2] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread Jorge Ramirez-Ortiz
Some V4L2 drivers fail to allocate buffers when sizeimage is not set to a max value. This is indeed the case for s5p-mfc [1] Most drivers should be able to calculate this value from the frame dimensions and format - or at least have their own default. However since this work around should not imp

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread Jorge Ramirez-Ortiz
On 10/04/2017 06:20 PM, wm4 wrote: Isn't this something that should be fixed in the driver? yes but it might take forever and I dont know how many other drivers might need it. Why 2MB? no analysis done but seems to be enough to hold an encoded frame. Should it be any bigger? I could use

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-04 Thread Michael Niedermayer
On Wed, Oct 04, 2017 at 08:18:59AM -0700, John Stebbins wrote: > > On 10/04/2017 03:50 AM, Michael Niedermayer wrote: > > On Fri, Sep 29, 2017 at 08:54:08AM -0700, John Stebbins wrote: > >> When keyframe intervals of dash segments are not perfectly aligned, > >> fragments in the stream can overlap

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-04 Thread John Stebbins
On 10/04/2017 10:13 AM, Michael Niedermayer wrote: > On Wed, Oct 04, 2017 at 08:18:59AM -0700, John Stebbins wrote: >> On 10/04/2017 03:50 AM, Michael Niedermayer wrote: >>> On Fri, Sep 29, 2017 at 08:54:08AM -0700, John Stebbins wrote: When keyframe intervals of dash segments are not perfectl

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-10-04 Thread pkv.stream
Le 02/10/2017 à 9:50 PM, pkv.stream a écrit : Thanks Michael; replaced the offending MSVC function. Le 02/10/2017 à 9:35 PM, Michael Niedermayer a écrit : On Sun, Oct 01, 2017 at 03:17:30AM +0200, pkv.stream wrote: Hello the submitted patch addresses the regression discussed in ticket #6706.

Re: [FFmpeg-devel] [PATCHv3] avformat/mpegts: opus muxing & demuxing for mapping family 255

2017-10-04 Thread pkv.stream
Le 15/09/2017 à 10:33 PM, Michael Niedermayer a écrit : On Wed, Sep 13, 2017 at 09:36:25PM +0200, pkv.stream wrote: Le 08/09/2017 à 1:46 AM, pkv.stream a écrit : Hi, I've removed inline declarations in the patch since they're not accepted in ffmpeg. Thanks for any more comments or reviews. R

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread wm4
On Wed, 4 Oct 2017 19:03:12 +0200 Jorge Ramirez-Ortiz wrote: > On 10/04/2017 06:20 PM, wm4 wrote: > >> Isn't this something that should be fixed in the driver? > > yes but it might take forever and I dont know how many other drivers > > might > > need it. > > >

Re: [FFmpeg-devel] [PATCHv2] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread Michael Niedermayer
On Wed, Oct 04, 2017 at 06:50:31PM +0200, Jorge Ramirez-Ortiz wrote: > Some V4L2 drivers fail to allocate buffers when sizeimage is not set > to a max value. This is indeed the case for s5p-mfc [1] > > Most drivers should be able to calculate this value from the frame > dimensions and format - or

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-10-04 Thread Michael Niedermayer
On Wed, Oct 04, 2017 at 01:07:34AM +0200, Carl Eugen Hoyos wrote: > 2017-10-04 1:00 GMT+02:00 Michael Niedermayer : > > On Tue, Oct 03, 2017 at 12:02:23AM +0200, Carl Eugen Hoyos wrote: > >> 2017-10-02 23:47 GMT+02:00 Carl Eugen Hoyos : > >> > 2017-10-02 23:02 GMT+02:00 Michael Niedermayer : > >> >

Re: [FFmpeg-devel] [PATCHv2] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread Jorge Ramirez-Ortiz
On 10/04/2017 08:56 PM, Michael Niedermayer wrote: On Wed, Oct 04, 2017 at 06:50:31PM +0200, Jorge Ramirez-Ortiz wrote: Some V4L2 drivers fail to allocate buffers when sizeimage is not set to a max value. This is indeed the case for s5p-mfc [1] Most drivers should be able to calculate this valu

[FFmpeg-devel] [PATCHv3] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread Jorge Ramirez-Ortiz
Some V4L2 drivers fail to allocate buffers when sizeimage is not set to a max value. This is indeed the case for s5p-mfc [1] Most drivers should be able to calculate this value from the frame dimensions and format - or at least have their own default. However since this work around should not imp

Re: [FFmpeg-devel] [PATCH 1/4] avdevice/decklink: Fix segfault when running -list_devices on OSX

2017-10-04 Thread Marton Balint
On Tue, 26 Sep 2017, Devin Heitmueller wrote: The string is allocated with CFStringGetCString but was being deallocated with free(), which would intermittently result in a segmentation fault. Use the correct function for freeing the allocated CFString. Signed-off-by: Devin Heitmueller --- l

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: change the decklink maintainer to myself

2017-10-04 Thread Marton Balint
On Sun, 1 Oct 2017, Deti Fliegl wrote: Thanks. Thanks, applied. Regards, Marton On 30.09.17 23:39, Marton Balint wrote: Signed-off-by: Marton Balint --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 412680abac..9027ed5

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: fix multipacket op47 decoding

2017-10-04 Thread Marton Balint
On Sun, 1 Oct 2017, Marton Balint wrote: It was disabled by mistake. Signed-off-by: Marton Balint --- libavdevice/decklink_dec.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 9f6c4598ba..cbad4d6ee2 10064

Re: [FFmpeg-devel] [PATCH 2/4] libavdevice/decklink: add support for -sources and -sinks arguments

2017-10-04 Thread Devin Heitmueller
> On Sep 30, 2017, at 4:02 PM, Marton Balint wrote: > > > > On Tue, 26 Sep 2017, Devin Heitmueller wrote: > >> Add support for enumerating the sources/sinks via the ffmpeg >> command line options, as opposed to having to create a real pipeline >> and use the "-list_devices" option which does

[FFmpeg-devel] [PATCH] avdevice/decklink_dec: fix extracting luma

2017-10-04 Thread Marton Balint
Signed-off-by: Marton Balint --- libavdevice/decklink_dec.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index f496a58059..7ac04375d9 100644 --- a/libavdevice/decklink_dec.cpp +++ b/libavdevice/decklink_dec.cpp @

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-10-04 Thread Moritz Barsnick
On Mon, Oct 02, 2017 at 21:50:50 +0200, pkv.stream wrote: > if (!ost->stream_copy) { > -char *sample_fmt = NULL; > + > + char *sample_fmt = NULL; > This is very obviously a patch which will not be accepted. > -MATCH_PER_STREAM_OPT(sample_fmts, str, sample_fmt,

Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_fps: clean-up filter options

2017-10-04 Thread Michael Niedermayer
On Mon, Sep 25, 2017 at 01:31:18PM +0200, Tobias Rapp wrote: > Align order of "start_time" option within filter documentation to actual > implementation and add missing AV_OPT_FLAG_FILTERING_PARAM flag. Fix > indent of "round" named constants and clear unused field values. > > Also fix some docume

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-10-04 Thread Kv Pham
Le 4 oct. 2017 11:24 PM, "Moritz Barsnick" a écrit : On Mon, Oct 02, 2017 at 21:50:50 +0200, pkv.stream wrote: > if (!ost->stream_copy) { > -char *sample_fmt = NULL; > + > + char *sample_fmt = NULL; > This is very obviously a patch which will not be accepted. > -

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter/vf_fps: add eof_action filter option

2017-10-04 Thread Michael Niedermayer
On Mon, Sep 25, 2017 at 01:31:19PM +0200, Tobias Rapp wrote: > Allows to specify the action to be performed when reading the last frame > from the internal FIFO buffer. By default the last frame is written to > filter output depending on the timestamp rounding method. When using > "pass" action the

Re: [FFmpeg-devel] [PATCH 2/2] lavc/v4l2: Mark static const tables as such

2017-10-04 Thread Michael Niedermayer
On Tue, Oct 03, 2017 at 09:08:14PM +0100, Mark Thompson wrote: > --- > libavcodec/v4l2_m2m_enc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Modern terrorism, a quick summary: Need oil, s

Re: [FFmpeg-devel] [PATCH 2/2] avformat/wavenc: skip writing peak-of-peaks position when writing peaks only

2017-10-04 Thread Michael Niedermayer
On Wed, Oct 04, 2017 at 10:33:11AM +0200, Tobias Rapp wrote: > On 30.09.2017 02:48, Michael Niedermayer wrote: > >On Fri, Sep 29, 2017 at 05:08:16PM +0200, Tobias Rapp wrote: > >>Signed-off-by: Tobias Rapp > >>--- > >> libavformat/wavenc.c | 5 - > >> tests/ref/lavf/wav_peak_only | 2

[FFmpeg-devel] [PATCH 1/3] avformat/http: fix chunked response w/ multiple_requests=1

2017-10-04 Thread Aman Gupta
From: Aman Gupta Currently if you use the multiple_requests=1 option and try to receive a chunked-encoded response, http_buf_read() will hang forever. After this patch, EOF is emulated once a 0-byte final chunk is received. This bheavior is reset in ff_http_do_new_request(), which is used to mak

[FFmpeg-devel] [PATCH 3/3] avformat/hls: add http_keepalive option

2017-10-04 Thread Aman Gupta
From: Aman Gupta This teaches the HLS demuxer to use the HTTP protocols multiple_requests=1 option, to take advantage of "Connection: Keep-Alive" when downloading playlists and segments from the HLS server. With the new option, you can avoid TCP connection and TLS negotiation overhead, which is

[FFmpeg-devel] [PATCH 2/3] avformat/http: fix stray quote in trace logging

2017-10-04 Thread Aman Gupta
From: Aman Gupta --- libavformat/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index 6af3259a43..f76a71fbb7 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -1298,7 +1298,7 @@ static int http_buf_read(URLContext *h,

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-04 Thread Michael Niedermayer
On Wed, Oct 04, 2017 at 10:58:19AM -0700, John Stebbins wrote: > On 10/04/2017 10:13 AM, Michael Niedermayer wrote: > > On Wed, Oct 04, 2017 at 08:18:59AM -0700, John Stebbins wrote: > >> On 10/04/2017 03:50 AM, Michael Niedermayer wrote: > >>> On Fri, Sep 29, 2017 at 08:54:08AM -0700, John Stebbin

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-10-04 Thread pkv.stream
Le 04/10/2017 à 11:18 PM, Moritz Barsnick a écrit : On Mon, Oct 02, 2017 at 21:50:50 +0200, pkv.stream wrote: if (!ost->stream_copy) { -char *sample_fmt = NULL; + + char *sample_fmt = NULL; This is very obviously a patch which will not be accepted. -MAT

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/x86/lossless_videoencdsp: Fix warning: signed dword value exceeds bounds

2017-10-04 Thread Michael Niedermayer
On Sun, Oct 01, 2017 at 02:10:41AM +0200, Henrik Gramner wrote: > On Sat, Sep 30, 2017 at 12:58 AM, Michael Niedermayer > wrote: > > -andi, -2 * regsize > > +andi, -(2 * regsize) > > regsize is defined to mmsize / 2 in the relevant case so the > expression

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/x86/lossless_videoencdsp: Fix handling of small widths

2017-10-04 Thread Michael Niedermayer
On Sat, Sep 30, 2017 at 12:58:28AM +0200, Michael Niedermayer wrote: > Fixes out of array access > Fixes: crash-huf.avi > > Regression since: 6b41b4414934cc930468ccd5db598dd6ef643987 > > This could also be fixed by adding checks in the C code that calls the dsp > > Found-by: Zhibin Hu and 连一汉 >

Re: [FFmpeg-devel] [PATCHv3] avcodec/v4l2: set sizeimage param for non-raw buffers [fixes #6716]

2017-10-04 Thread Mark Thompson
On 04/10/17 20:04, Jorge Ramirez-Ortiz wrote: > Some V4L2 drivers fail to allocate buffers when sizeimage is not set > to a max value. This is indeed the case for s5p-mfc [1] > > Most drivers should be able to calculate this value from the frame > dimensions and format - or at least have their own

[FFmpeg-devel] [PATCH] lavc/v4l2: Fix printf format for int64_t

2017-10-04 Thread Mark Thompson
--- Not everyone has a 64-bit long, especially on arm. libavcodec/v4l2_m2m_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/v4l2_m2m_enc.c b/libavcodec/v4l2_m2m_enc.c index b0d5a3bd15..f71ce5fb74 100644 --- a/libavcodec/v4l2_m2m_enc.c +++ b/libavcodec/v4l2_m2m

Re: [FFmpeg-devel] [PATCH] Videotoolbox encoder: Enable Videotoolbox encoder

2017-10-04 Thread pon pon
Sorry for my misunderstanding. I tests your patch. ./configure ffmpeg -i input -c:v h264_videotoolbox output ./configure --disable-encoder=h264_videotoolbox ./configure --disable-videotoolbox All work! Good! ponpon 2017-10-04 20:01 GMT+09:00 Clément Bœsch : > On Wed, Oct 04, 2017 at 07:45:50PM

[FFmpeg-devel] [PATCH] avformat: fix id3 chapters

2017-10-04 Thread Lukas Stabe
These changes store id3 chapter data in ID3v2ExtraMeta and introduce ff_id3v2_parse_chapters to parse them into the format context if needed. Encoders using ff_id3v2_read, which previously parsed chapters into the format context automatically, were adjusted to call ff_id3v2_parse_chapters. ---

[FFmpeg-devel] [PATCH v2] build: add install targets for the examples

2017-10-04 Thread James Almer
Split it off from install-data. Among other things, this prevents spamming triplicate log lines during install. Signed-off-by: James Almer --- Updated to apply after a recent merge. Makefile | 6 ++ doc/examples/Makefile | 14 +- 2 files changed, 15 insertions(+),

Re: [FFmpeg-devel] [PATCH v2] build: add install targets for the examples

2017-10-04 Thread Clément Bœsch
On Thu, Oct 05, 2017 at 12:55:19AM -0300, James Almer wrote: > Split it off from install-data. > > Among other things, this prevents spamming triplicate log lines during > install. > > Signed-off-by: James Almer > --- > Updated to apply after a recent merge. > > Makefile | 6 ++-

[FFmpeg-devel] [PATCH]lavc/h264:Only check x264_build if it was set

2017-10-04 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #6717. Please comment, Carl Eugen From 3315fa024958246685b2431c2605e867f651ad5b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 5 Oct 2017 08:29:27 +0200 Subject: [PATCH] lavc/h264: Only check x264_build if it was set. Fixes ticket #6718. --- libavcod

Re: [FFmpeg-devel] [PATCH] lavc/v4l2: Fix printf format for int64_t

2017-10-04 Thread Carl Eugen Hoyos
2017-10-05 2:07 GMT+02:00 Mark Thompson : > --- > Not everyone has a 64-bit long, especially on arm. Please push such patches directly, there is enough traffic on this mailing list. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg