Re: [FFmpeg-devel] [PATCH]lavc/put_bits: Remove usage of BITSTREAM_WRITER_LE.

2017-08-22 Thread Paul B Mahol
On 8/21/17, Carl Eugen Hoyos wrote: > Hi! > > Attached patch tries to slightly simplify and clean up the usage of > put_bits* in libavcodec: put_bits_le() functions exist for the > little-endian G.726 encoder, so the define makes less sense now. > > Fate passes here, please review, Carl Eugen > U

Re: [FFmpeg-devel] [PATCH]lavc/put_bits: Remove usage of BITSTREAM_WRITER_LE.

2017-08-22 Thread Ronald S. Bultje
Hi, On Mon, Aug 21, 2017 at 11:16 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch tries to slightly simplify and clean up the usage of > put_bits* in libavcodec: put_bits_le() functions exist for the > little-endian G.726 encoder, so the define makes less sense now. > > Fate passes here, pl

[FFmpeg-devel] [PATCH 1/2] ffprobe: Fix null pointer dereference with color primaries

2017-08-22 Thread Michael Niedermayer
Found-by: AD-lab of venustech Signed-off-by: Michael Niedermayer --- ffprobe.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/ffprobe.c b/ffprobe.c index 50d7c1a777..d4bdd9c099 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -1925,6 +1925,16 @@ static void pri

[FFmpeg-devel] [PATCH 2/2] ffprobe: Fix NULL pointer handling in color parameter printing

2017-08-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- ffprobe.c | 88 +++ 1 file changed, 49 insertions(+), 39 deletions(-) diff --git a/ffprobe.c b/ffprobe.c index d4bdd9c099..ba10563b9d 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -1925,6 +1925,26 @@ s

Re: [FFmpeg-devel] [PATCH 1/2] ffprobe: Fix null pointer dereference with color primaries

2017-08-22 Thread James Almer
On 8/22/2017 2:01 PM, James Almer wrote: > On 8/22/2017 1:34 PM, Michael Niedermayer wrote: >> Found-by: AD-lab of venustech >> Signed-off-by: Michael Niedermayer >> --- >> ffprobe.c | 20 >> 1 file changed, 12 insertions(+), 8 deletions(-) >> >> diff --git a/ffprobe.c b/ffpr

Re: [FFmpeg-devel] [PATCH 1/2] ffprobe: Fix null pointer dereference with color primaries

2017-08-22 Thread James Almer
On 8/22/2017 1:34 PM, Michael Niedermayer wrote: > Found-by: AD-lab of venustech > Signed-off-by: Michael Niedermayer > --- > ffprobe.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/ffprobe.c b/ffprobe.c > index 50d7c1a777..d4bdd9c099 100644 > ---

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-22 Thread Vitaly Buka
What else can I do yo make it accepted? On Sun, Aug 20, 2017 at 11:56 AM, Vitaly Buka wrote: > Signed integer overflow is undefined behavior. > Detected with clang and -fsanitize=signed-integer-overflow > > Signed-off-by: Vitaly Buka > --- > libavcodec/utils.c| 2 +- > libavformat/aviobuf.

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-22 Thread Paul B Mahol
On 8/22/17, Vitaly Buka wrote: > What else can I do yo make it accepted? Ping it after month or two? > > On Sun, Aug 20, 2017 at 11:56 AM, Vitaly Buka wrote: > >> Signed integer overflow is undefined behavior. >> Detected with clang and -fsanitize=signed-integer-overflow >> >> Signed-off-by: Vi

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-22 Thread James Almer
On 8/22/2017 2:30 PM, Paul B Mahol wrote: > On 8/22/17, Vitaly Buka wrote: >> What else can I do yo make it accepted? > > Ping it after month or two? A week is enough wait to justify a ping. A month is overkill. > >> >> On Sun, Aug 20, 2017 at 11:56 AM, Vitaly Buka wrote: >> >>> Signed intege

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-08-22 Thread Marton Balint
On Fri, 18 Aug 2017, Maksym Veremeyenko wrote: [...] Thanks for all the fixes. Is it ok to apply this version, or we are still waiting for some V3 SDK stuff? One more thing I noticed testing, maybe you can take a look: rgba and rgb0 format is not working (I used the V1 SDK), only audio fram

[FFmpeg-devel] [PATCH] avfilter/af_firequalizer: add min_phase option

2017-08-22 Thread Muhammad Faiz
Signed-off-by: Muhammad Faiz --- doc/filters.texi | 3 + libavfilter/af_firequalizer.c | 147 +- 2 files changed, 147 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 3b5a38fc9f..bd88665c89 100644 --- a/do

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/aacdec_template: Fix running cleanup in decode_ics_info()

2017-08-22 Thread Michael Niedermayer
On Mon, Aug 21, 2017 at 03:23:09PM -0700, Alex Converse wrote: > On Sun, Aug 20, 2017 at 5:15 PM, Michael Niedermayer > wrote: > > > > Fixes: out of array read > > Fixes: 2873/clusterfuzz-testcase-minimized-5924145713905664 > > > > Found-by: continuous fuzzing process > > https://github.com/googl

[FFmpeg-devel] [PATCH] configure: Fix DEF file post-processing with LTO enabled.

2017-08-22 Thread Kacper Michajłow
With LTO enabled exported symbol entry looks like: av_audio_convert @3 DATA In order to maintain valid format we need to strip everything after @. This patch fixes linking libraries compiled with MinGW toolchain with LTO enabled. Signed-off-by: Kacper Michajłow --- configure | 4 ++-- 1 file

[FFmpeg-devel] (no subject)

2017-08-22 Thread Rodrigo Severo
Hi, My company does some video recording and internal streaming. Our current solution (on Ubuntu 16.10 servers) uses ffmpeg and ffserver (versions 3.0.7). It works great. Unfortunately, on Ubuntu 17.04, it stopped working. I believe the problems I'm facing are related to the deprecation of ffse

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-08-22 Thread Maksym Veremeyenko
22.08.2017 21:06, Marton Balint пише: On Fri, 18 Aug 2017, Maksym Veremeyenko wrote: [...] Thanks for all the fixes. Is it ok to apply this version, or we are still waiting for some V3 SDK stuff? i received updated v3 SDK with a fixed issues i noticed, but i will ask about next release dat

Re: [FFmpeg-devel] [PATCH 1/1] libavdevice/decklink: configurablity to set max queue size

2017-08-22 Thread Marton Balint
On Fri, 18 Aug 2017, Patagar, Ravindra wrote: Hi Marton, Thanks for the review. Please find the updated patch attached. Thanks, applied. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpe

Re: [FFmpeg-devel] [PATCH 2/2] fate: add test vector aac-al04sf_48

2017-08-22 Thread Michael Niedermayer
On Mon, Aug 21, 2017 at 04:22:15PM -0700, Alex Converse wrote: > --- > tests/fate/aac.mak | 4 > 1 file changed, 4 insertions(+) where can i find the files to test & upload to fate samples ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's

Re: [FFmpeg-devel] [PATCH]lavc/put_bits: Remove usage of BITSTREAM_WRITER_LE.

2017-08-22 Thread Ivan Kalvachev
On 8/22/17, Ronald S. Bultje wrote: > Hi, > > On Mon, Aug 21, 2017 at 11:16 AM, Carl Eugen Hoyos > wrote: > >> Hi! >> >> Attached patch tries to slightly simplify and clean up the usage of >> put_bits* in libavcodec: put_bits_le() functions exist for the >> little-endian G.726 encoder, so the def

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: Add tile threading support

2017-08-22 Thread Ronald S. Bultje
Hi, overall pretty good. Nice performance improvement. We typically note performance improvement as a/b-1, not 1-b/a, so if runtime with 2 threads is 6 seconds and with 1 thread is 10 seconds, the improvement is not 1-6/10=0.4=40%, but rather 10/6-1=0.67=67%. On Tue, Aug 22, 2017 at 7:59 PM, Ilia

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-22 Thread Michael Niedermayer
On Sun, Aug 20, 2017 at 11:56:47AM -0700, Vitaly Buka wrote: > Signed integer overflow is undefined behavior. > Detected with clang and -fsanitize=signed-integer-overflow > > Signed-off-by: Vitaly Buka > --- > libavcodec/utils.c| 2 +- > libavformat/aviobuf.c | 2 ++ > libavformat/mov.c

Re: [FFmpeg-devel] [PATCH 2/2] fate: add test vector aac-al04sf_48

2017-08-22 Thread Alex Converse
On Tue, Aug 22, 2017 at 3:23 PM, Michael Niedermayer wrote: > On Mon, Aug 21, 2017 at 04:22:15PM -0700, Alex Converse wrote: >> --- >> tests/fate/aac.mak | 4 >> 1 file changed, 4 insertions(+) > > where can i find the files to test & upload to fate samples ? > The files are part of the off

[FFmpeg-devel] [PATCH] avcodec/vorbisenc: Improve documentation

2017-08-22 Thread Tyler Jones
Signed-off-by: Tyler Jones --- This patch applies cleanly onto "[PATCH 6/6] avcodec/vorbisenc: Add support for mono streams". libavcodec/vorbis_enc_data.h | 20 ++-- libavcodec/vorbisenc.c | 43 +-- libavcodec/vorbisenc.h | 20 +

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-08-22 Thread Maksym Veremeyenko
22.08.2017 23:14, Maksym Veremeyenko пише: [...] One more thing I noticed testing, maybe you can take a look: rgba and rgb0 format is not working (I used the V1 SDK), only audio frames are received, but no apparent error is shown. On the other hand, bgr0 and bgra formats do work. If you can't f