Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec: add Dolby E decoder

2017-07-19 Thread Paul B Mahol
On 7/1/17, foo86 wrote: > --- > configure | 1 + > doc/general.texi| 1 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 + > libavcodec/dolby_e.c| 707 > +++

Re: [FFmpeg-devel] [PATCH] libavformat/fifo: Fix initialization of underlying AVFormatContext

2017-07-19 Thread Jan Sebechlebsky
On 07/13/2017 01:15 PM, Jan Sebechlebsky wrote: I'll apply the patch in a few days with modified commit message. Jan Applied... ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCHv2 1/2] avdevice/decklink_dec: add support for decoding teletext from 10bit ancillary data

2017-07-19 Thread John Warburton
On Tue, Jul 18, 2017 at 6:10 PM, Marton Balint wrote: > On Sat, 8 Jul 2017, Marton Balint wrote: > >> This also add supports for 4K DeckLink cards because they always output the >> ancillary data in 10-bit. >> >> v2: >> - only try teletext decoding for 576i PAL mode >> - some comments as requested

Re: [FFmpeg-devel] [PATCH 1/3 v2] avutil: merge slice threading implementation from avcodec and avfilter

2017-07-19 Thread Muhammad Faiz
On Tue, Jul 18, 2017 at 2:14 PM, Muhammad Faiz wrote: > On Wed, Jul 12, 2017 at 8:44 PM, Muhammad Faiz wrote: >> Rework it to improve performance. Now mutex is not shared by workers, >> instead each worker has its own mutex and condition variable. This >> reduces lock contention between workers.

[FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

2017-07-19 Thread Tobias Rapp
Signed-off-by: Tobias Rapp --- tests/fate/filter-video.mak | 17 + tests/ref/fate/filter-refcmp-psnr-rgb | 45 +++ tests/ref/fate/filter-refcmp-psnr-yuv | 45 +++ tests/ref/fate/filter-refcmp-ssim-rgb | 30 +

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-19 Thread Nicolas George
Le decadi 30 messidor, an CCXXV, Rostislav Pehlivanov a écrit : > Its a crappy format, no reason to blame anyone else but the format. > We have plenty of crappy formats which have no clear separation between > packets so demuxers have to give not-entirely-demuxed packets to the > decoder which also

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-19 Thread Paul B Mahol
On 7/19/17, Nicolas George wrote: > Le decadi 30 messidor, an CCXXV, Rostislav Pehlivanov a ecrit : >> Its a crappy format, no reason to blame anyone else but the format. >> We have plenty of crappy formats which have no clear separation between >> packets so demuxers have to give not-entirely-dem

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-19 Thread Nicolas George
Le primidi 1er thermidor, an CCXXV, Paul B Mahol a écrit : > Except when those standards need to be applied to your work. Yet another ad-hominem attack. -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ff

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-19 Thread Paul B Mahol
On 7/19/17, Nicolas George wrote: > Le decadi 30 messidor, an CCXXV, Rostislav Pehlivanov a ecrit : >> Its a crappy format, no reason to blame anyone else but the format. >> We have plenty of crappy formats which have no clear separation between >> packets so demuxers have to give not-entirely-dem

Re: [FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

2017-07-19 Thread Ronald S. Bultje
Hi Tobias, On Wed, Jul 19, 2017 at 5:40 AM, Tobias Rapp wrote: > +# FIXME: override CPUFLAGS to avoid failure on x86 (issue #6519) I'm assuming this is because of floating point rounding differences. Is it possible to use a test similar to the floating-point codec tests that allows slight offs

Re: [FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

2017-07-19 Thread Paul B Mahol
On 7/19/17, Ronald S. Bultje wrote: > Hi Tobias, > > On Wed, Jul 19, 2017 at 5:40 AM, Tobias Rapp wrote: > >> +# FIXME: override CPUFLAGS to avoid failure on x86 (issue #6519) > This is unacceptable hack. > > I'm assuming this is because of floating point rounding differences. Is it > possible

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/scale: More descriptive in/ref/out logging

2017-07-19 Thread Ronald S. Bultje
Hi Kevin, On Wed, Jul 19, 2017 at 2:01 AM, Kevin Mark wrote: > Hello all, > > Just wondering if anyone had any thoughts on the grepability issue, > which I believe is the only potential issue/breaking change with this > patch. You wrote something like: "ffmpeg [...] scale2ref=0:0 [...] -v ver

Re: [FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

2017-07-19 Thread Ronald S. Bultje
Hi, On Wed, Jul 19, 2017 at 6:38 AM, Paul B Mahol wrote: > On 7/19/17, Ronald S. Bultje wrote: > > Hi Tobias, > > > > On Wed, Jul 19, 2017 at 5:40 AM, Tobias Rapp > wrote: > > > >> +# FIXME: override CPUFLAGS to avoid failure on x86 (issue #6519) > > > > This is unacceptable hack. > > > > > I'

Re: [FFmpeg-devel] [PATCH] avfilter: Add blue and violet noise generation filters

2017-07-19 Thread Paul B Mahol
On 7/19/17, geo...@spotify.com wrote: > From: George Boyle > > For the blue and violet noise, I took the pink and brown noise > respectively and subtracted the offsets instead of adding them. When I > eyeball the frequency spectrum of the resulting outputs it looks correct > to me, i.e. the blue

Re: [FFmpeg-devel] [PATCH] avfilter: Add blue and violet noise generation filters

2017-07-19 Thread Moritz Barsnick
On Wed, Jul 19, 2017 at 07:59:33 +0200, geo...@spotify.com wrote: > For the blue and violet noise, I took the pink and brown noise > respectively and subtracted the offsets instead of adding them. When I Cool. > -{ "color","set noise color", OFFSET(color), > AV_OPT_TYPE_INT,

Re: [FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

2017-07-19 Thread Tobias Rapp
On 19.07.2017 12:45, Ronald S. Bultje wrote: Hi, On Wed, Jul 19, 2017 at 6:38 AM, Paul B Mahol wrote: On 7/19/17, Ronald S. Bultje wrote: Hi Tobias, On Wed, Jul 19, 2017 at 5:40 AM, Tobias Rapp wrote: +# FIXME: override CPUFLAGS to avoid failure on x86 (issue #6519) This is unacce

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec: add Dolby E decoder

2017-07-19 Thread Moritz Barsnick
On Sat, Jul 01, 2017 at 17:03:46 +0300, foo86 wrote: > +static av_cold void init_tables(void) > +{ > +int i, j; > + > +for (i = 1; i < 17; i++) > +mantissa_tab1[i][0] = 1.0 / (1 << i - 1); > + > +for (i = 2; i < 16; i++) { > +mantissa_tab1[i][1] = 1.0 / ((1 << i) - 1);

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-19 Thread Nicolas George
Le primidi 1er thermidor, an CCXXV, Paul B Mahol a écrit : > If you had ever write parser, you would know that this above is giberish. Please enlighten us. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel ma

Re: [FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

2017-07-19 Thread Nicolas George
Hi. Thanks for the patch. Here are comments unrelated to the issues of asm failure. Le primidi 1er thermidor, an CCXXV, Tobias Rapp a écrit : > Signed-off-by: Tobias Rapp > --- > tests/fate/filter-video.mak | 17 + > tests/ref/fate/filter-refcmp-psnr-rgb | 45 > +++

Re: [FFmpeg-devel] [PATCH] avfilter: Add blue and violet noise generation filters

2017-07-19 Thread George Boyle
On Wed, Jul 19, 2017 at 1:39 PM, Moritz Barsnick wrote: > On Wed, Jul 19, 2017 at 07:59:33 +0200, geo...@spotify.com wrote: > > For the blue and violet noise, I took the pink and brown noise > > respectively and subtracted the offsets instead of adding them. When I > > Cool. > > > -{ "color",

[FFmpeg-devel] [PATCH] avfilter: Add blue and violet noise generation filters

2017-07-19 Thread george
From: George Boyle For the blue and violet noise, I took the pink and brown noise respectively and subtracted the offsets instead of adding them. When I eyeball the frequency spectrum of the resulting outputs it looks correct to me, i.e. the blue graph appears to be a mirror image of the pink, an

Re: [FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

2017-07-19 Thread Tobias Rapp
On 19.07.2017 14:24, Nicolas George wrote: Hi. Thanks for the patch. Here are comments unrelated to the issues of asm failure. Le primidi 1er thermidor, an CCXXV, Tobias Rapp a écrit : Signed-off-by: Tobias Rapp --- tests/fate/filter-video.mak | 17 + tests/ref/fate/filt

Re: [FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

2017-07-19 Thread Nicolas George
Le primidi 1er thermidor, an CCXXV, Tobias Rapp a écrit : > Indeed they are remainders from previous edits. It seems that stripping any > whitespace within the filter string is enough to ensure that it is passed as > one argument token to ffmpeg. So fixed locally. I suppose you left the quotes, ot

Re: [FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

2017-07-19 Thread Tobias Rapp
On 19.07.2017 17:06, Nicolas George wrote: Le primidi 1er thermidor, an CCXXV, Tobias Rapp a écrit : Indeed they are remainders from previous edits. It seems that stripping any whitespace within the filter string is enough to ensure that it is passed as one argument token to ffmpeg. So fixed loc

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-19 Thread Paul B Mahol
On 7/19/17, Nicolas George wrote: > Le primidi 1er thermidor, an CCXXV, Paul B Mahol a ecrit : >> If you had ever write parser, you would know that this above is giberish. > > Please enlighten us. Are there more than one Nicolas here? Anyway the input can be of any size so one would need to hold

Re: [FFmpeg-devel] [PATCH] hwupload_cuda : Add 10/16 bit format support

2017-07-19 Thread Michael Niedermayer
On Tue, Jul 18, 2017 at 10:34:20AM +, Yogender Gupta wrote: > Added 10/16bit formats to hwupload_cuda. > > Thanks, > Yogender > > --- > This email message is for the sole use of the intended recipient(s) and may

Re: [FFmpeg-devel] tsan warning about a data race in libavcodec/h264_direct.c

2017-07-19 Thread Ronald S. Bultje
Hi, On Wed, Jul 19, 2017 at 12:26 AM, Wan-Teh Chang < wtc-at-google@ffmpeg.org> wrote: > WARNING: ThreadSanitizer: data race (pid=116081) > Read of size 4 at 0x7b720118 by thread T3 (mutexes: write M2239): > #0 pred_temp_direct_motion ffmpeg/libavcodec/h264_direct.c:505:9 > (ffmpeg+

Re: [FFmpeg-devel] [PATCHv2 1/2] avdevice/decklink_dec: add support for decoding teletext from 10bit ancillary data

2017-07-19 Thread Marton Balint
On Wed, 19 Jul 2017, John Warburton wrote: On Tue, Jul 18, 2017 at 6:10 PM, Marton Balint wrote: On Sat, 8 Jul 2017, Marton Balint wrote: This also add supports for 4K DeckLink cards because they always output the ancillary data in 10-bit. v2: - only try teletext decoding for 576i PAL mode

Re: [FFmpeg-devel] [PATCH] Add tonemap filter

2017-07-19 Thread Michael Niedermayer
On Tue, Jul 18, 2017 at 09:33:46PM +0200, Vittorio Giovara wrote: > Based off mpv automatic tonemapping capabilities. > > Signed-off-by: Vittorio Giovara > --- > Updated following an off-list review. > Vittorio > > doc/filters.texi | 104 > libavfilter/Makefile |

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-19 Thread Michael Niedermayer
On Tue, Jul 18, 2017 at 05:03:52PM +0200, Peter Große wrote: > Signed-off-by: Peter Große > --- > tests/fate/filter-video.mak | 5 + > tests/ref/fate/filter-overlay-main-alpha | 15 +++ > 2 files changed, 20 insertions(+) > create mode 100644 tests/ref/fate/filter-o

Re: [FFmpeg-devel] tsan warning about a data race in libavcodec/h264_direct.c

2017-07-19 Thread Wan-Teh Chang
Hi Ronald, Thank you for the reply. On Wed, Jul 19, 2017 at 8:56 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Jul 19, 2017 at 12:26 AM, Wan-Teh Chang < > wtc-at-google@ffmpeg.org> wrote: > >> WARNING: ThreadSanitizer: data race (pid=116081) >> Read of size 4 at 0x7b720118 by thread T3

Re: [FFmpeg-devel] tsan warning about a data race in libavcodec/h264_direct.c

2017-07-19 Thread Ronald S. Bultje
Hi Wan-Teh, On Wed, Jul 19, 2017 at 2:31 PM, Wan-Teh Chang wrote: > Hi Ronald, > > Thank you for the reply. > > On Wed, Jul 19, 2017 at 8:56 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Jul 19, 2017 at 12:26 AM, Wan-Teh Chang < > > wtc-at-google@ffmpeg.org> wrote: > > > >> WARNING:

[FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-19 Thread Peter Große
Signed-off-by: Peter Große --- Updated version of the test. I was able to reproduce your checksums only after removing --disable-optimizations --disable-mmx --disable-stripping from my configure command. I thought optimizations should have no impact on the result?! tests/fate/filter-video.m

Re: [FFmpeg-devel] [PATCH] avcodec/dca: remove GetBitContext usage from avpriv_dca_parse_core_frame_header()

2017-07-19 Thread Michael Niedermayer
On Wed, Jul 19, 2017 at 01:57:21AM -0300, James Almer wrote: > This prevents ABI issues with GetBitContext. > > Signed-off-by: James Almer > --- > libavcodec/dca.c| 15 ++- > libavcodec/dca.h| 7 +-- > libavcodec/dca_core.c | 2 +- > libavcodec/dca_parser.c |

[FFmpeg-devel] [PATCH] libavdevice: fix ff_reverse shared build breakage with decklink_dec

2017-07-19 Thread Marton Balint
Similar to libavcodec, duplicate ff_reverse table in case of a shared build. Signed-off-by: Marton Balint --- libavdevice/Makefile | 1 + libavdevice/reverse.c | 1 + 2 files changed, 2 insertions(+) create mode 100644 libavdevice/reverse.c diff --git a/libavdevice/Makefile b/libavdevice/Make

[FFmpeg-devel] [PATCH] avcodec/dca: remove GetBitContext usage from avpriv_dca_parse_core_frame_header()

2017-07-19 Thread James Almer
This prevents potential ABI issues with GetBitContext. Signed-off-by: James Almer --- libavcodec/dca.c| 12 +++- libavcodec/dca.h| 7 +-- libavcodec/dca_core.c | 2 +- libavcodec/dca_parser.c | 4 +--- libavformat/dtsdec.c| 4 +--- 5 files changed, 19 insert

[FFmpeg-devel] [PATCH] Add tonemap filter

2017-07-19 Thread Vittorio Giovara
Based off mpv automatic tonemapping capabilities. Signed-off-by: Vittorio Giovara --- Fixed documentation build. Vittorio doc/filters.texi | 106 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_tonemap.c | 310 +

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-19 Thread Reimar Döffinger
On 19.07.2017, at 12:03, Nicolas George wrote: > Le decadi 30 messidor, an CCXXV, Rostislav Pehlivanov a écrit : > >> I think the image2 demuxer shouldn't handle this type of junk/useless data >> filtering and would rather see a separate demuxer like the current patch >> which deals with crap. >

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-19 Thread Reimar Döffinger
On 19.07.2017, at 12:03, Nicolas George wrote: > What I do insist on, is this: > > Look at the find_size() function in this patch: > https://ffmpeg.org/pipermail/ffmpeg-devel/2017-July/213076.html > > Then look at the fits_read_header() in this patch: > https://ffmpeg.org/pipermail/ffmpeg-devel/

Re: [FFmpeg-devel] [PATCHv2 1/2] avdevice/decklink_dec: add support for decoding teletext from 10bit ancillary data

2017-07-19 Thread Reimar Döffinger
On 19.07.2017, at 18:48, Marton Balint wrote: > > On Wed, 19 Jul 2017, John Warburton wrote: > >> On Tue, Jul 18, 2017 at 6:10 PM, Marton Balint wrote: >>> On Sat, 8 Jul 2017, Marton Balint wrote: >>> This also add supports for 4K DeckLink cards because they always output the ancill

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-19 Thread Michael Niedermayer
On Tue, Jul 18, 2017 at 11:49:26AM -0700, Dale Curtis wrote: > Updated patch that fixes other ctts modification code to use the new > ctts_allocated_size value; I've verified this passes fate. > > - dale > > On Tue, Jul 18, 2017 at 9:53 AM, Dale Curtis > wrote: > > > Resending as it's own messa

[FFmpeg-devel] Webp support

2017-07-19 Thread GT Wang
Hello dev, ffmpeg not support webp right ? In the future, ffmpeg will support this format ? Thanks. -- GT Wang Email:ili...@gmail.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Webp support

2017-07-19 Thread Lou Logan
On Tue, Jul 18, 2017, at 04:00 AM, GT Wang wrote: > Hello dev, > > ffmpeg not support webp right ? FFmpeg natively supports WebP decoding, demuxing, and muxing. FFmpeg can also encode WebP if configured with --enable-libwebp. ___ ffmpeg-devel mailing l

[FFmpeg-devel] [PATCH] support set words' space

2017-07-19 Thread efren yang
0001-support-set-words-space.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] vf_drawtext: support to set word spacing while drawing text. ./ffmpeg -i input -vf drawtext="word_spacing=10:textfile=1.txt:fontfile=demo.ttf" -f flv 1.flv could set word spacin

2017-07-19 Thread efren yang
Signed-off-by: efren yang --- libavfilter/vf_drawtext.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index f6151443bb..137ae5891e 100644 --- a/libavfilter/vf_drawtext.c +++ b/libavfilter/vf_drawtext.c @@ -162,6 +162,7 @@ typedef stru

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-19 Thread Dale Curtis
Thanks will take a look. Is this test not part of fate? make fate passed for me. The attached patch fixes this; the issue was that the index entries are 1 to 1 with ctts values. When samples are added without ctts entries we'd just initialize a single ctts entry with a count of 5. This left a gap i

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-19 Thread Dale Curtis
I found some samples with ctts and trun boxes, so I've updated the patch to handle these cases since I don't know how common they are in the wild and it's an easy fix. I'll send a followup patch if this one is accepted to remove support for > 1 count ctts entries. - dale On Wed, Jul 19, 2017 at 7

[FFmpeg-devel] [PATCH V3] examples/hw_decode: Add a HWAccel decoding example.

2017-07-19 Thread Jun Zhao
V3: re-work to support the other hwaccels, just test with vaapi, dxva2|d3d11va|videotoolbox might work as well. V2: re-work with new hw decoding API. From bd8cbd5c16be3001b950f0c4ae3548909a396bc6 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 20 Jul 2017 00:58:56 -0400 Subject: [PATCH V3] exa

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix hls fmp4 extention name bug

2017-07-19 Thread Steven Liu
ticket-id: #6541 when use hls fmp4 muxer, the extention name is not .m4s, this code can fix it. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 8a233270

Re: [FFmpeg-devel] [PATCH V3] examples/hw_decode: Add a HWAccel decoding example.

2017-07-19 Thread Steven Liu
2017-07-20 13:29 GMT+08:00 Jun Zhao : > V3: re-work to support the other hwaccels, just test with vaapi, > dxva2|d3d11va|videotoolbox might work as well. > V2: re-work with new hw decoding API. > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.or