[FFmpeg-devel] [PATCH] Add FITS Decoder

2017-07-02 Thread Paras Chadha
Made all the changes suggested Added a new function which reads a header FITS line safely. It also makes it more modular Added an option for the user to enter the value to be used in place of BLANK pixels Refactored code using macros to make it short Signed-off-by: Paras Chadha --- Changelog

Re: [FFmpeg-devel] [PATCH] Add FITS Decoder

2017-07-02 Thread Paras Chadha
On Fri, Jun 30, 2017 at 6:38 PM, Nicolas George wrote: > Hi. A few technical / cosmetic remarks below. I do not know the FITS > format itself more than in passing. > > Le duodi 12 messidor, an CCXXV, Paras Chadha a écrit : > > Made the changes suggested above > > > > Signed-off-by: Paras Chadha

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-02 Thread wm4
On Sun, 2 Jul 2017 00:09:42 +0200 Michael Niedermayer wrote: > This reduces the number of strstr() calls per byte > This diasalows empty tags like '< >' as well as '<' in tags like '' > > Fixes timeout > Fixes: 1817/clusterfuzz-testcase-minimized-5104230530547712 > > Found-by: continuous fuzzi

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_template: Fix undefined integer overflow in apply_tns()

2017-07-02 Thread wm4
On Sun, 2 Jul 2017 04:28:54 +0200 Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: -2147483648 - 1202286525 > cannot be represented in type 'int' > Fixes: 2071/clusterfuzz-testcase-minimized-6036414271586304 > > Found-by: continuous fuzzing process > https://github.

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_template: Fix undefined integer overflow in apply_tns()

2017-07-02 Thread Michael Niedermayer
On Sun, Jul 02, 2017 at 01:14:31PM +0200, wm4 wrote: > On Sun, 2 Jul 2017 04:28:54 +0200 > Michael Niedermayer wrote: > > > Fixes: runtime error: signed integer overflow: -2147483648 - 1202286525 > > cannot be represented in type 'int' > > Fixes: 2071/clusterfuzz-testcase-minimized-603641427158

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-02 Thread Michael Niedermayer
On Sun, Jul 02, 2017 at 01:14:00PM +0200, wm4 wrote: > On Sun, 2 Jul 2017 00:09:42 +0200 > Michael Niedermayer wrote: > > > This reduces the number of strstr() calls per byte > > This diasalows empty tags like '< >' as well as '<' in tags like > > '' > > > > Fixes timeout > > Fixes: 1817/clust

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-02 Thread Rostislav Pehlivanov
On 2 July 2017 at 03:28, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: 1965219850 + 995792909 > cannot be represented in type 'int' > Fixes: part of 2096/clusterfuzz-testcase-minimized-4901566068817920 > > Found-by: continuous fuzzing process https://github.com/googl

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: properly allocate raw_buffer

2017-07-02 Thread Thilo Borgmann
Am 01.07.17 um 03:38 schrieb Paul B Mahol: > This also reverts 18f94df8. > > Fixes #5297. > > Signed-off-by: Paul B Mahol > --- > libavcodec/alsdec.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > [...] > @@ -2062,7 +2057,7 @@ static av_cold int decode_init(AVCodecContext *avct

Re: [FFmpeg-devel] [PATCH] avcodec/mlz: simplify

2017-07-02 Thread Thilo Borgmann
Am 01.07.17 um 19:03 schrieb Paul B Mahol: > On 7/1/17, Thilo Borgmann wrote: >> Am 01.07.17 um 14:42 schrieb Paul B Mahol: >>> On 7/1/17, Michael Niedermayer wrote: On Sat, Jul 01, 2017 at 02:18:17PM +0200, Paul B Mahol wrote: > On 7/1/17, Michael Niedermayer wrote: >> On Sat, Jul

Re: [FFmpeg-devel] [PATCH] avcodec/als: use planar sample formats

2017-07-02 Thread Thilo Borgmann
Am 01.07.17 um 22:23 schrieb Paul B Mahol: > This is native layout of this codec. From where is that definition? -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: properly allocate raw_buffer

2017-07-02 Thread Paul B Mahol
On 7/2/17, Thilo Borgmann wrote: > Am 01.07.17 um 03:38 schrieb Paul B Mahol: >> This also reverts 18f94df8. >> >> Fixes #5297. >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/alsdec.c | 7 +-- >> 1 file changed, 1 insertion(+), 6 deletions(-) >> [...] >> @@ -2062,7 +2057,7 @@ static

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/alsdec: call correct function for multi-channel coding

2017-07-02 Thread Thilo Borgmann
Am 01.07.17 um 22:23 schrieb Paul B Mahol: > Fixes #5942. > > Signed-off-by: Paul B Mahol > --- > libavcodec/alsdec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) OK if tested. -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.o

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: properly allocate raw_buffer

2017-07-02 Thread Thilo Borgmann
Am 02.07.17 um 16:13 schrieb Paul B Mahol: > On 7/2/17, Thilo Borgmann wrote: >> Am 01.07.17 um 03:38 schrieb Paul B Mahol: >>> This also reverts 18f94df8. >>> >>> Fixes #5297. >>> >>> Signed-off-by: Paul B Mahol >>> --- >>> libavcodec/alsdec.c | 7 +-- >>> 1 file changed, 1 insertion(+), 6

Re: [FFmpeg-devel] [PATCH] avcodec/als: use planar sample formats

2017-07-02 Thread Paul B Mahol
On 7/2/17, Thilo Borgmann wrote: > Am 01.07.17 um 22:23 schrieb Paul B Mahol: >> This is native layout of this codec. > > From where is that definition? See how samples are stored in raw buffers. Many codecs do not do interleaving and that work is left to another library. ___

Re: [FFmpeg-devel] [PATCH] avcodec/mlz: simplify

2017-07-02 Thread Paul B Mahol
On 7/2/17, Thilo Borgmann wrote: > Am 01.07.17 um 19:03 schrieb Paul B Mahol: >> On 7/1/17, Thilo Borgmann wrote: >>> Am 01.07.17 um 14:42 schrieb Paul B Mahol: On 7/1/17, Michael Niedermayer wrote: > On Sat, Jul 01, 2017 at 02:18:17PM +0200, Paul B Mahol wrote: >> On 7/1/17, Michae

[FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-02 Thread Paras Chadha
Filled buf with 0 to prevent overfow Also added checks for integer overflow Signed-off-by: Paras Chadha --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/fitsdec.c| 224 +++ libavformat/version.h| 2 +- 4 fil

Re: [FFmpeg-devel] [PATCH 0/5] hvc1 Support Cherry-Picks

2017-07-02 Thread Derek Buitenhuis
On 6/28/2017 4:41 PM, Derek Buitenhuis wrote: > Apple software and devices requrie hvc1. This patchset was originally > sent to Libav for this same purpose. > > John Stebbins (5): > movenc: use correct tag list for AVOutputFormat.codec_tag > movenc: simplify codec_tag lookup > movenc: move t

Re: [FFmpeg-devel] [PATCH 0/5] hvc1 Support Cherry-Picks

2017-07-02 Thread Paul B Mahol
On 7/2/17, Derek Buitenhuis wrote: > On 6/28/2017 4:41 PM, Derek Buitenhuis wrote: >> Apple software and devices requrie hvc1. This patchset was originally >> sent to Libav for this same purpose. >> >> John Stebbins (5): >> movenc: use correct tag list for AVOutputFormat.codec_tag >> movenc: s

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: relax opt_order limit

2017-07-02 Thread Paul B Mahol
On 6/11/16, Thilo Borgmann wrote: > > Hi, > >> Am 09.06.2016 um 03:33 schrieb Michael Niedermayer >> : >> >> Fixes: Ticket5297 >> >> Needs review by maintainer / author to check that this is ok and >> sufficient >> --- >> libavcodec/alsdec.c | 10 +- >> 1 file changed, 5 insertions(+), 5

[FFmpeg-devel] [PATCH] libavformat/gdv: Fix parsing for soundless video

2017-07-02 Thread Azamat H. Hackimov
Added 2 byte skipping if there no sound present, that fixes playback files without sound stream. --- libavformat/gdv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/gdv.c b/libavformat/gdv.c index 90692bd61c..32209320a7 100644 --- a/libavformat/gdv.c +++ b/libavformat/gdv.c @@

[FFmpeg-devel] [PATCH] libavformat/gdv: Fix parsing for soundless video

2017-07-02 Thread Azamat H. Hackimov
Added 2 byte skipping if there no sound present, that fixes playback files without sound stream. --- libavformat/gdv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/gdv.c b/libavformat/gdv.c index 90692bd61c..32209320a7 100644 --- a/libavformat/gdv.c +++ b/libavformat/gdv.c @@

[FFmpeg-devel] [PATCH] avcodec/interplayvideo: Check sizes of decode buffers

2017-07-02 Thread Hein-Pieter van Braam
Fixes: 6503 crash with fuzzed file --- libavcodec/interplayvideo.c | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/interplayvideo.c b/libavcodec/interplayvideo.c index d6f484a..4b0e36d 100644 --- a/libavcodec/interplayvideo.c +++ b/libavcodec/interplayvideo.c @@ -972,6 +972,

Re: [FFmpeg-devel] [PATCH] avcodec/interplayvideo: Check sizes of decode buffers

2017-07-02 Thread Hein-Pieter van Braam
On Sun, 2017-07-02 at 23:24 +0200, Hein-Pieter van Braam wrote: > Fixes: 6503 crash with fuzzed file > --- I messed this up, I'll try to be more careful next time. v2 coming. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman

[FFmpeg-devel] [PATCH v2] avcodec/interplayvideo: Check sizes of decode buffers

2017-07-02 Thread Hein-Pieter van Braam
Fixes: 6503 crash with fuzzed file Signed-off-by: Hein-Pieter van Braam --- libavcodec/interplayvideo.c | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/interplayvideo.c b/libavcodec/interplayvideo.c index d6f484a..86530e6 100644 --- a/libavcodec/interplayvideo.c +++ b/liba

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-02 Thread Moritz Barsnick
On Sun, Jul 02, 2017 at 20:48:17 +0530, Paras Chadha wrote: > +int64_t header_size = 0, data_size=0, ret, pcount=0, gcount=1, d; [...] > +header_size += 80; [...] > +header_size += 80; [...] > +header_size += 80; [...] > +for (i = 0; i < naxis; i++) { [...] > +header_siz

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-02 Thread Michael Niedermayer
On Sun, Jul 02, 2017 at 02:24:53PM +0100, Rostislav Pehlivanov wrote: > On 2 July 2017 at 03:28, Michael Niedermayer wrote: > > > Fixes: runtime error: signed integer overflow: 1965219850 + 995792909 > > cannot be represented in type 'int' > > Fixes: part of 2096/clusterfuzz-testcase-minimized-49

Re: [FFmpeg-devel] [PATCH] avfilter: add VMAF filter

2017-07-02 Thread Michael Niedermayer
On Sun, Jul 02, 2017 at 11:34:11AM +0530, Ashish Singh wrote: > This patch fixes most of the styling and coding issues of the previous VMAF > patches. > > --- > configure| 5 + > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_vmaf.c|

Re: [FFmpeg-devel] [PATCH 2/5] movenc: simplify codec_tag lookup

2017-07-02 Thread Michael Niedermayer
On Wed, Jun 28, 2017 at 04:41:59PM +0100, Derek Buitenhuis wrote: > From: John Stebbins > > mux.c init_muxer() already sets codec_tag correctly in the cases > simplified here. > > This also adds the capability to support alternative tags for the > same codec_id. > > (cherry picked from commit f

Re: [FFmpeg-devel] [PATCH 1/5] movenc: use correct tag list for AVOutputFormat.codec_tag

2017-07-02 Thread James Almer
On 6/28/2017 12:41 PM, Derek Buitenhuis wrote: > From: John Stebbins > > ff_mp4_obj_type contains the wrong type of tags for > AVOutputFormat.codec_tag. AVOutputFormat.codec_tag is used to > validate AVCodecParameters.codec_tag so needs to be the same > type of tag. > > Creates new tag lists for

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: remove unused header

2017-07-02 Thread Steven Liu
2017-07-02 4:24 GMT+08:00 Paul B Mahol : > Signed-off-by: Paul B Mahol > --- > libavcodec/alsdec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c > index 31e95e2..ac59885 100644 > --- a/libavcodec/alsdec.c > +++ b/libavcodec/alsdec.c > @@ -31,7 +