Re: [FFmpeg-devel] [PATCH] avfilter: take_samples: do not directly return frame when samples are skipped

2017-05-20 Thread Paul B Mahol
On 5/18/17, Muhammad Faiz wrote: > Should fix Ticket6349. > Modifying data pointer may make it unaligned. > > Also change frame->nb_samples < max to frame->nb_samples <= max. > This improves performance. Benchmark: > ./ffmpeg -filter_complex "aevalsrc=0:n=1166,firequalizer=fixed=on" -f null > null

Re: [FFmpeg-devel] [PATCH] avfilter: take_samples: do not directly return frame when samples are skipped

2017-05-20 Thread Nicolas George
Le primidi 1er prairial, an CCXXV, Paul B Mahol a écrit : > LGTM I want time to comment. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] [PATCH] avfilter: take_samples: do not directly return frame when samples are skipped

2017-05-20 Thread Paul B Mahol
On 5/20/17, Nicolas George wrote: > Le primidi 1er prairial, an CCXXV, Paul B Mahol a ecrit : >> LGTM > > I want time to comment. No, you just want time to prolong this nightmare. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/m

Re: [FFmpeg-devel] [PATCH] avfilter: take_samples: do not directly return frame when samples are skipped

2017-05-20 Thread Nicolas George
Le primidi 1er prairial, an CCXXV, Paul B Mahol a écrit : > No, you just want time to prolong this nightmare. Ad-hominem, non-constructive, fanning the flame. Muhammad: do not push this patch before I comment. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] avfilter: take_samples: do not directly return frame when samples are skipped

2017-05-20 Thread Nicolas George
Le decadi 30 floréal, an CCXXV, Muhammad Faiz a écrit : > Every patch that can fix the crash of > ffmpeg -i clip.wav -af alimiter -c:a mp3 -b:a 128k -ar 48k -f null - > can claim that it fixes ticket 6349. > > Other cases should be in separate tickets. No, you are confusing the bug with its sympt

Re: [FFmpeg-devel] New to the list... thinking about a feature

2017-05-20 Thread Pedro Andres Aranda Gutierrez
Thanks for the encourgament. Patch will follow shortly :-) Best, /PA On 19 May 2017 at 01:49, Carl Eugen Hoyos wrote: > 2017-05-18 12:20 GMT+02:00 Pedro Andres Aranda Gutierrez < > paag...@gmail.com>: > > > I'm completely new to the list but have a couple of years experience as a > > user. I ha

[FFmpeg-devel] [PATCH] ffmpeg/ffprobe: Change verbosity level for reporting of empty streams in a Transport Stream

2017-05-20 Thread Pedro Andres Aranda Gutierrez
Rationale: Some satellite PVRs store empty streams in recorded transport stream. The list is of empty streams is sometimes too big to fit one screen-full and you can't see what ffmpeg is actually doing. Proposal: Make the verbosity level required to show empty streams AV_LOG_VERBOSE instead of AV

Re: [FFmpeg-devel] [PATCH] avfilter: take_samples: do not directly return frame when samples are skipped

2017-05-20 Thread Muhammad Faiz
On Sat, May 20, 2017 at 4:56 PM, Nicolas George wrote: > Le decadi 30 floréal, an CCXXV, Muhammad Faiz a écrit : >> Every patch that can fix the crash of >> ffmpeg -i clip.wav -af alimiter -c:a mp3 -b:a 128k -ar 48k -f null - >> can claim that it fixes ticket 6349. >> >> Other cases should be in s

[FFmpeg-devel] [PATCH v2] avfilter: take_samples: do not directly return frame when samples are skipped

2017-05-20 Thread Muhammad Faiz
Modifying data pointer when skipping samples may make it unaligned. Workaround for Ticket6349. This should fix the crash of ticket's testcase and a crash/regression with avxsynth (reported by Michael Niedermayer). Also change frame->nb_samples < max to frame->nb_samples <= max. This improves perf

Re: [FFmpeg-devel] [PATCH] lavf/mov: make invalid mdhd time_scale default to 1 instead of erroring out

2017-05-20 Thread Matthieu Bouron
On Sat, May 20, 2017 at 12:28:53AM +0200, Michael Niedermayer wrote: > On Wed, May 17, 2017 at 02:58:12PM +0200, Matthieu Bouron wrote: > > On Wed, May 17, 2017 at 01:56:13PM +0200, Matthieu Bouron wrote: > > > On Fri, May 12, 2017 at 11:12:12PM +0200, Michael Niedermayer wrote: > > > > On Thu, May

Re: [FFmpeg-devel] [PATCH V3] lavc/vaapi_encode_h264: Enable MB rate control.

2017-05-20 Thread Mark Thompson
On 19/05/17 14:10, Mark Thompson wrote: > On 19/05/17 00:43, Jun Zhao wrote: >> >> On 2017/5/14 12:26, Jun Zhao wrote: >>> V3: - Fix build error with old VAAPI version. >>> V2: - Refine the name/value type to mb_rate_control/bool. >>> - Only supported GEN9+ (SKL/APL/KBL/...) >>> - i965 driv

Re: [FFmpeg-devel] [PATCH v2] avfilter: take_samples: do not directly return frame when samples are skipped

2017-05-20 Thread Muhammad Faiz
On Sat, May 20, 2017 at 5:44 PM, Muhammad Faiz wrote: > Modifying data pointer when skipping samples may make it unaligned. > Workaround for Ticket6349. > > This should fix the crash of ticket's testcase and a crash/regression > with avxsynth (reported by Michael Niedermayer). > > Also change fram

[FFmpeg-devel] [PATCH] avcodec/takdec: Fix multiple runtime error: signed integer overflow: -512 * 4563386 cannot be represented in type 'int'

2017-05-20 Thread Michael Niedermayer
Fixes: 1706/clusterfuzz-testcase-minimized-6112772670619648 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/takdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/l

Re: [FFmpeg-devel] [PATCH v2] avfilter: take_samples: do not directly return frame when samples are skipped

2017-05-20 Thread Muhammad Faiz
On Sat, May 20, 2017 at 7:33 PM, Muhammad Faiz wrote: > On Sat, May 20, 2017 at 5:44 PM, Muhammad Faiz wrote: >> Modifying data pointer when skipping samples may make it unaligned. >> Workaround for Ticket6349. >> >> This should fix the crash of ticket's testcase and a crash/regression >> with av

Re: [FFmpeg-devel] [PATCH 2/4] h264dec: be more explicit in handling container cropping

2017-05-20 Thread James Almer
On 5/11/2017 9:56 AM, Michael Niedermayer wrote: > On Wed, May 10, 2017 at 11:06:52PM -0300, James Almer wrote: >> On 5/10/2017 9:55 PM, Michael Niedermayer wrote: >>> On Wed, May 10, 2017 at 10:41:30AM -0300, James Almer wrote: On 5/9/2017 11:56 PM, Michael Niedermayer wrote: > On Mon, Ma

Re: [FFmpeg-devel] [PATCH] avcodec/takdec: Fix multiple runtime error: signed integer overflow: -512 * 4563386 cannot be represented in type 'int'

2017-05-20 Thread Marton Balint
On Sat, 20 May 2017, Michael Niedermayer wrote: Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg This URL is a 404 for me, I guess the correct URL is https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Regards, Marton __

Re: [FFmpeg-devel] [PATCH v2] avfilter: take_samples: do not directly return frame when samples are skipped

2017-05-20 Thread Nicolas George
Le primidi 1er prairial, an CCXXV, Muhammad Faiz a écrit : > > I will push this soon. > Pushed and backported to 3.3 branch. Well, I was probably ok with this patch, but we will never know, will we? Can you explain the concept behind posting a patch for review and then pushing it before anybody c

[FFmpeg-devel] [PATCH 3/3] avcodec/mlpdec: Check quant_step_size against huff_lsbs

2017-05-20 Thread Michael Niedermayer
This reorders the operations so as to avoid computations with the above arguments before they have been initialized. Fixes part of 1708/clusterfuzz-testcase-minimized-5035111957397504 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by

[FFmpeg-devel] [PATCH 2/3] avcodec/mlpdec: Fix runtime error: shift exponent -5 is negative

2017-05-20 Thread Michael Niedermayer
Fixes part of 1708/clusterfuzz-testcase-minimized-5035111957397504 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mlpdec.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --gi

[FFmpeg-devel] [PATCH 1/3] avcodec/escape124: Check depth against num_superblocks

2017-05-20 Thread Michael Niedermayer
Fixes: runtime error: left shift of 66184 by 15 places cannot be represented in type 'int' Fixes: 1707/clusterfuzz-testcase-minimized-6502767008940032 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libav

Re: [FFmpeg-devel] [PATCH] avcodec/takdec: Fix multiple runtime error: signed integer overflow: -512 * 4563386 cannot be represented in type 'int'

2017-05-20 Thread Michael Niedermayer
On Sat, May 20, 2017 at 07:26:50PM +0200, Marton Balint wrote: > > On Sat, 20 May 2017, Michael Niedermayer wrote: > > >Found-by: continuous fuzzing process > >https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > > This URL is a 404 for me, I guess the correct URL is > https://github

Re: [FFmpeg-devel] [PATCH v2] avfilter: take_samples: do not directly return frame when samples are skipped

2017-05-20 Thread Muhammad Faiz
On Sun, May 21, 2017 at 1:12 AM, Nicolas George wrote: > Le primidi 1er prairial, an CCXXV, Muhammad Faiz a écrit : >> > I will push this soon. >> Pushed and backported to 3.3 branch. > > Well, I was probably ok with this patch, but we will never know, will > we? Thank's. > > Can you explain the

[FFmpeg-devel] [PATCH] avcodec/vp9block: fix runtime error: signed integer overflow: 196675 * 20670 cannot be represented in type 'int'

2017-05-20 Thread Michael Niedermayer
Fixes: 1710/clusterfuzz-testcase-minimized-4837032931098624 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vp9block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/li

Re: [FFmpeg-devel] [PATCH] libavformat/hls: Observe Set-Cookie headers

2017-05-20 Thread Micah Galizia
On 2017-05-17 05:23 AM, wm4 wrote: On Sat, 6 May 2017 14:28:10 -0400 Micah Galizia wrote: On 2017-05-05 09:28 PM, wm4 wrote: On Fri, 5 May 2017 20:55:05 -0400 Micah Galizia wrote: Signed-off-by: Micah Galizia --- libavformat/hls.c | 12 ++-- 1 file changed, 10 insertions(+

Re: [FFmpeg-devel] [PATCH] avcodec/vp9block: fix runtime error: signed integer overflow: 196675 * 20670 cannot be represented in type 'int'

2017-05-20 Thread Ronald S. Bultje
Hi, On Sat, May 20, 2017 at 8:12 PM, Michael Niedermayer wrote: > Fixes: 1710/clusterfuzz-testcase-minimized-4837032931098624 > > Found-by: continuous fuzzing process https://github.com/google/oss- > fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp9bl