Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-17 Thread Nicolas George
L'octidi 28 floréal, an CCXXV, Muhammad Faiz a écrit : > Actually, one can argue that because we've already missed 3.3.1, we > should wait for 3.3.2. But I can argue that master branch also has > users, and keeping the crash unresolved at master branch is not good > idea at all. The complete fix i

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-17 Thread Muhammad Faiz
On Wed, May 17, 2017 at 2:25 PM, Nicolas George wrote: > L'octidi 28 floréal, an CCXXV, Muhammad Faiz a écrit : >> Actually, one can argue that because we've already missed 3.3.1, we >> should wait for 3.3.2. But I can argue that master branch also has >> users, and keeping the crash unresolved at

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-17 Thread Nicolas George
L'octidi 28 floréal, an CCXXV, Muhammad Faiz a écrit : > Of course, pushing the partial fix won't conflict with the complete > fix. Of course it will, it touches the same area of code. > Ha ha ha. Of course, that's why I prefer the partial fix. Because it > is simple. It is simple because it is

[FFmpeg-devel] [PATCH]lavf/img2: Allow reading svg image sequences

2017-05-17 Thread Carl Eugen Hoyos
Hi! I believe attached patch is necessary to allow reading svg sequences. Please comment, Carl Eugen From 4c2d49dbb1167d613528f5dd72883a218ad46b02 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 17 May 2017 10:59:36 +0200 Subject: [PATCH] lavf/img2: Add svg and svgz to allow reading i

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-17 Thread Muhammad Faiz
On Wed, May 17, 2017 at 3:20 PM, Nicolas George wrote: > L'octidi 28 floréal, an CCXXV, Muhammad Faiz a écrit : >> Of course, pushing the partial fix won't conflict with the complete >> fix. > > Of course it will, it touches the same area of code. No, your code doesn't check the alignment at take

Re: [FFmpeg-devel] [PATCH] libavformat/hls: Observe Set-Cookie headers

2017-05-17 Thread wm4
On Sat, 6 May 2017 14:28:10 -0400 Micah Galizia wrote: > On 2017-05-05 09:28 PM, wm4 wrote: > > On Fri, 5 May 2017 20:55:05 -0400 > > Micah Galizia wrote: > > > >> Signed-off-by: Micah Galizia > >> --- > >> libavformat/hls.c | 12 ++-- > >> 1 file changed, 10 insertions(+), 2 dele

[FFmpeg-devel] Is this a bug? Or should it be developed? I want to be a ffmpeg developer.

2017-05-17 Thread Sinan Aksu
Hi, Most people who want to record rtmp with ffmpeg encounter the problem of validating the swf file. I do not know why, but can not verify ffmpeg while rtmpdump can verify a swf file. Unfortunately, ffmpeg size incorrectly calculates hash values. Unfortunately, there are no ffmpeg commands necess

[FFmpeg-devel] mp4 encryption with time code track

2017-05-17 Thread Eran Kornblau
Hi all, We bumped into an issue with the mp4 encryption support we submitted a while ago - in case ffmpeg decides to write a timecode track in the output mp4, it crashes. The reason is that mov_create_timecode_track calls ff_mov_write_packet on a track that doesn't have 'cenc' initialized, this

Re: [FFmpeg-devel] Is this a bug? Or should it be developed? I want to be a ffmpeg developer.

2017-05-17 Thread Steven Liu
2017-05-17 17:33 GMT+08:00 Sinan Aksu : > Hi, > > Most people who want to record rtmp with ffmpeg encounter the problem of > validating the swf file. I do not know why, but can not verify ffmpeg while > rtmpdump can verify a swf file. Unfortunately, ffmpeg size incorrectly > calculates hash values

[FFmpeg-devel] Getting access to FATE server

2017-05-17 Thread Bob Kirnum
So, I've been trying for about a week to get access to FATE server in order to start the process for submitting patches. Sent several emails to the fate-admin with my system's public key but no reply. Is there something not listed in the instructions which I need to do in order to expedite access

Re: [FFmpeg-devel] Getting access to FATE server

2017-05-17 Thread Hendrik Leppkes
On Wed, May 17, 2017 at 12:30 PM, Bob Kirnum wrote: > So, I've been trying for about a week to get access to FATE server in order > to start the process for submitting patches. Sent several emails to the > fate-admin with my system's public key but no reply. Is there something > not listed in th

Re: [FFmpeg-devel] Is this a bug? Or should it be developed? I want to be a ffmpeg developer.

2017-05-17 Thread Hendrik Leppkes
On Wed, May 17, 2017 at 11:33 AM, Sinan Aksu wrote: > Hi, > > Most people who want to record rtmp with ffmpeg encounter the problem of > validating the swf file. I do not know why, but can not verify ffmpeg while > rtmpdump can verify a swf file. Unfortunately, ffmpeg size incorrectly > calculates

Re: [FFmpeg-devel] Getting access to FATE server

2017-05-17 Thread Bob Kirnum
Interesting, thanks Hendrick. I have already run FATE successfully on my local system. Thanks, Bob On Wed, May 17, 2017 at 6:40 AM, Hendrik Leppkes wrote: > On Wed, May 17, 2017 at 12:30 PM, Bob Kirnum wrote: > > So, I've been trying for about a week to get access to FATE server in > order >

[FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both AMR-NB and AMR-WB

2017-05-17 Thread Bob Kirnum
--- libavformat/isom.c | 2 ++ libavformat/movenc.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/libavformat/isom.c b/libavformat/isom.c index 5522115..49ba735 100644 --- a/libavformat/isom.c +++ b/libavformat/isom.c @@ -69,6 +69,8 @@ const AVCodecTag ff_mp4_obj_type[] = { { AV_CO

Re: [FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both AMR-NB and AMR-WB

2017-05-17 Thread Moritz Barsnick
On Wed, May 17, 2017 at 07:04:07 -0400, Bob Kirnum wrote: > Subject: [FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both AMR-NB > and AMR-WB This is not avfilter. > { AV_CODEC_ID_MPEG4SYSTEMS, 0x02 }, > +{ AV_CODEC_ID_AMR_NB , MKTAG('s', 'a', 'm', 'r') }, /* AMR-NB 3gp >

Re: [FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both AMR-NB and AMR-WB

2017-05-17 Thread Bob Kirnum
Apologies. On Wed, May 17, 2017 at 7:21 AM, Moritz Barsnick wrote: > On Wed, May 17, 2017 at 07:04:07 -0400, Bob Kirnum wrote: > > > Subject: [FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both > AMR-NB and AMR-WB > > This is not avfilter. > > > { AV_CODEC_ID_MPEG4SYSTEMS, 0x02 },

Re: [FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both AMR-NB and AMR-WB

2017-05-17 Thread Carl Eugen Hoyos
2017-05-17 13:04 GMT+02:00 Bob Kirnum : > --- > libavformat/isom.c | 2 ++ > libavformat/movenc.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/libavformat/isom.c b/libavformat/isom.c > index 5522115..49ba735 100644 > --- a/libavformat/isom.c > +++ b/libavformat/isom.c > @@ -69,6 +

Re: [FFmpeg-devel] [PATCH] lavf/mov: make invalid mdhd time_scale default to 1 instead of erroring out

2017-05-17 Thread Matthieu Bouron
On Fri, May 12, 2017 at 11:12:12PM +0200, Michael Niedermayer wrote: > On Thu, May 11, 2017 at 04:33:50PM +0200, Matthieu Bouron wrote: > > Some samples have their metadata track time_scale incorrectly set to 0 > > and the check introduced by a398f054fdb9b0f0b5a91c231fba6ce014143f71 > > prevents pl

Re: [FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both AMR-NB and AMR-WB

2017-05-17 Thread Bob Kirnum
Backwards compatibility tested running complete FATE testing. Our media server can record to and play from MP4 containing H.264 and / or AMR-NB / WB. The codecs are proprietary implementations. We use libavformat for MP4 containers. The recorded containers can be played back using third party t

Re: [FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both AMR-NB and AMR-WB

2017-05-17 Thread Carl Eugen Hoyos
2017-05-17 14:05 GMT+02:00 Bob Kirnum : > Backwards compatibility tested running complete FATE testing. What I meant was: Do you have samples that were not created with FFmpeg, and cannot be decoded with FFmpeg without your patch, but can with the patch? > Our media server can record to and play

Re: [FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both AMR-NB and AMR-WB

2017-05-17 Thread Bob Kirnum
Hey Carl. I will provide samples on this thread. Do WMP or QT support decoding AMR-NB / WB? Bob On Wed, May 17, 2017 at 8:11 AM, Carl Eugen Hoyos wrote: > 2017-05-17 14:05 GMT+02:00 Bob Kirnum : > > Backwards compatibility tested running complete FATE testing. > > What I meant was: > Do you h

Re: [FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both AMR-NB and AMR-WB

2017-05-17 Thread Hendrik Leppkes
On Wed, May 17, 2017 at 2:05 PM, Bob Kirnum wrote: > Backwards compatibility tested running complete FATE testing. > > Our media server can record to and play from MP4 containing H.264 and / or > AMR-NB / WB. The codecs are proprietary implementations. We use > libavformat for MP4 containers. T

Re: [FFmpeg-devel] [PATCH]lavf/img2: Allow reading svg image sequences

2017-05-17 Thread Rostislav Pehlivanov
On 17 May 2017 at 10:03, Carl Eugen Hoyos wrote: > Hi! > > I believe attached patch is necessary to allow reading svg sequences. > > Please comment, Carl Eugen > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/lis

Re: [FFmpeg-devel] [PATCH] lavf/mov: make invalid mdhd time_scale default to 1 instead of erroring out

2017-05-17 Thread Matthieu Bouron
On Wed, May 17, 2017 at 01:56:13PM +0200, Matthieu Bouron wrote: > On Fri, May 12, 2017 at 11:12:12PM +0200, Michael Niedermayer wrote: > > On Thu, May 11, 2017 at 04:33:50PM +0200, Matthieu Bouron wrote: > > > Some samples have their metadata track time_scale incorrectly set to 0 > > > and the che

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_check_align().

2017-05-17 Thread Muhammad Faiz
On Thu, May 11, 2017 at 2:59 PM, Muhammad Faiz wrote: > On Tue, May 9, 2017 at 8:19 PM, Nicolas George wrote: >> diff --git a/libavutil/frame.c b/libavutil/frame.c >> index 24d5d5f184..e8467a1cd6 100644 >> --- a/libavutil/frame.c >> +++ b/libavutil/frame.c >> @@ -781,3 +781,21 @@ const char *av_f

Re: [FFmpeg-devel] [PATCH]lavf/img2: Allow reading svg image sequences

2017-05-17 Thread Carl Eugen Hoyos
2017-05-17 14:46 GMT+02:00 Rostislav Pehlivanov : > On 17 May 2017 at 10:03, Carl Eugen Hoyos wrote: > >> Hi! >> >> I believe attached patch is necessary to allow reading svg sequences. >> >> Please comment, Carl Eugen > With this patch svg and svgz files aren't detected as such and > demuxing an

Re: [FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both AMR-NB and AMR-WB

2017-05-17 Thread Bob Kirnum
Sorry, I am just coming up to speed with this. I am not the originator of this implementation, I cleaned it up and now handling this submission process. I am told we tested with VLC and QT. However, QT only supports AMR-NB. WMP does not support AMR at all. On Wed, May 17, 2017 at 8:27 AM, Hendr

Re: [FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both AMR-NB and AMR-WB

2017-05-17 Thread Carl Eugen Hoyos
2017-05-17 14:27 GMT+02:00 Hendrik Leppkes : > On Wed, May 17, 2017 at 2:05 PM, Bob Kirnum wrote: >> Backwards compatibility tested running complete FATE testing. >> >> Our media server can record to and play from MP4 containing H.264 and / or >> AMR-NB / WB. The codecs are proprietary implementa

Re: [FFmpeg-devel] [PATCH]lavf/img2: Allow reading svg image sequences

2017-05-17 Thread Rostislav Pehlivanov
On 17 May 2017 at 13:58, Carl Eugen Hoyos wrote: > 2017-05-17 14:46 GMT+02:00 Rostislav Pehlivanov : > > On 17 May 2017 at 10:03, Carl Eugen Hoyos wrote: > > > >> Hi! > >> > >> I believe attached patch is necessary to allow reading svg sequences. > >> > >> Please comment, Carl Eugen > > > With t

Re: [FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both AMR-NB and AMR-WB

2017-05-17 Thread Bob Kirnum
Did not realize the files I shared were too large. I copied them to a shared Google Drive here . . . https://drive.google.com/drive/folders/0B-TtYdUjPHBmM29uWkU4aHdReE0?usp=sharing On Wed, May 17, 2017 at 3:30 PM, Bob Kirnum wrote: > Sorry for the delay. Attached are two examples. Both files

Re: [FFmpeg-devel] [PATCH] avfilter: Enable in MP4 container both AMR-NB and AMR-WB

2017-05-17 Thread Carl Eugen Hoyos
2017-05-17 23:26 GMT+02:00 Bob Kirnum : > Did not realize the files I shared were too large. I copied them to a > shared Google Drive here . . . The question was if you have files that were not created with FFmpeg. Anyway: Since both files can be decoded with unpatched FFmpeg, I assume the demux

[FFmpeg-devel] [PATCH 1/4] avformat/movenc: add support for writing Mastering Display Metadata Box

2017-05-17 Thread James Almer
As defined in "VP Codec ISO Media File Format Binding v1.0" https://github.com/webmproject/vp9-dash/blob/master/VPCodecISOMediaFileFormatBinding.md Signed-off-by: James Almer --- libavformat/movenc.c | 37 + 1 file changed, 37 insertions(+) diff --git a/libav

[FFmpeg-devel] [PATCH 3/4] avformat/mov: add support for reading Mastering Display Metadata Box

2017-05-17 Thread James Almer
As defined in "VP Codec ISO Media File Format Binding v1.0" https://github.com/webmproject/vp9-dash/blob/master/VPCodecISOMediaFileFormatBinding.md Partially based on Matroska decoder code. Signed-off-by: James Almer --- libavformat/isom.h | 2 ++ libavformat/mov.c | 65 ++

[FFmpeg-devel] [PATCH 2/4] avformat/movenc: add support for writing Content Light Level Box

2017-05-17 Thread James Almer
As defined in "VP Codec ISO Media File Format Binding v1.0" https://github.com/webmproject/vp9-dash/blob/master/VPCodecISOMediaFileFormatBinding.md Signed-off-by: James Almer --- libavformat/movenc.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/libavformat/movenc.c

[FFmpeg-devel] [PATCH 4/4] avformat/mov: add support for reading Content Light Level Box

2017-05-17 Thread James Almer
As defined in "VP Codec ISO Media File Format Binding v1.0" https://github.com/webmproject/vp9-dash/blob/master/VPCodecISOMediaFileFormatBinding.md Signed-off-by: James Almer --- libavformat/isom.h | 2 ++ libavformat/mov.c | 43 +++ 2 files changed, 45

[FFmpeg-devel] [PATCH] avcodec/wavpack: Fix multiple runtime error: signed integer overflow: 548 * -2147483648 cannot be represented in type 'int'

2017-05-17 Thread Michael Niedermayer
Fixes: 1659/clusterfuzz-testcase-minimized-5396490639900672 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wavpack.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --g

Re: [FFmpeg-devel] [PATCH] build: remove --enable-raise-major configure option

2017-05-17 Thread James Almer
On 5/15/2017 8:59 PM, James Almer wrote: > On 5/6/2017 6:59 PM, James Almer wrote: >> It's not used by anything, has dubious usefulness, the reasons for which >> it was introduced are no longer valid, and only serves to add complexity >> to the build system. >> >> Signed-off-by: James Almer >> ---