[FFmpeg-devel] [PATCH] avformat/hlsenc: fix ticket 6231

2017-03-13 Thread Steven Liu
check if the hls_flags is byterange_mode and check if should close fd Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index b8122f1..5bcface 100644 --- a/libavformat/hlsenc

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-13 Thread Paul B Mahol
On 3/13/17, Sanchit Sinha wrote: > On Mon, Mar 13, 2017 at 2:36 AM, Paul B Mahol wrote: > >> On 3/12/17, Sanchit Sinha wrote: >> > Any changes required in this one? >> >> Please do not top post. >> >> Expect vertical alignment, no changes are needed. When you introduced tabs? That is unacceptab

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/simple_idct_template: Fix several integer overflows

2017-03-13 Thread Paul B Mahol
On 3/13/17, Michael Niedermayer wrote: > Benchmarks with START_TIMER indicate that the code is faster with unsigned, > (that is > with the patch), there was quite some fluctuation in the numbers so this may > be just > random > > Fixes: 811/clusterfuzz-testcase-6465493076541440 > > Found-by: conti

Re: [FFmpeg-devel] configure: clang -Oz for small size build to reduce size further

2017-03-13 Thread Carl Eugen Hoyos
2017-03-13 3:16 GMT+01:00 Wang Bin : > How to benchmark codecs? You could benchmark running fate but I wonder why. > Here is my configuration and result size. The total size of -Oz > static or dynamic libraries is about 1M smaller. This seems to be sufficient reason to apply the patch, I can co

Re: [FFmpeg-devel] [PATCH]lsws/input: Do not define unused functions

2017-03-13 Thread Carl Eugen Hoyos
2017-03-11 13:13 GMT+01:00 Michael Niedermayer : > On Tue, Mar 07, 2017 at 09:30:18AM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes a few warnings when compiling with newer gcc. >> >> Please comment, Carl Eugen > > might be simpler t use av_unused Do you think the code is less r

Re: [FFmpeg-devel] configure: clang -Oz for small size build to reduce size further

2017-03-13 Thread Paul B Mahol
On 3/13/17, Carl Eugen Hoyos wrote: > 2017-03-13 3:16 GMT+01:00 Wang Bin : >> How to benchmark codecs? > > You could benchmark running fate but I wonder why. So speed is not really important at all here. But if it is libav merge than it suddenly is. What a double standards!

Re: [FFmpeg-devel] [PATCH]lavc/avpacket: Make pkt parameter of av_packet_get_side_data() const

2017-03-13 Thread Carl Eugen Hoyos
2017-02-26 12:04 GMT+01:00 Carl Eugen Hoyos : > Anyway, new patch attached. I will push this version if nobody objects. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix duration wrong when no pkt duration

2017-03-13 Thread Steven Liu
when cannot get pkt duration, hlsenc segments duration will be set to 0, this patch can fix it. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 5df2514..d6f0631 100644 -

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-13 Thread Sanchit Sinha
Sir, I cannot find any tabs in the code. Can you point out where exactly? Thank You On Mon, Mar 13, 2017 at 2:20 PM, Paul B Mahol wrote: > On 3/13/17, Sanchit Sinha wrote: > > On Mon, Mar 13, 2017 at 2:36 AM, Paul B Mahol wrote: > > > >> On 3/12/17, Sanchit Sinha wrote: > >> > Any changes re

Re: [FFmpeg-devel] configure: clang -Oz for small size build to reduce size further

2017-03-13 Thread Carl Eugen Hoyos
2017-03-13 10:08 GMT+01:00 Paul B Mahol : > On 3/13/17, Carl Eugen Hoyos wrote: >> 2017-03-13 3:16 GMT+01:00 Wang Bin : >>> How to benchmark codecs? >> >> You could benchmark running fate but I wonder why. > > So speed is not really important at all here. On the contrary! But assuming a user who

Re: [FFmpeg-devel] configure: clang -Oz for small size build to reduce size further

2017-03-13 Thread Wang Bin
http://stackoverflow.com/questions/15548023/clang-optimization-levels -Oz disables -slp-vectorizer and -vectorize-loops ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Refund request for travelling costs to Chemnitz

2017-03-13 Thread Carl Eugen Hoyos
Hi! Alexander Strasser, Thilo Borgmann, Thomas Volkert and myself represented FFmpeg at the Chemnitzer Linuxtage 2017. We showed different filters in action on video screens, talked to guests and other projects and as usual answered many user questions. I request the refund of € 162,69 for flying

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-13 Thread Nicolas George
Le tridi 23 ventôse, an CCXXV, Marton Balint a écrit : > You should set either AVFrame->flags to AV_FRAME_FLAG_CORRUPT or > AVFrame->decode_error_flags to something, so the API user can distinguish > between a frame with possible guessed colors and a frame without such > guesses. Indeed, that woul

Re: [FFmpeg-devel] [PATCH] Change type of spherical stuff to uint32_t

2017-03-13 Thread wm4
On Sun, 12 Mar 2017 22:16:46 +0100 Michael Niedermayer wrote: > Using the same type across platforms is more robust and avoids platform > specific issues from differences in range. > Also fixed point integers are on a semantical level not size_t > > Previous version reviewed-by: James Almer > S

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_direct: Fix runtime error: signed integer overflow: 2147483647 - -14133 cannot be represented in type 'int'

2017-03-13 Thread wm4
On Sat, 11 Mar 2017 18:26:48 +0100 Michael Niedermayer wrote: > On Sat, Mar 11, 2017 at 05:46:31PM +0100, wm4 wrote: > > On Sat, 11 Mar 2017 14:50:42 +0100 > > Michael Niedermayer wrote: > > > > > On Sat, Mar 11, 2017 at 02:04:25PM +0100, wm4 wrote: > > > > On Sat, 11 Mar 2017 01:26:33 +010

Re: [FFmpeg-devel] [PATCH] Change type of spherical stuff to uint64_t

2017-03-13 Thread wm4
On Sun, 12 Mar 2017 21:06:26 +0100 Michael Niedermayer wrote: > Using the same type across platforms is more robust and avoids platform > specific issues from differences in range. > Also fixed point integers are on a semantical level not size_t > Please no. If you do this now we're going to g

Re: [FFmpeg-devel] [PATCH] Change type of spherical stuff to uint32_t

2017-03-13 Thread Nicolas George
Le duodi 22 ventôse, an CCXXV, Michael Niedermayer a écrit : > Using the same type across platforms is more robust and avoids platform > specific issues from differences in range. > Also fixed point integers are on a semantical level not size_t > > Previous version reviewed-by: James Almer > Sign

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/simple_idct_template: Fix several integer overflows

2017-03-13 Thread Michael Niedermayer
On Mon, Mar 13, 2017 at 09:51:40AM +0100, Paul B Mahol wrote: > On 3/13/17, Michael Niedermayer wrote: > > Benchmarks with START_TIMER indicate that the code is faster with unsigned, > > (that is > > with the patch), there was quite some fluctuation in the numbers so this may > > be just > > rando

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-13 Thread Paul B Mahol
On 3/13/17, Sanchit Sinha wrote: > Sir, I cannot find any tabs in the code. Can you point out where exactly? > Thank You > Do not top post. Yes, tabe are not present in latest patch, but overal style can still much improve. Just read other filters code and see their style. What text editor are

Re: [FFmpeg-devel] configure: clang -Oz for small size build to reduce size further

2017-03-13 Thread Paul B Mahol
On 3/13/17, Carl Eugen Hoyos wrote: > 2017-03-13 10:08 GMT+01:00 Paul B Mahol : >> On 3/13/17, Carl Eugen Hoyos wrote: >>> 2017-03-13 3:16 GMT+01:00 Wang Bin : How to benchmark codecs? >>> >>> You could benchmark running fate but I wonder why. >> >> So speed is not really important at all he

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/vp6: clear dimensions on failed resolution change in vp6_parse_header()

2017-03-13 Thread Ronald S. Bultje
Hi, On Sun, Mar 12, 2017 at 11:49 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Sun, Mar 12, 2017 at 03:04:06AM +0100, Michael Niedermayer wrote: > > Fixes: 807/clusterfuzz-testcase-6470061042696192 > > Fixes null pointer dereference > > > > Found-by: continuous fuzzing process ht

Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-13 Thread Muhammad Faiz
On Fri, Mar 10, 2017 at 9:43 PM, Muhammad Faiz wrote: > On Fri, Mar 10, 2017 at 5:44 PM, Michael Niedermayer > wrote: >> On Fri, Mar 10, 2017 at 11:11:05AM +0700, Muhammad Faiz wrote: >>> On Fri, Mar 10, 2017 at 10:44 AM, Michael Niedermayer >>> wrote: >>> > On Fri, Mar 10, 2017 at 09:19:38AM +0

[FFmpeg-devel] [PATCH v2] swresample/options: enable linear_interp and exact_rational by default

2017-03-13 Thread Muhammad Faiz
better quality without speedloss Signed-off-by: Muhammad Faiz --- doc/resampler.texi | 5 +- libswresample/options.c | 4 +- tests/fate/libswresample.mak | 189 --- tests/ref/acodec/s302m | 6 +- tests/ref/lavf/dv_fmt|

[FFmpeg-devel] The Crystalhd video decoder is broken - last ffmpeg good commit: 6d160afab2fa8d3bfb216fee96d3537ffc9e86e8

2017-03-13 Thread wallak
The crystalhd video decoder was not updated to the commit: af9cac1be1750ecc0e12c6788a3aeed1f1a778be changes and so is broken. Is there someone trying to upgrade the crystalhd code? This device is old, but is still useful. I hope I'm not the only one using it. Wallak. ___

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_direct: Fix runtime error: signed integer overflow: 2147483647 - -14133 cannot be represented in type 'int'

2017-03-13 Thread Michael Niedermayer
On Mon, Mar 13, 2017 at 11:39:05AM +0100, wm4 wrote: > On Sat, 11 Mar 2017 18:26:48 +0100 > Michael Niedermayer wrote: > > > On Sat, Mar 11, 2017 at 05:46:31PM +0100, wm4 wrote: > > > On Sat, 11 Mar 2017 14:50:42 +0100 > > > Michael Niedermayer wrote: > > > > > > > On Sat, Mar 11, 2017 at 02:

[FFmpeg-devel] [PATCH v2 1/2] avfilter/interlace: change lowpass_line function

2017-03-13 Thread Thomas Mundt
Hi, this patch set 1) changes the lowpass_line function prototype in vf_interlace and vf_tinterlace as suggested by James Almer. 2) adds a complex (-1 2 6 2 -1) vertical low-pass filter to vf_interlace and vf_tinterlace. This one slightly less reduces interlace 'twitter' but better retains detai

[FFmpeg-devel] [PATCH v2 2/2] avfilter/interlace: add complex vertical low-pass filter

2017-03-13 Thread Thomas Mundt
Patch attached... 0002-avfilter-interlace-add-complex-vertical-low-pass-fil.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/3] avcodec/pictordec: Fix runtime error: left shift of 805306368 by 2 places cannot be represented in type 'int'

2017-03-13 Thread Michael Niedermayer
Fixes: 823/clusterfuzz-testcase-6727060074528768 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pictordec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pictor

[FFmpeg-devel] [PATCH 2/3] avcodec/tiff: Check for multiple geo key directories

2017-03-13 Thread Michael Niedermayer
Fixes memleak Fixes: 826/clusterfuzz-testcase-5316921379520512 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/tiff.c b/

[FFmpeg-devel] [PATCH 3/3] avcodec/mpegaudiodec_template: Make l3_unscale() work with e=0

2017-03-13 Thread Michael Niedermayer
Fixes undefined behavior Fixes: 830/clusterfuzz-testcase-6253175327686656 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mpegaudiodec_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[FFmpeg-devel] [PATCH] avformat/http: fix http reconnect

2017-03-13 Thread 卢炯健
--- .DS_Store | Bin 0 -> 6148 bytes libavformat/http.c | 56 + 2 files changed, 39 insertions(+), 17 deletions(-) create mode 100644 .DS_Store diff --git a/.DS_Store b/.DS_Store new file mode 100644 index 000

Re: [FFmpeg-devel] [PATCH] avformat/http: fix http reconnect

2017-03-13 Thread Hendrik Leppkes
On Mon, Mar 13, 2017 at 12:15 PM, 卢炯健 wrote: > --- > .DS_Store | Bin 0 -> 6148 bytes > libavformat/http.c | 56 > + > 2 files changed, 39 insertions(+), 17 deletions(-) > create mode 100644 .DS_Store > Your patch contains a binary

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_direct: Fix runtime error: signed integer overflow: 2147483647 - -14133 cannot be represented in type 'int'

2017-03-13 Thread wm4
On Mon, 13 Mar 2017 16:02:43 +0100 Michael Niedermayer wrote: > On Mon, Mar 13, 2017 at 11:39:05AM +0100, wm4 wrote: > > On Sat, 11 Mar 2017 18:26:48 +0100 > > Michael Niedermayer wrote: > > > > > On Sat, Mar 11, 2017 at 05:46:31PM +0100, wm4 wrote: > > > > On Sat, 11 Mar 2017 14:50:42 +010

Re: [FFmpeg-devel] The Crystalhd video decoder is broken - last ffmpeg good commit: 6d160afab2fa8d3bfb216fee96d3537ffc9e86e8

2017-03-13 Thread Philip Langdale
On 2017-03-13 07:28, wal...@free.fr wrote: The crystalhd video decoder was not updated to the commit: af9cac1be1750ecc0e12c6788a3aeed1f1a778be changes and so is broken. Is there someone trying to upgrade the crystalhd code? This device is old, but is still useful. I hope I'm not the only one usi

[FFmpeg-devel] [PATCH 1/2] avcodec/wavpack: Fix multiple integer overflows

2017-03-13 Thread Michael Niedermayer
Fixes: 839/clusterfuzz-testcase-4871084446842880 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wavpack.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavc

[FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Check palette shift

2017-03-13 Thread Michael Niedermayer
Fixes multiple runtime error: shift exponent 792 is too large for 32-bit type 'unsigned int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 5 + 1 file changed, 5 insertions(+)

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_direct: Fix runtime error: signed integer overflow: 2147483647 - -14133 cannot be represented in type 'int'

2017-03-13 Thread Michael Niedermayer
On Mon, Mar 13, 2017 at 10:26:25PM +0100, wm4 wrote: > On Mon, 13 Mar 2017 16:02:43 +0100 > Michael Niedermayer wrote: > > > On Mon, Mar 13, 2017 at 11:39:05AM +0100, wm4 wrote: > > > On Sat, 11 Mar 2017 18:26:48 +0100 > > > Michael Niedermayer wrote: > > > > > > > On Sat, Mar 11, 2017 at 05:

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/wavpack: Fix runtime error: shift exponent 137 is too large for 32-bit type 'int'

2017-03-13 Thread Michael Niedermayer
On Mon, Mar 13, 2017 at 03:36:34AM +0100, Michael Niedermayer wrote: > Fixes: 808/clusterfuzz-testcase-4715513349406720 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/wavpack.h | 2

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/targa: Skip hflip on blank images

2017-03-13 Thread Michael Niedermayer
On Mon, Mar 13, 2017 at 03:36:35AM +0100, Michael Niedermayer wrote: > Fixes: timeout with 810/clusterfuzz-testcase-5249282825256960 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/t

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/wavpack: Fix runtime error: shift exponent 32 is too large for 32-bit type 'int'

2017-03-13 Thread Michael Niedermayer
On Mon, Mar 13, 2017 at 03:36:37AM +0100, Michael Niedermayer wrote: > Fixes: 822/clusterfuzz-testcase-4873433189974016 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/wavpack.c | 2

Re: [FFmpeg-devel] The Crystalhd video decoder is broken - last ffmpeg good commit: 6d160afab2fa8d3bfb216fee96d3537ffc9e86e8

2017-03-13 Thread wallak
Indeed 7447ec91b5a692121b81a04c6501a5811d867775 is working; But I have the following errors with the last ffmpeg git state: [h264_crystalhd @ 0x7fda3c060500] This decoder requires using the avcodec_send_packet() API. Last message repeated 456 times ... I've 'bisected' this last issue; The last g

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix ticket 6231

2017-03-13 Thread Steven Liu
2017-03-13 15:50 GMT+08:00 Steven Liu : > check if the hls_flags is byterange_mode and check if should close fd > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c

Re: [FFmpeg-devel] The Crystalhd video decoder is broken - last ffmpeg good commit: 6d160afab2fa8d3bfb216fee96d3537ffc9e86e8

2017-03-13 Thread Philip Langdale
On Tue, 14 Mar 2017 02:49:27 +0100 (CET) wal...@free.fr wrote: > Indeed 7447ec91b5a692121b81a04c6501a5811d867775 is working; But I > have the following errors with the last ffmpeg git state: > [h264_crystalhd @ 0x7fda3c060500] This decoder requires using the > avcodec_send_packet() API. Last messa

Re: [FFmpeg-devel] The Crystalhd video decoder is broken - last ffmpeg good commit: 6d160afab2fa8d3bfb216fee96d3537ffc9e86e8

2017-03-13 Thread Philip Langdale
On Mon, 13 Mar 2017 19:39:35 -0700 Philip Langdale wrote: > On Tue, 14 Mar 2017 02:49:27 +0100 (CET) > wal...@free.fr wrote: > > > Indeed 7447ec91b5a692121b81a04c6501a5811d867775 is working; But I > > have the following errors with the last ffmpeg git state: > > [h264_crystalhd @ 0x7fda3c060500]