Re: [FFmpeg-devel] [PATCH] libopenmpt: add missing avio_read return value check

2017-01-15 Thread Jörn Heusipp
On 01/09/2017 08:20 PM, Jörn Heusipp wrote: On 01/01/2017 08:27 PM, Andreas Cadhalpun wrote: This fixes heap-buffer-overflows in libopenmpt caused by interpreting the negative size value as unsigned size_t. Signed-off-by: Andreas Cadhalpun --- libavformat/libopenmpt.c | 5 + 1 file chang

[FFmpeg-devel] [PATCH] matroskaenc: remove unofficial compliance on color information

2017-01-15 Thread Rostislav Pehlivanov
When support for this was added the details weren't yet finalized. This is no longer the case. Fixes writing of mkv/webm files with HDR. Reported-by: Kagami Hiiragi Signed-off-by: Rostislav Pehlivanov --- libavformat/matroskaenc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) d

Re: [FFmpeg-devel] [PATCH] matroskaenc: remove unofficial compliance on color information

2017-01-15 Thread James Almer
On 1/15/2017 10:59 AM, Rostislav Pehlivanov wrote: > When support for this was added the details weren't yet finalized. > This is no longer the case. > Fixes writing of mkv/webm files with HDR. Should be ok. It's been months since these elements were made official in the spec and afaics we're writ

Re: [FFmpeg-devel] Implementation of Huffman codes for DCA encoder

2017-01-15 Thread Даниил Чередник
Hi. Is there any issue in this patch? On Sun, Jan 8, 2017 at 1:22 AM, Даниил Чередник wrote: > With real music and 256k bitrate encoding (the source was 44100, 16bit > stereo) I got: > Without Huffman: Best PSNR is 31.77 for shift 0 > With: Best PSNR is 37.45 for shift 0 > > Current implementa

Re: [FFmpeg-devel] Implementation of Huffman codes for DCA encoder

2017-01-15 Thread Paul B Mahol
On 1/15/17, Daniil CHerednik wrote: > Hi. > Is there any issue in this patch? Do you plan to work more on this encoder? Please do not top post. > > On Sun, Jan 8, 2017 at 1:22 AM, Daniil CHerednik > wrote: > >> With real music and 256k bitrate encoding (the source was 44100, 16bit >> stereo) I

[FFmpeg-devel] [PATCH 2/2] ffplay: fix indentation after last commit

2017-01-15 Thread Marton Balint
Signed-off-by: Marton Balint --- ffplay.c | 130 +++ 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/ffplay.c b/ffplay.c index d76e41c..7ea172f 100644 --- a/ffplay.c +++ b/ffplay.c @@ -894,81 +894,81 @@ static void video_

[FFmpeg-devel] [PATCH 1/2] ffplay: do not preallocate video texture

2017-01-15 Thread Marton Balint
Since the uploads happen in the main display function, it does not matter much. Signed-off-by: Marton Balint --- ffplay.c | 120 +++ 1 file changed, 20 insertions(+), 100 deletions(-) diff --git a/ffplay.c b/ffplay.c index 967679e..d76

Re: [FFmpeg-devel] Implementation of Huffman codes for DCA encoder

2017-01-15 Thread Даниил Чередник
On Sun, Jan 15, 2017 at 6:58 PM, Paul B Mahol wrote: > On 1/15/17, Daniil CHerednik wrote: > > Hi. > > Is there any issue in this patch? > > Do you plan to work more on this encoder? > Yes I do. > > Please do not top post. > Ok, sorry. > > > > > On Sun, Jan 8, 2017 at 1:22 AM, Daniil CHerednik

Re: [FFmpeg-devel] Implementation of Huffman codes for DCA encoder

2017-01-15 Thread Rostislav Pehlivanov
On 15 January 2017 at 15:14, Даниил Чередник wrote: > Hi. > Is there any issue in this patch? > > On Sun, Jan 8, 2017 at 1:22 AM, Даниил Чередник > wrote: > > > With real music and 256k bitrate encoding (the source was 44100, 16bit > > stereo) I got: > > Without Huffman: Best PSNR is 31.77 for

Re: [FFmpeg-devel] [PATCH] matroskaenc: remove unofficial compliance on color information

2017-01-15 Thread Rostislav Pehlivanov
On 15 January 2017 at 14:16, James Almer wrote: > On 1/15/2017 10:59 AM, Rostislav Pehlivanov wrote: > > When support for this was added the details weren't yet finalized. > > This is no longer the case. > > Fixes writing of mkv/webm files with HDR. > > Should be ok. It's been months since these

Re: [FFmpeg-devel] [PATCH] avformat: Add rtp_mpegtsraw (MPEG-TS RAW Stream output)

2017-01-15 Thread Andreas Håkon
Hi Moritz, Original Message Subject: Re: [FFmpeg-devel] [PATCH] avformat: Add rtp_mpegtsraw (MPEG-TS RAW Stream output) From: barsn...@gmx.net To: FFmpeg development discussions and patches On Fri, Jan 13, 2017 at 07:57:28 -0500, Andreas Håkon wrote: > +static int rtp_mpegtsr

[FFmpeg-devel] [PATCH] libavformat/mpegtsenc: support hevc with missing in stream headers like h.264

2017-01-15 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/mpegtsenc.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index cdd7e37a1f..0f394c5fe0 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -

Re: [FFmpeg-devel] [PATCH] avformat: Add rtp_mpegtsraw (MPEG-TS RAW Stream output)

2017-01-15 Thread Moritz Barsnick
On Sun, Jan 15, 2017 at 15:59:14 -0500, Andreas Håkon wrote: > The bracket style is identical to the rest of the ffmpeg code... !? Is appears you're right and I'm wrong, though I was totally convinced of the opposite... Moritz ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH] libopenmpt: add missing avio_read return value check

2017-01-15 Thread Michael Niedermayer
On Sun, Jan 15, 2017 at 12:55:46PM +0100, Jörn Heusipp wrote: > > On 01/09/2017 08:20 PM, Jörn Heusipp wrote: > >On 01/01/2017 08:27 PM, Andreas Cadhalpun wrote: > >>This fixes heap-buffer-overflows in libopenmpt caused by interpreting > >>the negative size value as unsigned size_t. > >> > >>Signe

Re: [FFmpeg-devel] [PATCH] avcodec: add SIPR parser

2017-01-15 Thread Michael Niedermayer
On Sat, Jan 14, 2017 at 03:57:51PM +0100, Paul B Mahol wrote: > Fixes #2056. > > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/sipr_parser.c | 74 > can you add a fate test f

Re: [FFmpeg-devel] Implementation of Huffman codes for DCA encoder

2017-01-15 Thread Rostislav Pehlivanov
On 15 January 2017 at 15:14, Даниил Чередник wrote: > Hi. > Is there any issue in this patch? > > On Sun, Jan 8, 2017 at 1:22 AM, Даниил Чередник > wrote: > > > With real music and 256k bitrate encoding (the source was 44100, 16bit > > stereo) I got: > > Without Huffman: Best PSNR is 31.77 for

Re: [FFmpeg-devel] [PATCH] Fix huge reported DTS on Ogg Theora files with bogus granulepos

2017-01-15 Thread Michael Niedermayer
On Fri, Jan 13, 2017 at 02:09:00PM -0800, Brion Vibber wrote: > Patch fixes an issue with broken Ogg Theora videos containing bogus > negative granulepos on some packets: libavformat was reporting huge > positive dts timestamps for these packets, causing downstream problems for > ffmpeg2theora at W

Re: [FFmpeg-devel] [PATCH 1/3] dxva2: use a single macro to test if the DXVA context is valid

2017-01-15 Thread Michael Niedermayer
On Fri, Jan 13, 2017 at 02:01:05PM +0100, Steve Lhomme wrote: > --- > libavcodec/dxva2_h264.c | 4 +--- > libavcodec/dxva2_hevc.c | 4 +--- > libavcodec/dxva2_internal.h | 5 + > libavcodec/dxva2_mpeg2.c| 4 +--- > libavcodec/dxva2_vc1.c | 4 +--- > libavcodec/dxva2_vp9.c