Re: [FFmpeg-devel] Removing DCE

2016-12-21 Thread Carl Eugen Hoyos
2016-12-16 3:48 GMT+01:00 Matt Oliver : > For DCE: > 1) Ends up with a horrible mess of ifdefs. This argument alone has often been sufficient to refuse patches here. > 6) Issues with lto with Clang and Gold. > 7) Other unspecified issues with debug builds Could you elaborate on these two? Carl

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread Carl Eugen Hoyos
2016-12-21 5:48 GMT+01:00 Rodger Combs : > This allows us to report the correct codec ID here Just curious: What does this fix? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Removing DCE

2016-12-21 Thread Matt Oliver
On 21 December 2016 at 19:26, Carl Eugen Hoyos wrote: > 2016-12-16 3:48 GMT+01:00 Matt Oliver : > > > For DCE: > > 1) Ends up with a horrible mess of ifdefs. > > This argument alone has often been sufficient to refuse patches here. > Hence the initial email as I think that this is a highly subje

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-21 Thread Nicolas George
Le decadi 30 frimaire, an CCXXV, Michael Niedermayer a écrit : > it shouldnt really be complex, not in concept, maybe in (efficient) > implementation I think it is. > For example as a concept one could imagine each filter runs as its > own thread and waits on its inputs availability and output sp

Re: [FFmpeg-devel] Removing DCE

2016-12-21 Thread Nicolas George
Le sextidi 26 frimaire, an CCXXV, Matt Oliver a écrit : > For DCE: I do not care much about DCE one way or the other, but I do care about valid arguments. > 1) Ends up with a horrible mess of ifdefs. > 2) Disabled parts of code will not be checked for syntax. > > Against DCE: > 3) DCE is not ac

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

2016-12-21 Thread Nicolas George
Le decadi 30 frimaire, an CCXXV, Andreas Cadhalpun a écrit : > I'm not aware of a user outside of ffmpeg and const changes shouldn't cause > big > problems, as only the API changes, not the ABI. So it is probably OK. Thanks. > I'm not convinced that this is more convenient. APIchanges can still

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavfi: make filter_frame non-recursive.

2016-12-21 Thread Nicolas George
Le decadi 30 frimaire, an CCXXV, Michael Niedermayer a écrit : > > ./ffmpeg -i ~/tickets/860/jpeg2000.mov -vframes 3 -vcodec huffyuv -y > > test.avi > can some bitexact flag be used to eliminate these (admitably) rare > cases ? The obvious answer would be: use -t instead of -vframes, it is alre

Re: [FFmpeg-devel] [PATCH 1/1] Updated version of patch 1840 (ticket 6021)

2016-12-21 Thread Moritz Barsnick
On Mon, Dec 19, 2016 at 03:05:18 +, Erik Bråthen Solem wrote: > Subject: [FFmpeg-devel] [PATCH 1/1] Updated version of patch 1840 (ticket > 6021) You need to give a proper commit message. Do have a look at other commits in the repo. The first line of the message (which is shown in this subj

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add FF_BAIL_ON_OVERFLOW

2016-12-21 Thread wm4
On Wed, 21 Dec 2016 01:43:46 +0100 Andreas Cadhalpun wrote: > On 20.12.2016 15:22, wm4 wrote: > > On Mon, 19 Dec 2016 23:36:11 +0100 > > Andreas Cadhalpun wrote: > > > >> On 16.12.2016 17:22, wm4 wrote: > >>> On Fri, 16 Dec 2016 03:32:07 +0100 > >>> Andreas Cadhalpun wrote: > >>> > >>

Re: [FFmpeg-devel] Removing DCE

2016-12-21 Thread wm4
On Fri, 16 Dec 2016 13:48:16 +1100 Matt Oliver wrote: > Recently we have again received several patches that are trying to add > workarounds for ffmpegs use of DCE. This is not the first time this has > happened and wont be the last until a decision is made about the use of > DCE. So I think its

Re: [FFmpeg-devel] Trying to ftp upload sample video

2016-12-21 Thread wm4
On Tue, 20 Dec 2016 20:34:28 +0100 Paul B Mahol wrote: > On 12/20/16, Ray Pasco wrote: > > There doesn't appear to be enough detail for uploading a sample file by > > ftp. > > > > [image: Inline image 1] > > > > What are the values for *port* and *password* ? > > > > Upload it somewhere else.

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-21 Thread Michael Niedermayer
On Wed, Dec 21, 2016 at 10:27:13AM +0100, Nicolas George wrote: > Le decadi 30 frimaire, an CCXXV, Michael Niedermayer a écrit : [...] > > > iam not sure its usfull but > > Another view from a different direction would be to see the filter > > graph as a network of pipes with flowing water and int

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

2016-12-21 Thread wm4
On Tue, 20 Dec 2016 22:58:28 +0100 Nicolas George wrote: > Le decadi 30 frimaire, an CCXXV, wm4 a écrit : > > > You mean a single structure returned by a single accessor with all the > > > stream's properties instead of individual accessors for individual > > > properties? Well, the naive methods

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

2016-12-21 Thread wm4
On Wed, 21 Dec 2016 01:56:59 +0100 Andreas Cadhalpun wrote: > On 20.12.2016 15:46, wm4 wrote: > > In general, replacing public fields with macro-generated accessors is > > really just a rename. Admittedly, it removes a confusing indirection > > (though ->inputs[0]) in this case, but in general th

Re: [FFmpeg-devel] Removing DCE

2016-12-21 Thread Michael Niedermayer
On Fri, Dec 16, 2016 at 01:48:16PM +1100, Matt Oliver wrote: > Recently we have again received several patches that are trying to add > workarounds for ffmpegs use of DCE. This is not the first time this has > happened and wont be the last until a decision is made about the use of > DCE. So I think

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread Michael Niedermayer
On Tue, Dec 20, 2016 at 10:48:12PM -0600, Rodger Combs wrote: > This allows us to report the correct codec ID here > --- > libavformat/allformats.c | 2 +- > libavformat/mp3dec.c | 62 > +++- > libavformat/version.h| 2 +- > 3 files changed, 4

[FFmpeg-devel] avcodec_open2 return -1

2016-12-21 Thread sea
In transcoding project of LeiXiaoHua(demo of usage of filters), if I use media file with h264 video stream as input file, the function avcodec_open2 will return -1. Media file with video stream in other format, such as mpeg4, mjpeg return 0 (OK). Why ? Someone meets the same problem? _

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-21 Thread Nicolas George
Le primidi 1er nivôse, an CCXXV, Michael Niedermayer a écrit : > The framework could monitor filters to determine their apparent > behavior. This would of course not give exact prediction of future > behavior. > I cant say how useful it would be to use this of course ... I do not see how to integr

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread Rodger Combs
> On Dec 21, 2016, at 02:27, Carl Eugen Hoyos wrote: > > 2016-12-21 5:48 GMT+01:00 Rodger Combs : >> This allows us to report the correct codec ID here > > Just curious: What does this fix? Reporting in ffprobe, or when using lavf as a library. Some devices and decoders either refuse to decod

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

2016-12-21 Thread Marton Balint
On Sun, 18 Dec 2016, Nicolas George wrote: Le primidi 21 frimaire, an CCXXV, Nicolas George a écrit : I will do so after the end of this week if I see no news. Done. It seems after this patch I got an infinite loop if I try to convert the attached file using this command line: ./ffmpeg

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

2016-12-21 Thread Nicolas George
Le primidi 1er nivôse, an CCXXV, Marton Balint a écrit : > It seems after this patch I got an infinite loop if I try to convert the > attached file using this command line: > > ./ffmpeg -i amerge-test.mov -filter_complex "[0:a:0][0:a:1]amerge=2[aout]" > -map "[aout]" out.wav That is a bigger glit

Re: [FFmpeg-devel] Trying to ftp upload sample video

2016-12-21 Thread compn
On Wed, 21 Dec 2016 14:31:43 +0100 wm4 wrote: > On Tue, 20 Dec 2016 20:34:28 +0100 > Paul B Mahol wrote: > > > Upload it somewhere else. > > Maybe we should stop recommending the FTP for sample uploading? I > never had much luck on it (on both sides: uploading, or looking at > something someon

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread compn
On Wed, 21 Dec 2016 12:51:18 -0600 Rodger Combs wrote: > > > On Dec 21, 2016, at 02:27, Carl Eugen Hoyos > > wrote: > > > > 2016-12-21 5:48 GMT+01:00 Rodger Combs : > >> This allows us to report the correct codec ID here > > > > Just curious: What does this fix? > > Reporting in ffprobe, or

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread James Almer
On 12/21/2016 4:50 PM, compn wrote: > On Wed, 21 Dec 2016 12:51:18 -0600 > Rodger Combs wrote: > >> >>> On Dec 21, 2016, at 02:27, Carl Eugen Hoyos >>> wrote: >>> >>> 2016-12-21 5:48 GMT+01:00 Rodger Combs : This allows us to report the correct codec ID here >>> >>> Just curious: What does

[FFmpeg-devel] [PATCH] avcodec: add Apple Pixlet decoder

2016-12-21 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/pixlet.c | 756 +

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread Rodger Combs
> On Dec 21, 2016, at 13:50, compn wrote: > > On Wed, 21 Dec 2016 12:51:18 -0600 > Rodger Combs wrote: > >> >>> On Dec 21, 2016, at 02:27, Carl Eugen Hoyos >>> wrote: >>> >>> 2016-12-21 5:48 GMT+01:00 Rodger Combs : This allows us to report the correct codec ID here >>> >>> Just curio

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: add FFFrameQueue API.

2016-12-21 Thread James Almer
On 11/27/2016 1:08 PM, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/Makefile | 1 + > libavfilter/framequeue.c | 123 + > libavfilter/framequeue.h | 173 > +++ > 3 files changed, 297 in

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: add FFFrameQueue API.

2016-12-21 Thread Nicolas George
Le primidi 1er nivôse, an CCXXV, James Almer a écrit : > This patchset broke 83 fate tests using valgrind. Looks like memleaks. > > http://fate.ffmpeg.org/report.cgi?time=20161221122451&slot=x86_64-archlinux-gcc-valgrindundef > http://fate.ffmpeg.org/report.cgi?time=20161221133057&slot=x86_64-arch

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread Nicolas George
Le primidi 1er nivôse, an CCXXV, compn a écrit : > if mp2 is a problem, i would rather make it more difficult for the user > to encode mp2. by defaulting to mp3 and / or printing a warning message > about mp2. honestly i cant remember any good coming from someone using > mp2. > > mp2 is dead, long

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread James Almer
On 12/20/2016 11:36 PM, Michael Niedermayer wrote: > On Tue, Dec 20, 2016 at 04:53:51PM -0800, Thomas Turner wrote: >> Signed-off-by: Thomas Turner >> --- >> libavutil/Makefile | 1 + >> libavutil/tests/audio_fifo.c | 196 + >> tests/fate/libavutil.

Re: [FFmpeg-devel] [PATCH] Add initial program date time option (hls_init_prog_time)

2016-12-21 Thread Steven Liu
2016-12-18 10:10 GMT+08:00 Steven Liu : > > > 2016-12-17 15:58 GMT+08:00 Robert Nagy : > >> From 14da4c9610ac0cf257b2c28f21899e854592e646 Mon Sep 17 00:00:00 2001 >> From: Jesper Ek >> Date: Wed, 7 Dec 2016 16:01:08 +0100 >> Subject: [PATCH] Add initial program date time option (hls_init_prog_tim

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread Michael Niedermayer
On Wed, Dec 21, 2016 at 09:45:39PM -0300, James Almer wrote: > On 12/20/2016 11:36 PM, Michael Niedermayer wrote: > > On Tue, Dec 20, 2016 at 04:53:51PM -0800, Thomas Turner wrote: > >> Signed-off-by: Thomas Turner > >> --- > >> libavutil/Makefile | 1 + > >> libavutil/tests/audio_fif

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread James Almer
On 12/21/2016 10:49 PM, Michael Niedermayer wrote: > On Wed, Dec 21, 2016 at 09:45:39PM -0300, James Almer wrote: >> On 12/20/2016 11:36 PM, Michael Niedermayer wrote: >>> On Tue, Dec 20, 2016 at 04:53:51PM -0800, Thomas Turner wrote: Signed-off-by: Thomas Turner --- libavutil/Make

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread Michael Niedermayer
On Wed, Dec 21, 2016 at 10:53:36PM -0300, James Almer wrote: > On 12/21/2016 10:49 PM, Michael Niedermayer wrote: > > On Wed, Dec 21, 2016 at 09:45:39PM -0300, James Almer wrote: > >> On 12/20/2016 11:36 PM, Michael Niedermayer wrote: > >>> On Tue, Dec 20, 2016 at 04:53:51PM -0800, Thomas Turner wr

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread Thomas Turner
yeah, currently taking a look. On 12/21/2016 06:08 PM, Michael Niedermayer wrote: On Wed, Dec 21, 2016 at 10:53:36PM -0300, James Almer wrote: On 12/21/2016 10:49 PM, Michael Niedermayer wrote: On Wed, Dec 21, 2016 at 09:45:39PM -0300, James Almer wrote: On 12/20/2016 11:36 PM, Michael Niede

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread James Almer
On 12/21/2016 11:22 PM, Thomas Turner wrote: > yeah, currently taking a look. int tot_elements = !(planes = av_sample_fmt_is_planar(afifo->sample_fmt)) ? samples : afifo->channels * samples; void **data_planes = allocate_memory(sizeof(void*) * planes); planes is zero when t

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread Thomas Turner
Yes, you're correct. I'll look over the test and make sure there isn't anymore bugs before sending in the patch. Thanks On Dec 21, 2016 6:28 PM, "James Almer" wrote: On 12/21/2016 11:22 PM, Thomas Turner wrote: > yeah, currently taking a look. int tot_elements = !(planes = av_sample_fmt_is_pl