[FFmpeg-devel] [PATCH] d3d11va: use the proper slice index

2016-10-05 Thread Steve Lhomme
The slice index expected by D3D11VA is the one from the texture not from the array or texture/slices. In VLC the slices we provide the decoder don't start from 0 and thus pictures appear in bogus order. With possible crashes and corruptions when using an invalid index. -- * forgot to bump the mic

Re: [FFmpeg-devel] [PATCH] lavc: set best effort timestamp if unset when using new decode API

2016-10-05 Thread wm4
On Tue, 4 Oct 2016 20:26:49 +0200 Michael Niedermayer wrote: > On Tue, Oct 04, 2016 at 06:33:48PM +0200, wm4 wrote: > > Some API users (in particular ffmpeg.c) check the best effort timestamp > > only. > > --- > > Using guess_correct_pts() - not sure what I was thinking. > > --- > > libavcodec/u

[FFmpeg-devel] [PATCH] d3d11va: use the proper slice index

2016-10-05 Thread Steve Lhomme
The slice index expected by D3D11VA is the one from the texture not from the array or texture/slices. In VLC the slices we provide the decoder don't start from 0 and thus pictures appear in bogus order. With possible crashes and corruptions when using an invalid index. -- * forgot to bump the min

Re: [FFmpeg-devel] [PATCH] libavformat/utils: ignore outlier subtitle and data stream end times as well

2016-10-05 Thread Michael Niedermayer
On Mon, Oct 03, 2016 at 08:10:18PM -0500, Rodger Combs wrote: > --- > libavformat/utils.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index 3acb260..ce68408 100644 > --- a/libavformat/utils.c > +++ b/libavfo

Re: [FFmpeg-devel] [PATCH 1/4] lavc/parser: export field order if not already set

2016-10-05 Thread Michael Niedermayer
On Mon, Oct 03, 2016 at 11:49:36PM -0500, Rodger Combs wrote: > Some codecs set this in the parser, but not the decoder > --- > libavcodec/parser.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/parser.c b/libavcodec/parser.c > index 2c8fc69..30cfc55 100644 > --- a/libav

Re: [FFmpeg-devel] [PATCH] Changelog: Add CUVID entries

2016-10-05 Thread Carl Eugen Hoyos
2016-10-05 5:56 GMT+02:00 Philip Langdale : > From: Philip Langdale > > Signed-off-by: Philip Langdale > --- > Changelog | 3 +++ > 1 file changed, 3 insertions(+) Please make this one line, I don't think flushing has to be mentioned. Thank you, Carl Eugen _

[FFmpeg-devel] [PATCH]lavu/hwaccel_vaapi: Add a fixme for the missing byte_order check

2016-10-05 Thread Carl Eugen Hoyos
Hi! I cannot test here but afaict, the current implementation of vaapi_pix_fmt_from_fourcc() can't be correct. Please comment, Carl Eugen From 52b0af32b965c2fce23afe8b57289e497f17f011 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 5 Oct 2016 14:04:25 +0200 Subject: [PATCH] lavu/hwco

[FFmpeg-devel] [PATCH] Bug fix:- renamed the macro variable which causes segfault for mips r6

2016-10-05 Thread shivraj.patil
From: Shivraj Patil Signed-off-by: Shivraj Patil --- libavutil/mips/generic_macros_msa.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavutil/mips/generic_macros_msa.h b/libavutil/mips/generic_macros_msa.h index b1d18dd..0a59619 100644 --- a/libavutil/mi

[FFmpeg-devel] [PATCH 1/2] lavf/utils: ignore outlier subtitle and data stream end times as well

2016-10-05 Thread Rodger Combs
--- libavformat/utils.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 3acb260..d19cc5e 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2524,7 +2524,7 @@ static int has_duration(AVFormatContext *ic)

[FFmpeg-devel] [PATCH 2/2] lavf/utils: avoid using programs for duration when there's only one

2016-10-05 Thread Rodger Combs
This allows us to be more selective about the streams we derive durations from (specifically, ignoring text streams with outlier end times) in the common case --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index

[FFmpeg-devel] [PATCH]configure: Use LDEXEFLAGS in check_ld().

2016-10-05 Thread Carl Eugen Hoyos
Hi! Attached patch makes sure that libraries are tested with actual ldexeflags. Please comment, Carl Eugen From 5e26339b041f5e35112ed7f479ade6e57c3b5248 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 5 Oct 2016 15:10:23 +0200 Subject: [PATCH] configure: Use LDEXEFLAGS in check_ld().

Re: [FFmpeg-devel] [PATCH]configure: Enable pie for toolchain=hardened.

2016-10-05 Thread Carl Eugen Hoyos
2016-10-04 18:00 GMT+02:00 Michael Niedermayer : > On Tue, Oct 04, 2016 at 12:24:00PM +0200, Carl Eugen Hoyos wrote: >> >> Sorry if I miss something but with this patch, the hardening_check >> script succeeds here both for x86_32 and x86_64 (static and shared). > only case i found that breaks is w

Re: [FFmpeg-devel] [PATCH]lavu/hwaccel_vaapi: Add a fixme for the missing byte_order check

2016-10-05 Thread Mark Thompson
On 05/10/16 13:06, Carl Eugen Hoyos wrote: > --- > Hi! > > I cannot test here but afaict, the current implementation of > vaapi_pix_fmt_from_fourcc() can't be correct. > > Please comment, Carl Eugen > > libavutil/hwcontext_vaapi.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/liba

Re: [FFmpeg-devel] [PATCH 00/11] CRC32 support for Matroska muxer

2016-10-05 Thread Dave Rice
Hi, > On Oct 3, 2016, at 7:36 PM, James Almer wrote: > > This patchsets implements the feature requested on ticket #4347. > The first three patches are preparation work. The first one isn't > strictly related to the implementation, but comes in handy > nonetheless. > > Patches 4 to 11 can be sq

Re: [FFmpeg-devel] [PATCH] Changelog: Add CUVID entries

2016-10-05 Thread Philip Langdale
On Wed, 5 Oct 2016 13:09:06 +0200 Carl Eugen Hoyos wrote: > 2016-10-05 5:56 GMT+02:00 Philip Langdale : > > From: Philip Langdale > > > > Signed-off-by: Philip Langdale > > --- > > Changelog | 3 +++ > > 1 file changed, 3 insertions(+) > > Please make this one line, I don't think flushing h

Re: [FFmpeg-devel] [PATCH] lavf/segment: provide a virtual AVIOContext representing all the segments

2016-10-05 Thread Michael Niedermayer
On Wed, Oct 05, 2016 at 12:33:54AM -0500, Rodger Combs wrote: > This allows the use of muxers like matroska, which attempt to seek even > when an AVIOContext doesn't set `seekable`, without concern for a rouge > seek leading the muxer to overwrite the wrong data in a later segment. > --- > doc/mux

Re: [FFmpeg-devel] [PATCH 1/2] lavf/utils: ignore outlier subtitle and data stream end times as well

2016-10-05 Thread Michael Niedermayer
On Wed, Oct 05, 2016 at 07:38:21AM -0500, Rodger Combs wrote: > --- > libavformat/utils.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) patchset LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those g

Re: [FFmpeg-devel] [PATCH 2/3] lavf/mov: improve `tref/chap` chapter handling

2016-10-05 Thread Michael Niedermayer
On Tue, Oct 04, 2016 at 09:27:53PM -0500, Rodger Combs wrote: > 3 parts: > - Supports multiple chapter streams > - Exports regular text chapter streams as opaque data. This prevents consumers > from showing chapters as if they were regular subtitle streams. > - Exports video chapter streams as th

Re: [FFmpeg-devel] [PATCH 3/3] lavf/mp3dec: read encoder delay/padding from Info tag

2016-10-05 Thread Jon Toohill
On Tue, Oct 4, 2016 at 7:19 AM, wm4 wrote: > On Mon, 3 Oct 2016 17:45:08 -0700 > Jon Toohill wrote: > > > Muxers can check AVCodecParameters.initial_padding for the > > encoder+decoder delay, and read the AV_PKT_DATA_SKIP_SAMPLES > > side data from the last packet for the encoder padding. > > >

Re: [FFmpeg-devel] [PATCH 3/3] lavf/mp3dec: read encoder delay/padding from Info tag

2016-10-05 Thread Jon Toohill
On Tue, Oct 4, 2016 at 9:10 AM, Michael Niedermayer wrote: > On Mon, Oct 03, 2016 at 05:45:08PM -0700, Jon Toohill wrote: > > Muxers can check AVCodecParameters.initial_padding for the > > encoder+decoder delay, and read the AV_PKT_DATA_SKIP_SAMPLES > > side data from the last packet for the enco

Re: [FFmpeg-devel] [PATCH 3/3] lavf/mp3dec: read encoder delay/padding from Info tag

2016-10-05 Thread Jon Toohill
On Wed, Oct 5, 2016 at 10:40 AM, Jon Toohill wrote: > On Tue, Oct 4, 2016 at 7:19 AM, wm4 wrote: > >> On Mon, 3 Oct 2016 17:45:08 -0700 >> Jon Toohill wrote: >> >> > Muxers can check AVCodecParameters.initial_padding for the >> > encoder+decoder delay, and read the AV_PKT_DATA_SKIP_SAMPLES >>

Re: [FFmpeg-devel] [OPW] OPW Project Proposal

2016-10-05 Thread Pallavi Kumari
I am looking for mentor(s). Kindly let me know if anyone interested. On Tue, Sep 27, 2016 at 2:22 PM, Pallavi Kumari wrote: > Lou, Jean thanks for your suggestions. I will go through them meanwhile I > have finished a rough sketch of the idea. Please find it at [1]. > > [1] https://wiki.mozilla

Re: [FFmpeg-devel] [PATCH 1/5] af_hdcd: allow all HDCD sample rates

2016-10-05 Thread Burt P.
applied -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 4/5] af_hdcd: hdcd_scan() and hdcd_integrate() handle stereo and single channel

2016-10-05 Thread Burt P.
applied -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavu/hwaccel_vaapi: Add a fixme for the missing byte_order check

2016-10-05 Thread Carl Eugen Hoyos
2016-10-05 16:39 GMT+02:00 Mark Thompson : > On 05/10/16 13:06, Carl Eugen Hoyos wrote: >> >> I cannot test here but afaict, the current implementation of >> vaapi_pix_fmt_from_fourcc() can't be correct. >> +// FIXME: Take VAImageFormat->byte_order into account >> static struct { >> unsigned

Re: [FFmpeg-devel] [PATCH 2/5] af_hdcd: support s16p (WavPack) directly

2016-10-05 Thread Burt P.
applied -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/3] lavf/mp3dec: read encoder delay/padding from Info tag

2016-10-05 Thread wm4
On Wed, 5 Oct 2016 10:42:13 -0700 Jon Toohill wrote: > On Wed, Oct 5, 2016 at 10:40 AM, Jon Toohill wrote: > > > On Tue, Oct 4, 2016 at 7:19 AM, wm4 wrote: > > > >> On Mon, 3 Oct 2016 17:45:08 -0700 > >> Jon Toohill wrote: > >> > >> > Muxers can check AVCodecParameters.initial_padding fo

Re: [FFmpeg-devel] [PATCH 3/5] af_hdcd: add mono as a supported channel layout

2016-10-05 Thread Burt P.
applied -- Burt On Sun, Oct 2, 2016 at 2:46 AM, Burt P wrote: > Signed-off-by: Burt P > --- > libavfilter/af_hdcd.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c > index 90b6b64..6f35c09 100644 > --- a/libavfilter/af_

Re: [FFmpeg-devel] [PATCH 5/5] af_hdcd: add experimental 20 and 24-bit decoding support

2016-10-05 Thread Burt P.
applied split into two commits -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/3] lavf/mp3dec: read encoder delay/padding from Info tag

2016-10-05 Thread Jon Toohill
On Wed, Oct 5, 2016 at 11:03 AM, wm4 wrote: > On Wed, 5 Oct 2016 10:42:13 -0700 > Jon Toohill wrote: > > > On Wed, Oct 5, 2016 at 10:40 AM, Jon Toohill > wrote: > > > > > On Tue, Oct 4, 2016 at 7:19 AM, wm4 wrote: > > > > > >> On Mon, 3 Oct 2016 17:45:08 -0700 > > >> Jon Toohill wrote: > > >

Re: [FFmpeg-devel] [PATCH 3/4] lavc/utils: avcodec_string: dump field order when known

2016-10-05 Thread Michael Niedermayer
On Mon, Oct 03, 2016 at 11:49:38PM -0500, Rodger Combs wrote: > --- > libavcodec/utils.c | 15 +++ > 1 file changed, 15 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot change the truth. signa

[FFmpeg-devel] [PATCH 0/2] Fix gapless encoding/remuxing for MP3

2016-10-05 Thread Jon Toohill
Round trip wav->mp3->wav now preserves the correct number of samples. Remuxing mp3->mp3 with -c:a copy also preserves any existing gapless metadata in the Info tag. The code in libmp3lame.c to set AV_PKT_DATA_SKIP_SAMPLES was mostly copied from libopusenc.c. Jon Toohill (2): lavc/libmp3lame: se

[FFmpeg-devel] [PATCH 1/2] lavc/libmp3lame: send encoder delay/padding in packet side data

2016-10-05 Thread Jon Toohill
--- libavcodec/libmp3lame.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c index 5642264..b3ba0d8 100644 --- a/libavcodec/libmp3lame.c +++ b/libavcodec/libmp3lame.c @@ -50,6 +50,7 @@ typedef struct LA

[FFmpeg-devel] [PATCH 2/2] lavf/mp3enc: write encoder delay/padding upon closing

2016-10-05 Thread Jon Toohill
--- libavformat/mp3enc.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c index de63401..ddf4b93 100644 --- a/libavformat/mp3enc.c +++ b/libavformat/mp3enc.c @@ -111,6 +111,8 @@ typedef struct MP3Con

Re: [FFmpeg-devel] [PATCH 2/4] lavc/h264_parser: export field order in more cases

2016-10-05 Thread Michael Niedermayer
On Mon, Oct 03, 2016 at 11:49:37PM -0500, Rodger Combs wrote: > --- > libavcodec/h264_parser.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) should be ok a bit off topic but ct_type should be more completely parsed and used if available if its more reliable it should m

Re: [FFmpeg-devel] [PATCH]lavu/hwaccel_vaapi: Add a fixme for the missing byte_order check

2016-10-05 Thread Mark Thompson
On 05/10/16 19:02, Carl Eugen Hoyos wrote: > 2016-10-05 16:39 GMT+02:00 Mark Thompson : >> On 05/10/16 13:06, Carl Eugen Hoyos wrote: >>> >>> I cannot test here but afaict, the current implementation of >>> vaapi_pix_fmt_from_fourcc() can't be correct. > >>> +// FIXME: Take VAImageFormat->byte_ord

Re: [FFmpeg-devel] [PATCH 0/4] V12 - SCTE-35 support

2016-10-05 Thread Marton Balint
On Tue, 4 Oct 2016, Josh de Kock wrote: On 01/10/2016 18:27, Carlos Fernandez Sanz wrote: - Addresses new comments such as like idx value checking and filename checking Carlos Fernandez (4): Adding SCTE-35 CUI codec SCTE-35 extraction from mpegts SCTE-35 support in hlsenc Correct In

Re: [FFmpeg-devel] [PATCH] Bug fix:- renamed the macro variable which causes segfault for mips r6

2016-10-05 Thread Michael Niedermayer
On Wed, Oct 05, 2016 at 05:52:24PM +0530, shivraj.pa...@imgtec.com wrote: > From: Shivraj Patil > > Signed-off-by: Shivraj Patil > --- > libavutil/mips/generic_macros_msa.h | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) applied thx [...] -- Michael GnuPG fingerpr

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc_h264: fix segfault when a53 SEI is not available

2016-10-05 Thread Michael Niedermayer
On Wed, Oct 05, 2016 at 09:34:25AM -0400, Nablet Developer wrote: > Signed-off-by: Nablet Developer > --- > libavcodec/qsvenc_h264.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dang

Re: [FFmpeg-devel] [PATCH] added possibility to set first to ninth audio language for RIFF taged files (e.g. avi files)

2016-10-05 Thread Michael Niedermayer
On Sun, Oct 02, 2016 at 07:01:05PM +0200, Florian Diemer wrote: > --- > Sorry but the first patch was improperly formatted. > > > According to this page > (http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/RIFF.html#Info) it is > possible > to add language information ("IAS1" (first languag

[FFmpeg-devel] [PATCH] mov: Evaluate the movie display matrix

2016-10-05 Thread Vittorio Giovara
This matrix needs to be applied after all others have (currently only display matrix from trak), but cannot be handled in movie box, since streams are not allocated yet. So store it in main context and if not identity, apply it when appropriate, handling the case when trak display matrix is identi

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc_h264: fix segfault when a53 SEI is not available

2016-10-05 Thread Michael Niedermayer
On Wed, Oct 05, 2016 at 11:35:08PM +0200, Michael Niedermayer wrote: > On Wed, Oct 05, 2016 at 09:34:25AM -0400, Nablet Developer wrote: > > Signed-off-by: Nablet Developer > > --- > > libavcodec/qsvenc_h264.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied actually, befor

Re: [FFmpeg-devel] [PATCH] lavf/segment: provide a virtual AVIOContext representing all the segments

2016-10-05 Thread James Almer
On 10/5/2016 2:33 AM, Rodger Combs wrote: > This allows the use of muxers like matroska, which attempt to seek even > when an AVIOContext doesn't set `seekable`, without concern for a rouge > seek leading the muxer to overwrite the wrong data in a later segment. For the record, this behavior in Ma

Re: [FFmpeg-devel] [PATCH 2/2] pixfmt: Use enum assignment for aliases

2016-10-05 Thread Timothy Gu
On Tue, Aug 23, 2016 at 12:28 PM Michael Niedermayer wrote: > On Sun, Aug 21, 2016 at 05:09:01PM -0700, Timothy Gu wrote: > > This way, Doxygen is happier as aliases are now grouped together, and > > it never handled #define's in an enum well in the first place. > > > > Y400A already exists as an

Re: [FFmpeg-devel] [PATCH 1/2] pixdesc: Order function prototypes semantically

2016-10-05 Thread Timothy Gu
On Mon, Aug 22, 2016 at 5:53 AM Michael Niedermayer wrote: > On Sun, Aug 21, 2016 at 05:09:00PM -0700, Timothy Gu wrote: > > --- > > libavutil/pixdesc.h | 194 > ++-- > > 1 file changed, 97 insertions(+), 97 deletions(-) > > LGTM > > thx > Applied

Re: [FFmpeg-devel] [PATCH] mov: Evaluate the movie display matrix

2016-10-05 Thread Michael Niedermayer
On Wed, Oct 05, 2016 at 05:25:33PM -0400, Vittorio Giovara wrote: > This matrix needs to be applied after all others have (currently only > display matrix from trak), but cannot be handled in movie box, since > streams are not allocated yet. > > So store it in main context and if not identity, app

Re: [FFmpeg-devel] [PATCH] mov: Evaluate the movie display matrix

2016-10-05 Thread Vittorio Giovara
On Wed, Oct 5, 2016 at 10:07 PM, Michael Niedermayer wrote: > On Wed, Oct 05, 2016 at 05:25:33PM -0400, Vittorio Giovara wrote: >> This matrix needs to be applied after all others have (currently only >> display matrix from trak), but cannot be handled in movie box, since >> streams are not alloca

[FFmpeg-devel] [PATCH] Cherry-pick commit id c1cc13cd2a9b8d6d2810ec42454f328a1a0d5efa avutil/mips/generic_macros_msa: rename macro variable which causes segfault for mips r6

2016-10-05 Thread shivraj.patil
From: Shivraj Patil Signed-off-by: Shivraj Patil Signed-off-by: Michael Niedermayer --- libavutil/mips/generic_macros_msa.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavutil/mips/generic_macros_msa.h b/libavutil/mips/generic_macros_msa.h index b1d18d

[FFmpeg-devel] [PATCH] Cherry-pick commit 6803a298f4338c19c3032d2417c6e857eb6d95be Support for MIPS cpu P6600

2016-10-05 Thread shivraj.patil
From: Shivraj Patil Signed-off-by: Shivraj Patil Signed-off-by: Michael Niedermayer --- configure |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 5b069eb..64142e7 100755 --- a/configure +++ b/configure @@ -4336,7 +4336,7 @@ elif enabled m