On Sun, Sep 25, 2016 at 07:35:56PM +0200, Clément Bœsch wrote:
> ---
> What else is missing?
> ---
> doc/libav-merge.txt | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/doc/libav-merge.txt b/doc/libav-merge.txt
> index 4fd863e..e200bdb 100644
> --- a/doc/libav-merge.txt
> +++
On Sat, Oct 01, 2016 at 02:07:40AM +0100, Josh de Kock wrote:
> Signed-off-by: Josh de Kock
> ---
> doc/developer.texi | 163
> -
> 1 file changed, 74 insertions(+), 89 deletions(-)
>
> diff --git a/doc/developer.texi b/doc/developer.texi
> in
On Fri, Sep 30, 2016 at 11:02:32PM -0400, Chris Landry wrote:
> From: Chris Landry
>
> When a video stream timebase is not 90k, the cc packet pts is relevant to the
> timebase of the video stream, but later is assumed to be 90k. Adjust it here
> to be 90k so timing is accurate in resulting subs
On Fri, Sep 30, 2016 at 07:01:09PM +0200, wm4 wrote:
> On Fri, 30 Sep 2016 17:51:42 +0100
> Josh de Kock wrote:
>
> > On 30/09/2016 17:34, Matthieu Bouron wrote:
> > > From: Matthieu Bouron
> > >
> > > ---
> > > libavcodec/mediacodecdec_h2645.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 de
On 01/10/2016 10:23, Michael Niedermayer wrote:
[...]
-@item
-You do not have to over-test things. If it works for you, and you think it
-should work for others, then commit. If your code has problems
-(portability, triggers compiler bugs, unusual environment etc) they will be
-reported and eve
Some function definitions are missing without it,
for example sigaction.
Fixes ticket #5868
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure b/configure
index 74db9b5..ff2cb62 100755
--- a/configure
+++ b/configure
@@ -4806,6 +4806,7 @@ case $target_os in
objfo
Signed-off-by: Marton Balint
---
libavfilter/f_metadata.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libavfilter/f_metadata.c b/libavfilter/f_metadata.c
index 188f0b6..1fe713c 100644
--- a/libavfilter/f_metadata.c
+++ b/libavfilter/f_metadata.c
@@ -280,13
Signed-off-by: Marton Balint
---
doc/filters.texi | 5 +++--
libavfilter/f_metadata.c | 6 --
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/doc/filters.texi b/doc/filters.texi
index 9d51757..4b2f7bf 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -16059,7 +160
On 10/1/16, Marton Balint wrote:
> Signed-off-by: Marton Balint
> ---
> doc/filters.texi | 5 +++--
> libavfilter/f_metadata.c | 6 --
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffm
On 10/1/16, Marton Balint wrote:
> Signed-off-by: Marton Balint
> ---
> libavfilter/f_metadata.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/ma
Decoders have previously not used AVFrame.pts, and with the upcoming
deprecation of pkt_pts (in favor of pts), this would lead to an errorneous
interpration of timestamps.
---
ffmpeg.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/ffmpeg.c b/ffmpeg.c
index 9a8e65a..cdbf
On Fri, 30 Sep 2016 21:48:03 +0200
Michael Niedermayer wrote:
> On Thu, Sep 29, 2016 at 08:25:18PM +0200, wm4 wrote:
> > This is a bit messy, mainly due to timestamp handling.
> >
> > decode_video() relied on the fact that it could set dts on a flush/drain
> > packet. This is not possible with t
Hello,
Would someone familiar with the mmx assembler parts of ffmpeg
look over and check that the fp-state is restored as needed?
This is crucial with musl libc which uses floating point in its
malloc() implementation.
My troubleshooting strongly suggests that it is the mmx code which is
the cul
On Sat, 1 Oct 2016, Paul B Mahol wrote:
On 10/1/16, Marton Balint wrote:
Signed-off-by: Marton Balint
---
libavfilter/f_metadata.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
lgtm
Pushed, thanks.
Marton
___
ffmpeg-
On Sat, 1 Oct 2016, Paul B Mahol wrote:
On 10/1/16, Marton Balint wrote:
Signed-off-by: Marton Balint
---
doc/filters.texi | 5 +++--
libavfilter/f_metadata.c | 6 --
2 files changed, 7 insertions(+), 4 deletions(-)
lgtm
Pushed, thanks.
Marton
___
On Sat, 1 Oct 2016 17:37:50 +0200
u-h...@aetey.se wrote:
> Hello,
>
> Would someone familiar with the mmx assembler parts of ffmpeg
> look over and check that the fp-state is restored as needed?
>
> This is crucial with musl libc which uses floating point in its
> malloc() implementation.
>
> M
On Sat, Oct 01, 2016 at 05:44:13PM +0200, wm4 wrote:
> AFAIK most MMX code in FFmpeg does not run emms (i.e. keeps the FPU
> state trashed) until returning to the API user.
This means when malloc()/free()/... happens to be called internally,
it corrupts the malloc structures, in a non-straightforw
On Sat, Oct 01, 2016 at 17:37:50 +0200, u-h...@aetey.se wrote:
> My troubleshooting
[...]
> behaves erratically on certain combinations
[...]
> Most often
You are a busy troubleshooter, but you fail to describe what you did,
and what exactly went wrong. No-one will be able to (even try to)
reprod
Fixes ticket #5873.
Signed-off-by: Marton Balint
---
ffplay.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/ffplay.c b/ffplay.c
index e64909a..a7a6785 100644
--- a/ffplay.c
+++ b/ffplay.c
@@ -2224,7 +2224,6 @@ static int video_thread(void *arg)
static int subtitle_thr
Signed-off-by: Marton Balint
---
ffplay.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/ffplay.c b/ffplay.c
index a7a6785..6d43191 100644
--- a/ffplay.c
+++ b/ffplay.c
@@ -230,9 +230,6 @@ typedef struct VideoState {
Decoder viddec;
Decoder subdec;
-int viddec_width;
Hi,
On Sat, Oct 1, 2016 at 11:56 AM, wrote:
> On Sat, Oct 01, 2016 at 05:44:13PM +0200, wm4 wrote:
> > AFAIK most MMX code in FFmpeg does not run emms (i.e. keeps the FPU
> > state trashed) until returning to the API user.
>
> This means when malloc()/free()/... happens to be called internally,
On Sat, Oct 1, 2016 at 5:37 PM, wrote:
> musl libc which uses floating point in its malloc() implementation.
That's honestly the real "WTF?" here.
On Sat, Oct 1, 2016 at 5:56 PM, wrote:
> On Sat, Oct 01, 2016 at 05:44:13PM +0200, wm4 wrote:
>> AFAIK most MMX code in FFmpeg does not run emms (
Signed-off-by: James Almer
---
configure | 4
libavcodec/aarch64/neontest.c | 10 ++
libavcodec/arm/neontest.c | 10 ++
libavcodec/x86/w64xmmtest.c | 10 ++
4 files changed, 34 insertions(+)
diff --git a/configure b/configure
index 74db9b5.
On Tue, Sep 27, 2016 at 3:13 PM, Marton Balint wrote:
>
> nothing useful in the header, it might make sense to create a data packet
> only from the buffer _after_ the section_length field, skipping the last
> CRC32 field as well.
I've been looking into this, but it would break some things (like
b
Hi,
On Sat, Oct 1, 2016 at 12:25 PM, James Almer wrote:
> Signed-off-by: James Almer
> ---
> configure | 4
> libavcodec/aarch64/neontest.c | 10 ++
> libavcodec/arm/neontest.c | 10 ++
> libavcodec/x86/w64xmmtest.c | 10 ++
> 4 files cha
On 10/1/2016 1:55 PM, Ronald S. Bultje wrote:
> Hi,
>
> On Sat, Oct 1, 2016 at 12:25 PM, James Almer wrote:
>
>> Signed-off-by: James Almer
>> ---
>> configure | 4
>> libavcodec/aarch64/neontest.c | 10 ++
>> libavcodec/arm/neontest.c | 10 ++
>>
From: Carlos Fernandez
Signed-off-by: Carlos Fernandez
---
libavcodec/avcodec.h| 2 ++
libavcodec/codec_desc.c | 6 ++
2 files changed, 8 insertions(+)
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index d72ee07..9064006 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avc
From: Carlos Fernandez
Signed-off-by: Carlos Fernandez
---
libavformat/hlsenc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index a3224ef..1aec53f 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -406,
From: Carlos Fernandez
Signed-off-by: Carlos Fernandez
---
libavformat/Makefile | 2 +-
libavformat/hlsenc.c | 112 +--
libavformat/scte_35.c | 527 ++
libavformat/scte_35.h | 86
4 files changed, 705 insertions(+), 22 deleti
From: Carlos Fernandez
Signed-off-by: Carlos Fernandez
---
libavformat/mpegts.c | 48 +++-
1 file changed, 47 insertions(+), 1 deletion(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index b31d233..c13d6d8 100644
--- a/libavformat/mpegts
- Addresses new comments such as like idx value checking and filename checking
Carlos Fernandez (4):
Adding SCTE-35 CUI codec
SCTE-35 extraction from mpegts
SCTE-35 support in hlsenc
Correct Indentation
libavcodec/avcodec.h| 2 +
libavcodec/codec_desc.c | 6 +
libavformat/Makefil
Hello Moritz,
On Sat, Oct 01, 2016 at 06:13:46PM +0200, Moritz Barsnick wrote:
> On Sat, Oct 01, 2016 at 17:37:50 +0200, u-h...@aetey.se wrote:
> > My troubleshooting
> [...]
> > behaves erratically on certain combinations
> [...]
> > Most often
>
> You are a busy troubleshooter, but you fail to
On Sat, 1 Oct 2016, Carlos Fernandez Sanz wrote:
From: Carlos Fernandez
Signed-off-by: Carlos Fernandez
---
libavformat/mpegts.c | 48 +++-
1 file changed, 47 insertions(+), 1 deletion(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
ind
From: Chris Landry
Should have used av_rescale_q to do the timebase adjustment. Fixed compiler
warning for variable declaration.
Signed-off-by: Chris Landry
---
libavdevice/lavfi.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libavdevice/lavfi.c b/libavdevice/lavf
Sorry, this was supposed to be submitted in response to my thread on this
one. New to sending email with git.
On Sat, Oct 1, 2016 at 2:04 PM, Chris Landry
wrote:
> From: Chris Landry
>
> Should have used av_rescale_q to do the timebase adjustment. Fixed
> compiler warning for variable declarati
From: Chris Landry
When a video stream timebase is not 90k, the cc packet pts is relevant to the
timebase of the video stream, but later is assumed to be 90k. Adjust it here to
be 90k so timing is accurate in resulting subs.
Signed-off-by: Chris Landry
---
libavdevice/lavfi.c | 11 ++
Haven't been able to connect to upload.ffmpeg.org.
Sample file is here:
https://www.dropbox.com/s/38ll6y7wws7zssr/cc_different_video_timebase.mp4?dl=0
Also have not been able to get the fate stuff working. I am not a C
developer and have a lot to learn here.
On Sat, Oct 1, 2016 at 6:27 AM, Micha
Hello,
It looks like some general information is due:
Musl libc is a high quality standard C library for Linux
with emphasis on "quality" and "standard"
http://www.musl-libc.org/
On Sat, Oct 01, 2016 at 12:31:05PM -0400, Ronald S. Bultje wrote:
> > This means when malloc()/free()/... happens to
From: Jay Ridgeway
This patch enables client cert and cert validation for RTSPS.
This is the second submission of this patch. Still learning git send-email.
Jay Ridgeway (2):
pass TLS args for RTSPS
RTSPS: use type bool and lower case opt descriptions
libavformat/rtsp.c|
From: Jay Ridgeway
---
libavformat/rtsp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 179a59b..53ecb6c 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -99,9 +99,9 @@ const AVOption ff_rtsp_options[] = {
From: Jay Ridgeway
rename URISTR to NONNULLSTR
---
libavformat/rtsp.c| 19 ---
libavformat/rtsp.h| 8
libavformat/tls_gnutls.c | 7 +++
libavformat/tls_openssl.c | 7 +++
libavformat/tls_schannel.c| 7 +
On 30 September 2016 at 14:16, Rostislav Pehlivanov
wrote:
>
>
> On 29 September 2016 at 21:54, Josh de Kock wrote:
>
>> There is really no need for two aac wrappers, we already have
>> libfdk-aac which is better. Not to mention that faac doesn't
>> even support HEv1, or HEv2. It's also under a
Hi,
On Sat, Oct 1, 2016 at 2:27 PM, wrote:
> Hello,
>
> It looks like some general information is due:
>
> Musl libc is a high quality standard C library for Linux
> with emphasis on "quality" and "standard"
> http://www.musl-libc.org/
>
> On Sat, Oct 01, 2016 at 12:31:05PM -0400, Ronald S. Bul
This commit also rewords some of the policies for more clarity.
Signed-off-by: Josh de Kock
---
doc/developer.texi | 172 +
1 file changed, 82 insertions(+), 90 deletions(-)
diff --git a/doc/developer.texi b/doc/developer.texi
index 4d3a7ae..b
Signed-off-by: Michael Niedermayer
---
tests/fate/ffmpeg.mak | 4 +
tests/ref/fate/psp| 287 ++
2 files changed, 291 insertions(+)
create mode 100644 tests/ref/fate/psp
diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
index eb90090
On 01/10/2016 19:42, jayri...@gmail.com wrote:
From: Jay Ridgeway
---
libavformat/rtsp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 179a59b..53ecb6c 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -99,9 +9
On 10/1/2016 4:24 PM, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer
> ---
> tests/fate/ffmpeg.mak | 4 +
> tests/ref/fate/psp| 287
> ++
> 2 files changed, 291 insertions(+)
> create mode 100644 tests/ref/fate/psp
>
> diff
On 01/10/2016 17:17, Marton Balint wrote:
Signed-off-by: Marton Balint
---
ffplay.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/ffplay.c b/ffplay.c
index a7a6785..6d43191 100644
--- a/ffplay.c
+++ b/ffplay.c
@@ -230,9 +230,6 @@ typedef struct VideoState {
Decoder viddec;
Will push tomorrow if nobody objects.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 01/10/2016 17:17, Marton Balint wrote:
Fixes ticket #5873.
Signed-off-by: Marton Balint
---
ffplay.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/ffplay.c b/ffplay.c
index e64909a..a7a6785 100644
--- a/ffplay.c
+++ b/ffplay.c
@@ -2224,7 +2224,6 @@ static int vide
On 01/10/2016 20:41, Timo Rothenpieler wrote:
Will push tomorrow if nobody objects.
LGTM, maybe add a note which says that it may have been a cygwin update
which broke the build.
--
Josh
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://
On Sat, 1 Oct 2016 20:27:44 +0200
u-h...@aetey.se wrote:
> If you are curious you may wish to look at its code (it is clean
> and readable).
Would you really call the piece of code that uses float in malloc.c
readable?
___
ffmpeg-devel mailing list
ffmp
Hello Ronald,
On Sat, Oct 01, 2016 at 03:11:38PM -0400, Ronald S. Bultje wrote:
> I'm not sure we want to go down the rabbit hole of allowing any code to be
> executed inside frame en/decoding routines. Historically, IIRC, we have
> disallowed float in user callbacks like request_frame also.
>
>
From: Jay Ridgeway
This patch enables TLS args for RTSPS. This is necessary for client
certificates and cert validation.
Squash changes from feedback into one patch.
---
libavformat/rtsp.c| 19 ---
libavformat/rtsp.h| 8
libavformat/tl
On Sat, Oct 01, 2016 at 08:19:16PM +0100, Josh de Kock wrote:
> This commit also rewords some of the policies for more clarity.
i think rewording and formating should be in seperate patches
and non cosmetic changes to this text really should be easy to
review by everyone as the text affects every
On 10/1/2016 7:11 PM, Michael Niedermayer wrote:
> i think rewording and formating should be in seperate patches
Agree. The text itself even mentions it should be done as such.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mail
Hi,
On Sat, Oct 1, 2016 at 4:12 PM, wrote:
> Hello Ronald,
>
> On Sat, Oct 01, 2016 at 03:11:38PM -0400, Ronald S. Bultje wrote:
> > I'm not sure we want to go down the rabbit hole of allowing any code to
> be
> > executed inside frame en/decoding routines. Historically, IIRC, we have
> > disall
Removed allowing for commiting disabled, unfinished code. Code
should always try be in a working state.
Explicitly state that FATE should pass, and code should work
for all reviewers who tested.
Signed-off-by: Josh de Kock
---
doc/developer.texi | 89 ++---
And sort policies into these sections.
Signed-off-by: Josh de Kock
---
doc/developer.texi | 95 +++---
1 file changed, 48 insertions(+), 47 deletions(-)
diff --git a/doc/developer.texi b/doc/developer.texi
index d4344ff..b85bf0f 100644
--- a/doc/d
On 01/10/2016 02:28, Josh de Kock wrote:
Full width text is really difficult to read, this just makes it
slightly more legible on larger (widescreen) screens.
Signed-off-by: Josh de Kock
---
See http://screenshotcomparison.com/comparison/186256 for a comparison of
before/after.
doc/t2h.init
Ensuring that emms is issued before every single libc function call is
likely problematic.
What if we simply document the requirement that C standard library
functions are assumed to not modify the x87 FPU state unless
specifically designated to handle floating-point numbers?
_
On Fri, Sep 30, 2016 at 6:28 PM Josh de Kock wrote:
> Full width text is really difficult to read, this just makes it
> slightly more legible on larger (widescreen) screens.
>
> Signed-off-by: Josh de Kock
> ---
> See http://screenshotcomparison.com/comparison/186256 for a comparison of
> before
On Sun, Oct 02, 2016 at 01:18:29AM +0200, Henrik Gramner wrote:
> Ensuring that emms is issued before every single libc function call is
> likely problematic.
maybe, maybe not, iam not sure but
calling emms between init/de/reinint and optimized inner loops should
be doable, we generally shouldnt b
On Sun, Oct 02, 2016 at 12:01:46AM +0100, Josh de Kock wrote:
> Removed allowing for commiting disabled, unfinished code. Code
> should always try be in a working state.
This is sometimes not exactly possible due to the lack of samples
to test code, or lack of access to specific devices to test th
Explicitly state that FATE should pass, and code should work
for all reviewers who tested.
Signed-off-by: Josh de Kock
---
doc/developer.texi | 91 ++
1 file changed, 44 insertions(+), 47 deletions(-)
diff --git a/doc/developer.texi b/doc/deve
And sort policies into these sections.
Signed-off-by: Josh de Kock
---
doc/developer.texi | 95 +++---
1 file changed, 48 insertions(+), 47 deletions(-)
diff --git a/doc/developer.texi b/doc/developer.texi
index 0075a27..e466d95 100644
--- a/doc/d
2016-10-01 19:48 GMT+02:00 :
> I do not expect the ffmpeg developers to try to reproduce this.
(Would you mind explaining this sentence to me? I
do not understand it.)
> I expect somebody to look at the code (beginning with the
> MMX assembler in the vp3 decoder), which is a lower
> threshold th
2016-09-30 2:13 GMT+02:00 James Almer :
> LGTM otherwise.
Applied with the requested change.
Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hello Henrik,
On Sun, Oct 02, 2016 at 01:18:29AM +0200, Henrik Gramner wrote:
> Ensuring that emms is issued before every single libc function call is
> likely problematic.
>
> What if we simply document the requirement that C standard library
> functions are assumed to not modify the x87 FPU sta
On Sat, Oct 01, 2016 at 06:25:29PM -0400, Ronald S. Bultje wrote:
> > We are not talking about what you and me "would like inside a standard
> > library" but whether we can rely on the specified interfaces. The
> > malloc() interface was apparently misunderstood as a promise to never
> > do float.
70 matches
Mail list logo
