Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg: use new decode API

2016-09-30 Thread wm4
On Thu, 29 Sep 2016 23:35:49 +0200 Michael Niedermayer wrote: > On Thu, Sep 29, 2016 at 08:25:18PM +0200, wm4 wrote: > > This is a bit messy, mainly due to timestamp handling. > > > > decode_video() relied on the fact that it could set dts on a flush/drain > > packet. This is not possible with t

Re: [FFmpeg-devel] Improved SAMI support

2016-09-30 Thread Clément Bœsch
On Fri, Sep 30, 2016 at 12:28:14AM +0200, Jehan Pagès wrote: > Hello! > > So I posted a patch about SAMI support > (https://trac.ffmpeg.org/ticket/3118), but I was told it would be > ignored on the bug tracker, therefore to use the dev mailing list. So > patch attached, and a small description: >

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-30 Thread Timo Rothenpieler
> dont remember if it was specific to libfaac but some issues in the > mov edit list patches about initial padding and trailing padding > where found using libfaac as encoder. > if libfaac support is droped, muxers wont be tested against it anymore > most likely. It could be done with command line

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg: use new decode API

2016-09-30 Thread Timo Rothenpieler
> Will push this patch in 24 hours unless other problems are pointed out. +1 for pushing the entire series. Changes like this are almost impossible to do without breaking some corner cases. Delaying it until all of those are fixed won't get the project anywhere. So far I haven't found anything th

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg: use new decode API

2016-09-30 Thread wm4
On Fri, 30 Sep 2016 10:38:41 +0200 Timo Rothenpieler wrote: > > Will push this patch in 24 hours unless other problems are pointed out. > > +1 for pushing the entire series. > Changes like this are almost impossible to do without breaking some > corner cases. > Delaying it until all of those a

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg: use new decode API

2016-09-30 Thread Timo Rothenpieler
Am 30.09.2016 um 10:43 schrieb wm4: > On Fri, 30 Sep 2016 10:38:41 +0200 > Timo Rothenpieler wrote: > >>> Will push this patch in 24 hours unless other problems are pointed out. >> >> +1 for pushing the entire series. >> Changes like this are almost impossible to do without breaking some >> cor

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg: use new decode API

2016-09-30 Thread Carl Eugen Hoyos
2016-09-30 10:43 GMT+02:00 wm4 : > Keep in mind that I'll fix anything that is pointed out and > reproducible. This seems to contradict your last two emails... Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/l

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg: use new decode API

2016-09-30 Thread Hendrik Leppkes
On Fri, Sep 30, 2016 at 11:07 AM, Carl Eugen Hoyos wrote: > 2016-09-30 10:43 GMT+02:00 wm4 : > >> Keep in mind that I'll fix anything that is pointed out and >> reproducible. > > This seems to contradict your last two emails... Please keep the discussion technical. If you can point out a reprodu

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg: use new decode API

2016-09-30 Thread Marton Balint
On Fri, 30 Sep 2016, wm4 wrote: On Thu, 29 Sep 2016 23:35:49 +0200 Michael Niedermayer wrote: On Thu, Sep 29, 2016 at 08:25:18PM +0200, wm4 wrote: > This is a bit messy, mainly due to timestamp handling. > > decode_video() relied on the fact that it could set dts on a flush/drain > packet.

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg: use new decode API

2016-09-30 Thread wm4
On Fri, 30 Sep 2016 11:12:31 +0200 (CEST) Marton Balint wrote: > On Fri, 30 Sep 2016, wm4 wrote: > > > On Thu, 29 Sep 2016 23:35:49 +0200 > > Michael Niedermayer wrote: > > > >> On Thu, Sep 29, 2016 at 08:25:18PM +0200, wm4 wrote: > >> > This is a bit messy, mainly due to timestamp handling

[FFmpeg-devel] [PATCH 1/3] lavc/utils: disallow zero sized packets with data set in avcodec_send_packet

2016-09-30 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/utils.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index cf85300..d0a6817 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -2813,6 +2813,9 @@ int attribute_align_arg avcodec_send_packet(AVC

[FFmpeg-devel] [PATCH 2/3] ffmpeg: warn users about demuxers producing zero sized packets

2016-09-30 Thread Marton Balint
Signed-off-by: Marton Balint --- ffmpeg.c | 9 + 1 file changed, 9 insertions(+) diff --git a/ffmpeg.c b/ffmpeg.c index 9a8e65a..2296df8 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -3865,10 +3865,19 @@ static int process_input(int file_index) int ret, i, j; int64_t duration; i

[FFmpeg-devel] [PATCH 3/3] lavd/openal: return EAGAIN if no samples are available

2016-09-30 Thread Marton Balint
Signed-off-by: Marton Balint --- libavdevice/openal-dec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavdevice/openal-dec.c b/libavdevice/openal-dec.c index 0647952..8773944 100644 --- a/libavdevice/openal-dec.c +++ b/libavdevice/openal-dec.c @@ -191,6 +191,9 @@ static int read_pack

Re: [FFmpeg-devel] [PATCH 1/3] lavc/utils: disallow zero sized packets with data set in avcodec_send_packet

2016-09-30 Thread wm4
On Fri, 30 Sep 2016 11:29:05 +0200 Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavcodec/utils.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index cf85300..d0a6817 100644 > --- a/libavcodec/utils.c > +++ b/libavcodec/ut

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg: warn users about demuxers producing zero sized packets

2016-09-30 Thread wm4
On Fri, 30 Sep 2016 11:29:06 +0200 Marton Balint wrote: > Signed-off-by: Marton Balint > --- > ffmpeg.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/ffmpeg.c b/ffmpeg.c > index 9a8e65a..2296df8 100644 > --- a/ffmpeg.c > +++ b/ffmpeg.c > @@ -3865,10 +3865,19 @@ static int p

Re: [FFmpeg-devel] [PATCH 3/3] lavd/openal: return EAGAIN if no samples are available

2016-09-30 Thread wm4
On Fri, 30 Sep 2016 11:29:07 +0200 Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavdevice/openal-dec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavdevice/openal-dec.c b/libavdevice/openal-dec.c > index 0647952..8773944 100644 > --- a/libavdevice/openal-dec

Re: [FFmpeg-devel] [PATCH 3/3] lavd/openal: return EAGAIN if no samples are available

2016-09-30 Thread Nicolas George
Le nonidi 9 vendémiaire, an CCXXV, Marton Balint a écrit : > Signed-off-by: Marton Balint > --- > libavdevice/openal-dec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavdevice/openal-dec.c b/libavdevice/openal-dec.c > index 0647952..8773944 100644 > --- a/libavdevice/openal-de

Re: [FFmpeg-devel] [PATCH 1/3] lavc/utils: disallow zero sized packets with data set in avcodec_send_packet

2016-09-30 Thread Hendrik Leppkes
On Fri, Sep 30, 2016 at 11:40 AM, wm4 wrote: > On Fri, 30 Sep 2016 11:29:05 +0200 > Marton Balint wrote: > >> Signed-off-by: Marton Balint >> --- >> libavcodec/utils.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/libavcodec/utils.c b/libavcodec/utils.c >> index cf85300..d0a681

[FFmpeg-devel] [PATCH] configure: define _GNU_SOURCE on cygwin

2016-09-30 Thread Timo Rothenpieler
Some function definitions are missing without it, for example sigaction. Fixes ticket #5868 --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 899057d..0e2f459 100755 --- a/configure +++ b/configure @@ -4805,6 +4805,7 @@ case $target_os in objfo

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-30 Thread Rostislav Pehlivanov
On 29 September 2016 at 21:54, Josh de Kock wrote: > There is really no need for two aac wrappers, we already have > libfdk-aac which is better. Not to mention that faac doesn't > even support HEv1, or HEv2. It's also under a license which is > unusable for distribution, so it would only be usefu

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-30 Thread wm4
On Fri, 30 Sep 2016 14:16:40 +0100 Rostislav Pehlivanov wrote: > On 29 September 2016 at 21:54, Josh de Kock wrote: > > > There is really no need for two aac wrappers, we already have > > libfdk-aac which is better. Not to mention that faac doesn't > > even support HEv1, or HEv2. It's also unde

[FFmpeg-devel] [PATCH] lavc/mediacodecdec_h2645: fix nalu data_size type

2016-09-30 Thread Matthieu Bouron
From: Matthieu Bouron --- libavcodec/mediacodecdec_h2645.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mediacodecdec_h2645.c b/libavcodec/mediacodecdec_h2645.c index 122be88..9f8110c 100644 --- a/libavcodec/mediacodecdec_h2645.c +++ b/libavcodec/mediacodecdec_h

Re: [FFmpeg-devel] [PATCH] lavc/mediacodecdec_h2645: fix nalu data_size type

2016-09-30 Thread Josh de Kock
On 30/09/2016 17:34, Matthieu Bouron wrote: From: Matthieu Bouron --- libavcodec/mediacodecdec_h2645.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mediacodecdec_h2645.c b/libavcodec/mediacodecdec_h2645.c index 122be88..9f8110c 100644 --- a/libavcodec/mediacod

Re: [FFmpeg-devel] [PATCH] lavc/mediacodecdec_h2645: fix nalu data_size type

2016-09-30 Thread wm4
On Fri, 30 Sep 2016 17:51:42 +0100 Josh de Kock wrote: > On 30/09/2016 17:34, Matthieu Bouron wrote: > > From: Matthieu Bouron > > > > --- > > libavcodec/mediacodecdec_h2645.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/mediacodecdec_h2645.c > > b/

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-30 Thread Michael Niedermayer
On Fri, Sep 30, 2016 at 10:33:04AM +0200, Timo Rothenpieler wrote: > > dont remember if it was specific to libfaac but some issues in the > > mov edit list patches about initial padding and trailing padding > > where found using libfaac as encoder. > > if libfaac support is droped, muxers wont be t

Re: [FFmpeg-devel] [PATCH 3/3] lavd/openal: return EAGAIN if no samples are available

2016-09-30 Thread Marton Balint
On Fri, 30 Sep 2016, Nicolas George wrote: Le nonidi 9 vendémiaire, an CCXXV, Marton Balint a écrit : Signed-off-by: Marton Balint --- libavdevice/openal-dec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavdevice/openal-dec.c b/libavdevice/openal-dec.c index 0647952..8773944 10

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-30 Thread Rostislav Pehlivanov
On 30 September 2016 at 18:12, Michael Niedermayer wrote: > On Fri, Sep 30, 2016 at 10:33:04AM +0200, Timo Rothenpieler wrote: > > > dont remember if it was specific to libfaac but some issues in the > > > mov edit list patches about initial padding and trailing padding > > > where found using li

[FFmpeg-devel] [PATCH] lavf/aviobuf.c: Adapt avio_accept and avio_handshake to new AVIOContext API

2016-09-30 Thread Stephan Holljes
Signed-off-by: Stephan Holljes --- libavformat/aviobuf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) This fixes doc/examples/http_multiclient.c from segfaulting. Seems like these functions were forgotten during the white- and blacklisting update. diff --git a/libavformat/aviobu

Re: [FFmpeg-devel] [PATCH 3/3] lavd/openal: return EAGAIN if no samples are available

2016-09-30 Thread Nicolas George
Le nonidi 9 vendémiaire, an CCXXV, Marton Balint a écrit : > Alsa dev and v4l2 seem to work this way regardless if non blocking mode is > set or not, After a quick glance, no, they do not, at least provided the kernel and system libraries keep the same promise (which, AFAIK, they do). >

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg: use new decode API

2016-09-30 Thread Michael Niedermayer
On Thu, Sep 29, 2016 at 08:25:18PM +0200, wm4 wrote: > This is a bit messy, mainly due to timestamp handling. > > decode_video() relied on the fact that it could set dts on a flush/drain > packet. This is not possible with the old API, and won't be. (I think > doing this was very questionable with

Re: [FFmpeg-devel] [PATCH 3/3] lavd/openal: return EAGAIN if no samples are available

2016-09-30 Thread Marton Balint
On Fri, 30 Sep 2016, Nicolas George wrote: Le nonidi 9 vendémiaire, an CCXXV, Marton Balint a écrit : Alsa dev and v4l2 seem to work this way regardless if non blocking mode is set or not, After a quick glance, no, they do not, at least provided the kernel and system libraries keep the same

[FFmpeg-devel] [PATCH] lavd/openal: don't return zero sized packet if no samples are available

2016-09-30 Thread Marton Balint
Signed-off-by: Marton Balint --- libavdevice/openal-dec.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavdevice/openal-dec.c b/libavdevice/openal-dec.c index 0647952..6eb0efe 100644 --- a/libavdevice/openal-dec.c +++ b/libavdevice/openal-dec.c @@ -187,9 +1

Re: [FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

2016-09-30 Thread Michael Niedermayer
On Fri, Sep 30, 2016 at 08:00:53PM +0100, Rostislav Pehlivanov wrote: > On 30 September 2016 at 18:12, Michael Niedermayer > wrote: > > > On Fri, Sep 30, 2016 at 10:33:04AM +0200, Timo Rothenpieler wrote: > > > > dont remember if it was specific to libfaac but some issues in the > > > > mov edit

Re: [FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: support mkdir_p for use_localtime_mkdir

2016-09-30 Thread Steven Liu
2016-09-28 16:28 GMT+08:00 Steven Liu : > Tested-by: Zuo Genyu <1515161...@qq.com> (Windows) > > > 2016-09-28 16:13 GMT+08:00 Steven Liu : > >> >> >> 2016-09-27 21:56 GMT+08:00 Steven Liu : >> >>> >>> >>> 2016-09-27 6:50 GMT+08:00 Michael Niedermayer : >>> On Mon, Sep 26, 2016 at 04:04:32PM +

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: add flv live stream flag

2016-09-30 Thread Michael Niedermayer
On Fri, Sep 30, 2016 at 01:23:37PM +0800, Steven Liu wrote: > 2016-09-30 0:53 GMT+08:00 Michael Niedermayer : > > > On Thu, Sep 29, 2016 at 09:25:35PM +0800, Steven Liu wrote: > > > patch update > > > > > > merge 1/2 and 2/2 into one patch > > > > > doc/muxers.texi |5 + > > > libavf

[FFmpeg-devel] Does ffmpeg allow negative cts_offset in mp4 trun box?

2016-09-30 Thread Matt Wolenetz
Per spec, if cts_offset is signed, the box version needs to be set to 1. Yet I see no corresponding condition around this in libavformat/movenc.c; version is hardcoded to 0 and the *signed int32* typed value is written out. This can cause issues in players if they follow the spec and expect a vers

[FFmpeg-devel] [PATCH 1/2] fate: Add fate-svq3-watermark

2016-09-30 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- tests/fate/qt.mak | 3 ++- tests/ref/fate/svq3-watermark | 15 +++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 tests/ref/fate/svq3-watermark diff --git a/tests/fate/qt.mak b/tests/fate/qt.mak index 670523e..

[FFmpeg-devel] [PATCH 2/2] fate: Add regression test for Ticket 186

2016-09-30 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- tests/fate/video.mak | 3 +- tests/ref/fate/mpeg2-ticket186 | 357 + 2 files changed, 359 insertions(+), 1 deletion(-) create mode 100644 tests/ref/fate/mpeg2-ticket186 diff --git a/tests/fate/video.mak b

[FFmpeg-devel] [PATCH] doc/developer: improve Development Policy formatting

2016-09-30 Thread Josh de Kock
Signed-off-by: Josh de Kock --- doc/developer.texi | 163 - 1 file changed, 74 insertions(+), 89 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index 4d3a7ae..2df58a9 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @

[FFmpeg-devel] [PATCH] doc/t2h: add max-width to css.

2016-09-30 Thread Josh de Kock
Full width text is really difficult to read, this just makes it slightly more legible on larger (widescreen) screens. Signed-off-by: Josh de Kock --- See http://screenshotcomparison.com/comparison/186256 for a comparison of before/after. doc/t2h.init | 2 +- doc/t2h.pm | 2 +- 2 files change

Re: [FFmpeg-devel] [PATCH 1/2] fate: Add fate-svq3-watermark

2016-09-30 Thread Michael Niedermayer
On Sat, Oct 01, 2016 at 02:27:15AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tests/fate/qt.mak | 3 ++- > tests/ref/fate/svq3-watermark | 15 +++ > 2 files changed, 17 insertions(+), 1 deletion(-) > create mode 100644 tests/ref/fate/s

Re: [FFmpeg-devel] [PATCH 1/2] fate: Add fate-svq3-watermark

2016-09-30 Thread Josh de Kock
On 01/10/2016 02:56, Michael Niedermayer wrote: On Sat, Oct 01, 2016 at 02:27:15AM +0200, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- tests/fate/qt.mak | 3 ++- tests/ref/fate/svq3-watermark | 15 +++ 2 files changed, 17 insertions(+), 1 deletion(

[FFmpeg-devel] [PATCH] libavdevice/lavfi.c: adjust subcc_packet->pts to be in 90 timebase

2016-09-30 Thread Chris Landry
From: Chris Landry When a video stream timebase is not 90k, the cc packet pts is relevant to the timebase of the video stream, but later is assumed to be 90k. Adjust it here to be 90k so timing is accurate in resulting subs. Signed-off-by: Chris Landry --- libavdevice/lavfi.c | 11 ++