Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegts: Skip over broken 0x80 headers

2016-04-28 Thread Carl Eugen Hoyos
Kieran Kunhya obe.tv> writes: > > It is very important that FFmpeg also decodes invalid > > files as long as no valid files are affected. > > Nonsense, > should FFmpeg be able to decode any file created by using netcat > on random RTP data? > Should FFmpeg be able to decode wireshark dumps wh

[FFmpeg-devel] [PATCH 1/3] lavc/bsf: add a null bitstream filter.

2016-04-28 Thread Nicolas George
It passes packets unchanged with a very low overhead. Using it allows to have the same code path when bitstream filtering is not used, making the code simpler and avoiding bitroting. The filter can not be disabled so that applications can rely on it. It is added out of alphabetical order to keep th

[FFmpeg-devel] [PATCH 2/3] lavf/concat: switch to new BSF API.

2016-04-28 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/concatdec.c | 165 ++-- 1 file changed, 76 insertions(+), 89 deletions(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index b3a430e..bbea158 100644 --- a/libavformat/concatdec.c +++ b/lib

[FFmpeg-devel] [PATCH 3/3] fate: add test for concat with and without automatic filtering.

2016-04-28 Thread Nicolas George
Signed-off-by: Nicolas George --- tests/convert.ffconcat | 3 +++ tests/fate/concatdec.mak | 9 + tests/ref/fate/concat-demuxer-convert-lavf-h264| 1 + tests/ref/fate/concat-demuxer-convert-lavf-h264-noconv | 1 + 4 fil

Re: [FFmpeg-devel] [PATCH 1/3] lavc/bsf: add a null bitstream filter.

2016-04-28 Thread Hendrik Leppkes
On Thu, Apr 28, 2016 at 12:36 PM, Hendrik Leppkes wrote: > On Thu, Apr 28, 2016 at 11:06 AM, Nicolas George wrote: >> The filter can not be disabled so that applications can rely on it. >> > > It probably does generally no harm to include it since its tiny, > however it would still show up in con

Re: [FFmpeg-devel] [PATCH 1/3] lavc/bsf: add a null bitstream filter.

2016-04-28 Thread Hendrik Leppkes
On Thu, Apr 28, 2016 at 11:06 AM, Nicolas George wrote: > The filter can not be disabled so that applications can rely on it. > It probably does generally no harm to include it since its tiny, however it would still show up in configure and be disable-able in configure (since the list is generate

[FFmpeg-devel] [PATCH] Bonk decoder and demuxer

2016-04-28 Thread Paul B Mahol
Hi, patches attached. From 506e14978a831424134c63695ddb386fa56dcfc9 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Mon, 25 Apr 2016 20:42:58 +0200 Subject: [PATCH 1/2] avcodec: add Bonk decoder Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 +

Re: [FFmpeg-devel] [PATCH 3/3] configure: Remove -Wredundant-decls on OS/2 to suppress noise.

2016-04-28 Thread KO Myung-Hun
Dmitriy Kuminov wrote: > On 2016-04-21 06:46:38 +, Reimar Döffinger said: > >> Have something that results in adding -I/usr/include to the compile >> options or to C_INCLUDE_PATH? Probably your compiler is misconfigured >> to not consider that a system include path. >> Adding -isystem /usr/i

[FFmpeg-devel] [PATCH] lavfi, ffmpeg: simplify filter names.

2016-04-28 Thread Nicolas George
The names are only used for technical output and debugging. Make them similar to C identifiers for easier quick reading of debug dumps. Signed-off-by: Nicolas George --- ffmpeg_filter.c | 24 libavfilter/avfiltergraph.c | 6 +++--- 2 files changed, 15 insert

Re: [FFmpeg-devel] [PATCH 1/3] lavc/bsf: add a null bitstream filter.

2016-04-28 Thread Nicolas George
Le decadi 10 floréal, an CCXXIV, Hendrik Leppkes a écrit : > It probably does generally no harm to include it since its tiny, That was my reasoning. > however it would still show up in configure and be disable-able in > configure (since the list is generated from the extern const bitstream > filt

[FFmpeg-devel] [PATCH] avcodec/utils: split side-data in new decode API too

2016-04-28 Thread wm4
The deprecated avcodec_decode_video2() and avcodec_decode_audio4() functions called av_packet_split_side_data() on the input packets. This is required for packets produced by libavformat with the AVFMT_FLAG_KEEP_SIDE_DATA flag unset (which is unfortunately the default). The new API didn't do this

Re: [FFmpeg-devel] [PATCH 1/3] lavc/bsf: add a null bitstream filter.

2016-04-28 Thread Michael Niedermayer
On Thu, Apr 28, 2016 at 03:24:10PM +0200, Nicolas George wrote: > Le decadi 10 floréal, an CCXXIV, Hendrik Leppkes a écrit : > > It probably does generally no harm to include it since its tiny, > > That was my reasoning. > > > however it would still show up in configure and be disable-able in > >

Re: [FFmpeg-devel] [PATCH 1/3] lavc/bsf: add a null bitstream filter.

2016-04-28 Thread Nicolas George
Le decadi 10 floréal, an CCXXIV, Michael Niedermayer a écrit : > i think a system that allows user apps to add their own > bitstream filters would be good Possibly, but that is completely unrelated to the current discussion. Regards, -- Nicolas George signature.asc Description: Digital sign

Re: [FFmpeg-devel] [PATCH 3/3] fate: add test for concat with and without automatic filtering.

2016-04-28 Thread James Almer
On 4/28/2016 6:06 AM, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > tests/convert.ffconcat | 3 +++ > tests/fate/concatdec.mak | 9 + > tests/ref/fate/concat-demuxer-convert-lavf-h264| 1 + > tests/ref/f

[FFmpeg-devel] [PATCH]lavd/decklink_dec: Make bitrate calculation 64bit

2016-04-28 Thread Carl Eugen Hoyos
Hi! I hope attached patch fixes an issue seen in a decklink user report where the bit_rate was negative. Or should the division be changed to 1ULL/...? Completely untested. Please review, Carl Eugen diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 9d7dc97..89c1a8b 1

Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Make bitrate calculation 64bit

2016-04-28 Thread Nicolas George
Le decadi 10 floréal, an CCXXIV, Carl Eugen Hoyos a écrit : > I hope attached patch fixes an issue seen in a decklink user report where > the bit_rate was negative. Or should the division be changed to 1ULL/...? This does not make the computation 64 bits, it makes them whatever the size happens t

Re: [FFmpeg-devel] [PATCH] Bonk decoder and demuxer

2016-04-28 Thread Piotr Bandurski
Hi, I did a quick test, but it's not bitexact here: https://www.datafilehost.com/d/4820b89a Regards ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Chrome not able to playback aac_he_v2 when remuxed from mpegts to mp4 using the aac_adtstoasc bitstream filter

2016-04-28 Thread Anders Rein
Google Chrome is not able to playback aac_he_v2 streams remuxed from mpegts to mp4. To reproduce the problem: ffmpeg -f lavfi -i 'aevalsrc=sin(2*PI*t*440)[out0]' -t 10 -movflags faststart -c:a libfdk_aac -ac 2 -ar 48000 -profile:a aac_he_v2 -f mpegts tmp.ts ffmpeg -i tmp.ts -c copy -bsf:a aac_

Re: [FFmpeg-devel] [PATCH] Bonk decoder and demuxer

2016-04-28 Thread Piotr Bandurski
> I did a quick test, but it's not bitexact here: > > https://www.datafilehost.com/d/4820b89a also it deadlocks with mono files: https://www.datafilehost.com/d/b702c504 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/li

Re: [FFmpeg-devel] [PATCH] Bonk decoder and demuxer

2016-04-28 Thread James Almer
On 4/28/2016 8:13 AM, Paul B Mahol wrote: > +static av_cold int bonk_init(AVCodecContext *avctx) > +{ > +BonkContext *s = avctx->priv_data; > +int i; > + > +avctx->sample_fmt = AV_SAMPLE_FMT_S16; > +if (avctx->extradata_size < 17) > +return AVERROR(EINVAL); > + > +if

Re: [FFmpeg-devel] Chrome not able to playback aac_he_v2 when remuxed from mpegts to mp4 using the aac_adtstoasc bitstream filter

2016-04-28 Thread Sergey Volk
Looks like it's failing here: https://code.google.com/p/chromium/codesearch#chromium/src/media/filters/ffmpeg_audio_decoder.cc&l=419 Here is the error message I got from Chrome: [1:9:0428/101459:VERBOSE2:decoder_selector.cc(195)] InitializeDecoder [1:9:0428/101459:ERROR:ffmpeg_audio_decoder.cc(421

Re: [FFmpeg-devel] [PATCH 3/3] configure: Remove -Wredundant-decls on OS/2 to suppress noise.

2016-04-28 Thread Dmitriy Kuminov
On 2016-04-28 12:13:21 +, KO Myung-Hun said: Then, it may be a problem of pkg-config. pkg-config does not output system header directories such as /usr/include unless PKG_CONFIG_ALLOW_SYSTEM_CFLAGS is set. However, pkg-config seems not to think of /@unixroot/usr/include as a system header di

Re: [FFmpeg-devel] [PATCH] Bonk decoder and demuxer

2016-04-28 Thread Paul B Mahol
Dana 28. 4. 2016. 18:47 osoba "Piotr Bandurski" napisala je: > > Hi, > > I did a quick test, but it's not bitexact here: > > https://www.datafilehost.com/d/4820b89a > You sure this is lossless file? > Regards > > ___ > ffmpeg-devel mailing list > ffmpe

Re: [FFmpeg-devel] [PATCH] Bonk decoder and demuxer

2016-04-28 Thread Piotr Bandurski
> > I did a quick test, but it's not bitexact here: > > > > https://www.datafilehost.com/d/4820b89a > > > > You sure this is lossless file? Yes. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avfilter/af_amix: dont fail if there are no samples in output_frame()

2016-04-28 Thread Michael Niedermayer
Fixes Ticket5326 Signed-off-by: Michael Niedermayer --- libavfilter/af_amix.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/af_amix.c b/libavfilter/af_amix.c index e64e289..3e5e7ee 100644 --- a/libavfilter/af_amix.c +++ b/libavfilter/af_amix.c @@ -312,6 +312,9 @@ static i

Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Make bitrate calculation 64bit

2016-04-28 Thread Michael Niedermayer
On Thu, Apr 28, 2016 at 05:30:36PM +0200, Nicolas George wrote: > Le decadi 10 floréal, an CCXXIV, Carl Eugen Hoyos a écrit : > > I hope attached patch fixes an issue seen in a decklink user report where > > the bit_rate was negative. Or should the division be changed to 1ULL/...? > > This does n

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegts: Skip over broken 0x80 headers

2016-04-28 Thread Kieran Kunhya
On Thu, 28 Apr 2016 at 08:42 Carl Eugen Hoyos wrote: > Kieran Kunhya obe.tv> writes: > > > > It is very important that FFmpeg also decodes invalid > > > files as long as no valid files are affected. > > > > Nonsense, > > > should FFmpeg be able to decode any file created by using netcat > > on r

Re: [FFmpeg-devel] [PATCH] Bonk decoder and demuxer

2016-04-28 Thread Paul B Mahol
On 4/28/16, Piotr Bandurski wrote: >> I did a quick test, but it's not bitexact here: >> >> https://www.datafilehost.com/d/4820b89a > > also it deadlocks with mono files: > > https://www.datafilehost.com/d/b702c504 > Did you used lossless mode with this one? If not, could you provide source of th

Re: [FFmpeg-devel] [PATCH] Bonk decoder and demuxer

2016-04-28 Thread Piotr Bandurski
> > also it deadlocks with mono files: > > > > https://www.datafilehost.com/d/b702c504 > > > > Did you used lossless mode with this one? If not, could you provide > source of this file? this file should be lossless as well, but just in case here is source wav file: https://www.datafilehost.com/d

Re: [FFmpeg-devel] [PATCH] Bonk decoder and demuxer

2016-04-28 Thread Paul B Mahol
On 4/28/16, Paul B Mahol wrote: > Hi, > > patches attached. > Improved version attached. From 1a330f7bba56bc1f7ed8f972c130f2a3997fd5b8 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Mon, 25 Apr 2016 20:42:58 +0200 Subject: [PATCH 1/2] avcodec: add Bonk decoder Signed-off-by: Paul B Mahol --

Re: [FFmpeg-devel] [PATCH] Bonk decoder and demuxer

2016-04-28 Thread Piotr Bandurski
> Improved version attached. I found another bug, this time in lossy mode - the file encoded as "joint stereo" decodes after a few seconds into noise: https://www.datafilehost.com/d/c2e8b332 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http:/

Re: [FFmpeg-devel] [PATCH 02/12] lavf: update auto-bsf to new BSF API

2016-04-28 Thread Rodger Combs
> On Apr 27, 2016, at 07:29, Nicolas George wrote: > > Le nonidi 9 floréal, an CCXXIV, Rodger Combs a écrit : >> --- >> libavformat/internal.h | 5 +++-- >> libavformat/mux.c | 40 +- >> libavformat/segment.c | 6 +++-- >> libavformat/utils.c| 59 >>

[FFmpeg-devel] [PATCH] avformat/movenc: Skip unsupported video tracks in timecode generation

2016-04-28 Thread Michael Niedermayer
Fixes Ticket5414 Signed-off-by: Michael Niedermayer --- libavformat/movenc.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 5acb9af..76032c8 100644 --- a/libavformat/movenc.c +++ b/libavfo

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/dca: move channel counter utility into dca.h

2016-04-28 Thread James Almer
On 4/27/2016 2:21 PM, foo86 wrote: > Also add actual speaker pair definitions. > --- > libavcodec/dca.h | 28 > libavcodec/dca_exss.c | 9 ++--- > 2 files changed, 30 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/dca.h b/libavcodec/dca.h > index

Re: [FFmpeg-devel] [PATCH 0/5] DTS Express (LBR) decoder

2016-04-28 Thread James Almer
On 4/27/2016 2:19 PM, foo86 wrote: > This moves several DCA tables around in preparation and adds decoder for DTS > Express (LBR) format that is typically used for secondary audio tracks on BDs. > > Current implementation supports decoding mono, stereo and 5.1 tracks at > maximum > sampling rate

Re: [FFmpeg-devel] [PATCH] avcodec/utils: split side-data in new decode API too

2016-04-28 Thread Michael Niedermayer
On Thu, Apr 28, 2016 at 03:34:34PM +0200, wm4 wrote: > The deprecated avcodec_decode_video2() and avcodec_decode_audio4() > functions called av_packet_split_side_data() on the input packets. This > is required for packets produced by libavformat with the > AVFMT_FLAG_KEEP_SIDE_DATA flag unset (whic

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/dca: add DTS Express (LBR) decoder

2016-04-28 Thread James Almer
On 4/27/2016 2:22 PM, foo86 wrote: > --- > Changelog|1 + > libavcodec/Makefile |2 +- > libavcodec/dca_lbr.c | 1858 > ++ > libavcodec/dca_lbr.h | 130 > libavcodec/dcadata.c | 460 + > libavcodec/dcadata.h |

Re: [FFmpeg-devel] [PATCH] Bonk decoder and demuxer

2016-04-28 Thread Michael Niedermayer
On Thu, Apr 28, 2016 at 01:13:34PM +0200, Paul B Mahol wrote: > Hi, > > patches attached. [...] > +static int bonk_probe(AVProbeData *p) > +{ > +int i; > + > +for (i = 0; i < p->buf_size - 5; i++) { > +if (!p->buf[i] && AV_RL32(p->buf + i + 1) == MKTAG('B','O','N','K')) > +