[FFmpeg-devel] [PATCH] avcodec/mips: Optimization synced to the newest code base.

2016-03-29 Thread Jovan Zelincevic
FFT expanded to 2^17. Signed-off-by: Jovan Zelincevic --- libavcodec/mips/fft_mips.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/mips/fft_mips.c b/libavcodec/mips/fft_mips.c index 529e076..03dcbad 100644 --- a/libavcodec/mips/fft_mips.c +++ b/libavc

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Demux the PixelCrop* values

2016-03-29 Thread wm4
On Sat, 26 Mar 2016 16:56:55 -0600 Nic Wolfe wrote: > The Matroska spec defines PixelCropTop, PixelCropBottom, PixelCropLeft, > and PixelCropRight elements: > https://www.matroska.org/technical/specs/index.html > > This commit adds support for demuxing these values so that > applications using

[FFmpeg-devel] [PATCH] lavu/base64: add AV_BASE64_DECODE_SIZE() macro

2016-03-29 Thread Stefano Sabatini
This is consistent with the AV_BASE64_SIZE macro and avoids the literal use of constants in the code. TODO: update APIchanges and bump minor. --- libavutil/base64.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavutil/base64.h b/libavutil/base64.h index 514498e..

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Demux the PixelCrop* values

2016-03-29 Thread Dave Rice
Hi, > On Mar 29, 2016, at 4:23 AM, wm4 wrote: > > On Sat, 26 Mar 2016 16:56:55 -0600 > Nic Wolfe wrote: > >> The Matroska spec defines PixelCropTop, PixelCropBottom, PixelCropLeft, >> and PixelCropRight elements: >> https://www.matroska.org/technical/specs/index.html >> >> This commit adds s

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Optimization synced to the newest code base.

2016-03-29 Thread Nedeljko Babic
LGTM - Nedeljko Od: Jovan Zelincevic Poslato: 29. mart 2016 9:43 Za: ffmpeg-devel@ffmpeg.org Cc: Zeljko Lukac; Nedeljko Babic; Jovan Zelincevic Tema: [PATCH] avcodec/mips: Optimization synced to the newest code base. FFT expanded to 2^17. Signed-off-by: J

[FFmpeg-devel] [PATCH v3 1/3] Refactor close_slaves function in tee muxer

2016-03-29 Thread sebechlebskyjan
From: Jan Sebechlebsky Closing single slave operation is pulled out into separate function close_slave(TeeSlave*). Both close_slave and close_slaves function are moved before open_slave function. Signed-off-by: Jan Sebechlebsky --- libavformat/tee.c | 58 ++-

Re: [FFmpeg-devel] [PATCH v2 2/3] Fix leaks in tee muxer when open_slave fails

2016-03-29 Thread Jan Sebechlebsky
On 03/24/2016 09:51 PM, Marton Balint wrote: On Thu, 24 Mar 2016, Jan Sebechlebsky wrote: Calling close_slave in case error is to be returned from open_slave will free allocated resources. Since failure can happen before bsfs array is initialized, close_slave must check that bsfs is not NUL

[FFmpeg-devel] [PATCH v3 2/3] Fix leak and crash in tee muxer when open_slave fails

2016-03-29 Thread sebechlebskyjan
From: Jan Sebechlebsky Calling close_slave in case error is to be returned from open_slave will free allocated resources. Since failure can happen before bsfs array is initialized, close_slave must check that bsfs is not NULL before accessing tee_slave->bsfs[i] element. Signed-off-by: Jan Sebec

[FFmpeg-devel] [RFC]lavf/mpegtsenc: Allow DVB stream_type for mp2 audio

2016-03-29 Thread Carl Eugen Hoyos
Hi! Could attached maybe fix ticket #5388? Carl Eugen diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 51677ea..e226cfa 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -318,7 +318,9 @@ static int mpegts_write_pmt(AVFormatContext *s, MpegTSService *servic

[FFmpeg-devel] [PATCH v3 1/3] Refactor close_slaves function in tee muxer

2016-03-29 Thread sebechlebskyjan
From: Jan Sebechlebsky Closing single slave operation is pulled out into separate function close_slave(TeeSlave*). Both close_slave and close_slaves function are moved before open_slave function. Signed-off-by: Jan Sebechlebsky --- I've missed bad spacing in close_slave argument in previous ver

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Optimization synced to the newest code base.

2016-03-29 Thread Michael Niedermayer
On Tue, Mar 29, 2016 at 12:51:23PM +, Nedeljko Babic wrote: > LGTM applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship: All citizens are under surveillance, all their steps and actions recorded, for the politicians to enforce control

Re: [FFmpeg-devel] [RFC]lavf/mpegtsenc: Allow DVB stream_type for mp2 audio

2016-03-29 Thread Kieran Kunhya
On Tue, 29 Mar 2016 at 15:32 Carl Eugen Hoyos wrote: > Hi! > > Could attached maybe fix ticket #5388? > > Carl Eugen > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel The correct solution is

[FFmpeg-devel] Fwd: [Build #9405537] armhf build of ffmpeg 7:3.1~~git20160327.62458~ubuntu14.04.1 in ubuntu trusty RELEASE [~motumedia/ubuntu/ffmpeg-daily]

2016-03-29 Thread Reinhard Tartler
Hi, Since a couple of days, the daily builds of FFmpeg on armhf appear to fail on armhf (but not on other archtectures). The relevant part of the build log appears to be this: Test checkasm failed. Look at tests/data/fate/checkasm.err for details. checkasm: using random seed 3250260437 Bus error

Re: [FFmpeg-devel] [PATCH v2 3/3] Tee muxer improvement (handling slave failure)

2016-03-29 Thread Nicolas George
Le decadi 10 germinal, an CCXXIV, Nicolas George a écrit : > Le decadi 10 germinal, an CCXXIV, Jan Sebechlebsky a écrit : > > >>+@item onfail > > >>+Specify behaviour on output failure. This can be set to either 'abort' > > >>(which is > > >I believe @code{...} is recommended for explicit words. >

Re: [FFmpeg-devel] [PATCH v2 3/3] Tee muxer improvement (handling slave failure)

2016-03-29 Thread Jan Sebechlebsky
On 03/29/2016 09:01 PM, Nicolas George wrote: Le decadi 10 germinal, an CCXXIV, Nicolas George a écrit : Le decadi 10 germinal, an CCXXIV, Jan Sebechlebsky a écrit : +@item onfail +Specify behaviour on output failure. This can be set to either 'abort' (which is I believe @code{...} is recomme

Re: [FFmpeg-devel] [RFC]lavf/mpegtsenc: Allow DVB stream_type for mp2 audio

2016-03-29 Thread Carl Eugen Hoyos
On Tuesday 29 March 2016 05:37:02 pm Kieran Kunhya wrote: > On Tue, 29 Mar 2016 at 15:32 Carl Eugen Hoyos wrote: > > > > Could attached maybe fix ticket #5388? > > The correct solution is to give "MP2" the MP1 stream_type and > "MP3" the MP2 stream_type. As in attached? Afaict, this is not what

[FFmpeg-devel] [PATCH v3 3/3] Tee muxer improvement (handling slave failure)

2016-03-29 Thread sebechlebskyjan
From: Jan Sebechlebsky Adds per slave option 'onfail' to the tee muxer allowing an output to fail,so other slave outputs can continue. Signed-off-by: Jan Sebechlebsky --- doc/muxers.texi | 14 libavformat/tee.c | 96 +-- 2 files ch

Re: [FFmpeg-devel] [RFC]lavf/mpegtsenc: Allow DVB stream_type for mp2 audio

2016-03-29 Thread Moritz Barsnick
On Tue, Mar 29, 2016 at 21:09:07 +0200, Carl Eugen Hoyos wrote: > Afaict, this is not what was requested in the ticket though. Pretty much so, except if you want to interpret different things into "broadcasting standards". From an ITU-T H.222.0 standpoint, your patch at least correctly fixes *som

Re: [FFmpeg-devel] [PATCH] mpegts: pcr period option for variable bitrate multiplexing

2016-03-29 Thread Predrag Filipovic
Regarding "pcr is different but once the value is correct, mechanism is the same ... pat/sdt" Correct. These are (pcr vs other) or can be identical for CBR. Identical (mechanisms) is OK for VBR (as a matter of principle) but one could also have simpler implementation for pat/sdt since their lower b

Re: [FFmpeg-devel] [PATCH 6/6] lavc/audiotoolboxdec: fix a number of config and timestamp issues

2016-03-29 Thread Rodger Combs
> On Mar 28, 2016, at 00:39, pon pon > wrote: > > 2016-03-28 2:20 GMT+09:00 Rodger Combs : > >> - ADTS-formatted AAC didn't work >> - Channel layouts were never exported >> - Channel mappings were incorrect beyond stereo >> - Channel counts weren't updated after packets were decoded >> - Times

Re: [FFmpeg-devel] [PATCH 3/6] lavc/audiotoolboxenc: fix iOS build

2016-03-29 Thread Rodger Combs
> On Mar 27, 2016, at 21:13, crossle song wrote: > > Work well on iPhone 6, but on iPhone 4S iOS 9.0, return [aac_at @ > 0x1702a400] Encode error: -50, can not work I don't have a test setup for iOS devices (nor a 4S to test on); does this case work correctly with your patch, but not mine? W

Re: [FFmpeg-devel] [PATCH] lavu/base64: add AV_BASE64_DECODE_SIZE() macro

2016-03-29 Thread Michael Niedermayer
On Tue, Mar 29, 2016 at 12:39:23PM +0200, Stefano Sabatini wrote: > This is consistent with the AV_BASE64_SIZE macro and avoids the literal > use of constants in the code. > > TODO: update APIchanges and bump minor. > --- > libavutil/base64.h | 9 +++-- > 1 file changed, 7 insertions(+), 2 de

Re: [FFmpeg-devel] [PATCH] Implement hdcd filtering

2016-03-29 Thread Michael Niedermayer
On Tue, Mar 29, 2016 at 11:30:28AM +0200, Benjamin St wrote: > > Not all of the comments on top of the filter file look > > very useful to me, what do you think? > > In any case, I'd say a link to these should be useful: > > http://www.audiomisc.co.uk/HFN/HDCD/Enigma.html > > http://www.audiomisc.c

[FFmpeg-devel] Support AS-10 MXF

2016-03-29 Thread NabFab
Hi, Could you please tell me if ffmpeg is supporting AS-10 or AS-11 MXF format according to AMWA specifications ? Thank you --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus __

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-29 Thread Disha Singh
The most recent patch has been attached. The lpc error persists. I have removed some patcheck errors. -Disha On Tue, Mar 29, 2016 at 6:24 AM, Michael Niedermayer wrote: > On Tue, Mar 29, 2016 at 03:13:50AM +0530, Disha Singh wrote: > > What is lpc ? > > linear predictive coding > > > > Which lp

[FFmpeg-devel] [PATCH] avcodec/aacenc_quantization: Fix undefined behavior and instead detect and print an error

2016-03-29 Thread Michael Niedermayer
This is a hotfix and not a real fix of the underlaying bug The underlaying bug is ATM not fully understood iam not sure if we should apply this or not Signed-off-by: Michael Niedermayer --- libavcodec/aacenc_quantization.h | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH 3/6] lavc/audiotoolboxenc: fix iOS build

2016-03-29 Thread crossle song
Please merge the audiotoolbox patch On Wed, Mar 30, 2016 at 10:07 AM, crossle song wrote: > OK, I'll try your all patch before about audiotoolbox > > On Wed, Mar 30, 2016 at 5:01 AM, Rodger Combs > wrote: > >> >> > On Mar 27, 2016, at 21:13, crossle song wrote: >> > >> > Work well on iPhone 6,

Re: [FFmpeg-devel] [PATCH 3/6] lavc/audiotoolboxenc: fix iOS build

2016-03-29 Thread crossle song
OK, I'll try your all patch before about audiotoolbox On Wed, Mar 30, 2016 at 5:01 AM, Rodger Combs wrote: > > > On Mar 27, 2016, at 21:13, crossle song wrote: > > > > Work well on iPhone 6, but on iPhone 4S iOS 9.0, return [aac_at @ > > 0x1702a400] Encode error: -50, can not work > > I don't

Re: [FFmpeg-devel] [PATCH 1/2] tests/audiomatch: also print signal vs reference length

2016-03-29 Thread Michael Niedermayer
On Tue, Mar 22, 2016 at 01:43:46PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tests/audiomatch.c |2 +- > .../fate/audiomatch-afconvert-16000-mono-he-adts |2 +- > .../fate/audiomatch-afconvert-16000-mono-he-m4a|

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-29 Thread Michael Niedermayer
On Wed, Mar 30, 2016 at 06:38:33AM +0530, Disha Singh wrote: > The most recent patch has been attached. The lpc error persists. > I have removed some patcheck errors. > [...] > +/ > + *** Functions that proce

Re: [FFmpeg-devel] [PATCH] avcodec/aacenc_quantization: Fix undefined behavior and instead detect and print an error

2016-03-29 Thread Claudio Freire
On Tue, Mar 29, 2016 at 10:51 PM, Michael Niedermayer wrote: > This is a hotfix and not a real fix of the underlaying bug > The underlaying bug is ATM not fully understood > > iam not sure if we should apply this or not > > Signed-off-by: Michael Niedermayer > --- > libavcodec/aacenc_quantizatio

Re: [FFmpeg-devel] [PATCH] avcodec/aacenc_quantization: Fix undefined behavior and instead detect and print an error

2016-03-29 Thread Claudio Freire
On Wed, Mar 30, 2016 at 1:18 AM, Claudio Freire wrote: > On Tue, Mar 29, 2016 at 10:51 PM, Michael Niedermayer > wrote: >> This is a hotfix and not a real fix of the underlaying bug >> The underlaying bug is ATM not fully understood >> >> iam not sure if we should apply this or not >> >> Signed-o