Re: [FFmpeg-devel] [PATCH 1/3] x86/hevc_sao: simplify sao_band_filter 10/12bit

Hi, 2015-12-16 4:24 GMT+01:00 James Almer : > Ping for patchset. I'll probably have a look on Sunday. But I don't expect my review to be very worthwhile, so several people can probably do a better and faster one. -- Christophe ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 1/3] x86/hevc_sao: simplify sao_band_filter 10/12bit

On Thu, Dec 10, 2015 at 08:02:26PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/x86/hevc_sao_10bit.asm | 142 > +++--- > 1 file changed, 57 insertions(+), 85 deletions(-) should be ok if tested & working (it passes fate here, also che

Re: [FFmpeg-devel] [PATCH 2/3] x86/hevc_sao: simplify sao_edge_filter 10/12bit

On Thu, Dec 10, 2015 at 08:02:27PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/x86/hevc_sao_10bit.asm | 150 > ++ > 1 file changed, 54 insertions(+), 96 deletions(-) tested with various cpuflags on x86-32 ad 64 [...] -- Michael

Re: [FFmpeg-devel] [PATCH] lavu/eval: remove pow and exp2 for postfixes

On Tue, Dec 15, 2015 at 10:56:16PM -0500, Ganesh Ajjanagadde wrote: > These postfixes can be computed statically, and there is no need to > waste runtime resources. > > Tested with FATE. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/eval.c | 52

Re: [FFmpeg-devel] [PATCH 1/2] lavc: move exp2fi to ff_exp2fi in internal.h

On Wed, Dec 16, 2015 at 12:53:28AM -0500, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/internal.h | 19 +++ > libavcodec/jpeg2000.c | 18 ++ > 2 files changed, 21 insertions(+), 16 deletions(-) LGTM thx [...] -- Michael G

Re: [FFmpeg-devel] [PATCH v3 07/14] mips: i6400 core is not mips32r2, so disable mips32r2

On Thu, Dec 03, 2015 at 01:22:22PM +, Vicente Olivert Riera wrote: > Signed-off-by: Vicente Olivert Riera > --- > Changes v2 -> v3: > - Nothing. > > Changes v1 -> v2: > - Nothing. > > configure | 1 + > 1 file changed, 1 insertion(+) applied thanks [...] -- Michael GnuPG fingerpri

Re: [FFmpeg-devel] [PATCH v3 08/14] mips: add mips64r2 architecture variant

On Thu, Dec 03, 2015 at 01:22:23PM +, Vicente Olivert Riera wrote: > Signed-off-by: Vicente Olivert Riera > --- > Changes v2 -> v3: > - Nothing. > > Changes v1 -> v2: > - Nothing. > > configure | 12 > 1 file changed, 12 insertions(+) applied thanks [...] -- Michael G

Re: [FFmpeg-devel] [PATCH] ffmpeg: Allow specifying the program number for created programs

On Tue, Dec 15, 2015 at 04:51:59PM +0100, Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > doc/ffmpeg.texi |4 ++-- > ffmpeg_opt.c| 22 +- > 2 files changed, 23 insertions(+), 3 deletions(-) applied [...] -- M

Re: [FFmpeg-devel] [PATCH] lavu/eval: remove pow and exp2 for postfixes

On Wed, Dec 16, 2015 at 6:17 AM, Michael Niedermayer wrote: > On Tue, Dec 15, 2015 at 10:56:16PM -0500, Ganesh Ajjanagadde wrote: >> These postfixes can be computed statically, and there is no need to >> waste runtime resources. >> >> Tested with FATE. >> >> Signed-off-by: Ganesh Ajjanagadde >> -

Re: [FFmpeg-devel] [PATCH 1/2] lavc: move exp2fi to ff_exp2fi in internal.h

On Wed, Dec 16, 2015 at 6:18 AM, Michael Niedermayer wrote: > On Wed, Dec 16, 2015 at 12:53:28AM -0500, Ganesh Ajjanagadde wrote: >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavcodec/internal.h | 19 +++ >> libavcodec/jpeg2000.c | 18 ++ >> 2 files changed, 2

Re: [FFmpeg-devel] [PATCH] ffmpeg: add progress speed to status line and report

On Fri, Dec 11, 2015 at 16:49:14 +0100, Moritz Barsnick wrote: > This adds a computation of the progress speed versus realtime ("Nx") > to the status line and to the report log. It uses the progress time > as already calculated for total output time as a base. > --- > ffmpeg.c | 15 ++-

Re: [FFmpeg-devel] [PATCH] ffmpeg: add progress speed to status line and report

Le sextidi 26 frimaire, an CCXXIV, Moritz Barsnick a écrit : > BTW, these two are used quite often in this function and sort of beg > for macros, but I don't go around macro-ifying code just for the fun of > it. ;-) No need for macros, there is the av_bprint() API for that. Regards, -- Nicola

Re: [FFmpeg-devel] [PATCH] ffmpeg: add progress speed to status line and report

On Wed, Dec 16, 2015 at 15:28:31 +0100, Nicolas George wrote: > > BTW, these two are used quite often in this function and sort of beg > > for macros, but I don't go around macro-ifying code just for the fun of > > it. ;-) > > No need for macros, there is the av_bprint() API for that. *shrug* OT

Re: [FFmpeg-devel] avfilter/vf_decimate: Check that input parameters match

Le quartidi 24 frimaire, an CCXXIV, Michael Niedermayer a écrit : > ffmpeg | branch: master | Michael Niedermayer | Mon > Dec 14 21:18:39 2015 +0100| [30fe3fd52721c8c6566001192cd16be423ffc92b] | > committer: Michael Niedermayer > > avfilter/vf_decimate: Check that input parameters match > > Fi

Re: [FFmpeg-devel] Cyrillic devices name support in libavdevice/dshow

On 12/14/15, Michael Savin wrote: > Hi, please review this patch for cyrillic devices name support in > libavdevice/dshow. > Bug described here: https://trac.ffmpeg.org/ticket/5045 Still mulling over why this would be needed...hm ___ ffmpeg-devel ma

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

On 12/15/2015 07:25 PM, Mats Peterson wrote: On 12/15/2015 06:51 PM, Mats Peterson wrote: Here is a *suggestion* for how to end the QuickTime palette in Matroska saga. I have created a new file 'qtpalette.c' with a function get_qtpalette(), that will be called from both matroskadec.c and mov.c.

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

On 12/16/2015 06:07 PM, Mats Peterson wrote: On 12/15/2015 07:25 PM, Mats Peterson wrote: On 12/15/2015 06:51 PM, Mats Peterson wrote: Here is a *suggestion* for how to end the QuickTime palette in Matroska saga. I have created a new file 'qtpalette.c' with a function get_qtpalette(), that will

Re: [FFmpeg-devel] [PATCH] lavu/frame: Optimize frame_copy_video

On 12/15/2015 10:39 PM, Jean Delvare wrote: > I see two completely different things. > > The change I proposed is specific to one function, only changes const > vs non-const, and the object under discussion is being accessed for > reading only (thus the const pointer.) It would remove a memcpy but

Re: [FFmpeg-devel] [PATCH] lavu/frame: Optimize frame_copy_video

On 12/16/15, Derek Buitenhuis wrote: > On 12/15/2015 10:39 PM, Jean Delvare wrote: >> I see two completely different things. >> >> The change I proposed is specific to one function, only changes const >> vs non-const, and the object under discussion is being accessed for >> reading only (thus the

Re: [FFmpeg-devel] Cyrillic devices name support in libavdevice/dshow

On 12/16/2015 4:29 PM, Roger Pack wrote: > Still mulling over why this would be needed...hm It makes sense that CP_OEMCP is needed for device names, in my mind, after reading https://support.microsoft.com/en-us/kb/108450 - however, I don't think changing the generic functions in cmdutils.c is

Re: [FFmpeg-devel] avfilter/vf_decimate: Check that input parameters match

On Wed, Dec 16, 2015 at 03:57:47PM +0100, Nicolas George wrote: > Le quartidi 24 frimaire, an CCXXIV, Michael Niedermayer a écrit : > > ffmpeg | branch: master | Michael Niedermayer | > > Mon Dec 14 21:18:39 2015 +0100| [30fe3fd52721c8c6566001192cd16be423ffc92b] > > | committer: Michael Niederma

[FFmpeg-devel] [PATCH 1/2] Revert "avfilter/vf_decimate: Check that input parameters match"

From: Michael Niedermayer ill commit a better solution This reverts commit 30fe3fd52721c8c6566001192cd16be423ffc92b. --- libavfilter/vf_decimate.c |9 - 1 file changed, 9 deletions(-) diff --git a/libavfilter/vf_decimate.c b/libavfilter/vf_decimate.c index cd374c3..a563859 100644 -

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_decimate: Use the correct frame in difference calculation

From: Michael Niedermayer Fixes Ticket4964 Signed-off-by: Michael Niedermayer --- libavfilter/vf_decimate.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_decimate.c b/libavfilter/vf_decimate.c index a563859..9f382ae 100644 --- a/libavfilter/vf_decim

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

On Wed, 16 Dec 2015 18:13:01 +0100, Mats Peterson wrote: > I forgot to remove a "fprintf(stderr, "COLOR COUNT: %d\n", > color_count);" line in qtpalette.c, but it's easy to find. This will just make people ignore the patch because we don't have enough time to update your patch for you. Please pr

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

On 12/16/2015 07:15 PM, Lou Logan wrote: On Wed, 16 Dec 2015 18:13:01 +0100, Mats Peterson wrote: I forgot to remove a "fprintf(stderr, "COLOR COUNT: %d\n", color_count);" line in qtpalette.c, but it's easy to find. This will just make people ignore the patch because we don't have enough time

Re: [FFmpeg-devel] [PATCH] sonic: make sure num_taps is not larger than frame_size

On 16.12.2015 02:08, Michael Niedermayer wrote: > On Tue, Dec 15, 2015 at 11:50:21PM +0100, Andreas Cadhalpun wrote: >> If that is the case, the loop setting predictor_state in >> sonic_decode_frame causes out of bounds reads of int_samples, which has >> only frame_size number of elements. >> >> Si

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

On 12/16/2015 07:18 PM, Mats Peterson wrote: On 12/16/2015 07:15 PM, Lou Logan wrote: On Wed, 16 Dec 2015 18:13:01 +0100, Mats Peterson wrote: I forgot to remove a "fprintf(stderr, "COLOR COUNT: %d\n", color_count);" line in qtpalette.c, but it's easy to find. This will just make people igno

Re: [FFmpeg-devel] [libav-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

On 16.12.2015 02:02, Michael Niedermayer wrote: > On Tue, Dec 15, 2015 at 10:41:15PM +0100, Andreas Cadhalpun wrote: >> opus_silk.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> 253c6f7d87dcadf712840f45dde18f5698b9c1d4 >> 0001-opus_silk-fix-typo-causing-overflow-in-silk_stabiliz

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

On Wed, 16 Dec 2015 19:18:33 +0100, Mats Peterson wrote: > If you can create a proper patchset out of the archive, you can remove > that single line. That will not happen. > It's unnecessary for me to upload a new archive with such a small > change. It's a whole new file, at that. Another reas

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

On 12/16/2015 07:45 PM, Lou Logan wrote: On Wed, 16 Dec 2015 19:18:33 +0100, Mats Peterson wrote: If you can create a proper patchset out of the archive, you can remove that single line. That will not happen. It's unnecessary for me to upload a new archive with such a small change. It's a w

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

On 12/16/2015 07:52 PM, Mats Peterson wrote: On 12/16/2015 07:45 PM, Lou Logan wrote: On Wed, 16 Dec 2015 19:18:33 +0100, Mats Peterson wrote: If you can create a proper patchset out of the archive, you can remove that single line. That will not happen. It's unnecessary for me to upload a

[FFmpeg-devel] [PATCH] on2avc: limit number of bits to 30 in get_egolomb

More don't fit into the integer output. Also use get_bits_long, since get_bits only supports reading up to 25 bits, while get_bits_long supports the full integer range. Signed-off-by: Andreas Cadhalpun --- libavcodec/on2avc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

> I have said before that I'm not going to dwell into the complexities of Git, > since it feels about as wasteful as programming a GUI in my book. If you > can't accept the patches in their current format, so be it. Thanks for your > time and understanding. We accept git patches here and that's th

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

On 12/16/2015 08:26 PM, Kieran Kunhya wrote: I have said before that I'm not going to dwell into the complexities of Git, since it feels about as wasteful as programming a GUI in my book. If you can't accept the patches in their current format, so be it. Thanks for your time and understanding.

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

On 12/16/2015 08:27 PM, Mats Peterson wrote: On 12/16/2015 08:26 PM, Kieran Kunhya wrote: I have said before that I'm not going to dwell into the complexities of Git, since it feels about as wasteful as programming a GUI in my book. If you can't accept the patches in their current format, so be

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

On Wed, Dec 16, 2015 at 8:30 PM, Mats Peterson wrote: > On 12/16/2015 08:27 PM, Mats Peterson wrote: >> >> On 12/16/2015 08:26 PM, Kieran Kunhya wrote: I have said before that I'm not going to dwell into the complexities of Git, since it feels about as wasteful as programming a

[FFmpeg-devel] [PATCH] nuv: reject negative fps rate

Signed-off-by: Andreas Cadhalpun --- libavformat/nuv.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/nuv.c b/libavformat/nuv.c index 2a1b70f..4cb28d5 100644 --- a/libavformat/nuv.c +++ b/libavformat/nuv.c @@ -172,6 +172,10 @@ static int nuv_header(AVFormatContext *s) if

Re: [FFmpeg-devel] [PATCH] lavu/frame: Optimize frame_copy_video

Hi Derek, On Wed, 16 Dec 2015 17:16:26 +, Derek Buitenhuis wrote: > On 12/15/2015 10:39 PM, Jean Delvare wrote: > > I see two completely different things. > > > > The change I proposed is specific to one function, only changes const > > vs non-const, and the object under discussion is being a

Re: [FFmpeg-devel] Cyrillic devices name support in libavdevice/dshow

Hello Derek, Wednesday, December 16, 2015, 8:24:33 PM, you wrote: DB> On 12/16/2015 4:29 PM, Roger Pack wrote: >> Still mulling over why this would be needed...hm DB> It makes sense that CP_OEMCP is needed for device names, in my mind, DB> after reading https://support.microsoft.com/en-us/kb

Re: [FFmpeg-devel] [PATCH] sonic: make sure num_taps is not larger than frame_size

On Wed, Dec 16, 2015 at 07:27:05PM +0100, Andreas Cadhalpun wrote: > On 16.12.2015 02:08, Michael Niedermayer wrote: > > On Tue, Dec 15, 2015 at 11:50:21PM +0100, Andreas Cadhalpun wrote: > >> If that is the case, the loop setting predictor_state in > >> sonic_decode_frame causes out of bounds read

Re: [FFmpeg-devel] Cyrillic devices name support in libavdevice/dshow

Hello All, Wednesday, December 16, 2015, 11:36:17 PM, you wrote: IU> Hello Derek, IU> Wednesday, December 16, 2015, 8:24:33 PM, you wrote: DB>> On 12/16/2015 4:29 PM, Roger Pack wrote: >>> Still mulling over why this would be needed...hm DB>> It makes sense that CP_OEMCP is needed for devi

[FFmpeg-devel] [PATCH] avfilter: add ITU-R 468 noise meter

Signed-off-by: Paul B Mahol --- configure| 1 + doc/filters.texi | 9 ++ libavfilter/Makefile | 1 + libavfilter/af_itur468.c | 222 +++ libavfilter/allfilters.c | 1 + 5 files changed, 234 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH 11/11] diracdec: Add support for HQ profile

On 9 December 2015 at 00:05, Kieran Kunhya wrote: > --- > libavcodec/diracdec.c | 119 > +- > 1 file changed, 80 insertions(+), 39 deletions(-) bump ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 06/11] diracdec: Add 10-bits to pix_fmt table

> this is maybe missing a < 2 check > i see a > 4 check but didnt find a < 2 check from a quick look The check already exists. Keiran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add support for HLS PLAYLIST types EVENT and VOD

Adam Kent semicircular.net> writes: > +if (hls->flags & HLS_EVENT_PLAYLIST) { > +avio_printf(out, "#EXT-X-PLAYLIST-TYPE:EVENT\n"); > +} else if (hls->flags & HLS_VOD_PLAYLIST) { > +avio_printf(out, "#EXT-X-PLAYLIST-TYPE:VOD\n"); This seems to indicate that they are exclus

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

On Wed, 2015-12-16 at 20:30 +0100, Mats Peterson wrote: > On 12/16/2015 08:27 PM, Mats Peterson wrote: > > On 12/16/2015 08:26 PM, Kieran Kunhya wrote: > >>> I have said before that I'm not going to dwell into the complexities > >>> of Git, > >>> since it feels about as wasteful as programming a GU

Re: [FFmpeg-devel] [PATCH] nuv: reject negative fps rate

On Wed, Dec 16, 2015 at 08:56:55PM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/nuv.c | 4 > 1 file changed, 4 insertions(+) looks logical iam not nuv maintainer though and i dont know if all files have fps set [...] -- Michael GnuPG fingerpr

[FFmpeg-devel] [PATCH] diracdec: Fix codeblock parameters reading

--- libavcodec/diracdec.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c index abe1a5a..07eb512 100644 --- a/libavcodec/diracdec.c +++ b/libavcodec/diracdec.c @@ -1128,7 +1128,22 @@ static int dirac_unpack_idwt_pa

[FFmpeg-devel] Add "xmv" extension to the xmv codec

I just submitted a pull request, #166, to https://github.com/FFmpeg/FFmpeg . I am not a ffmpeg developer, but I came across this problem that the extension "xmv" is not associated with XMV format file. This quick one line change fixes that. Thank you for consi

Re: [FFmpeg-devel] [PATCH] ffmpeg: add progress speed to status line and report

On Fri, Dec 11, 2015 at 04:49:14PM +0100, Moritz Barsnick wrote: > This adds a computation of the progress speed versus realtime ("Nx") > to the status line and to the report log. It uses the progress time > as already calculated for total output time as a base. > --- > ffmpeg.c | 15 +

[FFmpeg-devel] [PATCH] Add support for HLS PLAYLIST types EVENT and VOD

Thanks Carl, good point, hope this is better. --- doc/muxers.texi | 8 libavformat/hlsenc.c | 20 2 files changed, 28 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index b6d8823..c6e3b8f 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -368

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

On 12/16/2015 08:30 PM, Mats Peterson wrote: On 12/16/2015 08:27 PM, Mats Peterson wrote: On 12/16/2015 08:26 PM, Kieran Kunhya wrote: I have said before that I'm not going to dwell into the complexities of Git, since it feels about as wasteful as programming a GUI in my book. If you can't acce