Re: [FFmpeg-devel] [PATCH] all: use predefined mathematics macros

On 11/11/15, Ganesh Ajjanagadde wrote: > This uses M_SQRT2, M_PI, and M_E instead of the actual literals. > Benefits include: > 1. Reduced scope for copy/paste errors and improved readability. > 2. Consistency across the codebase. > 3. Actually fixes an incorrect sqrt(2) in avcodec/ppc. > 4. Great

Re: [FFmpeg-devel] [PATCH] qsvenc: Add adaptive_i and adaptive_b toggles

On Tue, Nov 10, 2015 at 9:41 PM, Will Kelleher wrote: > Signed-off-by: Will Kelleher > --- > libavcodec/qsvenc.c | 2 ++ > libavcodec/qsvenc.h | 2 ++ > libavcodec/qsvenc_h264.c | 2 ++ > 3 files changed, 6 insertions(+) > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > inde

[FFmpeg-devel] [PATCH] avformat/async: Fix bug where async could not recover after seek to eof

When async issues its inner seek via ffurl_seek, it treats failures as EOF being reached. This is not consistent with the behavior of other protocols (e.g. http, cache) which continue to tolerate reads after failed seeks, and therefore does not interact correctly with them. A common pattern where

Re: [FFmpeg-devel] [libav-devel] [PATCH 4/4] dds: add missing newline to log messages

On Wed, Nov 11, 2015 at 1:16 AM, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/dds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/dds.c b/libavcodec/dds.c > index fe36709..4d68b33 100644 > --- a/libavcodec/dds.c > +++ b/

Re: [FFmpeg-devel] [libav-devel] [PATCH 3/4] dds: make sure pallete frame buffer exists before use

On Wed, Nov 11, 2015 at 1:16 AM, Andreas Cadhalpun wrote: > Otherwise it causes a NULL pointer dereference of frame->data[1]. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/dds.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/dds.c b/libavcodec/dds.c > index c9

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/4] dds: validate compressed source buffer size

On Wed, Nov 11, 2015 at 1:15 AM, Andreas Cadhalpun wrote: > A too small buffer will cause segfaults somewhere below > decompress_texture_thread. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/dds.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/libavcodec/dds.c b/liba

Re: [FFmpeg-devel] [libav-devel] [PATCH 1/4] dds: validate source buffer size before copying

On Wed, Nov 11, 2015 at 1:14 AM, Andreas Cadhalpun wrote: > If it is too small av_image_copy_plane segfaults. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/dds.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/dds.c b/libavcodec/dds.c > index a604d56..324e665

Re: [FFmpeg-devel] [PATCH] all: use predefined mathematics macros

On Tue, Nov 10, 2015 at 10:35:23PM -0500, Ganesh Ajjanagadde wrote: > This uses M_SQRT2, M_PI, and M_E instead of the actual literals. > Benefits include: > 1. Reduced scope for copy/paste errors and improved readability. > 2. Consistency across the codebase. > 3. Actually fixes an incorrect sqrt(2

Re: [FFmpeg-devel] [PATCH] aac_fixed: fix overflow in sbr_sum_square_c

On Sun, Nov 08, 2015 at 09:26:21PM +0100, Andreas Cadhalpun wrote: > On 08.11.2015 20:17, Michael Niedermayer wrote: > > On Sun, Nov 08, 2015 at 05:14:10PM +0100, Andreas Cadhalpun wrote: > >> If accu overflows, a negative value can be returned. > >> > >> Signed-off-by: Andreas Cadhalpun > >> ---

Re: [FFmpeg-devel] [PATCH] aacsbr_fixed: check for envelope scalefactors overflowing

On Mon, Nov 09, 2015 at 09:16:11PM +0100, Andreas Cadhalpun wrote: > This prevents various values from getting an insanely huge exponent. > If someone knows a cleaner solution, thats welcome! > > This is similar to commit 8978c74 for aacsbr. > > Signed-off-by: Andreas Cadhalpun > --- > libavcod

Re: [FFmpeg-devel] [PATCH] qsvenc: Add adaptive_i and adaptive_b toggles

Hello Will, Tuesday, November 10, 2015, 11:41:19 PM, you wrote: WK> Signed-off-by: Will Kelleher WK> --- WK> libavcodec/qsvenc.c | 2 ++ WK> libavcodec/qsvenc.h | 2 ++ WK> libavcodec/qsvenc_h264.c | 2 ++ WK> 3 files changed, 6 insertions(+) WK> diff --git a/libavcodec/qsvenc.c b/li

Re: [FFmpeg-devel] [PATCH] qsvenc: Add adaptive_i and adaptive_b toggles

Hello Hendrik, Wednesday, November 11, 2015, 11:56:49 AM, you wrote: HL> On Tue, Nov 10, 2015 at 9:41 PM, Will Kelleher wrote: >> Signed-off-by: Will Kelleher >> --- >> libavcodec/qsvenc.c | 2 ++ >> libavcodec/qsvenc.h | 2 ++ >> libavcodec/qsvenc_h264.c | 2 ++ >> 3 files changed,

Re: [FFmpeg-devel] [PATCH] all: use predefined mathematics macros

On Wed, Nov 11, 2015 at 3:28 AM, Paul B Mahol wrote: > On 11/11/15, Ganesh Ajjanagadde wrote: >> This uses M_SQRT2, M_PI, and M_E instead of the actual literals. >> Benefits include: >> 1. Reduced scope for copy/paste errors and improved readability. >> 2. Consistency across the codebase. >> 3. A

Re: [FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

On Sun, Nov 08, 2015 at 10:02:56PM +0100, Andreas Cadhalpun wrote: > This fixes a SIGFPE crash in the aac_fixed decoder. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/aacsbr_fixed.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/aacsbr_fixed.c

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: set muxer packet duration based on framerate only for CFR

On Tue, Nov 10, 2015 at 10:53:29PM +0100, Michael Niedermayer wrote: > From: Michael Niedermayer > > a set ost->frame_rate does not imply CFR in ffmpeg > > The changed fate tests had all wrong packet durations > (like 1/1000 or 1/9) > > There might be more cases in which is_cfr could be set

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: Print a warning if a pkt duration is already set before using the frame rate

On Tue, Nov 10, 2015 at 10:53:30PM +0100, Michael Niedermayer wrote: > From: Michael Niedermayer > > I didnt find any case that triggers this but if it gets triggered it needs to > be > investigated > > Signed-off-by: Michael Niedermayer applied [...] -- Michael GnuPG fingerprint: 9FF21

Re: [FFmpeg-devel] [PATCH] all: use predefined mathematics macros

On Tue, Nov 10, 2015 at 10:35:23PM -0500, Ganesh Ajjanagadde wrote: > This uses M_SQRT2, M_PI, and M_E instead of the actual literals. > Benefits include: > 1. Reduced scope for copy/paste errors and improved readability. > 2. Consistency across the codebase. > 3. Actually fixes an incorrect sqrt(2

Re: [FFmpeg-devel] [PATCH] all: use predefined mathematics macros

On Wed, Nov 11, 2015 at 10:21 AM, Clément Bœsch wrote: > On Tue, Nov 10, 2015 at 10:35:23PM -0500, Ganesh Ajjanagadde wrote: >> This uses M_SQRT2, M_PI, and M_E instead of the actual literals. >> Benefits include: >> 1. Reduced scope for copy/paste errors and improved readability. >> 2. Consistenc

Re: [FFmpeg-devel] [PATCH 1/2] ffserver: Do not add or rescale AV_NOPTS_VALUE from the demuxer

On Sun, Nov 01, 2015 at 06:34:43PM +0100, Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > ffserver.c |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF1

[FFmpeg-devel] UDP constant bitrate feature (cbr)

We added UDP output constant bitrate functionality. Please review patch. P.S.: It's first patch we send. Please notify me if something made wrong. udp-cbr-single.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http:

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

Trying to reattach patch 11.11.2015 22:01, Pavel Meshkov пишет: We added UDP output constant bitrate functionality. Please review patch. P.S.: It's first patch we send. Please notify me if something made wrong. ___ ffmpeg-devel mailing list ffmpeg-dev

Re: [FFmpeg-devel] [libav-devel] [PATCH 3/4] dds: make sure pallete frame buffer exists before use

On 11.11.2015 12:28, Vittorio Giovara wrote: > On Wed, Nov 11, 2015 at 1:16 AM, Andreas Cadhalpun > wrote: >> Otherwise it causes a NULL pointer dereference of frame->data[1]. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/dds.c | 5 + >> 1 file changed, 5 insertions(+) >> >> di

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/4] dds: validate compressed source buffer size

On 11.11.2015 12:31, Vittorio Giovara wrote: > On Wed, Nov 11, 2015 at 1:15 AM, Andreas Cadhalpun > wrote: >> A too small buffer will cause segfaults somewhere below >> decompress_texture_thread. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/dds.c | 9 + >> 1 file changed,

Re: [FFmpeg-devel] [PATCH] aac_fixed: fix overflow in sbr_sum_square_c

On 11.11.2015 13:46, Michael Niedermayer wrote: > On Sun, Nov 08, 2015 at 09:26:21PM +0100, Andreas Cadhalpun wrote: >> On 08.11.2015 20:17, Michael Niedermayer wrote: >>> but the patch does not look like an optimal solution >> >> It's certainly not pretty, but it fixes the crashes/assertion failur

Re: [FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

On 11.11.2015 14:55, Michael Niedermayer wrote: > On Sun, Nov 08, 2015 at 10:02:56PM +0100, Andreas Cadhalpun wrote: >> This fixes a SIGFPE crash in the aac_fixed decoder. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/aacsbr_fixed.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 de

Re: [FFmpeg-devel] [PATCH] aacsbr_fixed: check for envelope scalefactors overflowing

On 11.11.2015 13:48, Michael Niedermayer wrote: > On Mon, Nov 09, 2015 at 09:16:11PM +0100, Andreas Cadhalpun wrote: >> This prevents various values from getting an insanely huge exponent. >> If someone knows a cleaner solution, thats welcome! >> >> This is similar to commit 8978c74 for aacsbr. >>

Re: [FFmpeg-devel] [libav-devel] [PATCH 4/4] dds: add missing newline to log messages

On 11.11.2015 12:27, Vittorio Giovara wrote: > On Wed, Nov 11, 2015 at 1:16 AM, Andreas Cadhalpun > wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/dds.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/dds.c b/libavcodec/dds.c >> index f

Re: [FFmpeg-devel] [libav-devel] [PATCH 1/4] dds: validate source buffer size before copying

On 11.11.2015 12:32, Vittorio Giovara wrote: > On Wed, Nov 11, 2015 at 1:14 AM, Andreas Cadhalpun > wrote: >> If it is too small av_image_copy_plane segfaults. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/dds.c | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/liba

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/4] dds: validate compressed source buffer size

On 11.11.2015 12:31, Vittorio Giovara wrote: > On Wed, Nov 11, 2015 at 1:15 AM, Andreas Cadhalpun > wrote: >> A too small buffer will cause segfaults somewhere below >> decompress_texture_thread. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/dds.c | 9 + >> 1 file changed,

[FFmpeg-devel] [PATCH] hevc: Fix a53 caption extraction

Just realized my previous patch doesn't work quite right. I uploaded a better sample file that actually has visible captions to /incoming/hevc_cc.ts. I tested with that file doing hevc->x264 and it works. This is basically an exact copy of the existing h264 logic. will Signed-off-by: Will Kell

Re: [FFmpeg-devel] [PATCH] aac_fixed: fix overflow in sbr_sum_square_c

On Wed, Nov 11, 2015 at 09:09:51PM +0100, Andreas Cadhalpun wrote: > On 11.11.2015 13:46, Michael Niedermayer wrote: > > On Sun, Nov 08, 2015 at 09:26:21PM +0100, Andreas Cadhalpun wrote: > >> On 08.11.2015 20:17, Michael Niedermayer wrote: > >>> but the patch does not look like an optimal solution

Re: [FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

On 11/07, Ivan Uskov wrote: > Although the code looks ok by itself, I believe it is bad idea to place > H.264-specific codeto the function which is commonfor all > encoders. I believe H.264-specific user data insertion should locates into > the qsvenc_h264.c > I.e. the

Re: [FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

On Wed, Nov 11, 2015 at 09:31:18PM +0100, Andreas Cadhalpun wrote: > On 11.11.2015 14:55, Michael Niedermayer wrote: > > On Sun, Nov 08, 2015 at 10:02:56PM +0100, Andreas Cadhalpun wrote: > >> This fixes a SIGFPE crash in the aac_fixed decoder. > >> > >> Signed-off-by: Andreas Cadhalpun > >> --- >

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

On 11 Nov 2015 7:08 p.m., "Pavel Meshkov" wrote: > > Trying to reattach patch > > 11.11.2015 22:01, Pavel Meshkov пишет: >> >> We added UDP output constant bitrate functionality. >> Please review patch. >> >> P.S.: It's first patch we send. Please notify me if something made wrong. This an awful

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

On 11 November 2015 at 22:41, Kieran Kunhya wrote: > > On 11 Nov 2015 7:08 p.m., "Pavel Meshkov" wrote: >> >> Trying to reattach patch >> >> 11.11.2015 22:01, Pavel Meshkov пишет: >>> >>> We added UDP output constant bitrate functionality. >>> Please review patch. >>> >>> P.S.: It's first patch w

Re: [FFmpeg-devel] FFmpeg 2.8.2

On Sun, Nov 08, 2015 at 08:23:28PM +0100, Michael Niedermayer wrote: > Hi > > I will probably make 2.8.2 soon (days/week), if you want somethig > backported, please backport sooner release made [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkn

[FFmpeg-devel] FFmpeg 2.7.3 and 2.6.5

Hi I intend to make 2.7.3 and 2.6.5 soon (day(s)), if you want something backported do it before i make the release (or if its something critical tell me and i can wait longer of course) -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is bet

[FFmpeg-devel] [PATCH] os2threads: Add pthread_once()

--- compat/os2threads.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/compat/os2threads.h b/compat/os2threads.h index 5b6ca55..f8fb2c8 100644 --- a/compat/os2threads.h +++ b/compat/os2threads.h @@ -32,6 +32,8 @@ #undef __STRICT_ANSI__ /* for _beginthrea

Re: [FFmpeg-devel] [libav-devel] [PATCH 3/4] dds: make sure pallete frame buffer exists before use

On Wed, Nov 11, 2015 at 8:29 PM, Andreas Cadhalpun wrote: > On 11.11.2015 12:28, Vittorio Giovara wrote: >> On Wed, Nov 11, 2015 at 1:16 AM, Andreas Cadhalpun >> wrote: >>> Otherwise it causes a NULL pointer dereference of frame->data[1]. >>> >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> lib