[FFmpeg-devel] [PATCH] avcodec/flacenc: Invalid Rice order

2015-06-16 Thread George Boyle
Fixes ticket #4628. The problem arose, in the sample file at least, in the last block where the minimum and maximum Rice partition orders were both 0. In that case, and any other where pmax == pmin, the original UINT32_MAX placeholder value for bits[opt_porder] was getting overwritten before the c

Re: [FFmpeg-devel] [RFC] DXVA2 decoding and FFmpeg

2015-06-16 Thread wm4
On Mon, 15 Jun 2015 17:55:35 +0200 Stefano Sabatini wrote: > On date Monday 2015-06-15 11:56:13 +0200, Stefano Sabatini encoded: > [...] > > From 3a75ef1e86360cd6f30b8e550307404d0d1c1dba Mon Sep 17 00:00:00 2001 > > From: Stefano Sabatini > > Date: Mon, 15 Jun 2015 11:02:50 +0200 > > Subject: [P

Re: [FFmpeg-devel] [RFC] DXVA2 decoding and FFmpeg

2015-06-16 Thread Stefano Sabatini
On date Tuesday 2015-06-16 10:20:31 +0200, wm4 encoded: > On Mon, 15 Jun 2015 17:55:35 +0200 > Stefano Sabatini wrote: > > > On date Monday 2015-06-15 11:56:13 +0200, Stefano Sabatini encoded: > > [...] > > > From 3a75ef1e86360cd6f30b8e550307404d0d1c1dba Mon Sep 17 00:00:00 2001 > > > From: Stefa

Re: [FFmpeg-devel] [PATCH] swresample: make swr_get_out_samples() work with all resamplers

2015-06-16 Thread wm4
On Tue, 16 Jun 2015 01:43:59 +0200 Michael Niedermayer wrote: > On Thu, Jun 04, 2015 at 07:19:25PM +0200, wm4 wrote: > > Making it fail if e.g. soxr is used makes the function completely > > useless. > > --- > > libswresample/swresample.c | 10 +++--- > > 1 file changed, 7 insertions(+), 3 d

Re: [FFmpeg-devel] [PATCH] libvpxenc: add color-space option for vp9

2015-06-16 Thread Michael Niedermayer
On Mon, Jun 15, 2015 at 10:43:17PM -0700, James Zern wrote: > the vp9 bitstream supports 8 values: > unknown (default), bt601, bt709, smpte170, smpte240, bt2020, reserved > and sRGB. > --- > doc/encoders.texi | 12 > libavcodec/libvpxenc.c | 22 ++ > 2 files c

Re: [FFmpeg-devel] [PATCH] doc/muxers.texi: properly insert {}s in example

2015-06-16 Thread Michael Niedermayer
On Mon, Jun 15, 2015 at 11:04:45PM -0700, James Zern wrote: > use '@{' / '@}', fixes compile errors: > *** '{' without macro. Before: 1:-'.'} > *** '}' without opening '{' before: > > since: > 907ac20 avformat/hlsenc: added HLS encryption > > Signed-off-by: James Zern > --- > doc/muxers.texi |

Re: [FFmpeg-devel] [PATCH] avcodec/flacenc: Invalid Rice order

2015-06-16 Thread Michael Niedermayer
On Tue, Jun 16, 2015 at 08:25:01AM +0100, George Boyle wrote: > Fixes ticket #4628. > > The problem arose, in the sample file at least, in the last block where the > minimum and maximum Rice partition orders were both 0. In that case, and any > other where pmax == pmin, the original UINT32_MAX pla

Re: [FFmpeg-devel] [PATCH] avcodec/flacenc: Invalid Rice order

2015-06-16 Thread George Boyle
On 16/06/15 12:02, Michael Niedermayer wrote: > > please post a patch that contains the remaining 2 hunks in >24h > > also for future fate tests, small samples are preferred to keep the > fate testsuite manageable size wise Ok, will do. Thanks George _

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Change version byte for JPEG2000 to match mxf.c and RP224v12

2015-06-16 Thread Michael Niedermayer
On Tue, Jun 16, 2015 at 07:26:18AM +0100, tim nicholson wrote: > On 15/06/15 13:13, Michael Niedermayer wrote: > > This should make no difference as the byte is ignored > > > > Found-by: tim nicholson > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mxfdec.c |2 +- > > 1 file

Re: [FFmpeg-devel] [RFC] DXVA2 decoding and FFmpeg

2015-06-16 Thread Michael Niedermayer
On Tue, Jun 16, 2015 at 10:35:52AM +0200, Stefano Sabatini wrote: > On date Tuesday 2015-06-16 10:20:31 +0200, wm4 encoded: > > On Mon, 15 Jun 2015 17:55:35 +0200 > > Stefano Sabatini wrote: > > > > > On date Monday 2015-06-15 11:56:13 +0200, Stefano Sabatini encoded: > > > [...] > > > > From 3a7

Re: [FFmpeg-devel] [RFC] DXVA2 decoding and FFmpeg

2015-06-16 Thread Gwenole Beauchesne
Hi, 2015-06-16 10:35 GMT+02:00 Stefano Sabatini : > On date Tuesday 2015-06-16 10:20:31 +0200, wm4 encoded: >> On Mon, 15 Jun 2015 17:55:35 +0200 >> Stefano Sabatini wrote: >> >> > On date Monday 2015-06-15 11:56:13 +0200, Stefano Sabatini encoded: >> > [...] >> > > From 3a75ef1e86360cd6f30b8e550

Re: [FFmpeg-devel] [RFC] DXVA2 decoding and FFmpeg

2015-06-16 Thread Gwenole Beauchesne
Hi, 2015-06-16 14:03 GMT+02:00 Michael Niedermayer : > On Tue, Jun 16, 2015 at 10:35:52AM +0200, Stefano Sabatini wrote: >> On date Tuesday 2015-06-16 10:20:31 +0200, wm4 encoded: >> > On Mon, 15 Jun 2015 17:55:35 +0200 >> > Stefano Sabatini wrote: >> > >> > > On date Monday 2015-06-15 11:56:13 +

Re: [FFmpeg-devel] [RFC] DXVA2 decoding and FFmpeg

2015-06-16 Thread Stefano Sabatini
On date Tuesday 2015-06-16 14:16:11 +0200, Gwenole Beauchesne encoded: > Hi, > > 2015-06-16 14:03 GMT+02:00 Michael Niedermayer : [...] > >> +#if HAVE_SSE2 > >> +/* Copy 16/64 bytes from srcp to dstp loading data with the SSE>=2 > >> instruction > >> + * load and storing data with the SSE>=2 inst

Re: [FFmpeg-devel] [RFC] DXVA2 decoding and FFmpeg

2015-06-16 Thread wm4
On Tue, 16 Jun 2015 14:16:11 +0200 Gwenole Beauchesne wrote: > Hi, > > 2015-06-16 14:03 GMT+02:00 Michael Niedermayer : > > On Tue, Jun 16, 2015 at 10:35:52AM +0200, Stefano Sabatini wrote: > >> On date Tuesday 2015-06-16 10:20:31 +0200, wm4 encoded: > >> > On Mon, 15 Jun 2015 17:55:35 +0200 > >

Re: [FFmpeg-devel] [RFC] DXVA2 decoding and FFmpeg

2015-06-16 Thread Hendrik Leppkes
On Tue, Jun 16, 2015 at 2:30 PM, Stefano Sabatini wrote: > On date Tuesday 2015-06-16 14:16:11 +0200, Gwenole Beauchesne encoded: >> Hi, >> >> 2015-06-16 14:03 GMT+02:00 Michael Niedermayer : > [...] >> >> +#if HAVE_SSE2 >> >> +/* Copy 16/64 bytes from srcp to dstp loading data with the SSE>=2 >>

[FFmpeg-devel] [PATCH] avcodec/codec_desc: rename smv video codec name to smvjpeg to match decoder name

2015-06-16 Thread Paul B Mahol
Also fixes clash with smv audio codec. Signed-off-by: Paul B Mahol --- libavcodec/codec_desc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index c1694f3..f32843a 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_

[FFmpeg-devel] [PATCH 2/2] MAINTAINERS: add myself as hls encryption maintainer

2015-06-16 Thread Christian Suloway
Signed-off-by: Christian Suloway --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7b239a1..fa9e966 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -416,6 +416,7 @@ Muxers/Demuxers: gxf.c Reimar Doeffinger gxfen

[FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: removed empty/unused print_encryption_tag function

2015-06-16 Thread Christian Suloway
Signed-off-by: Christian Suloway --- libavformat/hlsenc.c | 4 1 file changed, 4 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 68c6479..cf29f4f 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -310,10 +310,6 @@ static void hls_free_segments(HLSSe

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: removed empty/unused print_encryption_tag function

2015-06-16 Thread Michael Niedermayer
On Tue, Jun 16, 2015 at 09:15:56AM -0500, Christian Suloway wrote: > Signed-off-by: Christian Suloway > --- > libavformat/hlsenc.c | 4 > 1 file changed, 4 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a p

Re: [FFmpeg-devel] [PATCH 2/2] MAINTAINERS: add myself as hls encryption maintainer

2015-06-16 Thread Michael Niedermayer
On Tue, Jun 16, 2015 at 09:15:57AM -0500, Christian Suloway wrote: > Signed-off-by: Christian Suloway > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB DNS cache poisoning attacks, popul

Re: [FFmpeg-devel] [PATCH] avcodec/codec_desc: rename smv video codec name to smvjpeg to match decoder name

2015-06-16 Thread Michael Niedermayer
On Tue, Jun 16, 2015 at 01:29:55PM +, Paul B Mahol wrote: > Also fixes clash with smv audio codec. > > Signed-off-by: Paul B Mahol > --- > libavcodec/codec_desc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730

[FFmpeg-devel] Code review tools

2015-06-16 Thread Philip Langdale
Hi all, I've been thinking about whether we'd benefit from using a code review tool like reviewboard (www.reviewboard.org). I use reviewboard at work and it offers a lot of features that make email based reviews seem very crude by comparison. For me, the stand out features are a very good diff vi

Re: [FFmpeg-devel] [PATCH] avcodec/codec_desc: rename smv video codec name to smvjpeg to match decoder name

2015-06-16 Thread wm4
On Tue, 16 Jun 2015 13:29:55 + Paul B Mahol wrote: > Also fixes clash with smv audio codec. > > Signed-off-by: Paul B Mahol > --- > libavcodec/codec_desc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c > index c1

Re: [FFmpeg-devel] [PATCH] avcodec/codec_desc: rename smv video codec name to smvjpeg to match decoder name

2015-06-16 Thread Hendrik Leppkes
On Tue, Jun 16, 2015 at 8:33 PM, wm4 wrote: > On Tue, 16 Jun 2015 13:29:55 + > Paul B Mahol wrote: > >> Also fixes clash with smv audio codec. >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/codec_desc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/liba

Re: [FFmpeg-devel] [PATCH] avcodec/codec_desc: rename smv video codec name to smvjpeg to match decoder name

2015-06-16 Thread wm4
On Tue, 16 Jun 2015 21:18:13 +0200 Hendrik Leppkes wrote: > On Tue, Jun 16, 2015 at 8:33 PM, wm4 wrote: > > On Tue, 16 Jun 2015 13:29:55 + > > Paul B Mahol wrote: > > > >> Also fixes clash with smv audio codec. > >> > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/codec_desc.c |

Re: [FFmpeg-devel] [PATCH] avcodec/codec_desc: rename smv video codec name to smvjpeg to match decoder name

2015-06-16 Thread Hendrik Leppkes
On Tue, Jun 16, 2015 at 9:23 PM, wm4 wrote: > On Tue, 16 Jun 2015 21:18:13 +0200 > Hendrik Leppkes wrote: > >> On Tue, Jun 16, 2015 at 8:33 PM, wm4 wrote: >> > On Tue, 16 Jun 2015 13:29:55 + >> > Paul B Mahol wrote: >> > >> >> Also fixes clash with smv audio codec. >> >> >> >> Signed-off-by

Re: [FFmpeg-devel] [PATCH] avcodec/codec_desc: rename smv video codec name to smvjpeg to match decoder name

2015-06-16 Thread wm4
On Tue, 16 Jun 2015 21:31:26 +0200 Hendrik Leppkes wrote: > On Tue, Jun 16, 2015 at 9:23 PM, wm4 wrote: > > On Tue, 16 Jun 2015 21:18:13 +0200 > > Hendrik Leppkes wrote: > > > >> On Tue, Jun 16, 2015 at 8:33 PM, wm4 wrote: > >> > On Tue, 16 Jun 2015 13:29:55 + > >> > Paul B Mahol wrote: >

Re: [FFmpeg-devel] [PATCH] avcodec/codec_desc: rename smv video codec name to smvjpeg to match decoder name

2015-06-16 Thread Hendrik Leppkes
On Tue, Jun 16, 2015 at 9:45 PM, wm4 wrote: > On Tue, 16 Jun 2015 21:31:26 +0200 > Hendrik Leppkes wrote: > >> On Tue, Jun 16, 2015 at 9:23 PM, wm4 wrote: >> > On Tue, 16 Jun 2015 21:18:13 +0200 >> > Hendrik Leppkes wrote: >> > >> >> On Tue, Jun 16, 2015 at 8:33 PM, wm4 wrote: >> >> > On Tue,

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/2] matroskadec: validate audio channels and bitdepth

2015-06-16 Thread Andreas Cadhalpun
On 16.06.2015 00:37, Luca Barbato wrote: > On 16/06/15 00:14, Andreas Cadhalpun wrote: >>> I wonder if the sanity check in the decoder would be enough to not have >>> other problems down the line. >> >> No, because the problem is in the two lines below the check. > > Not here =) The avio_wl16 cal

Re: [FFmpeg-devel] [PATCH 1/2] matroskadec: check audio sample rate

2015-06-16 Thread Andreas Cadhalpun
On 16.06.2015 02:16, Michael Niedermayer wrote: > On Mon, Jun 15, 2015 at 09:17:36PM +0200, Andreas Cadhalpun wrote: >> And default to 8000 if it is invalid. >> >> An invalid sample rate can trigger av_assert2 in av_rescale_rnd. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/matrosk

Re: [FFmpeg-devel] [PATCH] configure: make makeinfo_html check more robust

2015-06-16 Thread Andreas Cadhalpun
On 16.06.2015 02:50, Timothy Gu wrote: > On Sun, Jun 14, 2015 at 2:32 AM Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> The current check is too strict for newer makeinfo versions. >> Existing version strings are: >> makeinfo (GNU texinfo) 4.13 >> makeinfo (GNU texinfo) 5.2 >>

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/2] matroskadec: validate audio channels and bitdepth

2015-06-16 Thread Andreas Cadhalpun
On 16.06.2015 03:22, Michael Niedermayer wrote: > On Tue, Jun 16, 2015 at 12:09:37AM +0200, Andreas Cadhalpun wrote: >> matroskadec.c | 12 >> 1 file changed, 12 insertions(+) >> c84b48d9c49779669de96671e178dd1f6da215d9 >> 0002-matroskadec-validate-audio-channels-and-bitdepth.patc

Re: [FFmpeg-devel] [PATCH] doc: avoid incorrect phrase 'allows to'

2015-06-16 Thread Andreas Cadhalpun
On 16.06.2015 07:51, Lou Logan wrote: > On Mon, Jun 15, 2015, at 08:24 AM, Andreas Cadhalpun wrote: >> >> OK, I reworded the changes in avformat.h. New patch attached. > > Patch looks good to me. Thanks. Pushed. Best regards, Andreas ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/codec_desc: rename smv video codec name to smvjpeg to match decoder name

2015-06-16 Thread wm4
On Tue, 16 Jun 2015 21:55:13 +0200 Hendrik Leppkes wrote: > On Tue, Jun 16, 2015 at 9:45 PM, wm4 wrote: > > On Tue, 16 Jun 2015 21:31:26 +0200 > > Hendrik Leppkes wrote: > > > >> On Tue, Jun 16, 2015 at 9:23 PM, wm4 wrote: > >> > On Tue, 16 Jun 2015 21:18:13 +0200 > >> > Hendrik Leppkes wrote

Re: [FFmpeg-devel] [PATCH] avcodec/codec_desc: rename smv video codec name to smvjpeg to match decoder name

2015-06-16 Thread Andreas Cadhalpun
On 16.06.2015 21:31, Hendrik Leppkes wrote: > I see no reason these strings should be considered API. They are > descriptive names, not option tokens or anything. > If you want a reliable static way to identify a codec, use the id. At least currently using the codec id is the only way to reliably

Re: [FFmpeg-devel] [PATCH] avcodec/codec_desc: rename smv video codec name to smvjpeg to match decoder name

2015-06-16 Thread Paul B Mahol
On 6/16/15, Andreas Cadhalpun wrote: > On 16.06.2015 21:31, Hendrik Leppkes wrote: >> I see no reason these strings should be considered API. They are >> descriptive names, not option tokens or anything. >> If you want a reliable static way to identify a codec, use the id. > > At least currently u

Re: [FFmpeg-devel] [PATCH] avcodec/codec_desc: rename smv video codec name to smvjpeg to match decoder name

2015-06-16 Thread Andreas Cadhalpun
On 16.06.2015 22:29, Paul B Mahol wrote: > On 6/16/15, Andreas Cadhalpun wrote: >> On 16.06.2015 21:31, Hendrik Leppkes wrote: >>> I see no reason these strings should be considered API. They are >>> descriptive names, not option tokens or anything. >>> If you want a reliable static way to identif

[FFmpeg-devel] [PATCH] avio: fix potential crashes when combining ffio_ensure_seekback + crc

2015-06-16 Thread wm4
Calling ffio_ensure_seekback() if ffio_init_checksum() has been called on the same context can lead to out of bounds memory accesses and crashes. The reason is that ffio_ensure_seekback() does not update checksum_ptr after reallocating the buffer, resulting in a dangling pointer. This effectively

[FFmpeg-devel] [PATCH 1/6] lavf/brstm: add support for BFSTM files

2015-06-16 Thread Rodger Combs
--- libavcodec/utils.c | 4 ++ libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/brstm.c | 129 +++ 4 files changed, 115 insertions(+), 20 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index

[FFmpeg-devel] [PATCH 2/6] lavc/adpcm: THP: handle trailing padding

2015-06-16 Thread Rodger Combs
--- libavcodec/adpcm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 22b5468..07ebce8 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -637,7 +637,7 @@ static int get_nb_samples(AVCodecContext *avctx, GetByteContex

[FFmpeg-devel] [PATCH 3/6] lavf/brstm: add support for seeking

2015-06-16 Thread Rodger Combs
--- libavformat/brstm.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavformat/brstm.c b/libavformat/brstm.c index 1eba943..8adffb8 100644 --- a/libavformat/brstm.c +++ b/libavformat/brstm.c @@ -30,6 +30,7 @@ typedef struct BRSTMDemuxContext { uint32_tcurrent_b

[FFmpeg-devel] [PATCH 5/6] ffprobe: display loop points when applicable

2015-06-16 Thread Rodger Combs
--- ffprobe.c | 4 1 file changed, 4 insertions(+) diff --git a/ffprobe.c b/ffprobe.c index 3e5324e..d54eb87 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -2436,6 +2436,10 @@ static int show_format(WriterContext *w, AVFormatContext *fmt_ctx) } print_time("start_time", fmt_ctx->st

[FFmpeg-devel] [PATCH 4/6] lavf: add support for loop points

2015-06-16 Thread Rodger Combs
--- libavformat/avformat.h | 12 libavformat/options_table.h | 2 ++ libavformat/utils.c | 2 +- 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 719c23b..8158874 100644 --- a/libavformat/avformat.h +++

[FFmpeg-devel] [PATCH 6/6] lavf/brstm: expose the loop point when present

2015-06-16 Thread Rodger Combs
--- libavformat/brstm.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavformat/brstm.c b/libavformat/brstm.c index 8adffb8..53d8da9 100644 --- a/libavformat/brstm.c +++ b/libavformat/brstm.c @@ -72,6 +72,7 @@ static int read_header(AVFormatContext *s) uint3

Re: [FFmpeg-devel] [PATCH] avio: fix potential crashes when combining ffio_ensure_seekback + crc

2015-06-16 Thread Michael Niedermayer
On Wed, Jun 17, 2015 at 12:21:02AM +0200, wm4 wrote: > Calling ffio_ensure_seekback() if ffio_init_checksum() has been called > on the same context can lead to out of bounds memory accesses and > crashes. The reason is that ffio_ensure_seekback() does not update > checksum_ptr after reallocating th

Re: [FFmpeg-devel] [PATCH] libvpxenc: add color-space option for vp9

2015-06-16 Thread James Almer
On 16/06/15 2:43 AM, James Zern wrote: > the vp9 bitstream supports 8 values: > unknown (default), bt601, bt709, smpte170, smpte240, bt2020, reserved > and sRGB. > --- > doc/encoders.texi | 12 > libavcodec/libvpxenc.c | 22 ++ > 2 files changed, 34 insertions