Re: [FFmpeg-devel] [PATCH 1/3] libvpxenc: only set noise reduction w/vp8

2015-04-24 Thread James Zern
On Thu, Apr 23, 2015 at 8:14 AM, Michael Niedermayer wrote: > On Wed, Apr 22, 2015 at 08:58:35PM -0700, James Zern wrote: >> this quiets a warning: >> Failed to set VP8E_SET_NOISE_SENSITIVITY codec control: Unspecified >> internal error >> --- >> libavcodec/libvpxenc.c | 5 +++-- >> 1 file change

[FFmpeg-devel] [PATCH] lavd/v4l2: print buffer flags in case of error

2015-04-24 Thread Giorgio Vazzana
Hello, I wrote this simple patch a while back trying to solve ticket #4030, but I think we might as well apply it as it would make debugging easier in general. Giorgio Vazzana From 1b471609878a9982960bf25e921c560e595ad667 Mon Sep 17 00:00:00 2001 From: Giorgio Vazzana Date: Thu, 16 Oct 2014 11:1

[FFmpeg-devel] Fix bug for PPC LE

2015-04-24 Thread rongyan
Hi, GCC tool has a bug of PPC intrinsic interpret, which has been fixed in GCC 4.9.1. This bug lead to errors in two of our previous patches. We found this when we update our GCC tools to 4.9.1 and by reading the related info on GCC website. We fix our previous error here: 1. The attchment is t

Re: [FFmpeg-devel] [PATCH 2/2] libavutil: Make changes in softfloat needed for fixed point aac decoder.

2015-04-24 Thread Nedeljko Babic
>> >> As I said in the comment of this patch and before in comments to review, >> I modified the code in the softfloat to be more usable in the implementation >> of fixed point aac decoder. >> Fixed point aac decoder was developed by using our float emulation and it was >> more convenient to chang

[FFmpeg-devel] [PATCH] libavutil: Make changes in softfloat needed for fixed point aac decoder.

2015-04-24 Thread Nedeljko Babic
From: Djordje Pesut Functions for sqrt and sincos are added. Div function is improved. Some changes are made in order for code in softfloat to be usable in fixed aac decoder code. This doesn't create any impact on current ffmpeg code since softfloat is currently not in use and this way we don'

[FFmpeg-devel] [PATCH] avformat/mp3: large id3 tags break concatenated file detection

2015-04-24 Thread wm4
If the file size is much larger than what is indicated in the XING header, the demuxer assumes it's a concatenated file, and throws away the (presumably) incorrect duration information. Unfortunately, this also triggers if the id3 tags are very large (embedded pictures and such). Then the half-bake

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: print buffer flags in case of error

2015-04-24 Thread Michael Niedermayer
On Fri, Apr 24, 2015 at 11:26:26AM +0200, Giorgio Vazzana wrote: > Hello, > > I wrote this simple patch a while back trying to solve ticket #4030, > but I think we might as well apply it as it would make debugging > easier in general. > > Giorgio Vazzana > v4l2.c |4 ++-- > 1 file changed,

Re: [FFmpeg-devel] [PATCH] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for HEVC copy and hv mc functions

2015-04-24 Thread Nedeljko Babic
LGTM Thanks, Nedeljko Od: ffmpeg-devel-boun...@ffmpeg.org [ffmpeg-devel-boun...@ffmpeg.org] u ime korisnika Shivraj Patil Poslato: 22. april 2015 11:04 Za: ffmpeg-devel@ffmpeg.org Cc: Shivraj Patil Tema: [FFmpeg-devel] [PATCH] avcodec/mips: MSA (MIPS-SIMD-

Re: [FFmpeg-devel] Fix bug for PPC LE

2015-04-24 Thread Michael Niedermayer
On Fri, Apr 24, 2015 at 06:09:14PM +0800, rongyan wrote: > Hi, > GCC tool has a bug of PPC intrinsic interpret, which has been fixed in GCC > 4.9.1. This bug lead to errors in two of our previous patches. We found this > when we update our GCC tools to 4.9.1 and by reading the related info on GCC

Re: [FFmpeg-devel] [PATCH] avformat/mp3: large id3 tags break concatenated file detection

2015-04-24 Thread Michael Niedermayer
On Fri, Apr 24, 2015 at 12:26:39PM +0200, wm4 wrote: > If the file size is much larger than what is indicated in the XING > header, the demuxer assumes it's a concatenated file, and throws away > the (presumably) incorrect duration information. Unfortunately, this > also triggers if the id3 tags ar

Re: [FFmpeg-devel] [PATCH 2/2] vp9: add fate tests for show-existing-frame feature.

2015-04-24 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 12:24:41PM -0400, Ronald S. Bultje wrote: > Samples available at: > http://downloads.webmproject.org/test_data/libvpx/vp90-2-10-show-existing-frame.webm > http://downloads.webmproject.org/test_data/libvpx/vp90-2-10-show-existing-frame2.webm > --- > tests/fate/vpx.mak

Re: [FFmpeg-devel] [PATCH 3/3] vp9: add lf_deltas fate test.

2015-04-24 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 11:51:03AM -0400, Ronald S. Bultje wrote: > Sample available at: > http://downloads.webmproject.org/test_data/libvpx/vp90-2-09-lf_deltas.webm > --- > tests/fate/vpx.mak | 1 + > tests/ref/fate/vp9-09-lf_deltas | 35 +++ > 2 file

Re: [FFmpeg-devel] [PATCH] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for HEVC copy and hv mc functions

2015-04-24 Thread Michael Niedermayer
On Fri, Apr 24, 2015 at 12:30:41PM +, Nedeljko Babic wrote: > LGTM applied thanks [..] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is l

Re: [FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-24 Thread Niklesh Lalwani
Hi, I am really sorry for replying late. I was stuck up with my end semester examinations. Anyways, I was working on implementing structs and passing style_start and style_end as indices rather than addresses, but with no proper results till now. Here is my previous patch improved with C code stand

[FFmpeg-devel] [PATCH] avcodec/libx264: Remove cleanup code, its uneeded since FF_CODEC_CAP_INIT_CLEANUP

2015-04-24 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/libx264.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index d81721c..82c4f2e 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -703,7 +703,7 @@ static av_c

[FFmpeg-devel] [PATCH] Decoding of Bold-Italic_Underlined styles for 3gpp timed text subtitles

2015-04-24 Thread Niklesh Lalwani
From: Niklesh Updated Patch. This patch stores indices in style_start and style_end rather than addresses. Also corrected a bug while using av_dyarray_add() which went unnoticed for the particular test samples used. Signed-off-by: Niklesh --- libavcodec/movtextdec.c | 97 +

Re: [FFmpeg-devel] [PATCH] Decoding of Bold-Italic_Underlined styles for 3gpp timed text subtitles

2015-04-24 Thread Michael Niedermayer
On Sat, Apr 25, 2015 at 02:53:26AM +0530, Niklesh Lalwani wrote: > From: Niklesh > > Updated Patch. This patch stores indices in style_start and style_end rather > than addresses. Also corrected a bug while using av_dyarray_add() which went > unnoticed for the particular test samples used. > Si

Re: [FFmpeg-devel] [PATCH] libavutil: Make changes in softfloat needed for fixed point aac decoder.

2015-04-24 Thread Michael Niedermayer
On Fri, Apr 24, 2015 at 12:18:10PM +0200, Nedeljko Babic wrote: > From: Djordje Pesut > > Functions for sqrt and sincos are added. > > Div function is improved. > > Some changes are made in order for code in softfloat to be usable in fixed aac > decoder code. > > This doesn't create any impact

Re: [FFmpeg-devel] [PATCH 2/2] avformat/format: Add generic trace av_log in av_probe_input_format3()

2015-04-24 Thread Michael Niedermayer
On Mon, Apr 20, 2015 at 05:38:56PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/format.c |2 ++ > 1 file changed, 2 insertions(+) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have often repented sp