Re: [FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-02-28 Thread Carl Eugen Hoyos
arwa arif gmail.com> writes: > * FFmpeg is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by If you want this filter to be licensed under GPL you have to add a line to configure. Carl Eugen ___

[FFmpeg-devel] [PATCH 1/3] avcodec: use av_frame_free() for coded_frame

2015-02-28 Thread Clément Bœsch
--- libavcodec/avuienc.c| 2 +- libavcodec/libopenjpegenc.c | 4 ++-- libavcodec/libtheoraenc.c | 2 +- libavcodec/libutvideoenc.cpp| 2 +- libavcodec/libvpxenc.c | 2 +- libavcodec/proresenc_anatoliy.c | 2 +- libavcodec/proresenc_kostya.c | 2 +- libavcodec/r

[FFmpeg-devel] [PATCH 2/3] avfilter/lavfutils: use av_frame_free for freeing an AVFrame

2015-02-28 Thread Clément Bœsch
--- libavfilter/lavfutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/lavfutils.c b/libavfilter/lavfutils.c index 80310d2..75e68a7 100644 --- a/libavfilter/lavfutils.c +++ b/libavfilter/lavfutils.c @@ -96,7 +96,7 @@ end: av_free_packet(&pkt); avcodec

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_tblend: use av_frame_free for freeing an AVFrame

2015-02-28 Thread Clément Bœsch
--- libavfilter/vf_blend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_blend.c b/libavfilter/vf_blend.c index a29cabc..d232457 100644 --- a/libavfilter/vf_blend.c +++ b/libavfilter/vf_blend.c @@ -379,7 +379,7 @@ static av_cold void uninit(AVFilterContext *ctx

Re: [FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-02-28 Thread arwa arif
On Sat, Feb 28, 2015 at 2:42 PM, Carl Eugen Hoyos wrote: > arwa arif gmail.com> writes: > > > * FFmpeg is free software; you can redistribute it and/or modify > > * it under the terms of the GNU General Public License as published by > > If you want this filter to be licensed under GPL you > hav

Re: [FFmpeg-devel] [PATCH 3/3] lavf/matroskadec: export chained segment chapter metadata.

2015-02-28 Thread Nicolas George
Le nonidi 9 ventôse, an CCXXIII, wm4 a écrit : > At the very least, you should check the ordered chapter flag. If it's > not set, the segment uid is supposed to be ignored. You need to export > the edition IDs. The spec does not seem to state so. I will wait to have a sample where that makes a dif

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: use av_frame_free() for coded_frame

2015-02-28 Thread Clément Bœsch
On Sat, Feb 28, 2015 at 10:38:32AM +0100, Clément Bœsch wrote: > --- > libavcodec/avuienc.c| 2 +- > libavcodec/libopenjpegenc.c | 4 ++-- > libavcodec/libtheoraenc.c | 2 +- > libavcodec/libutvideoenc.cpp| 2 +- > libavcodec/libvpxenc.c | 2 +- > libavcodec/pror

Re: [FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-02-28 Thread Michael Niedermayer
On Sat, Feb 28, 2015 at 04:00:36PM +0530, arwa arif wrote: > On Sat, Feb 28, 2015 at 2:42 PM, Carl Eugen Hoyos wrote: > > > arwa arif gmail.com> writes: > > > > > * FFmpeg is free software; you can redistribute it and/or modify > > > * it under the terms of the GNU General Public License as publ

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_tblend: use av_frame_free for freeing an AVFrame

2015-02-28 Thread Paul B Mahol
On 2/28/15, Clement Boesch wrote: > --- > libavfilter/vf_blend.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_blend.c b/libavfilter/vf_blend.c > index a29cabc..d232457 100644 > --- a/libavfilter/vf_blend.c > +++ b/libavfilter/vf_blend.c > @@ -379,7 +379,

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/lavfutils: use av_frame_free for freeing an AVFrame

2015-02-28 Thread Paul B Mahol
On 2/28/15, Clement Boesch wrote: > --- > libavfilter/lavfutils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/lavfutils.c b/libavfilter/lavfutils.c > index 80310d2..75e68a7 100644 > --- a/libavfilter/lavfutils.c > +++ b/libavfilter/lavfutils.c > @@ -96,7 +

Re: [FFmpeg-devel] [PATCH 3/3] lavf/matroskadec: export chained segment chapter metadata.

2015-02-28 Thread wm4
On Sat, 28 Feb 2015 11:34:37 +0100 Nicolas George wrote: > Le nonidi 9 ventôse, an CCXXIII, wm4 a écrit : > > At the very least, you should check the ordered chapter flag. If it's > > not set, the segment uid is supposed to be ignored. You need to export > > the edition IDs. > > The spec does no

Re: [FFmpeg-devel] [PATCH] ffmpeg: Fix -vstats when coded_frame is not set

2015-02-28 Thread Michael Niedermayer
On Mon, Feb 23, 2015 at 04:52:58PM +0100, Michael Niedermayer wrote: > There are several encoders which do not set coded_frame > > Signed-off-by: Michael Niedermayer > --- > ffmpeg.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) applied [...] -- Michael GnuPG fingerprin

Re: [FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-02-28 Thread arwa arif
Updated the patch. From ba761516b97b146f4c62d6c5c08dc5ea02c06af5 Mon Sep 17 00:00:00 2001 From: Arwa Arif Date: Tue, 24 Feb 2015 12:17:30 +0530 Subject: [PATCH] Port FFT domain filter. --- libavfilter/Makefile |1 + libavfilter/allfilters.c |1 + libavfilter/vf_fftfilt.c | 258 +

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vc1: optimize block functions

2015-02-28 Thread Michael Niedermayer
On Wed, Feb 25, 2015 at 12:28:45AM +0800, zhaoxiu.zeng wrote: > 在 2015/2/19 2:12, Michael Niedermayer 写道: > > On Sat, Feb 14, 2015 at 10:56:28PM +0800, zhaoxiu.zeng wrote: > >> From 960eca51e6e65e6969f7d829e29ddc2387420733 Mon Sep 17 00:00:00 2001 > >> From: Zeng Zhaoxiu > >> Date: Sat, 14 Feb 201

Re: [FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-02-28 Thread Michael Niedermayer
On Sat, Feb 28, 2015 at 08:22:49PM +0530, arwa arif wrote: > Updated the patch. > Makefile |1 > allfilters.c |1 > vf_fftfilt.c | 258 > +++ > 3 files changed, 260 insertions(+) > dde368ae2972c85600e209bee3a9e26a05938baf 00

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ppc/fdctdsp: fix const warning

2015-02-28 Thread Michael Niedermayer
On Fri, Feb 27, 2015 at 11:07:22PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/ppc/fdctdsp.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a r

[FFmpeg-devel] [PATCH] avutil/mathematics: remove superfluous asserts from av_rescale_rnd

2015-02-28 Thread Andreas Cadhalpun
Hi, the asserts in av_rescale_rnd are unnecessary since commit 3929c174. Best regards, Andreas >From 932813ac54beaca4c1e02d76b76c50097d0f1336 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Sat, 28 Feb 2015 19:45:31 +0100 Subject: [PATCH] avutil/mathematics: remove superfluous asserts fr

[FFmpeg-devel] [PATCH] avcodec/utils: use correct printf specifier in ff_set_sar

2015-02-28 Thread Andreas Cadhalpun
Hi, AVRational.num and AVRational.den are signed integers, so the correct printf specifier is %d not %u. Best regards, Andreas >From 001f2e3b8bb3623928f2ec4c95dea2c3b9b04341 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Sat, 28 Feb 2015 20:11:36 +0100 Subject: [PATCH] avcodec/utils:

[FFmpeg-devel] [PATCH] avformat/flvenc: check that the codec_tag fits in one byte

2015-02-28 Thread Andreas Cadhalpun
Hi, Trying to mux prores into flv triggers an av_assert2, because the prores codec tag doesn't fit in one byte. Attached is a patch fixing this. Best regards, Andreas >From 850352d0e1c262b434094fb19787bbd5b6bf6c57 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Sat, 28 Feb 2015 20:58:3

Re: [FFmpeg-devel] [PATCH] avutil/mathematics: remove superfluous asserts from av_rescale_rnd

2015-02-28 Thread Michael Niedermayer
On Sat, Feb 28, 2015 at 08:21:21PM +0100, Andreas Cadhalpun wrote: > Hi, > > the asserts in av_rescale_rnd are unnecessary since commit 3929c174. > > Best regards, > Andreas > mathematics.c |3 --- > 1 file changed, 3 deletions(-) > 9af17404d606e3f9a6a5c37a515dfae8ac371313 > 0001-avutil-m

Re: [FFmpeg-devel] [PATCH] avcodec/utils: use correct printf specifier in ff_set_sar

2015-02-28 Thread Michael Niedermayer
On Sat, Feb 28, 2015 at 08:28:09PM +0100, Andreas Cadhalpun wrote: > Hi, > > AVRational.num and AVRational.den are signed integers, so the > correct printf specifier is %d not %u. > > Best regards, > Andreas > utils.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 0ab5520aa1e58707

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: check that the codec_tag fits in one byte

2015-02-28 Thread Michael Niedermayer
On Sat, Feb 28, 2015 at 09:12:57PM +0100, Andreas Cadhalpun wrote: > Hi, > > Trying to mux prores into flv triggers an av_assert2, because the > prores codec tag doesn't fit in one byte. > Attached is a patch fixing this. > > Best regards, > Andreas > flvenc.c |2 +- > 1 file changed, 1 ins

[FFmpeg-devel] [PATCH 1/3] avfilter/af_volume: fix precision=fixed and volume=0 case

2015-02-28 Thread Gilles Chanteperdrix
When precision is fixed and volume is 0, filter_frame does not perform any operation on the output buffer. This works if the output buffer has been allocated and zeroed with ff_get_audio_buffer but not if the input buffer is used as output buffer. Fix this by not using the input buffer as output b

[FFmpeg-devel] [PATCH 2/3] avformat: map T.140 RTP codec to text

2015-02-28 Thread Gilles Chanteperdrix
This makes more sense than mapping to AV_CODEC_ID_SUBRIP. Nothing indicates that a T.140 track contains subrip sub-titles. Signed-off-by: Gilles Chanteperdrix --- libavformat/rtpdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtpdec.c b/libavformat/rtpdec.c

[FFmpeg-devel] [PATCH 3/3] Revert "rtsp: Interpret the text media type as AVMEDIA_TYPE_DATA"

2015-02-28 Thread Gilles Chanteperdrix
This reverts commit 26524e358147aade6e9dd18fff42d61b966bbc70. If we want the T.140 codec to have the AV_CODEC_ID_TEXT codec id, its type needs to be AVMEDIA_TYPE_SUBTITLE, so, keep interpreting the text media type as AVMEDIA_TYPE_SUBTITLE. Signed-off-by: Gilles Chanteperdrix --- libavformat/rts

[FFmpeg-devel] [PATCH] avformat/rmenc: limit packet size

2015-02-28 Thread Andreas Cadhalpun
Hi, the chunk size in rm files is stored in 16 bits, but the packet size can be larger, triggering an av_assert2 in avio_w8 (via avio_wb16). Best regards, Andreas >From 044b4bd4df935b918055c24ae661e9bcc31e425a Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Sat, 28 Feb 2015 23:11:50 +0

Re: [FFmpeg-devel] [PATCH] avformat/rmenc: limit packet size

2015-02-28 Thread Clément Bœsch
On Sat, Feb 28, 2015 at 11:32:59PM +0100, Andreas Cadhalpun wrote: > Hi, > > the chunk size in rm files is stored in 16 bits, but the packet size can be > larger, triggering an av_assert2 in avio_w8 (via avio_wb16). > > Best regards, > Andreas > From 044b4bd4df935b918055c24ae661e9bcc31e425a Mon

Re: [FFmpeg-devel] [PATCH] avformat/rmenc: limit packet size

2015-02-28 Thread Andreas Cadhalpun
On 28.02.2015 23:35, Clément Bœsch wrote: On Sat, Feb 28, 2015 at 11:32:59PM +0100, Andreas Cadhalpun wrote: diff --git a/libavformat/rmenc.c b/libavformat/rmenc.c index 838388f..1567834 100644 --- a/libavformat/rmenc.c +++ b/libavformat/rmenc.c @@ -396,6 +396,10 @@ static int rm_write_video(AVF

[FFmpeg-devel] [PATCH] lavc/pngenc: Support writing colorspace tags.

2015-02-28 Thread Niklas Haas
These are defined in http://www.w3.org/TR/PNG/#11addnlcolinfo. --- libavcodec/pngenc.c | 87 + 1 file changed, 87 insertions(+) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index ef2..c0bce91 100644 --- a/libavcodec/pngenc.c +++ b/

Re: [FFmpeg-devel] [PATCH] lavc/pngenc: Support writing colorspace tags.

2015-02-28 Thread Michael Niedermayer
On Sat, Feb 28, 2015 at 02:50:03AM +0100, Niklas Haas wrote: > These are defined in http://www.w3.org/TR/PNG/#11addnlcolinfo. > --- > libavcodec/pngenc.c | 87 > + > 1 file changed, 87 insertions(+) This has already been applied from github in

Re: [FFmpeg-devel] [PATCH] avformat/rmenc: limit packet size

2015-02-28 Thread Michael Niedermayer
On Sat, Feb 28, 2015 at 11:40:30PM +0100, Andreas Cadhalpun wrote: > On 28.02.2015 23:35, Clément Bœsch wrote: > >On Sat, Feb 28, 2015 at 11:32:59PM +0100, Andreas Cadhalpun wrote: > >>diff --git a/libavformat/rmenc.c b/libavformat/rmenc.c > >>index 838388f..1567834 100644 > >>--- a/libavformat/rme

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/af_volume: fix precision=fixed and volume=0 case

2015-02-28 Thread Michael Niedermayer
On Sat, Feb 28, 2015 at 11:15:39PM +0100, Gilles Chanteperdrix wrote: > When precision is fixed and volume is 0, filter_frame does not > perform any operation on the output buffer. This works if the > output buffer has been allocated and zeroed with ff_get_audio_buffer > but not if the input buffer

Re: [FFmpeg-devel] [PATCH] avutil/ppc/intreadwrite: remove AV_??64 overriding code

2015-02-28 Thread Michael Niedermayer
On Fri, Feb 27, 2015 at 09:59:26PM +0100, Michael Niedermayer wrote: > The code has undefined behavior and makes no difference when optimizations > are enabled. > > Signed-off-by: Michael Niedermayer applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You

Re: [FFmpeg-devel] [PATCH 3/3] Revert "rtsp: Interpret the text media type as AVMEDIA_TYPE_DATA"

2015-02-28 Thread Michael Niedermayer
On Sat, Feb 28, 2015 at 11:15:41PM +0100, Gilles Chanteperdrix wrote: > This reverts commit 26524e358147aade6e9dd18fff42d61b966bbc70. > > If we want the T.140 codec to have the AV_CODEC_ID_TEXT codec id, > its type needs to be AVMEDIA_TYPE_SUBTITLE, so, keep interpreting > the text media type as A

Re: [FFmpeg-devel] [PATCH 2/3] avformat: map T.140 RTP codec to text

2015-02-28 Thread Michael Niedermayer
On Sat, Feb 28, 2015 at 11:15:40PM +0100, Gilles Chanteperdrix wrote: > This makes more sense than mapping to AV_CODEC_ID_SUBRIP. Nothing > indicates that a T.140 track contains subrip sub-titles. > > Signed-off-by: Gilles Chanteperdrix > --- > libavformat/rtpdec.c | 2 +- > 1 file changed, 1 in

Re: [FFmpeg-devel] [PATCH 2/3] avformat: map T.140 RTP codec to text

2015-02-28 Thread Clément Bœsch
On Sat, Feb 28, 2015 at 11:15:40PM +0100, Gilles Chanteperdrix wrote: > This makes more sense than mapping to AV_CODEC_ID_SUBRIP. Nothing > indicates that a T.140 track contains subrip sub-titles. > > Signed-off-by: Gilles Chanteperdrix > --- > libavformat/rtpdec.c | 2 +- > 1 file changed, 1 in