Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-20 Thread Paul B Mahol
On 1/19/15, arwa arif wrote: > On Mon, Jan 19, 2015 at 8:53 PM, Stefano Sabatini > wrote: > >> On date Monday 2015-01-19 15:20:54 +0100, Clement Boesch encoded: >> > On Mon, Jan 19, 2015 at 02:09:33PM +, Paul B Mahol wrote: >> > > On 1/18/15, arwa arif wrote: >> > > > Attached the patch. >>

Re: [FFmpeg-devel] Adding Closed caption in nut muxer

2015-01-20 Thread Anshul
On 01/13/2015 06:50 PM, Michael Niedermayer wrote: On Tue, Jan 13, 2015 at 12:00:36PM +0100, Nicolas George wrote: Le quartidi 24 nivôse, an CCXXIII, Anshul a écrit : Please find attachment. Using this people can also mux cc608 stream in nut muxer IIRC, you need to submit a patch to libnut be

Re: [FFmpeg-devel] Post-processing filter Documentation

2015-01-20 Thread Stefano Sabatini
On date Monday 2015-01-19 04:41:37 +0530, Arwa Arif encoded: [...] http://trac.ffmpeg.org/wiki/Postprocessing [...] > Updated. Any comment on the images? Still missing benchmarks and pp filter covering. About the reference images, I think it would be useful to show the uncompressed original, a

Re: [FFmpeg-devel] [FFmpeg-cvslog] Adding Closed caption Support

2015-01-20 Thread Anshul
On 01/13/2015 01:15 PM, Clément Bœsch wrote: On Tue, Jan 13, 2015 at 08:12:10AM +0100, Clément Bœsch wrote: On Tue, Jan 13, 2015 at 11:26:06AM +0530, Anshul Maheshwari wrote: [...] Also added roll-up functionality. patch is attached. Thanks Anshul Attaching patch From ca66e917f45bd47dd7979

[FFmpeg-devel] Expanded decoder for CEA-608 and World System Teletext

2015-01-20 Thread Shan
Just a FYI, I noticed the recent, but limited CEA-608 decoder addition to the project. I have developed my own version to translate these to 25 frame STL files a while ago in my own time for the broadcaster I work for. I would have submitted them, but I loath using git for any thing but basic ret

Re: [FFmpeg-devel] Adding Closed caption in nut muxer

2015-01-20 Thread Michael Niedermayer
On Tue, Jan 20, 2015 at 03:22:08PM +0530, Anshul wrote: > > On 01/13/2015 06:50 PM, Michael Niedermayer wrote: > >On Tue, Jan 13, 2015 at 12:00:36PM +0100, Nicolas George wrote: > >>Le quartidi 24 nivôse, an CCXXIII, Anshul a écrit : > >>>Please find attachment. > >>>Using this people can also mux

Re: [FFmpeg-devel] [FFmpeg-cvslog] Adding Closed caption Support

2015-01-20 Thread Michael Niedermayer
On Tue, Jan 20, 2015 at 04:39:40PM +0530, Anshul wrote: > > On 01/13/2015 01:15 PM, Clément Bœsch wrote: > >On Tue, Jan 13, 2015 at 08:12:10AM +0100, Clément Bœsch wrote: > >>On Tue, Jan 13, 2015 at 11:26:06AM +0530, Anshul Maheshwari wrote: > >>[...] > Also added roll-up functionality. >

Re: [FFmpeg-devel] [PATCH] tests: drop bc dependency

2015-01-20 Thread Michael Niedermayer
On Mon, Jan 19, 2015 at 10:58:02PM +0100, Clément Bœsch wrote: > We already have a dependency on awk, bc is sometimes not found in the > base system, and we save a shell fork. > --- > tests/fate-run.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) looks ok but iam no awk/bc/shell guru s

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-20 Thread Michael Niedermayer
On Thu, Jan 15, 2015 at 10:21:22PM +0530, supraja reddy wrote: > Hello, > > I have attached the patch for twofish implementation. Please let me know if > there are any changes to be made. > > Thank you, > > Supraja [...] > +av_cold int av_twofish_init(AVTWOFISH *cs, const uint8_t *Key, int key

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-20 Thread arwa arif
> > > @@ -0,0 +1,342 @@ > > +/* > > + * Original MPlayer filters by Richard Felker, Hampa Hug, Daniel Moreno, > > + * and Michael Niedermeyer. > > + * > > + * Copyright (c) 2014 James Darnley > > + * Copyright (c) 2015 Arwa Arif > > + * > > + * This file is part of FFmpeg. > > + * > > + * FFmpeg

Re: [FFmpeg-devel] Post-processing filter Documentation

2015-01-20 Thread arwa arif
> > Still missing benchmarks and pp filter covering. > > What is meant by pp filter covering? Do you want benchmark for each image? And by benchmark you mean runtime, right? > About the reference images, I think it would be useful to show the > uncompressed original, and use FFmpeg to encode it (

[FFmpeg-devel] [PATCH] avfilter/vf_lenscorrection: support 8bit planar RGB formats

2015-01-20 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_lenscorrection.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_lenscorrection.c b/libavfilter/vf_lenscorrection.c index 9fb1424..82ddb29 100644 --- a/libavfilter/vf_lenscorrection.c +++ b/libavfilter/vf_lenscorrection.c @@ -104,6

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lenscorrection: support 8bit planar RGB formats

2015-01-20 Thread compn
On Tue, 20 Jan 2015 17:17:16 + Paul B Mahol wrote: > AV_PIX_FMT_YUV420P, AV_PIX_FMT_YUVJ420P, > AV_PIX_FMT_YUVA444P, AV_PIX_FMT_YUVA420P, > AV_PIX_FMT_YUV422P, > +AV_PIX_FMT_GBRP, AV_PIX_FMT_GBRAP, > AV_PIX_FMT_NONE looks ok to me , if tested... :

[FFmpeg-devel] [PATCH] libavcodec/ppc/mpegvideoencdsp.c: fix stack smashing in pix_norm1_altivec() and pix_sum_altivec()

2015-01-20 Thread Andreas Cadhalpun
Hi, after enabling the altivec optimizations on ppc64el, many fate tests failed, some of them with 'stack smashing detected'. For the full build log see [1]. The attached patch fixes all the stack smashing crashes. But I don't know, what causes the other test failures. Rong Yan, maybe you c

[FFmpeg-devel] [PATCH] avcodec/h264: Partially decode and display single fields try #2

2015-01-20 Thread Michael Niedermayer
This like the previous attempt does not fully correctly decode this type of non standard H.264, but it now works fully automatic requiring no manual filters or flags to be used See Ticket2254 Signed-off-by: Michael Niedermayer --- libavcodec/h264.c | 31 ++-

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-20 Thread supraja reddy
Hello, Thanks for you reviews. I see this is only use during init but if it still matters speedwise > and assuming this is a galois field multiplication the it can be > written as > > EXP_GF256[LOG_GF256[a] + LOG_GF256[b]] (for a!=0 && b!=0) > > Do you want me to insert tables EXP_GF256 and LOG_

Re: [FFmpeg-devel] [PATCH] tests: drop bc dependency

2015-01-20 Thread Reimar Döffinger
On Mon, Jan 19, 2015 at 10:58:02PM +0100, Clément Bœsch wrote: > -echo "scale=2; v = $1 - $2; if (v < 0) v = -v; if (v > $3) r = 1; r" | bc > +awk "BEGIN { v=$1-$2; printf \"%d\\n\", ((v<0?v:-v) > $3) ? 1 : 0 }" I'd suggest single quotes for the outer ones, then you do not need to escape \

Re: [FFmpeg-devel] [PATCH] avcodec/h264: Partially decode and display single fields try #2

2015-01-20 Thread Kieran Kunhya
> +for(p=0; p<3; p++) { > +int h = f->height; > +int w = f->width; > +if (p) { > +w >>= h_chroma_shift; > +h >>= v_chroma_shift; > +} > +

[FFmpeg-devel] [PATCH 0/2] [RFC] avformat/flv subtitle fixes

2015-01-20 Thread Michael Niedermayer
this patchset (tries to) fix onTextData handling in flv kurosu spotted that flv_data_packet() is not used and this is my attempt to fix it. Note, i do not have a flv file with onTextData, so if someone has one please share! Also this probably still contains some bugs, a review from someone knowing

[FFmpeg-devel] [PATCH 2/2] avformat/flvdec: re enable flv_data_packet() and use AVMEDIA_TYPE_SUBTITLE

2015-01-20 Thread Michael Niedermayer
Found-by: kurosu Signed-off-by: Michael Niedermayer --- libavformat/flvdec.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 572268f..f98cb97 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -48

[FFmpeg-devel] [PATCH 1/2] avformat/flvenc: accept AVMEDIA_TYPE_SUBTITLE instead of DATA for subtitles

2015-01-20 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/flvenc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index 5e27ed0..7d3a0ca 100644 --- a/libavformat/flvenc.c +++ b/libavformat/flvenc.c @@ -389,6 +389,14 @@ stati

Re: [FFmpeg-devel] [PATCH] avcodec/h264: Partially decode and display single fields try #2

2015-01-20 Thread Michael Niedermayer
On Tue, Jan 20, 2015 at 09:51:25PM +, Kieran Kunhya wrote: > > +for(p=0; p<3; p++) { > > +int h = f->height; > > +int w = f->width; > > +if (p) { > > +w >>= h_chroma_shift; > > +

[FFmpeg-devel] [PATCH] avformat/mov: simplify pasp value before setting SAR

2015-01-20 Thread Michael Niedermayer
This avoids a 65536:65536 SAR Signed-off-by: Michael Niedermayer --- libavformat/mov.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 556411f..2a9a3f7 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -737,8 +737,8 @

Re: [FFmpeg-devel] [PATCH] libavcodec/ppc/mpegvideoencdsp.c: fix stack smashing in pix_norm1_altivec() and pix_sum_altivec()

2015-01-20 Thread Michael Niedermayer
On Tue, Jan 20, 2015 at 07:12:09PM +0100, Andreas Cadhalpun wrote: > Hi, > > after enabling the altivec optimizations on ppc64el, many fate tests > failed, some of them with 'stack smashing detected'. For the full > build log see [1]. > > The attached patch fixes all the stack smashing crashes. >

[FFmpeg-devel] [PATCH] ffprobe: fix memleaks on errors

2015-01-20 Thread Michael Niedermayer
Found-by: Andreas Cadhalpun Signed-off-by: Michael Niedermayer --- ffprobe.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/ffprobe.c b/ffprobe.c index faddc16..38879f1 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -2398,6 +2398,7 @@ static int open_input_

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-20 Thread Agatha Hu
On 2015/1/18 4:01, Philip Langdale wrote: There is a long sad story behind all this, but it's somewhat ambiguous as to whether DVD content should be treated as 720 pixels wide or 704 pixels, with 16 pixels cut off. If you decide is should be 704 pixels wide, you need to adjust the sample aspect r

[FFmpeg-devel] [PATCH] avcodec/nvenc: add repeatSPSPPS flag for streaming

2015-01-20 Thread Agatha Hu
Still using attachment to prevent word-wrapping. For video streaming, repeatSPSPPS flag should be set as 1 besides disableSPSPPS=0, elsewise if running ffmpeg before vlc/ffmpeg, there will be no video header, decoder can't work properly. Agatha Hu >From 526f4f37f1fbd8214a2866dad1d6c2ea480ffd9a

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: add repeatSPSPPS flag for streaming

2015-01-20 Thread Timo Rothenpieler
Still using attachment to prevent word-wrapping. For video streaming, repeatSPSPPS flag should be set as 1 besides disableSPSPPS=0, elsewise if running ffmpeg before vlc/ffmpeg, there will be no video header, decoder can't work properly. Agatha Hu Looks good to merge. signature.asc Descrip