Re: [FFmpeg-devel] libavutil: added camellia block cipher

2015-01-02 Thread supraja reddy
Hello, I have modified the LR128 function slightly to make it more compact. Thanks, Supraja On Wed, Dec 31, 2014 at 9:53 PM, supraja reddy wrote: > Hello, > > I have made the following changes. > > > create mode 100644 libavutil/camellia.h >> >> Missing changelog entry. >> > I have updated th

[FFmpeg-devel] [PATCH] doc/ffmpeg: mention both ffpreset/avpreset in documentation, remove superfluous example

2015-01-02 Thread Werner Robitza
ffmpeg looks for both .ffpreset and .avpreset files depending on whether the -[avsf]pre or -pre option is used. Added two sections for each type of preset including the rules according to which files are searched. (Notably, the lookup order is swapped for avpreset files, because it first looks for

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg mention both ffpreset/avpreset in documentation, remove superfluous example

2015-01-02 Thread Werner Robitza
On Fri, Jan 2, 2015 at 12:13 AM, Michael Niedermayer wrote: > its not as simple, > -pre uses .avpreset and -apre/-fpre/-vpre/-spre uses ffpreset > they work differently, avpreset only allows "encoder options" > so for example you cannot put vcodec=libvpx in it New patch on the way. (By the way,

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: move edit list heuristics into mov_build_index()

2015-01-02 Thread Clément Bœsch
On Mon, Dec 01, 2014 at 11:10:14PM +0100, Clément Bœsch wrote: > From: Clément Bœsch > > mov_read_elst() is now only responsible from storing the table in a data > structure; this is consistent with other table readers functions. > --- > libavformat/isom.h | 10 +-- > libavformat/mov.c | 78

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: reindent after previous commit

2015-01-02 Thread Clément Bœsch
On Mon, Dec 01, 2014 at 11:10:15PM +0100, Clément Bœsch wrote: > From: Clément Bœsch > > --- > libavformat/mov.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > Applied [...] -- Clément B. pgpmknIC5tBQZ.pgp Description: PGP signature

[FFmpeg-devel] how to add configuration option to ffmepg

2015-01-02 Thread llj
Hi, dear ffmpeg developer, below is a peace of code in libx264.c. static av_cold int X264_init(AVCodecContext *avctx) { X264Context *x4 = avctx->priv_data; int sw,sh; if (avctx->global_quality > 0) av_log(avctx, AV_LOG_WARNING, "-qscale is ignored, -crf is recommended.\n");

Re: [FFmpeg-devel] [PATCH] Changelog: Add cropdetect non 8bpp

2015-01-02 Thread Michael Niedermayer
On Thu, Jan 01, 2015 at 10:25:00AM +0100, Reimar Döffinger wrote: > On Thu, Jan 01, 2015 at 03:34:15AM +0100, Michael Niedermayer wrote: > > Suggested-by: Reimar > > Signed-off-by: Michael Niedermayer > > --- > > Changelog |1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Changel

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg mention both ffpreset/avpreset in documentation, remove superfluous example

2015-01-02 Thread Michael Niedermayer
On Fri, Jan 02, 2015 at 11:13:29AM +0100, Werner Robitza wrote: > On Fri, Jan 2, 2015 at 12:13 AM, Michael Niedermayer wrote: > > its not as simple, > > -pre uses .avpreset and -apre/-fpre/-vpre/-spre uses ffpreset > > they work differently, avpreset only allows "encoder options" > > so for exampl

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2015-01-02 Thread Michael Niedermayer
On Fri, Jan 02, 2015 at 02:03:05PM +0530, supraja reddy wrote: > Hello, > > I have modified the LR128 function slightly to make it more compact. > > Thanks, > Supraja > > On Wed, Dec 31, 2014 at 9:53 PM, supraja reddy > wrote: > > > Hello, > > > > I have made the following changes. > > > > >

Re: [FFmpeg-devel] how to add configuration option to ffmepg

2015-01-02 Thread Michael Niedermayer
On Fri, Jan 02, 2015 at 09:44:10PM +0800, llj wrote: > Hi, dear ffmpeg developer, > below is a peace of code in libx264.c. > > > static av_cold int X264_init(AVCodecContext *avctx) > { > X264Context *x4 = avctx->priv_data; > int sw,sh; > > > if (avctx->global_quality > 0) >

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2015-01-02 Thread Giorgio Vazzana
Hello, 2015-01-02 15:17 GMT+01:00 Michael Niedermayer : > i assume giorgio is ok with the patch as he previously said "rest LGTM" > so applied thank you Supraja for the good work and thanks Michael for applying the patch. I spotted only minor things, attached some patches from most important to

Re: [FFmpeg-devel] [PATCH] lavd/lavfi: allow to extract subcc.

2015-01-02 Thread Michael Niedermayer
On Thu, Dec 04, 2014 at 01:37:08PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > doc/indevs.texi | 14 > libavdevice/lavfi.c | 92 > + > 2 files changed, 99 insertions(+), 7 deletions(-) > > > Correctly reb

Re: [FFmpeg-devel] [PATCH 2/2] Adding closed caption decoder

2015-01-02 Thread Michael Niedermayer
On Wed, Dec 31, 2014 at 07:09:33PM +0530, Anshul wrote: [...] > +static void build_parity_table(int *parity_table) > +{ > +unsigned int byte; > +int parity_v; > +for (byte = 0; byte <= 127; byte++) { > +parity_v = av_popcount(byte) & 1; > +parity_table[byte] = parity_v;

Re: [FFmpeg-devel] [PATCH] web/contact: Suggest that patch authors subscribe to ffmpeg-devel

2015-01-02 Thread Lou Logan
On Thu, 1 Jan 2015 20:54:43 +0100, Michael Niedermayer wrote: > --- > src/contact |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/contact b/src/contact > index 130addf..7233806 100644 > --- a/src/contact > +++ b/src/contact > @@ -35,7 +35,8 @@ > href=

Re: [FFmpeg-devel] [PATCH] web/contact: Suggest that patch authors subscribe to ffmpeg-devel

2015-01-02 Thread Lou Logan
On Fri, 2 Jan 2015 11:35:08 -0900, Lou Logan wrote: > On Thu, 1 Jan 2015 20:54:43 +0100, Michael Niedermayer wrote: > > > --- > > src/contact |3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/src/contact b/src/contact > > index 130addf..7233806 100644 > > ---

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2015-01-02 Thread Michael Niedermayer
On Fri, Jan 02, 2015 at 05:13:33PM +0100, Giorgio Vazzana wrote: > Hello, > > 2015-01-02 15:17 GMT+01:00 Michael Niedermayer : > > i assume giorgio is ok with the patch as he previously said "rest LGTM" > > so applied > > thank you Supraja for the good work and thanks Michael for applying the pat

Re: [FFmpeg-devel] [PATCH 1/2] lavd/v4l2: implement list device callback

2015-01-02 Thread Lukasz Marek
On 21 December 2014 at 23:39, Lukasz Marek wrote: > On 21.12.2014 22:43, Lukasz Marek wrote: > >> Signed-off-by: Lukasz Marek >> --- >> libavdevice/v4l2.c | 58 ++ >> >> 1 file changed, 58 insertions(+) >> >> diff --git a/libavdevice/v4l2.c

Re: [FFmpeg-devel] [PATCH 2/2] cmdutils: use helper functions for listing sinks/sources

2015-01-02 Thread Lukasz Marek
On 21 December 2014 at 21:04, Lukasz Marek wrote: > List device callback must be able to return valid list without opening > device. > This callback should return input values for open function, not vice-versa. > Read header funtion is very likey to fail without proper configuration > provided. >

Re: [FFmpeg-devel] [PATCH 2/2] cmdutils: use helper functions for listing sinks/sources

2015-01-02 Thread Michael Niedermayer
On Sat, Jan 03, 2015 at 04:45:56AM +0100, Lukasz Marek wrote: > On 21 December 2014 at 21:04, Lukasz Marek wrote: > > > List device callback must be able to return valid list without opening > > device. > > This callback should return input values for open function, not vice-versa. > > Read heade

Re: [FFmpeg-devel] [PATCH 2/2] Adding closed caption decoder

2015-01-02 Thread Anshul
On 01/03/2015 01:42 AM, Michael Niedermayer wrote: > On Wed, Dec 31, 2014 at 07:09:33PM +0530, Anshul wrote: > [...] > >> +static void build_parity_table(int *parity_table) >> +{ >> +unsigned int byte; >> +int parity_v; >> +for (byte = 0; byte <= 127; byte++) { >> +parity_v = av