Re: [FFmpeg-devel] [PATCH] lavfi: USPP filter

2014-12-12 Thread Stefano Sabatini
On date Friday 2014-12-12 12:15:44 +0530, arwa arif encoded: [...] > From b075eb959b00124de6c54a058fec865647d9dd17 Mon Sep 17 00:00:00 2001 > From: Arwa Arif > Date: Fri, 12 Dec 2014 11:14:26 +0530 > Subject: [PATCH] Delete mp=uspp > > --- > doc/filters.texi |1 - > libavfil

Re: [FFmpeg-devel] [PATCH 2/2] Adding closed caption decoder

2014-12-12 Thread Anshul
On 12/06/2014 04:24 PM, Anshul wrote: > On 12/06/2014 04:22 PM, Anshul wrote: >> On 12/05/2014 07:56 PM, Nicolas George wrote: >>> Hi. I had time to look at the code with some more details. Comments are >>> below. >>> >From 31f69ccfb45247a7cc203084a931b8523284aa13 Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [PATCH] avformat: add dump_metadata_lines

2014-12-12 Thread wm4
On Fri, 12 Dec 2014 02:24:54 +0100 Michael Niedermayer wrote: > On Thu, Dec 11, 2014 at 01:18:21AM +, Vittorio Giovara wrote: > > On Wed, Dec 10, 2014 at 1:23 PM, wm4 wrote: > > > On Wed, 10 Dec 2014 03:38:03 +0100 > > > Lukasz Marek wrote: > > > > > >> W dniu środa, 10 grudnia 2014 Vittori

Re: [FFmpeg-devel] [PATCH] lavfi: USPP filter

2014-12-12 Thread wm4
On Fri, 12 Dec 2014 02:04:18 + (UTC) Carl Eugen Hoyos wrote: > arwa arif gmail.com> writes: > > > I checked the ouput with quality 8, I am getting a broken output. > > Yes, that's ticket #3596. > > Congratulation for porting the filter, will you do fspp next? > It's one ancient legacy f

Re: [FFmpeg-devel] [PATCH] lavfi: USPP filter

2014-12-12 Thread Carl Eugen Hoyos
arwa arif gmail.com> writes: > Since, fspp is written in assembly language also, > I am not very sure if I will be able to do it. You can start with the C variant only, then copy the asm code to a new file as done in this commit: http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=a2c547ff I

Re: [FFmpeg-devel] [PATCH]Fix leak reading invalid mxf files

2014-12-12 Thread Michael Niedermayer
On Wed, Dec 10, 2014 at 11:30:54AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #4173 for me. > To be split in two parts. > > Please comment, Carl Eugen probably ok if tomas doesnt reply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH]Fix leak reading invalid mxf files

2014-12-12 Thread Tomas Härdin
On Wed, 2014-12-10 at 11:30 +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #4173 for me. > To be split in two parts. > > Please comment, Carl Eugen Looks alright. Maybe you want to pass it a MXFMetadataSet** so you can use av_freep() like before? But I suppose it doesn't ma

[FFmpeg-devel] [PATCH] avcodec/xiph: mark returned header pointers const from avpriv_split_xiph_headers()

2014-12-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/vorbis_parser.c |2 +- libavcodec/vorbisdec.c |2 +- libavcodec/vp3.c |2 +- libavcodec/xiph.c |2 +- libavcodec/xiph.h |2 +- libavformat/matroskaenc.c |2 +- libavformat/sdp.c |

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-12 Thread Nicolas George
Le duodi 22 frimaire, an CCXXIII, Rodger Combs a écrit : > This also moves general charenc conversion from avcodec to avformat; > the version in avcodec is left, but renamed; I'm not sure if that's > the optimal solution. > > The documentation could probably use some improvements, and a few more >

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-12 Thread Lukasz Marek
On 12 December 2014 at 07:05, Rodger Combs wrote: > > diff --git a/configure b/configure > index e2e3619..a5a9f9b 100755 > --- a/configure > +++ b/configure > @@ -199,6 +199,9 @@ External library support: >--enable-gnutls enable gnutls, needed for https support >

[FFmpeg-devel] [PATCH 1/2] avcodec/avdct: support >8bit per sample dcts

2014-12-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/avdct.c |3 +++ libavcodec/avdct.h |2 ++ 2 files changed, 5 insertions(+) diff --git a/libavcodec/avdct.c b/libavcodec/avdct.c index a01a6b7..f92c691 100644 --- a/libavcodec/avdct.c +++ b/libavcodec/avdct.c @@ -63,6 +63,8 @@ static const

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_spp: support 10bit per sample

2014-12-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavfilter/vf_spp.c | 89 -- 1 file changed, 71 insertions(+), 18 deletions(-) diff --git a/libavfilter/vf_spp.c b/libavfilter/vf_spp.c index 8eb0c7e..c03cf1f 100644 --- a/libavfilter/vf_spp.c +++ b/libavfi

[FFmpeg-devel] [PATCH 1/5] lavu/dict: check for malloc failures

2014-12-12 Thread wm4
--- I didn't actually test these fixes, because someone just passed me a list of failures found with failmalloc, rather than providing reproducible test cases. --- libavutil/dict.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index 29

[FFmpeg-devel] [PATCH 3/5] lavu/dict: remove weird intptr_t cast

2014-12-12 Thread wm4
I can't come up with a reason why this would be needed. --- libavutil/dict.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index c4b97dc..e33e6a1 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -100,14 +100,14 @@ int av_dict_set

[FFmpeg-devel] [PATCH 2/5] lavu/dict: check for malloc failures some more

2014-12-12 Thread wm4
This fix is rather messy because of AV_DICT_DONT_STRDUP_VAL. It's not even clear how this should be handled. Maybe freeing the user's data on failure would actually be ok. --- libavutil/dict.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavutil/dict.c b/libavutil/dict.c index a362d

[FFmpeg-devel] [PATCH 4/5] lavc/avpacket: check for malloc failure

2014-12-12 Thread wm4
--- libavcodec/avpacket.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 3c26046..1867476 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -546,8 +546,11 @@ int av_packet_ref(AVPacket *dst, const AVPacket

[FFmpeg-devel] [PATCH 5/5] lavu/utils: check for malloc failure

2014-12-12 Thread wm4
--- libavformat/utils.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 5a2a72d..fc582b7 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -3652,6 +3652,10 @@ AVStream *avformat_new_stream(AVFormatContext *s, const AVCodec *c)

Re: [FFmpeg-devel] [PATCH 4/5] lavc/avpacket: check for malloc failure

2014-12-12 Thread Michael Niedermayer
On Fri, Dec 12, 2014 at 06:15:42PM +0100, wm4 wrote: > --- > libavcodec/avpacket.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Avoid a single point of failure, be that a person or equi

[FFmpeg-devel] [PATCH]Set the default for --shlibdir to --libdir

2014-12-12 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #4183. Please review, Carl Eugen diff --git a/configure b/configure index e2e3619..dc6c742 100755 --- a/configure +++ b/configure @@ -2685,7 +2685,7 @@ docdir_default='${prefix}/share/doc/ffmpeg' incdir_default='${prefix}/include' libdir_default='${prefix}/lib'

Re: [FFmpeg-devel] [PATCH 5/5] lavu/utils: check for malloc failure

2014-12-12 Thread Michael Niedermayer
On Fri, Dec 12, 2014 at 06:15:43PM +0100, wm4 wrote: > --- > libavformat/utils.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index 5a2a72d..fc582b7 100644 > --- a/libavformat/utils.c > +++ b/libavformat/utils.c > @@ -3652,6 +3652,10 @@

[FFmpeg-devel] [PATCH] avformat/utils: check for malloc failure

2014-12-12 Thread wm4
--- Also fixed the commit message. --- libavformat/utils.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 5a2a72d..8aee511 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -3652,6 +3652,11 @@ AVStream *avformat_new_stream(AVFor

Re: [FFmpeg-devel] [PATCH 1/5] lavu/dict: check for malloc failures

2014-12-12 Thread Michael Niedermayer
On Fri, Dec 12, 2014 at 06:15:39PM +0100, wm4 wrote: > --- > I didn't actually test these fixes, because someone just passed me > a list of failures found with failmalloc, rather than providing > reproducible test cases. > --- > libavutil/dict.c | 6 +- > 1 file changed, 5 insertions(+), 1 del

Re: [FFmpeg-devel] [PATCH] avformat/utils: check for malloc failure

2014-12-12 Thread Michael Niedermayer
On Fri, Dec 12, 2014 at 10:22:55PM +0100, wm4 wrote: > --- > Also fixed the commit message. > --- > libavformat/utils.c | 5 + > 1 file changed, 5 insertions(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do it that

Re: [FFmpeg-devel] [PATCH] doc: add FFREPORT example

2014-12-12 Thread Michael Niedermayer
On Thu, Dec 11, 2014 at 12:00:09PM -0900, Lou Logan wrote: > And fix a few nits. > > Signed-off-by: Lou Logan > --- > doc/fftools-common-opts.texi | 18 +- > 1 file changed, 13 insertions(+), 5 deletions(-) should be ok would be nice if named log levels could be used instead th

Re: [FFmpeg-devel] [PATCH]Set the default for --shlibdir to --libdir

2014-12-12 Thread Ivan Kalvachev
On 12/12/14, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #4183. > > Please review, Carl Eugen You should also update the configure help text, as the default is not PREFIX/lib anymore. Best Regards ___ ffmpeg-devel mailing list ffmpeg-

Re: [FFmpeg-devel] [PATCH 2/5] lavu/dict: check for malloc failures some more

2014-12-12 Thread Lukasz Marek
On 12.12.2014 18:15, wm4 wrote: This fix is rather messy because of AV_DICT_DONT_STRDUP_VAL. It's not even clear how this should be handled. Maybe freeing the user's data on failure would actually be ok. const char* arg suggests this function should not free it, but dict would free it eventual

Re: [FFmpeg-devel] [PATCH]Set the default for --shlibdir to --libdir

2014-12-12 Thread Carl Eugen Hoyos
On Saturday 13 December 2014 01:12:02 am Ivan Kalvachev wrote: > On 12/12/14, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes ticket #4183. > > > > Please review, Carl Eugen > > You should also update the configure help text, as the default is not > PREFIX/lib anymore. New patch atta

Re: [FFmpeg-devel] [PATCH 2/5] lavu/dict: check for malloc failures some more

2014-12-12 Thread Michael Niedermayer
On Fri, Dec 12, 2014 at 06:15:40PM +0100, wm4 wrote: > This fix is rather messy because of AV_DICT_DONT_STRDUP_VAL. It's not > even clear how this should be handled. Maybe freeing the user's data on > failure would actually be ok. > --- > libavutil/dict.c | 6 ++ > 1 file changed, 6 insertions

Re: [FFmpeg-devel] [PATCH]Set the default for --shlibdir to --libdir

2014-12-12 Thread Michael Niedermayer
On Sat, Dec 13, 2014 at 01:50:03AM +0100, Carl Eugen Hoyos wrote: > On Saturday 13 December 2014 01:12:02 am Ivan Kalvachev wrote: > > On 12/12/14, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch fixes ticket #4183. > > > > > > Please review, Carl Eugen > > > > You should also update

Re: [FFmpeg-devel] [PATCH] doc: add FFREPORT example

2014-12-12 Thread Lou Logan
On Sat, 13 Dec 2014 00:30:27 +0100, Michael Niedermayer wrote: > should be ok > > would be nice if named log levels could be used instead though Agreed. Anyway, I pushed this. Maybe I can figure out how to get it to work with named log levels too. ___

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: added HLS encryption

2014-12-12 Thread Michael Niedermayer
On Thu, Dec 11, 2014 at 12:27:37PM -0600, Christian Suloway wrote: > Added HLS encryption with -hls_key_info_file option. The > first line of key_info_file specifies the key URI for the playlist, and > the second line specifies the path to the file containing the encryption > key. Changes to key_i