Re: [FFmpeg-devel] [PATCH v2] Fix undefined reference to xcb_shape_rectangles in xcbgrab.c

2014-11-24 Thread Boris Reisig
Sorry, here's an update of my patch that works with (--enable-libxcb-shape) and without (--disable-libxcb-shape) now. Attached is v2 of the patch. On 11/23/2014 5:13 PM, Michael Niedermayer wrote: Hi On Sun, Nov 23, 2014 at 02:48:54PM -0600, Boris Reisig wrote: It seems when using the late

[FFmpeg-devel] pipeline multithreading

2014-11-24 Thread Daniel Oberhoff
Hi, >From what I gather the filter graph is utilizing modern multicores by >“striping” where filters support it, i.e. an image is divided in stripes and >the filter gets called in separate threads for separate stripes. I was >wondering if there is or will be pipeline multuthreading, i.e. with a

Re: [FFmpeg-devel] [PATCH 1/4] libavcodec: new API for frame threading by step

2014-11-24 Thread Christophe Gisquet
Hi, 2014-07-23 21:13 GMT+02:00 Christophe Gisquet : > The new _progress3 functions allow reporting the x,y position in > decoding. > > ff_thread_report_progress3_raster_end allows signaling the end of > a raster line and updates unconditionally the position to the > start of next raster line. > >

Re: [FFmpeg-devel] bprint.h can't be included in C++ code

2014-11-24 Thread Nicolas George
Le tridi 3 frimaire, an CCXXIII, Vadim Kalinsky a écrit : > Yep, my bad. Thanks for the updated patch. > Maybe I'm little contaminated with modern PLs, but I don't see huge > difference in readability between the old and the new versions. Both are > terrible :-) At least, this one, I can actuall

[FFmpeg-devel] [PATCH] avformat/rawdec: raw formats have no timestamps

2014-11-24 Thread wm4
Some raw demuxers already had AVFMT_NOTIMESTAMPS set. Add it for all the others. --- Not sure if this is correct. But I noticed that libavformat does not return any timestamps for .shn (Shorten) files, and I'd like to use the AVFMT_NOTIMESTAMPS flag to make up my own timestamps (or at least let suc

[FFmpeg-devel] [PATCH] avutil/bprint: make header work with C++, simplify

2014-11-24 Thread wm4
This change should be ABI-compatible. Since the size of the useable internal buffer was actually different on 32 bit and 64 bit, so the code contains a somewhat ugly kludge to maintain ABI-compatibility. It can be removed on the next ABI-bump. --- Note that there are the following (and IMO sufficie

Re: [FFmpeg-devel] bprint.h can't be included in C++ code

2014-11-24 Thread wm4
On Fri, 21 Nov 2014 13:43:20 -0500 Vadim Kalinsky wrote: > C++ does not support anonymous struct. > Proposed an alternative patch ([PATCH] avutil/bprint: make header work with C++, simplify). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http:

Re: [FFmpeg-devel] [PATCH] avutil/bprint: make header work with C++, simplify

2014-11-24 Thread Nicolas George
Le quartidi 4 frimaire, an CCXXIII, wm4 a écrit : > This change should be ABI-compatible. Since the size of the useable > internal buffer was actually different on 32 bit and 64 bit, so the code > contains a somewhat ugly kludge to maintain ABI-compatibility. It can be > removed on the next ABI-bum

[FFmpeg-devel] [PATCH] avformat/apngdec: transmit all the chunks between consecutive fcTL ones.

2014-11-24 Thread Benoit Fouet
In order to support multiple IDAT of fdAT chunks following an fcTL one, transmit all the chunks between two fcTL ones (or between fcTL and IEND one). --- libavformat/apngdec.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/libavformat/apngdec.c

[FFmpeg-devel] [PATCH] avformat/apngdec: transmit all the chunks between consecutive fcTL ones.

2014-11-24 Thread Benoit Fouet
In order to support multiple IDAT of fdAT chunks following an fcTL one, transmit all the chunks between two fcTL ones (or between fcTL and IEND one). --- libavformat/apngdec.c | 34 -- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/libavformat/apngd

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: add APNG support.

2014-11-24 Thread Benoit Fouet
Hi, - Mail original - > On Fri, Nov 21, 2014 at 08:09:50AM -0500, compn wrote: > > On Fri, 21 Nov 2014 12:05:47 +0100 > > Benoit Fouet wrote: > > > > > configure | 1 + > > > libavcodec/Makefile | 1 + > > > libavcodec/allcodecs.c | 1 + > > > libavcodec/avcodec

Re: [FFmpeg-devel] [PATCH] avutil/bprint: make header work with C++, simplify

2014-11-24 Thread Reimar Döffinger
On 24.11.2014, at 15:27, Nicolas George wrote: > Le quartidi 4 frimaire, an CCXXIII, wm4 a écrit : >> This change should be ABI-compatible. Since the size of the useable >> internal buffer was actually different on 32 bit and 64 bit, so the code >> contains a somewhat ugly kludge to maintain ABI-c

Re: [FFmpeg-devel] pipeline multithreading

2014-11-24 Thread Timothy Gu
On Mon, Nov 24, 2014 at 3:35 AM, Daniel Oberhoff wrote: > Hi, > > From what I gather the filter graph is utilizing modern multicores by > “striping” where filters support it, i.e. an image is divided in stripes > and the filter gets called in separate threads for separate stripes. In FFmpeg we ca

Re: [FFmpeg-devel] pipeline multithreading

2014-11-24 Thread Reimar Döffinger
On Mon, Nov 24, 2014 at 12:35:58PM +0100, Daniel Oberhoff wrote: > inout -> filter1 -> filter2 -> output > > some threads processing frame n in the output (i.e. encoding), other threads > procesing frame n+1 in filter2, others processing frame n+2 in filter1, and > yet others processing frame n+

Re: [FFmpeg-devel] bprint.h can't be included in C++ code

2014-11-24 Thread Vadim Kalinsky
> Nit: space after commas. > Is it necessary to typedef the structure on top of declaring it? In C, this: > {...} is legal, no need to typedef it. > Apart from that, I think the helper structure should be scoped in the > ff_namespace > Nit: no empty line between doxy and declaration. Patch

Re: [FFmpeg-devel] [PATCH v2] Fix undefined reference to xcb_shape_rectangles in xcbgrab.c

2014-11-24 Thread Michael Niedermayer
On Mon, Nov 24, 2014 at 02:00:05AM -0600, Boris Reisig wrote: > Sorry, here's an update of my patch that works with > (--enable-libxcb-shape) and without (--disable-libxcb-shape) now. > Attached is v2 of the patch. > > On 11/23/2014 5:13 PM, Michael Niedermayer wrote: > >Hi > > > >On Sun, Nov 23

Re: [FFmpeg-devel] [PATCH] avformat/apngdec: transmit all the chunks between consecutive fcTL ones.

2014-11-24 Thread James Almer
On 24/11/14 12:12 PM, Benoit Fouet wrote: > In order to support multiple IDAT of fdAT chunks following an fcTL one, > transmit all the chunks between two fcTL ones (or between fcTL and IEND > one). Using one of the samples from https://people.mozilla.org/~dolske/apng/demo.html $ ./ffmpeg -i chomp

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix accurate seeking with -copyts

2014-11-24 Thread Michael Niedermayer
On Sun, Nov 23, 2014 at 11:31:20PM -0600, Rodger Combs wrote: > --- > ffmpeg.h| 1 + > ffmpeg_filter.c | 18 -- > 2 files changed, 17 insertions(+), 2 deletions(-) applied btw, a fate test (especially one which shows the timestamps like with framecrc) for this could be q

Re: [FFmpeg-devel] [PATCH] avformat/rawdec: raw formats have no timestamps

2014-11-24 Thread Michael Niedermayer
On Mon, Nov 24, 2014 at 03:20:53PM +0100, wm4 wrote: > Some raw demuxers already had AVFMT_NOTIMESTAMPS set. Add it for all the > others. > --- > Not sure if this is correct. But I noticed that libavformat does not > return any timestamps for .shn (Shorten) files, and I'd like to use > the AVFMT_NO

Re: [FFmpeg-devel] [PATCH] lavc/avuienc: fix mem leak in case of init failure

2014-11-24 Thread Michael Niedermayer
On Mon, Nov 24, 2014 at 04:52:01AM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavcodec/avuienc.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live des

Re: [FFmpeg-devel] [PATCH] avformat/apngdec: transmit all the chunks between consecutive fcTL ones.

2014-11-24 Thread Benoit Fouet
Hi, Le 24/11/2014 17:54, James Almer a écrit : On 24/11/14 12:12 PM, Benoit Fouet wrote: In order to support multiple IDAT of fdAT chunks following an fcTL one, transmit all the chunks between two fcTL ones (or between fcTL and IEND one). Using one of the samples from https://people.mozilla.or

Re: [FFmpeg-devel] [PATCH] avformat/apngdec: transmit all the chunks between consecutive fcTL ones.

2014-11-24 Thread James Almer
On 24/11/14 4:52 PM, Benoit Fouet wrote: > Hi, > > Le 24/11/2014 17:54, James Almer a écrit : >> On 24/11/14 12:12 PM, Benoit Fouet wrote: >>> In order to support multiple IDAT of fdAT chunks following an fcTL one, >>> transmit all the chunks between two fcTL ones (or between fcTL and IEND >>> one

Re: [FFmpeg-devel] [PATCH] avformat/apngdec: transmit all the chunks between consecutive fcTL ones.

2014-11-24 Thread Michael Niedermayer
On Mon, Nov 24, 2014 at 04:12:26PM +0100, Benoit Fouet wrote: > In order to support multiple IDAT of fdAT chunks following an fcTL one, > transmit all the chunks between two fcTL ones (or between fcTL and IEND > one). > --- > libavformat/apngdec.c | 34 -- > 1 file

Re: [FFmpeg-devel] [PATCH] avformat/apngdec: transmit all the chunks between consecutive fcTL ones.

2014-11-24 Thread Michael Niedermayer
On Mon, Nov 24, 2014 at 09:15:27PM +0100, Michael Niedermayer wrote: > On Mon, Nov 24, 2014 at 04:12:26PM +0100, Benoit Fouet wrote: > > In order to support multiple IDAT of fdAT chunks following an fcTL one, > > transmit all the chunks between two fcTL ones (or between fcTL and IEND > > one). > >

Re: [FFmpeg-devel] [PATCH 1/2] lavc/options: fix leaks in avcodec_free_context

2014-11-24 Thread Michael Niedermayer
On Mon, Nov 24, 2014 at 05:16:49AM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavcodec/options.c | 3 +++ > 1 file changed, 3 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize

Re: [FFmpeg-devel] [PATCH 2/2] lavc/utils: free private options on avcodec_open2 fail

2014-11-24 Thread Michael Niedermayer
On Sun, Nov 23, 2014 at 12:58:07AM +0100, Lukasz Marek wrote: > It protects leaking string/binary/dict options from priv context. > > Signed-off-by: Lukasz Marek > --- > libavcodec/utils.c | 2 ++ > 1 file changed, 2 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147E

Re: [FFmpeg-devel] [PATCH 1/2] lavu/opt: handle NULL obj in av_opt_next

2014-11-24 Thread Michael Niedermayer
On Sun, Nov 23, 2014 at 01:10:21AM +0100, Lukasz Marek wrote: > On 23.11.2014 00:59, Clément Bœsch wrote: > >On Sun, Nov 23, 2014 at 12:58:06AM +0100, Lukasz Marek wrote: > >>It indirectly also fixes av_opt_free for NULL objs. > >> > >>Signed-off-by: Lukasz Marek > >>--- > >> libavutil/opt.c | 2

Re: [FFmpeg-devel] [PATCH] doc/examples/decoding_encoding: fix storing all channels

2014-11-24 Thread Michael Niedermayer
On Fri, Nov 21, 2014 at 02:38:20AM +0100, Michael Niedermayer wrote: > Fixes Ticket3355 > > Signed-off-by: Michael Niedermayer > --- > doc/examples/decoding_encoding.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128

Re: [FFmpeg-devel] [PATCH 1/4] web/style: Only add bottom border when requested to 's in

2014-11-24 Thread Timothy Gu
On Saturday, November 22, 2014, Timothy Gu wrote: > When the is a row heading, the border looks as ugly as heck. > > Add a special case for in as a long heading. > > Signed-off-by: Timothy Gu > > --- > > This does not have any difference in the website right now, but there will > be > in the n

Re: [FFmpeg-devel] [PATCH 1/4] web/style: Only add bottom border when requested to 's in

2014-11-24 Thread Michael Niedermayer
On Sat, Nov 22, 2014 at 10:36:18PM -0800, Timothy Gu wrote: > When the is a row heading, the border looks as ugly as heck. > > Add a special case for in as a long heading. > > Signed-off-by: Timothy Gu > --- > > This does not have any difference in the website right now, but there will be >

Re: [FFmpeg-devel] [PATCH 2/4] web/style: Remove ugly white border around tables on mobile devices

2014-11-24 Thread Michael Niedermayer
On Sat, Nov 22, 2014 at 10:36:19PM -0800, Timothy Gu wrote: > Signed-off-by: Timothy Gu > --- > > See http://imgur.com/qsnnjAi > > --- > src/less/style.less | 4 > 1 file changed, 4 insertions(+) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0F

Re: [FFmpeg-devel] [PATCH 4/4] web/download: Fix indentation

2014-11-24 Thread Michael Niedermayer
On Sat, Nov 22, 2014 at 10:36:21PM -0800, Timothy Gu wrote: > Signed-off-by: Timothy Gu > --- > src/download | 86 > ++-- > 1 file changed, 43 insertions(+), 43 deletions(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B14

Re: [FFmpeg-devel] [PATCH 3/4] web/download: Make "snapshot" and "browse" buttons

2014-11-24 Thread Michael Niedermayer
On Sat, Nov 22, 2014 at 10:36:20PM -0800, Timothy Gu wrote: > Signed-off-by: Timothy Gu > --- > > See end results at http://imgur.com/GtLoaFe,PF2DeNy (both desktop and mobile) > > --- > src/download | 57 ++--- > 1 file changed, 38 insertions(