Re: [FFmpeg-devel] bprint.h can't be included in C++ code

On Fri, 21 Nov 2014 21:42:35 +0100 Nicolas George wrote: > Le primidi 1er frimaire, an CCXXIII, Vadim Kalinsky a écrit : > > bprint.h can't be included in C++ code > > C++ does not support anonymous struct. > > Thanks for the patch. > > Basically, bprint.h is not meant to be included in c++ cod

Re: [FFmpeg-devel] bprint.h can't be included in C++ code

On Fri, 21 Nov 2014 21:42:35 +0100 Nicolas George wrote: > Le primidi 1er frimaire, an CCXXIII, Vadim Kalinsky a écrit : > > bprint.h can't be included in C++ code > > C++ does not support anonymous struct. > > Thanks for the patch. > > Basically, bprint.h is not meant to be included in c++ cod

Re: [FFmpeg-devel] [PATCH 1/2] lavf/apngdec: properly skip currently unsupported in-stream tags

On Sat, Nov 22, 2014 at 08:16:50AM +0100, Benoit Fouet wrote: > Hi, > > On November 21, 2014 11:09:33 PM GMT+01:00, James Almer > wrote: > >Signed-off-by: James Almer > >--- > > libavformat/apngdec.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/libavformat/apngdec.c b/libavforma

Re: [FFmpeg-devel] [PATCH] lavf: fix apngdec under msvc.

On Sat, Nov 22, 2014 at 06:31:25PM +1100, Matt Oliver wrote: > The recently added apngdec code does not compile under msvc. > > See: > http://fate.ffmpeg.org/report.cgi?time=20141122053145&slot=x86_32-msvc12-windows-native > > Attached is a patch to fix it. > apngdec.c |2 +- > 1 file chang

Re: [FFmpeg-devel] [PATCH] h264_mb: Use smaller data type for refs in await_references.

On Sun, Nov 16, 2014 at 09:54:14PM +0100, Michael Niedermayer wrote: > On Sat, Nov 15, 2014 at 07:02:44PM +0100, Reimar Döffinger wrote: > > As far as I can tell the value can never go outside > > the int16_t type. > > And especially the cost of the initialization is > > reduced quite a bit by maki

Re: [FFmpeg-devel] [PATCH] h264_i386: Optimize decode_significance_8x8_x86 for 64 bit.

On Mon, Nov 17, 2014 at 01:41:13PM +0100, Michael Niedermayer wrote: > On Mon, Nov 17, 2014 at 08:19:32AM +0100, Reimar Döffinger wrote: > > On 17.11.2014, at 02:37, Michael Niedermayer wrote: > > > On Sat, Nov 15, 2014 at 06:16:03PM +0100, Reimar Döffinger wrote: > > >> 11674 -> 10877 decicycles

[FFmpeg-devel] [PATCH 1/1] ffv1dec: Avoid unnecessarily large stack usage and copies.

Ideally the compiler could figure this out on its own, but it seems it can't. An alternative that would avoid the messy explicit memcpy would be to use a sub-struct for the parts that should be preserved, which can then simply be assigned. Signed-off-by: Reimar Döffinger --- libavcodec/ffv1dec.c

Re: [FFmpeg-devel] [PATCH] qdm2: Allow hard-coding VLC tables.

On Sun, Sep 07, 2014 at 02:12:34PM +0200, Reimar Döffinger wrote: > Also adds a lot of infrastructure necessary for it. > Some of it is a bit ugly though. > Increases binary size for hardcoded tables by about 12 kB, > which is about 15 kB from qdm2_table minus data and code > saved that was only us

Re: [FFmpeg-devel] [PATCH 1/1] ffv1dec: Avoid unnecessarily large stack usage and copies.

On Sat, Nov 22, 2014 at 02:14:13PM +0100, Reimar Döffinger wrote: > Ideally the compiler could figure this out on its own, > but it seems it can't. > An alternative that would avoid the messy explicit memcpy > would be to use a sub-struct for the parts that should > be preserved, which can then sim

Re: [FFmpeg-devel] [PATCH] ffplay: fix mem leak when opening input or parsing options fail.

On Fri, 21 Nov 2014, Benoit Fouet wrote: --- ffplay.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ffplay.c b/ffplay.c index f79161d..1914a66 100644 --- a/ffplay.c +++ b/ffplay.c @@ -3169,8 +3169,9 @@ static int read_thread(void *arg) stream_component_close(i

Re: [FFmpeg-devel] [PATCH 1/2] lavfi/ebur128: add support for smaller video sizes

On Fri, 21 Nov 2014, Clément Bœsch wrote: (sorry for the delay) On Sun, Nov 16, 2014 at 10:53:15PM +0100, Marton Balint wrote: Signed-off-by: Marton Balint --- doc/filters.texi| 4 ++-- libavfilter/f_ebur128.c | 11 --- 2 files changed, 10 insertions(+), 5 deletions(-) di

Re: [FFmpeg-devel] [PATCH] ffplay: fix mem leak when opening input or parsing options fail.

On Sat, Nov 22, 2014 at 02:58:01PM +0100, Marton Balint wrote: > > > On Fri, 21 Nov 2014, Benoit Fouet wrote: > > >--- > >ffplay.c | 5 +++-- > >1 file changed, 3 insertions(+), 2 deletions(-) > > > >diff --git a/ffplay.c b/ffplay.c > >index f79161d..1914a66 100644 > >--- a/ffplay.c > >+++ b/ffpl

Re: [FFmpeg-devel] [PATCH] qdm2: Allow hard-coding VLC tables.

On Sat, 22 Nov 2014 14:17:09 +0100 Reimar Döffinger wrote: > On Sun, Sep 07, 2014 at 02:12:34PM +0200, Reimar Döffinger wrote: > > Also adds a lot of infrastructure necessary for it. > > Some of it is a bit ugly though. > > Increases binary size for hardcoded tables by about 12 kB, > > which is a

[FFmpeg-devel] [PATCH] lavf/apngdec: print currently unsupported in-stream tags in a more readable form

Also use length and not stream position Signed-off-by: James Almer --- libavformat/apngdec.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c index db501ec..1e0f1c7 100644 --- a/libavformat/apngdec.c +++ b/libavformat/apngdec

Re: [FFmpeg-devel] [PATCH] qdm2: Allow hard-coding VLC tables.

On Sat, 22 Nov 2014 14:17:09 +0100 Reimar Döffinger wrote: > On Sun, Sep 07, 2014 at 02:12:34PM +0200, Reimar Döffinger wrote: > > Also adds a lot of infrastructure necessary for it. > > Some of it is a bit ugly though. > > Increases binary size for hardcoded tables by about 12 kB, > > which is a

Re: [FFmpeg-devel] [PATCH] qdm2: Allow hard-coding VLC tables.

On Sat, Nov 22, 2014 at 11:59:39AM -0500, compn wrote: > On Sat, 22 Nov 2014 14:17:09 +0100 > Reimar Döffinger wrote: > > > On Sun, Sep 07, 2014 at 02:12:34PM +0200, Reimar Döffinger wrote: > > > Also adds a lot of infrastructure necessary for it. > > > Some of it is a bit ugly though. > > > Incr

Re: [FFmpeg-devel] [PATCH 1/1] ffv1dec: Avoid unnecessarily large stack usage and copies.

On Sat, Nov 22, 2014 at 02:42:25PM +0100, Michael Niedermayer wrote: > On Sat, Nov 22, 2014 at 02:14:13PM +0100, Reimar Döffinger wrote: > > Ideally the compiler could figure this out on its own, > > but it seems it can't. > > An alternative that would avoid the messy explicit memcpy > > would be t

[FFmpeg-devel] [PATCH] libavcodec/tiff: Fix static linking of lzma with msvc.

This fixes an error when using static lzma libs with msvc compiler. Without it the lzma.h header defaults to forcing dll (shared) linkage which breaks when using static libs. The fix requires adding a simple define before the header is included that only affects lzma.h on win32 and only with msvc/i

[FFmpeg-devel] [PATCH] svq1enc: reduce stack usage of recursively-called function.

--- libavcodec/svq1enc.c | 2 +- libavcodec/svq1enc.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c index 288da1f..2a0d780 100644 --- a/libavcodec/svq1enc.c +++ b/libavcodec/svq1enc.c @@ -96,7 +96,7 @@ static int encode_block(SVQ1

[FFmpeg-devel] [PATCH] flacenc: calculate lower sum levels in-place.

Should improve cache usage and reduces stack usage. Also reduces number of copies in case many levels have the same number of bits. --- libavcodec/flacenc.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/libavcodec/flacenc.c b/libavcodec/fl

[FFmpeg-devel] [PATCH] v210dec: Fix width calculation

--- libavcodec/v210dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c index ae03952..978dffe 100644 --- a/libavcodec/v210dec.c +++ b/libavcodec/v210dec.c @@ -117,7 +117,7 @@ static int decode_frame(AVCodecContext *avctx, void *data

Re: [FFmpeg-devel] Dshow Crossbar support

On Wed, Nov 19, 2014 at 3:03 PM, Zach Swena wrote: > Hi, > > Can anyone elaborate on why direct show devices that use crossbar are not > supported by FFmpeg? Also, what is keeping someone from taking the > crossbar support found in VLC and porting it to FFmpeg, assuming the said > port complied

Re: [FFmpeg-devel] [PATCH] v210dec: Fix width calculation

On Sat, Nov 22, 2014 at 07:11:57PM +, Kieran Kunhya wrote: > --- > libavcodec/v210dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c > index ae03952..978dffe 100644 > --- a/libavcodec/v210dec.c > +++ b/libavcodec/v210dec.

Re: [FFmpeg-devel] [PATCH] v210dec: Fix width calculation

On 22 November 2014 at 19:32, Reimar Döffinger wrote: > On Sat, Nov 22, 2014 at 07:11:57PM +, Kieran Kunhya wrote: >> --- >> libavcodec/v210dec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c >> index ae03952..978dffe 1

[FFmpeg-devel] [PATCH] lpc: Remove stack usage by allocating LLSModel in context.

Signed-off-by: Reimar Döffinger --- libavcodec/lpc.c | 2 +- libavcodec/lpc.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c index f54f6f8..deb02e7 100644 --- a/libavcodec/lpc.c +++ b/libavcodec/lpc.c @@ -208,7 +208,7 @@ int ff_lpc_calc

Re: [FFmpeg-devel] [PATCH] lpc: Remove stack usage by allocating LLSModel in context.

On Sat, Nov 22, 2014 at 08:49:45PM +0100, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger Was of course meant to be "reduce stack usage" in subject, fixed locally. I thought about adding a alloc function for LLSModel while at it, but the code changes would have needed to be a bit larger

Re: [FFmpeg-devel] Modified force_key_frames option to accept frame numbers

I am sorry for the spam, but as I have not published any changes to ffmpeg before, I thought I should double-check. Nicolas, you replied earlier that you would not oppose the feature described below. Does that mean I can go ahead and submit my change? Can I consider my change reviewed or am I su

[FFmpeg-devel] [PATCH] v210enc: Add x86 SIMD

--- libavcodec/v210enc.c| 78 ++--- libavcodec/v210enc.h| 31 libavcodec/x86/Makefile | 2 ++ 3 files changed, 88 insertions(+), 23 deletions(-) create mode 100644 libavcodec/v210enc.h diff --git a/libavcodec/v210enc.c b/l

[FFmpeg-devel] [PATCH] v210enc: Add x86 SIMD

--- libavcodec/v210enc.c | 78 ++- libavcodec/v210enc.h | 31 + libavcodec/x86/Makefile | 2 ++ libavcodec/x86/v210enc.asm| 76 + libavcodec/x86/v210enc_init.c | 31

Re: [FFmpeg-devel] [PATCH] v210enc: Add x86 SIMD

Kieran Kunhya obe.tv> writes: > --- a/libavcodec/x86/Makefile > +++ b/libavcodec/x86/Makefile > -47,6 +47,7 >x86/rv40dsp_init.o > OBJS-$(CONFIG_SVQ1_ENCODER)+= x86/svq1enc.o > OBJS-$(CONFIG_TRUEHD_DECODER) += x86/mlpdsp.

[FFmpeg-devel] [PATCH] lavc/anm: fix mem leak in case of init failure

Signed-off-by: Lukasz Marek --- libavcodec/anm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/anm.c b/libavcodec/anm.c index 79a87dd..3727534 100644 --- a/libavcodec/anm.c +++ b/libavcodec/anm.c @@ -47,8 +47,10 @@ static av_cold int decode_init(AVCodecContext

[FFmpeg-devel] [PATCH 1/2] lavc/libvorbisdec: fix mem leak in case of init failure

Signed-off-by: Lukasz Marek --- libavcodec/libvorbisdec.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/libavcodec/libvorbisdec.c b/libavcodec/libvorbisdec.c index b703b65..f2c5046 100644 --- a/libavcodec/libvorbisdec.c +++ b/libavcodec/libvorbisdec.c

[FFmpeg-devel] [PATCH] lavc/smacker: fix mem leak in case of init failure

Signed-off-by: Lukasz Marek --- libavcodec/smacker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c index 518bdad..b5538c7 100644 --- a/libavcodec/smacker.c +++ b/libavcodec/smacker.c @@ -589,6 +589,7 @@ static av_cold int decode_init(AVCodecContex

[FFmpeg-devel] [PATCH 2/2] lavc/libvorbisdec: use better error codes

Signed-off-by: Lukasz Marek --- libavcodec/libvorbisdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/libvorbisdec.c b/libavcodec/libvorbisdec.c index f2c5046..db00572 100644 --- a/libavcodec/libvorbisdec.c +++ b/libavcodec/libvorbisdec.c @@ -40,7 +40,7

[FFmpeg-devel] [PATCH] lavc/mss1: fix mem leak in case of init failure

Signed-off-by: Lukasz Marek --- libavcodec/mss1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/mss1.c b/libavcodec/mss1.c index 6bb524b..2eb67df 100644 --- a/libavcodec/mss1.c +++ b/libavcodec/mss1.c @@ -197,6 +197,8 @@ static av_cold int mss1_decode_init(AVCodecContext *avctx

Re: [FFmpeg-devel] [libav-devel] [PATCH] v210enc: Add x86 SIMD

On 22/11/14 5:58 PM, Kieran Kunhya wrote: > diff --git a/libavcodec/v210enc.h b/libavcodec/v210enc.h > new file mode 100644 > index 000..b8b6143 > --- /dev/null > +++ b/libavcodec/v210enc.h > @@ -0,0 +1,31 @@ > +/* > + * This file is part of Libav. It shouldn't take long to make a patch that c

[FFmpeg-devel] [PATCH]Print a warning if vp6 is muxed into flv

Hi! FFmpeg should print a warning when the non-flipped version of vp6 is muxed into flv: The feature was requested and is used. Related to ticket #4132. Please comment, Carl Eugen diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index a8cd994..5468c4d 100644 --- a/libavformat/flvenc.c ++

[FFmpeg-devel] [PATCH] libavcodec/rv30: fix mem leak in case of init failure

Also replaced return -1 with return AVERROR(EINVAL) Signed-off-by: Lukasz Marek --- libavcodec/rv30.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/rv30.c b/libavcodec/rv30.c index fd8fd4f..1483107 100644 --- a/libavcodec/rv30.c +++ b/libavcodec/rv30.c @@

[FFmpeg-devel] [PATCH] xface: Fix encoder crashes due to too small on-stack array.

Also add a FATE test. Signed-off-by: Reimar Döffinger --- libavcodec/xface.h | 9 + libavcodec/xfaceenc.c | 3 +++ libavformat/nut.c | 1 + tests/fate/vcodec.mak | 5 + tests/ref/vsynth/vsynth1-xface | 4 tests/ref/vsynth/vsynth2-xface

Re: [FFmpeg-devel] [PATCH] libavcodec/tiff: Fix static linking of lzma with msvc.

On Sun, Nov 23, 2014 at 05:25:25AM +1100, Matt Oliver wrote: > This fixes an error when using static lzma libs with msvc compiler. Without > it the lzma.h header defaults to forcing dll (shared) linkage which breaks > when using static libs. The fix requires adding a simple define before the > head

[FFmpeg-devel] [PATCH] lavc/smvjpegdec: fix mem leak in case of init failure

Signed-off-by: Lukasz Marek --- libavcodec/smvjpegdec.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/smvjpegdec.c b/libavcodec/smvjpegdec.c index 69327cd..261a441 100644 --- a/libavcodec/smvjpegdec.c +++ b/libavcodec/smvjpegdec.c @@ -89,8 +89,10 @@ static

Re: [FFmpeg-devel] [PATCH] lpc: Remove stack usage by allocating LLSModel in context.

On Sat, Nov 22, 2014 at 08:49:45PM +0100, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/lpc.c | 2 +- > libavcodec/lpc.h | 4 > 2 files changed, 5 insertions(+), 1 deletion(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0

[FFmpeg-devel] [PATCH 1/2] xface: reduce table sizes.

Signed-off-by: Reimar Döffinger --- libavcodec/xface.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/xface.h b/libavcodec/xface.h index 6fbe908..63df5d3 100644 --- a/libavcodec/xface.h +++ b/libavcodec/xface.h @@ -85,8 +85,8 @@ enum XFaceColor { XFACE_COLOR_BL

[FFmpeg-devel] [PATCH 2/2] xface: reduce stack usage by directly storing 2 bytes data instead of pointers.

Signed-off-by: Reimar Döffinger --- libavcodec/xfaceenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/xfaceenc.c b/libavcodec/xfaceenc.c index 0ade302..7edef1e 100644 --- a/libavcodec/xfaceenc.c +++ b/libavcodec/xfaceenc.c @@ -74,7 +74,7 @@ static int al

Re: [FFmpeg-devel] [PATCH] lavc/anm: fix mem leak in case of init failure

On Sat, Nov 22, 2014 at 10:46:02PM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavcodec/anm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need l

[FFmpeg-devel] [PATCH] lavfi: add tdiff filter

TODO: bump minor --- Changelog| 1 + doc/filters.texi | 4 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_tdiff.c | 131 +++ 5 files changed, 138 insertions(+) create mode 100644 libav

Re: [FFmpeg-devel] [PATCH] lavc/smacker: fix mem leak in case of init failure

On Sat, Nov 22, 2014 at 10:46:24PM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavcodec/smacker.c | 1 + > 1 file changed, 1 insertion(+) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who f

Re: [FFmpeg-devel] [PATCH 1/2] lavc/libvorbisdec: fix mem leak in case of init failure

On Sat, Nov 22, 2014 at 10:46:40PM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavcodec/libvorbisdec.c | 22 +++--- > 1 file changed, 15 insertions(+), 7 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB C

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libvorbisdec: use better error codes

On Sat, Nov 22, 2014 at 10:46:41PM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavcodec/libvorbisdec.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dic

Re: [FFmpeg-devel] [PATCH 1/2] xface: reduce table sizes.

On date Saturday 2014-11-22 23:31:58 +0100, Reimar Döffinger encoded: > Signed-off-by: Reimar Döffinger > --- > libavcodec/xface.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/xface.h b/libavcodec/xface.h > index 6fbe908..63df5d3 100644 > --- a/libavcod

Re: [FFmpeg-devel] [PATCH 2/2] xface: reduce stack usage by directly storing 2 bytes data instead of pointers.

On date Saturday 2014-11-22 23:31:59 +0100, Reimar Döffinger encoded: > Signed-off-by: Reimar Döffinger > --- > libavcodec/xfaceenc.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/xfaceenc.c b/libavcodec/xfaceenc.c > index 0ade302..7edef1e 100644 > -

Re: [FFmpeg-devel] [PATCH] lavc/mss1: fix mem leak in case of init failure

On Sat, Nov 22, 2014 at 10:57:05PM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavcodec/mss1.c | 2 ++ > 1 file changed, 2 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have often repented speaking, but never

[FFmpeg-devel] [PATCH 01/10] avfilter/signalstats: fix different buffers for out frame if burn is enabled

This was the original intend. --- libavfilter/vf_signalstats.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c index 47545aa..8c6a2d6 100644 --- a/libavfilter/vf_signalstats.c +++ b/libavfilter/vf_signalstats.c @@ -

[FFmpeg-devel] [PATCH 02/10] avfilter/signalstats: remove pointless sub filter init system

--- libavfilter/vf_signalstats.c | 57 1 file changed, 15 insertions(+), 42 deletions(-) diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c index 8c6a2d6..b5b45b8 100644 --- a/libavfilter/vf_signalstats.c +++ b/libavfilter/vf_sign

[FFmpeg-devel] [PATCH 03/10] avfilter/signalstats: integrate height loop into subfilters

--- libavfilter/vf_signalstats.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c index b5b45b8..e0ee3ee 100644 --- a/libavfilter/vf_signalstats.c +++ b/libavfilter/vf_signalst

[FFmpeg-devel] [PATCH 06/10] avfilter/signalstats: add slice threading for subfilters

--- libavfilter/vf_signalstats.c | 72 1 file changed, 60 insertions(+), 12 deletions(-) diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c index 5983e61..960e98a 100644 --- a/libavfilter/vf_signalstats.c +++ b/libavfilter/vf_sign

[FFmpeg-devel] [PATCH 04/10] avfilter/signalstats: reindent after previous commit

--- libavfilter/vf_signalstats.c | 106 +-- 1 file changed, 53 insertions(+), 53 deletions(-) diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c index e0ee3ee..d6d9c3e 100644 --- a/libavfilter/vf_signalstats.c +++ b/libavfilter/vf_sign

[FFmpeg-devel] [PATCH 07/10] avfilter/signalstats: isolate sat hue computation metrics in a function

This will be useful for the following commit --- libavfilter/vf_signalstats.c | 77 1 file changed, 70 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c index 960e98a..0403a6d 100644 --- a/libavfilte

[FFmpeg-devel] [PATCH 08/10] avfilter/signalstats: add threading in compute_sat_hue_metrics

--- libavfilter/vf_signalstats.c | 37 - 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c index 0403a6d..014b87d 100644 --- a/libavfilter/vf_signalstats.c +++ b/libavfilter/vf_signalstats.

[FFmpeg-devel] [PATCH 05/10] avfilter/signalstats: fix repitition/repetition typo

--- libavfilter/vf_signalstats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c index d6d9c3e..5983e61 100644 --- a/libavfilter/vf_signalstats.c +++ b/libavfilter/vf_signalstats.c @@ -53,11 +53,11 @@ typedef struc

[FFmpeg-devel] [PATCH 09/10] avfilter/signalstats: localize a few variables

--- libavfilter/vf_signalstats.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c index 014b87d..3ef689f 100644 --- a/libavfilter/vf_signalstats.c +++ b/libavfilter/vf_signalstats.c @@ -360,7 +360,6 @@ static int

[FFmpeg-devel] [PATCH 10/10] avfilter/signalstats: re-use yuv/yuvu/yuvv vars in diff

--- libavfilter/vf_signalstats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c index 3ef689f..4b2792f 100644 --- a/libavfilter/vf_signalstats.c +++ b/libavfilter/vf_signalstats.c @@ -413,7 +413,7 @@ static int

Re: [FFmpeg-devel] [PATCH] xface: Fix encoder crashes due to too small on-stack array.

On date Saturday 2014-11-22 23:14:45 +0100, Reimar Döffinger encoded: > Also add a FATE test. > > Signed-off-by: Reimar Döffinger > --- > libavcodec/xface.h | 9 + > libavcodec/xfaceenc.c | 3 +++ > libavformat/nut.c | 1 + > tests/fate/vcodec.mak

Re: [FFmpeg-devel] [PATCH] libavcodec/rv30: fix mem leak in case of init failure

On Sat, Nov 22, 2014 at 11:12:53PM +0100, Lukasz Marek wrote: > Also replaced return -1 with return AVERROR(EINVAL) > > Signed-off-by: Lukasz Marek > --- > libavcodec/rv30.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF21

[FFmpeg-devel] [PATCH 1/2] lavu/opt: handle NULL obj in av_opt_next

It indirectly also fixes av_opt_free for NULL objs. Signed-off-by: Lukasz Marek --- libavutil/opt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/opt.c b/libavutil/opt.c index 47b1f0c..85330c9 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -50,6 +50,8 @@ const AVOption *

[FFmpeg-devel] [PATCH] lavu/opt: add const to av_opt_copy arg

Signed-off-by: Lukasz Marek --- libavutil/opt.c | 2 +- libavutil/opt.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 0546a37..47b1f0c 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -1570,7 +1570,7 @@ static int opt_size(enum

[FFmpeg-devel] [PATCH] lavc/huffyuvdec: fix mem leak in case of init failure

Signed-off-by: Lukasz Marek --- libavcodec/huffyuvdec.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c index 3b2b0f7..5535323 100644 --- a/libavcodec/huffyuvdec.c +++ b/libavcodec/huffyuvdec.c @@ -275

[FFmpeg-devel] [PATCH 2/2] lavc/utils: free private options on avcodec_open2 fail

It protects leaking string/binary/dict options from priv context. Signed-off-by: Lukasz Marek --- libavcodec/utils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index bf2a5b9..7e37b82 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -1

Re: [FFmpeg-devel] [PATCH 1/2] lavu/opt: handle NULL obj in av_opt_next

On Sun, Nov 23, 2014 at 12:58:06AM +0100, Lukasz Marek wrote: > It indirectly also fixes av_opt_free for NULL objs. > > Signed-off-by: Lukasz Marek > --- > libavutil/opt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index 47b1f0c..85330c9 10064

Re: [FFmpeg-devel] [PATCH] lavu/opt: add const to av_opt_copy arg

On 23.11.2014 00:58, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavutil/opt.c | 2 +- libavutil/opt.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 0546a37..47b1f0c 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c

Re: [FFmpeg-devel] [PATCH] lavfi: add tdiff filter

On Sat, Nov 22, 2014 at 11:44:29PM +0100, Stefano Sabatini wrote: > TODO: bump minor > --- > Changelog| 1 + > doc/filters.texi | 4 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_tdiff.c | 131 > ++

Re: [FFmpeg-devel] [PATCH 1/2] lavu/opt: handle NULL obj in av_opt_next

On 23.11.2014 00:59, Clément Bœsch wrote: On Sun, Nov 23, 2014 at 12:58:06AM +0100, Lukasz Marek wrote: It indirectly also fixes av_opt_free for NULL objs. Signed-off-by: Lukasz Marek --- libavutil/opt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/opt.c b/libavutil/opt.c

Re: [FFmpeg-devel] [PATCH] lavfi: add tdiff filter

On Sat, Nov 22, 2014 at 11:44:29PM +0100, Stefano Sabatini wrote: > TODO: bump minor > --- > Changelog| 1 + > doc/filters.texi | 4 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_tdiff.c | 131 > ++

[FFmpeg-devel] [PATCH] v210enc: Add x86 SIMD

From: Kieran Kunhya Signed-off-by: Michael Niedermayer --- libavcodec/v210enc.c | 78 + libavcodec/v210enc.h | 31 libavcodec/x86/Makefile |2 ++ libavcodec/x86/v210enc.asm| 75 +++

Re: [FFmpeg-devel] [libav-devel] [PATCH] v210enc: Add x86 SIMD

On Sat, Nov 22, 2014 at 07:10:04PM -0300, James Almer wrote: > On 22/11/14 5:58 PM, Kieran Kunhya wrote: > > diff --git a/libavcodec/v210enc.h b/libavcodec/v210enc.h > > new file mode 100644 > > index 000..b8b6143 > > --- /dev/null > > +++ b/libavcodec/v210enc.h > > @@ -0,0 +1,31 @@ > > +/* > >

Re: [FFmpeg-devel] [PATCH] lavu/opt: add const to av_opt_copy arg

On Sun, Nov 23, 2014 at 01:01:19AM +0100, Lukasz Marek wrote: > On 23.11.2014 00:58, Lukasz Marek wrote: > >Signed-off-by: Lukasz Marek > >--- > > libavutil/opt.c | 2 +- > > libavutil/opt.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/libavutil/opt.c b/libavut

Re: [FFmpeg-devel] [PATCH] lavc/anm: fix mem leak in case of init failure

On 22.11.2014 23:38, Michael Niedermayer wrote: On Sat, Nov 22, 2014 at 10:46:02PM +0100, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavcodec/anm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) LGTM pushed ___ ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] lavc/smacker: fix mem leak in case of init failure

On 22.11.2014 23:44, Michael Niedermayer wrote: On Sat, Nov 22, 2014 at 10:46:24PM +0100, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavcodec/smacker.c | 1 + 1 file changed, 1 insertion(+) LGTM pushed ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libvorbisdec: use better error codes

On 23.11.2014 00:02, Michael Niedermayer wrote: On Sat, Nov 22, 2014 at 10:46:41PM +0100, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavcodec/libvorbisdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) LGTM pushed both

Re: [FFmpeg-devel] [PATCH]Print a warning if vp6 is muxed into flv

On Sat, Nov 22, 2014 at 11:10:20PM +0100, Carl Eugen Hoyos wrote: > Hi! > > FFmpeg should print a warning when the non-flipped version of vp6 is muxed > into flv: The feature was requested and is used. > Related to ticket #4132. > > Please comment, Carl Eugen > flvenc.c |3 +++ > 1 file ch

Re: [FFmpeg-devel] [PATCH] svq1enc: reduce stack usage of recursively-called function.

On Sat, Nov 22, 2014 at 07:50:59PM +0100, Reimar Döffinger wrote: > --- > libavcodec/svq1enc.c | 2 +- > libavcodec/svq1enc.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness th

Re: [FFmpeg-devel] [PATCH] xface: Fix encoder crashes due to too small on-stack array.

On Sat, Nov 22, 2014 at 11:14:45PM +0100, Reimar Döffinger wrote: > Also add a FATE test. > > Signed-off-by: Reimar Döffinger > --- > libavcodec/xface.h | 9 + > libavcodec/xfaceenc.c | 3 +++ > libavformat/nut.c | 1 + I forgot this part: > const AVCo

Re: [FFmpeg-devel] [PATCH 1/2] xface: reduce table sizes.

On Sun, Nov 23, 2014 at 12:20:00AM +0100, Stefano Sabatini wrote: > On date Saturday 2014-11-22 23:31:58 +0100, Reimar Döffinger encoded: > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/xface.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavcod

Re: [FFmpeg-devel] [PATCH] lpc: Remove stack usage by allocating LLSModel in context.

On Sat, Nov 22, 2014 at 11:26:56PM +0100, Michael Niedermayer wrote: > On Sat, Nov 22, 2014 at 08:49:45PM +0100, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/lpc.c | 2 +- > > libavcodec/lpc.h | 4 > > 2 files changed, 5 insertions(+), 1 deletion(-) > >

Re: [FFmpeg-devel] [PATCH] svq1enc: reduce stack usage of recursively-called function.

On Sun, Nov 23, 2014 at 03:57:47AM +0100, Michael Niedermayer wrote: > On Sat, Nov 22, 2014 at 07:50:59PM +0100, Reimar Döffinger wrote: > > --- > > libavcodec/svq1enc.c | 2 +- > > libavcodec/svq1enc.h | 2 ++ > > 2 files changed, 3 insertions(+), 1 deletion(-) > > LGTM Pushed, thanks.

[FFmpeg-devel] [PATCH 1/4] web/style: Only add bottom border when requested to 's in

When the is a row heading, the border looks as ugly as heck. Add a special case for in as a long heading. Signed-off-by: Timothy Gu --- This does not have any difference in the website right now, but there will be in the new fateserver. --- src/download| 2 +- src/less/style.less

[FFmpeg-devel] [PATCH 2/4] web/style: Remove ugly white border around tables on mobile devices

Signed-off-by: Timothy Gu --- See http://imgur.com/qsnnjAi --- src/less/style.less | 4 1 file changed, 4 insertions(+) diff --git a/src/less/style.less b/src/less/style.less index 83212a4..378a972 100644 --- a/src/less/style.less +++ b/src/less/style.less @@ -327,6 +327,10 @@ code { }

[FFmpeg-devel] [PATCH 3/4] web/download: Make "snapshot" and "browse" buttons

Signed-off-by: Timothy Gu --- See end results at http://imgur.com/GtLoaFe,PF2DeNy (both desktop and mobile) --- src/download | 57 ++--- 1 file changed, 38 insertions(+), 19 deletions(-) diff --git a/src/download b/src/download index d4b433b.

[FFmpeg-devel] [PATCH 4/4] web/download: Fix indentation

Signed-off-by: Timothy Gu --- src/download | 86 ++-- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/src/download b/src/download index 4af35a5..f3f9ce3 100644 --- a/src/download +++ b/src/download @@ -207,52 +207,52 @@