[FFmpeg-devel] [PATCH] avformat/mov: E-AC-3 streams need parsing too.

2014-10-09 Thread Benoit Fouet
syncframes in E-AC-3 can be combined to provide 6 audio blocks per sample, thus requiring parsing for proper decoding. --- libavformat/mov.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index fdd0671..40c2fc4 100644 --- a/libavformat/mov.c +++ b/libavfo

[FFmpeg-devel] [PATCH] avformat/movenc: add support for syncframes concatenation for E-AC-3.

2014-10-09 Thread Benoit Fouet
E-AC-3 samples should contain 6 audio blocks, so concatenate syncframes in order to achieve this. --- libavformat/movenc.c | 41 +++-- 1 file changed, 35 insertions(+), 6 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 18c5955..4f4f1

Re: [FFmpeg-devel] [PATCH] vp9:enable multi-thread decoding when refreshctx is equal to 0

2014-10-09 Thread Di Wu
<<< image/gif; name="201410091817425_Z5JE7EUA.gif": Unrecognized >>> 0001-vp9-enable-multi-thread-decoding-when-refreshctx-is-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH] ismindex: handle discontinuous streams better

2014-10-09 Thread Michael Niedermayer
On Wed, Oct 08, 2014 at 09:39:26AM +0300, Mika Raento wrote: > Reads the fragment duration from the trun sample data, rather than > assuming that there are no gaps. Creates much better playlists for our > inputs. > --- > tools/ismindex.c | 95 > ++--

Re: [FFmpeg-devel] [PATCH 1/2] compat/w32pthreads: use the CONDITION_VARIABLE typedef if available

2014-10-09 Thread Matt Oliver
> > > Only tested with Mingw-w64 v3. > Can someone test MSVC or ICL? I know the former defines the struct, so the > configure check should succeed on that one at least. > Works fine on both MSVC and ICL (ICL uses the same headers as MSVC so not normally an issue - I tested anyway though).

Re: [FFmpeg-devel] [PATCH 1/2] compat/w32pthreads: use the CONDITION_VARIABLE typedef if available

2014-10-09 Thread Michael Niedermayer
On Wed, Oct 08, 2014 at 10:51:54PM -0300, James Almer wrote: > This silences warnings about passing arguments from incompatible pointer type > when targeting Windows Vista or newer. > > Signed-off-by: James Almer > --- > Only tested with Mingw-w64 v3. > Can someone test MSVC or ICL? I know the fo

Re: [FFmpeg-devel] [PATCH 2/2] compat/w32pthreads: use the condition variable API directly when targeting newer versions of Windows

2014-10-09 Thread Michael Niedermayer
On Wed, Oct 08, 2014 at 10:51:55PM -0300, James Almer wrote: > Wrap the function calls in a similar fashion to how it's being done > with the critical section API. > > Signed-off-by: James Almer > --- > compat/w32pthreads.h | 64 > +++- > 1 file c

Re: [FFmpeg-devel] [PATCH v2] lavf: fix 2GB file seek limit on Android

2014-10-09 Thread Michael Niedermayer
On Thu, Oct 09, 2014 at 10:49:43AM +0800, Yu Xiaolei wrote: > > --- > libavformat/os_support.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavformat/os_support.h b/libavformat/os_support.h > index 1522740..0b9fd49 100644 > --- a/libavformat/os_support.h > +++ b/libavformat/

Re: [FFmpeg-devel] [PATCH 02/14] libavcodec: Implementation of AAC_fixed_decoder (LC-module) [2/5]

2014-10-09 Thread Nedeljko Babic
> >softfloat uses "if (a.mant + 0x4000 < 0)" to normalize >0x4000U + 0x4000U is < 0 for int32 and thus not part of the >range though -1 would be, is that a problem ? >we could use a.mant + 0x4000 <= 0 in that case > >the main difference i see to aac is that it shifts up if its too s

Re: [FFmpeg-devel] [PATCH] avformat/mov: E-AC-3 streams need parsing too.

2014-10-09 Thread Michael Niedermayer
On Thu, Oct 09, 2014 at 09:17:49AM +0200, Benoit Fouet wrote: > syncframes in E-AC-3 can be combined to provide 6 audio blocks per > sample, thus requiring parsing for proper decoding. > --- > libavformat/mov.c | 1 + > 1 file changed, 1 insertion(+) applied thanks [...] -- Michael GnuPG f

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-09 Thread Mika Raento
fate passes with these changes, no new tests added. - mika On 9 October 2014 08:53, Mika Raento wrote: > If present, an MFRA box and its TFRAs are read for fragment start times. > > Without this change, timestamps for discontinuous fragmented mp4 are > wrong, and cause audio/video desync and are

Re: [FFmpeg-devel] [PATCH 02/14] libavcodec: Implementation of AAC_fixed_decoder (LC-module) [2/5]

2014-10-09 Thread Michael Niedermayer
On Thu, Oct 09, 2014 at 12:02:26PM +, Nedeljko Babic wrote: > > > >softfloat uses "if (a.mant + 0x4000 < 0)" to normalize > >0x4000U + 0x4000U is < 0 for int32 and thus not part of the > >range though -1 would be, is that a problem ? > >we could use a.mant + 0x4000 <= 0 in that

[FFmpeg-devel] [PATCH] Fix writing first audio Cues in dash mode.

2014-10-09 Thread Frank Galligan
In dahsmode Matroska is not writing the first Cluster for every audio stream in the Cues element. Signed-off-by: Frank Galligan --- libavformat/matroskaenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 4af2d6e.

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-09 Thread Michael Niedermayer
On Thu, Oct 09, 2014 at 08:52:29AM +0300, Mika Raento wrote: > On 8 October 2014 16:03, Michael Niedermayer wrote: [...] > >> +if (avio_rb32(f) != mfra_size) { > >> +av_log(s, AV_LOG_DEBUG, "doesn't look like mfra (size)\n"); > >> +return -1; > >> +} > >> +if (avio_rb32

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-09 Thread Mika Raento
On 9 October 2014 18:30, Michael Niedermayer wrote: > On Thu, Oct 09, 2014 at 08:52:29AM +0300, Mika Raento wrote: >> On 8 October 2014 16:03, Michael Niedermayer wrote: > [...] >> >> +if (avio_rb32(f) != mfra_size) { >> >> +av_log(s, AV_LOG_DEBUG, "doesn't look like mfra (size)\n");

[FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-09 Thread Mika Raento
If present, an MFRA box and its TFRAs are read for fragment start times. Without this change, timestamps for discontinuous fragmented mp4 are wrong, and cause audio/video desync and are not usable for generating HLS. --- libavformat/isom.h | 15 ++ libavformat/mov.c | 140 ++

Re: [FFmpeg-devel] [PATCH] Fix writing first audio Cues in dash mode.

2014-10-09 Thread Vignesh Venkatasubramanian
On Thu, Oct 9, 2014 at 8:28 AM, Frank Galligan wrote: > In dahsmode Matroska is not writing the first Cluster for every > audio stream in the Cues element. > > Signed-off-by: Frank Galligan > --- > libavformat/matroskaenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/2] compat/w32pthreads: use the CONDITION_VARIABLE typedef if available

2014-10-09 Thread James Almer
On 09/10/14 7:41 AM, Matt Oliver wrote: >> >> >> Only tested with Mingw-w64 v3. >> Can someone test MSVC or ICL? I know the former defines the struct, so the >> configure check should succeed on that one at least. >> > > Works fine on both MSVC and ICL (ICL uses the same headers as MSVC so not > n

[FFmpeg-devel] [PATCH 2/2] compat/w32pthreads: use the condition variable API directly when targeting newer versions of Windows

2014-10-09 Thread James Almer
Wrap the function calls in a similar fashion to how it's being done with the critical section API. Signed-off-by: James Almer --- The redefinition of InitializeCriticalSection and WaitForSingleObject is not removed now, as it's still needed by other functions. Sorry for missing it earlier. com

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-09 Thread Michael Niedermayer
On Thu, Oct 09, 2014 at 06:57:59PM +0300, Mika Raento wrote: > If present, an MFRA box and its TFRAs are read for fragment start times. > > Without this change, timestamps for discontinuous fragmented mp4 are > wrong, and cause audio/video desync and are not usable for generating > HLS. > --- > l

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-09 Thread Michael Niedermayer
On Thu, Oct 09, 2014 at 09:44:43PM +0200, Michael Niedermayer wrote: > On Thu, Oct 09, 2014 at 06:57:59PM +0300, Mika Raento wrote: > > If present, an MFRA box and its TFRAs are read for fragment start times. > > > > Without this change, timestamps for discontinuous fragmented mp4 are > > wrong, a

Re: [FFmpeg-devel] [PATCH] Fix writing first audio Cues in dash mode.

2014-10-09 Thread Michael Niedermayer
On Thu, Oct 09, 2014 at 09:03:29AM -0700, Vignesh Venkatasubramanian wrote: > On Thu, Oct 9, 2014 at 8:28 AM, Frank Galligan > wrote: > > In dahsmode Matroska is not writing the first Cluster for every > > audio stream in the Cues element. > > > > Signed-off-by: Frank Galligan > > --- > > libav

Re: [FFmpeg-devel] [PATCH 2/2] compat/w32pthreads: use the condition variable API directly when targeting newer versions of Windows

2014-10-09 Thread Michael Niedermayer
On Thu, Oct 09, 2014 at 01:52:08PM -0300, James Almer wrote: > Wrap the function calls in a similar fashion to how it's being done > with the critical section API. > > Signed-off-by: James Almer > --- > The redefinition of InitializeCriticalSection and WaitForSingleObject is not > removed now, a

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-09 Thread Yusuke Nakamura
2014-10-10 4:49 GMT+09:00 Michael Niedermayer : > On Thu, Oct 09, 2014 at 09:44:43PM +0200, Michael Niedermayer wrote: > > On Thu, Oct 09, 2014 at 06:57:59PM +0300, Mika Raento wrote: > > > If present, an MFRA box and its TFRAs are read for fragment start > times. > > > > > > Without this change,

Re: [FFmpeg-devel] [PATCH 2/2] compat/w32pthreads: use the condition variable API directly when targeting newer versions of Windows

2014-10-09 Thread James Almer
On 09/10/14 5:34 PM, Michael Niedermayer wrote: > On Thu, Oct 09, 2014 at 01:52:08PM -0300, James Almer wrote: >> Wrap the function calls in a similar fashion to how it's being done >> with the critical section API. >> >> Signed-off-by: James Almer >> --- >> The redefinition of InitializeCriticalS

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: add -seek_error option

2014-10-09 Thread Michael Niedermayer
On Wed, Oct 08, 2014 at 07:13:33PM +0200, Simon Thelen wrote: > Enabling -seek_error causes ffmpeg to quit when it notices that > stop_time <= start_time. is there a reason not to stop and continue ? iam asking as if not then this could be done unconditionally [...] -- Michael GnuPG fingerpr

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: add -seek_error option

2014-10-09 Thread Simon Thelen
On 09/10/14 at 23:05, Michael Niedermayer wrote: > On Wed, Oct 08, 2014 at 07:13:33PM +0200, Simon Thelen wrote: > > Enabling -seek_error causes ffmpeg to quit when it notices that > > stop_time <= start_time. > > is there a reason not to stop and continue ? > iam asking as if not then this could

Re: [FFmpeg-devel] [PATCH] ffplay: dont leave swresampler in half initialized state

2014-10-09 Thread Marton Balint
On Thu, 9 Oct 2014, Michael Niedermayer wrote: On Wed, Oct 08, 2014 at 11:48:58PM +0200, Marton Balint wrote: On init failure, let's just free it, so next time it will be recreated from start. Also fixes Coverity CID 1241515. Signed-off-by: Marton Balint --- ffplay.c | 4 +++- 1 file chang

[FFmpeg-devel] [PATCH] utvideoenc: properly set slice height/last line

2014-10-09 Thread Christophe Gisquet
Fixes ticket #3949. -- Christophe From 9bcaac9495d41b633010873d50ea0b7e01d9a9a4 Mon Sep 17 00:00:00 2001 From: Christophe Gisquet Date: Thu, 9 Oct 2014 23:27:38 +0200 Subject: [PATCH] utvideoenc: properly set slice height/last line Mimic decoder and obey sampling. Does not affect fate tests fo

Re: [FFmpeg-devel] [PATCH] avformat/movenc: add EAC3 muxing support.

2014-10-09 Thread Michael Niedermayer
On Tue, Oct 07, 2014 at 03:02:38PM +0200, Benoit Fouet wrote: > Support only one independent substream right now, and only syncframes > containing 6 blocks. > > Fixes part of ticket #3074 > --- > > Right now, this produces the same output as the previous patch for supported > streams, and rejects

Re: [FFmpeg-devel] [PATCH] ffplay: dont leave swresampler in half initialized state

2014-10-09 Thread Michael Niedermayer
On Thu, Oct 09, 2014 at 11:26:52PM +0200, Marton Balint wrote: > > On Thu, 9 Oct 2014, Michael Niedermayer wrote: > > >On Wed, Oct 08, 2014 at 11:48:58PM +0200, Marton Balint wrote: > >>On init failure, let's just free it, so next time it will be recreated from > >>start. > >> > >>Also fixes Cove

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: add -seek_error option

2014-10-09 Thread Michael Niedermayer
On Thu, Oct 09, 2014 at 11:22:07PM +0200, Simon Thelen wrote: > On 09/10/14 at 23:05, Michael Niedermayer wrote: > > On Wed, Oct 08, 2014 at 07:13:33PM +0200, Simon Thelen wrote: > > > Enabling -seek_error causes ffmpeg to quit when it notices that > > > stop_time <= start_time. > > > > is there a

Re: [FFmpeg-devel] [PATCH] lavf/webm_dash: Allow filenames without directories

2014-10-09 Thread Michael Niedermayer
On Thu, Oct 09, 2014 at 02:56:47PM -0700, Vignesh Venkatasubramanian wrote: > Fix basename computation code to allow just file names without any > directories in the path. > > Signed-off-by: Vignesh Venkatasubramanian > --- > libavformat/matroskadec.c | 3 +-- > 1 file changed, 1 insertion(+), 2

[FFmpeg-devel] [PATCH] avcodec/utils: Display pixel format information as none ... if unknown instead of omitting it

2014-10-09 Thread Michael Niedermayer
This is similar to 20a5956b8daeee4cb59d6fa00ec809b02c04d7f8 The difference this change makes affects only rather few files but looks like: Stream #0:1: Video: mjpeg, 90k tbr, 90k tbn, 90k tbc vs. Stream #0:1: Video: mjpeg, none(bt470bg/unknown/unknown), 90k tbr, 90k tbn, 90k tbc Signed-off-by: M

Re: [FFmpeg-devel] [PATCH] vp9:enable multi-thread decoding when refreshctx is equal to 0

2014-10-09 Thread Di Wu
<<< image/gif; name="201410100943737_4XEV4D4T.gif": Unrecognized >>> 0001-vp9-enable-multi-thread-decoding-when-refreshctx-is-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH] vp9:enable multi-thread decoding when refreshctx is equal to 0

2014-10-09 Thread Di Wu
Hi, On 10/9/2014 08:46 AM, Ronald wrote: > I think functionally this looks OK, thanks for finding it. Please do follow > Reynaldo's suggestions on style/cosmetics. I'd go as far as to change the > second if into an else if, since they do related stuff, but I don't mind > either way. On

[FFmpeg-devel] [PATCH] ffprobe: Add support for color_trc/color_pri/chroma_loc

2014-10-09 Thread Michael Niedermayer
Idea from: a2c00d22e71d13b72828147be86aa9e961c6cae6 Signed-off-by: Michael Niedermayer --- doc/ffprobe.xsd|3 +++ ffprobe.c | 16 tests/ref/fate/ffprobe_compact |4 ++-- tests/ref/fate/ffprobe_csv |4 ++-- tests/ref/fate/ffpr

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-09 Thread Mika Raento
Right. Will definitely take a look. I wouldn't mind help turning that into a fate testcase. I've been struggling with writing fate tests. At least for somebody like me, having more coverage in the fate tests would help enormously, as I definitely do not have the required expertise to know what may

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-09 Thread Mika Raento
On 9 October 2014 23:37, Yusuke Nakamura wrote: > 2014-10-10 4:49 GMT+09:00 Michael Niedermayer : > >> On Thu, Oct 09, 2014 at 09:44:43PM +0200, Michael Niedermayer wrote: >> > On Thu, Oct 09, 2014 at 06:57:59PM +0300, Mika Raento wrote: >> > > If present, an MFRA box and its TFRAs are read for fr

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-09 Thread Mika Raento
Ah. My approach to matching truns to fragment times was way too naive. Rewritten to look up the time by sequence number and to handle multiple truns inside a single traf. Resubmitting. Mika On 9 October 2014 22:44, Michael Niedermayer wrote: > On Thu, Oct 09, 2014 at 06:57:59PM +0300, Mika R

[FFmpeg-devel] [PATCH] float_dsp-test: allow forcing cpuflags

2014-10-09 Thread James Almer
Signed-off-by: James Almer --- libavutil/float_dsp.c| 35 ++- tests/fate/libavutil.mak | 2 +- 2 files changed, 31 insertions(+), 6 deletions(-) diff --git a/libavutil/float_dsp.c b/libavutil/float_dsp.c index 8ac7480..78de1a1 100644 --- a/libavutil/float_dsp