Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: fix of crash caused by assert

2014-09-02 Thread Giorgio Vazzana
2014-09-02 2:07 GMT+02:00 Michael Niedermayer : > should i apply the previous patch or wait ? Let's wait some days so that Dmitry can test the patch if he wants to and give us some feedback. > also if you want, you can add yourself to the v4l2 maintainers in the > MAINTAINERs file, as you seem to

Re: [FFmpeg-devel] ffmpeg and musl toolchain support

2014-09-02 Thread Jörg Krause
On 09/01/2014 04:59 PM, wm4 wrote: On Mon, 01 Sep 2014 16:14:52 +0200 Jörg Krause wrote: When building against musl instead of glibc, compilation fails at libavutil/error.c CC libavutil/error.o libavutil/error.c: In function 'av_strerror': libavutil/error.c:68:9: error: implicit declaration

Re: [FFmpeg-devel] [PATCH 2/2] avformat/swfdec: Use side data to communicate w/h changes to the decoder

2014-09-02 Thread Paul B Mahol
On 9/2/14, Michael Niedermayer wrote: > Fixes reading from freed data > Fixes part of Ticket3539 > > Signed-off-by: Michael Niedermayer > --- > libavformat/swfdec.c |8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavformat/swfdec.c b/libavformat/swfdec.c > i

Re: [FFmpeg-devel] Filter_mb_edge

2014-09-02 Thread Nicolas Derouineau
I finally got it ... The explanation is in h264dsp_template.c (big bunch of macro, yummy !) De : ffmpeg-devel-boun...@ffmpeg.org de la part de Nicolas Derouineau Envoyé : lundi 1 septembre 2014 17:22 À : ffmpeg-devel@ffmpeg.org Objet : [FFmpeg-devel] Fil

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rawdec: Support CODEC_CAP_PARAM_CHANGE

2014-09-02 Thread Paul B Mahol
On 9/2/14, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/rawdec.c | 30 -- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/libavcodec/rawdec.c b/libavcodec/rawdec.c > index 305c13e..28792a1 100644 > --- a/lib

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-02 Thread Deti Fliegl
On 30.08.14 01:22, Michael Niedermayer wrote: moving code from (like from decklink_enc.cpp to decklink_common.cpp) should be in a seperate patch Done. Both patches are attached to this mail. If you want to maintain this code, please add yourself to the MAINTAINERs file Added. non static fun

Re: [FFmpeg-devel] Implementation od fixed point AAC decoder

2014-09-02 Thread Nedeljko Babic
>> >> Hello, >> >> I am sending new patch set with the implementation of fixed point AAC >> decoder. >> >> Most of the requests from review of float emulation done by Reimar are >> integrated in this patch set. > >That at least doesn't include the comments I made on float_add and >float_gt imp

Re: [FFmpeg-devel] [PATCH] segment: don't access outside seg->frames array

2014-09-02 Thread Michael Niedermayer
On Mon, Sep 01, 2014 at 08:10:03PM +0300, Mika Raento wrote: > Fixes wrong number of segments output and undefined memory access. > --- > libavformat/segment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF13

Re: [FFmpeg-devel] [PATCH 02/14] libavcodec: Implementation of AAC_fixed_decoder (LC-module) [2/5]

2014-09-02 Thread Nedeljko Babic
>> +/* Rounding to zero used for simplicity */ >> +static av_always_inline aac_float_t float_add(aac_float_t a, aac_float_t b) >> +{ >> +int diff; >> + >> +if (a.mant == 0) >> +return b; >> + >> +if (b.mant == 0) >> +return a; >> + >> +diff = a.expo - b.expo; >> + >>

[FFmpeg-devel] how to merge fixed point wma decoder from rockbox to libav 0.7.6

2014-09-02 Thread Diaz Soho
Hi All, Is there anyone have idea about how to merge fixed point wma decoder to libav 0.7.6? because my cpu does not include fpu, when use the wma decoder in libav , it take a lot of cpu time. Or is anyone have merge fixed point wma decoder to libav? Thanks for any input!! _

Re: [FFmpeg-devel] [PATCH] segment: fix remuxing and copy metadata

2014-09-02 Thread Michael Niedermayer
On Mon, Sep 01, 2014 at 08:05:44PM +0300, Mika Raento wrote: > To get mpegts metadata copied when segmenting. > --- > libavformat/segment.c | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/libavformat/segment.c b/libavformat/segment.c > index 1cb6454..0

[FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
Add the feature test macro which is required for building with the musl toolchain. The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant version of strerror_r(). Signed-off-by: Jörg Krause --- libavutil/error.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/erro

[FFmpeg-devel] [PATCH 2/4] libavutil/time: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
Add the feature test macro which is required for building with the musl toolchain. The required feature test macro is: nanosleep(): _POSIX_C_SOURCE >= 199309L Signed-off-by: Jörg Krause --- libavutil/time.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/time.c b/libavutil/ti

Re: [FFmpeg-devel] how to merge fixed point wma decoder from rockbox to libav 0.7.6

2014-09-02 Thread compn
On Tue, 2 Sep 2014 17:48:57 +0800 Diaz Soho wrote: > Hi All, > > Is there anyone have idea about how to merge fixed point wma decoder > to libav 0.7.6? > because my cpu does not include fpu, when use the wma decoder in > libav , it take a lot of cpu time. > > Or is anyone have merge fixed point

[FFmpeg-devel] [PATCH 3/4] libavutil/file: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
Add the feature test macro which is required for building with the musl toolchain. The required feature test macro is: fdopen(): _POSIX_C_SOURCE >= 1 Signed-off-by: Jörg Krause --- libavutil/file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/file.c b/libavutil/file.c index

[FFmpeg-devel] [PATCH 4/4] libavutil/file_open: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
Add the feature test macro which is required for building with the musl toolchain. The required feature test macro is: fdopen(): _POSIX_C_SOURCE >= 1 Signed-off-by: Jörg Krause --- libavutil/file_open.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/file_open.c b/libavutil/fil

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 12:33:26PM +0200, Jörg Krause wrote: > Add the feature test macro which is required for building with the > musl toolchain. > > The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant > version of strerror_r(). is there a reason why you dont set it from con

[FFmpeg-devel] [PATCH v2 3/4] libavutil/file: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
Add the feature test macro which is required for building with the musl toolchain. The required feature test macro is: mkstemp(): _POSIX_C_SOURCE >= 200112L Signed-off-by: Jörg Krause --- Changes v1 -> v2: - Fixed commit message --- libavutil/file.c | 2 ++ 1 file changed, 2 insertions(+) d

[FFmpeg-devel] FFmpeg 2.4

2014-09-02 Thread Michael Niedermayer
Hi Its almost 2 Months since 2.3 and i assume people want a new release from around the same time of when libav 11 will get released so expect FFmpeg 2.4 to be released soon! if you want something in it, now is the time to push/post it if you want something fixed, now is the time to fix it Thank

[FFmpeg-devel] Redirecting MP4 muxed data to socket using movflags resets timestamp

2014-09-02 Thread Parth Shah
I am using FFMPEG library to mux H.264 and AAC frames to MP4 file. I do that C program. I store H.264 and AAC frame's timestamp in epoch format. I use ffprobe to check timestamps that stored in the MP4 file, ffprobe confirms that file is in MP4 format and timestamps are stored correctly. below

Re: [FFmpeg-devel] [PATCH 2/2] avformat/swfdec: Use side data to communicate w/h changes to the decoder

2014-09-02 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 08:39:00AM +, Paul B Mahol wrote: > On 9/2/14, Michael Niedermayer wrote: > > Fixes reading from freed data > > Fixes part of Ticket3539 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/swfdec.c |8 ++-- > > 1 file changed, 6 insertions(+), 2

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rawdec: Support CODEC_CAP_PARAM_CHANGE

2014-09-02 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 08:44:47AM +, Paul B Mahol wrote: > On 9/2/14, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/rawdec.c | 30 -- > > 1 file changed, 16 insertions(+), 14 deletions(-) > > > > diff --git a/libavcode

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
Am 02.09.2014 12:40 schrieb Michael Niedermayer: On Tue, Sep 02, 2014 at 12:33:26PM +0200, Jörg Krause wrote: Add the feature test macro which is required for building with the musl toolchain. The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant version of strerror_r(). is

Re: [FFmpeg-devel] FFmpeg 2.4

2014-09-02 Thread Marcus Johnson
Alright, probably a bad place to post this, but I made a few cosmetic changes to the dts decoder, the first replaces the request_channels calls with the request_channel_layout function, and the second removes the code that disabled deprecation warnings around those calls. On Tue, Sep 2, 2014 at

[FFmpeg-devel] how to merge fixed point wma decoder from rockbox to libav 0.7.6

2014-09-02 Thread Diaz Soho
Hi All, Is there anyone have idea about how to merge fixed point wma decoder to libav 0.7.6? because my cpu does not include fpu, when use the wma decoder in libav , it take a lot of cpu time. Or is anyone have merge fixed point wma decoder to libav? Thanks for any input!! _

[FFmpeg-devel] [PATCH] avformat/swfdec: Do not change the pixel format

2014-09-02 Thread Michael Niedermayer
This is currently not supported Fixes part of Ticket 3539 Signed-off-by: Michael Niedermayer --- libavformat/swfdec.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavformat/swfdec.c b/libavformat/swfdec.c index ca2a1c4..528bc23 100644 --- a/libavformat/s

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 01:52:24PM +0200, Jörg Krause wrote: > > > Am 02.09.2014 12:40 schrieb Michael Niedermayer: > >On Tue, Sep 02, 2014 at 12:33:26PM +0200, Jörg Krause wrote: > >>Add the feature test macro which is required for building with the > >>musl toolchain. > >> > >>The feature test

[FFmpeg-devel] [PATCH] cmdutils: Add some whitespace when printing layouts

2014-09-02 Thread Tobias Rapp
Attached patch adds some whitespace when listing channel layouts with the "-layouts" option. == Output before patch == Individual channels: NAMEDESCRIPTION FL front left FR front right FC front center [...] Standard channel layouts: NAMEDECOMPOSITION

[FFmpeg-devel] [PATCH] SSE2 version of vf_idet's filter_line()

2014-09-02 Thread Pascal Massimino
Hi, Much faster. An example (time ffmpeg -i ... -vf idet -f null /dev/null) Raw C: user 25.007s MMX:user 16.818s MMXEXT: user 16.191s SSE2: user 15.481s no idet filter: user 15.025s YMMV. skal commit de5064a0126a0a5bed9d8f151fa79b07614729fe Author: skal Date: Tue Sep 2 16:55

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread wm4
On Tue, 2 Sep 2014 12:33:26 +0200 Jörg Krause wrote: > Add the feature test macro which is required for building with the > musl toolchain. > > The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant > version of strerror_r(). > > Signed-off-by: Jörg Krause > --- > libavutil/

[FFmpeg-devel] how to merge fixed point wma decoder from rockbox to libav 0.7.6

2014-09-02 Thread Diaz Soho
Hi compn, how about : merging the fixed point decoders from rockbox has been on our todo list for a while. https://github.com/Rockbox/rockbox/tree/master/lib/rbcodec/codecs any idea ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ff

Re: [FFmpeg-devel] FFmpeg 2.4

2014-09-02 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 08:05:56AM -0400, Marcus Johnson wrote: > Alright, probably a bad place to post this, but I made a few cosmetic > changes to the dts decoder, the first replaces the request_channels calls > with the request_channel_layout function, and the second removes the code > that disa

Re: [FFmpeg-devel] [PATCH] SSE2 version of vf_idet's filter_line()

2014-09-02 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 05:13:08PM +0200, Pascal Massimino wrote: > Hi, > > Much faster. > An example (time ffmpeg -i ... -vf idet -f null /dev/null) > Raw C: user 25.007s > MMX:user 16.818s > MMXEXT: user 16.191s > SSE2: user 15.481s > no idet filter: user 15.025s > > YMMV. >

Re: [FFmpeg-devel] [PATCH] cmdutils: Add some whitespace when printing layouts

2014-09-02 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 05:04:31PM +0200, Tobias Rapp wrote: > Attached patch adds some whitespace when listing channel layouts > with the "-layouts" option. applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try

Re: [FFmpeg-devel] [PATCH] rangecoder-test: Allow running with small stack size.

2014-09-02 Thread Reimar Döffinger
On Tue, Sep 02, 2014 at 01:48:09AM +0200, Michael Niedermayer wrote: > On Mon, Sep 01, 2014 at 11:26:06PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/rangecoder.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > LGTM Pushed. __

Re: [FFmpeg-devel] [PATCH] vf_deshake: reduce stack usage.

2014-09-02 Thread Reimar Döffinger
On Tue, Sep 02, 2014 at 01:54:38AM +0200, Michael Niedermayer wrote: > On Mon, Sep 01, 2014 at 11:36:52PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavfilter/deshake.h| 3 +++ > > libavfilter/vf_deshake.c | 13 + > > 2 files changed, 8 inser

Re: [FFmpeg-devel] [PATCH] vf_deshake: Avoid doing a malloc+free for every single frame.

2014-09-02 Thread Reimar Döffinger
On Tue, Sep 02, 2014 at 01:55:20AM +0200, Michael Niedermayer wrote: > On Mon, Sep 01, 2014 at 11:49:28PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavfilter/deshake.h| 2 ++ > > libavfilter/vf_deshake.c | 10 ++ > > 2 files changed, 8 insertion

Re: [FFmpeg-devel] [PATCH] rl.h: Use on-stack temporary VLC tables instead of having them static.

2014-09-02 Thread Reimar Döffinger
On Mon, Sep 01, 2014 at 08:59:43PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/mpeg12.c| 21 ++--- > libavcodec/mpegvideo.c | 12 > libavcodec/rl.h| 8 ++-- > 3 files changed, 20 insertions(+), 21 deletions(-)

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread Reimar Döffinger
On Tue, Sep 02, 2014 at 05:03:56PM +0200, Michael Niedermayer wrote: > On Tue, Sep 02, 2014 at 01:52:24PM +0200, Jörg Krause wrote: > > > > > > Am 02.09.2014 12:40 schrieb Michael Niedermayer: > > >On Tue, Sep 02, 2014 at 12:33:26PM +0200, Jörg Krause wrote: > > >>Add the feature test macro which

Re: [FFmpeg-devel] Redirecting MP4 muxed data to socket using movflags resets timestamp

2014-09-02 Thread Reimar Döffinger
On Tue, Sep 02, 2014 at 04:42:09PM +0530, Parth Shah wrote: > My question is why this timestamps gets changed? Is thereant method to send > MP4 file over socket without changing its timestamp? > > > Any help or advice? Thank you in advance. This belongs on ffmpeg-user. Plus, I'd suggest reconsid

[FFmpeg-devel] Request for testing

2014-09-02 Thread James Darnley
I am looking for someone with an XOP capable CPU to compile and run two basic fate tests for me. All you have to do is: - get the ffmpeg source from my git repo (link below) - checkout the flac_enc_lpc branch: git checkout flac_enc_lpc - configure with --enable-gpl - build ffmpeg - run: make fate-

[FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

2014-09-02 Thread Reimar Döffinger
A bit more complex than e.g. adding it to the context, but using the context for something that will be used only during initialization seemed a bit wasteful. Signed-off-by: Reimar Döffinger --- libavcodec/ffv1enc.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libav

[FFmpeg-devel] [PATCH 1/4] avformat/assdec: UTF-16 support

2014-09-02 Thread wm4
Use the UTF-16 BOM to detect UTF-16 encoding. Convert the file contents to UTF-8 on the fly using FFTextReader, which acts as converting wrapper around AVIOContext. It also can work on a static buffer, needed for format probing. The FFTextReader wrapper now also takes care of skipping the UTF-8 BOM

[FFmpeg-devel] [PATCH 2/4] avformat/srtdec: UTF-16 support

2014-09-02 Thread wm4
--- libavformat/srtdec.c| 22 +++-- libavformat/subtitles.c | 51 +++-- libavformat/subtitles.h | 33 +--- 3 files changed, 91 insertions(+), 15 deletions(-) diff --git a/libavformat/srtdec.c b/libavformat

[FFmpeg-devel] [PATCH 3/4] avformat/samidec: UTF-16 support

2014-09-02 Thread wm4
ff_smil_extract_next_chunk() is still used by RealText. --- libavformat/samidec.c | 17 ++--- libavformat/subtitles.c | 15 --- libavformat/subtitles.h | 5 + 3 files changed, 27 insertions(+), 10 deletions(-) diff --git a/libavformat/samidec.c b/libavformat/samidec

[FFmpeg-devel] [PATCH 4/4] avformat/realtextdec: UTF-16 support

2014-09-02 Thread wm4
Also remove ff_smil_extract_next_chunk - this was the last user of it. --- libavformat/realtextdec.c | 17 ++--- libavformat/subtitles.c | 9 - libavformat/subtitles.h | 5 - 3 files changed, 10 insertions(+), 21 deletions(-) diff --git a/libavformat/realtextdec.c b/

[FFmpeg-devel] [PATCH] ffv1dec: Avoid unnecessarily large stack usage and copies.

2014-09-02 Thread Reimar Döffinger
Ideally the compiler could figure this out on its own, but it seems it can't. An alternative that would avoid the messy explicit memcpy would be to use a sub-struct for the parts that should be preserved, which can then simply be assigned. Signed-off-by: Reimar Döffinger --- libavcodec/ffv1dec.c

Re: [FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

2014-09-02 Thread wm4
On Tue, 2 Sep 2014 20:32:57 +0200 Reimar Döffinger wrote: > A bit more complex than e.g. adding it to the context, but > using the context for something that will be used only during > initialization seemed a bit wasteful. > > Signed-off-by: Reimar Döffinger > --- > libavcodec/ffv1enc.c | 8 +

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 07:41:40PM +0200, Reimar Döffinger wrote: > On Tue, Sep 02, 2014 at 05:03:56PM +0200, Michael Niedermayer wrote: > > On Tue, Sep 02, 2014 at 01:52:24PM +0200, Jörg Krause wrote: > > > > > > > > > Am 02.09.2014 12:40 schrieb Michael Niedermayer: > > > >On Tue, Sep 02, 2014

Re: [FFmpeg-devel] [PATCH 1/4] avformat/assdec: UTF-16 support

2014-09-02 Thread Reimar Döffinger
On Tue, Sep 02, 2014 at 08:56:09PM +0200, wm4 wrote: > Use the UTF-16 BOM to detect UTF-16 encoding. Convert the file contents > to UTF-8 on the fly using FFTextReader, which acts as converting wrapper > around AVIOContext. It also can work on a static buffer, needed for > format probing. The FFTex

Re: [FFmpeg-devel] Request for testing

2014-09-02 Thread Kelly Anderson
On Tuesday, September 02, 2014 20:22:24 James Darnley wrote: > I am looking for someone with an XOP capable CPU to compile and run two > basic fate tests for me. All you have to do is: > - get the ffmpeg source from my git repo (link below) > - checkout the flac_enc_lpc branch: git checkout flac_e

Re: [FFmpeg-devel] [PATCH 1/4] avformat/assdec: UTF-16 support

2014-09-02 Thread wm4
On Tue, 2 Sep 2014 21:05:08 +0200 Reimar Döffinger wrote: > On Tue, Sep 02, 2014 at 08:56:09PM +0200, wm4 wrote: > > Use the UTF-16 BOM to detect UTF-16 encoding. Convert the file contents > > to UTF-8 on the fly using FFTextReader, which acts as converting wrapper > > around AVIOContext. It also

Re: [FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

2014-09-02 Thread Reimar Döffinger
On Tue, Sep 02, 2014 at 08:58:50PM +0200, wm4 wrote: > On Tue, 2 Sep 2014 20:32:57 +0200 > Reimar Döffinger wrote: > > @@ -933,6 +938,7 @@ static av_cold int encode_init(AVCodecContext *avctx) > > } > > } > > } > > +av_freep(&best_state); > > }

Re: [FFmpeg-devel] Request for testing

2014-09-02 Thread James Darnley
On 2014-09-02 20:39, Kelly Anderson wrote: > TESTacodec-flac-comp-5 > TESTacodec-flac-24-comp-5 > tests/Makefile:192: recipe for target 'fate-acodec-flac-24-comp-5' failed > make: *** [fate-acodec-flac-24-comp-5] Error 1 Thanks. Good to know that the 16-bit version works. I am probably

Re: [FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

2014-09-02 Thread wm4
On Tue, 2 Sep 2014 21:18:24 +0200 Reimar Döffinger wrote: > On Tue, Sep 02, 2014 at 08:58:50PM +0200, wm4 wrote: > > On Tue, 2 Sep 2014 20:32:57 +0200 > > Reimar Döffinger wrote: > > > @@ -933,6 +938,7 @@ static av_cold int encode_init(AVCodecContext *avctx) > > > } > > >

Re: [FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

2014-09-02 Thread Reimar Döffinger
On Tue, Sep 02, 2014 at 09:28:27PM +0200, wm4 wrote: > On Tue, 2 Sep 2014 21:18:24 +0200 > Reimar Döffinger wrote: > > So I'd prefer to avoid it. However there is the question of which > > code mess/benefit ratio we want to accept. > > I don't see anything wrong in the patch (well, maybe you shou

Re: [FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

2014-09-02 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 08:32:57PM +0200, Reimar Döffinger wrote: > A bit more complex than e.g. adding it to the context, but > using the context for something that will be used only during > initialization seemed a bit wasteful. > > Signed-off-by: Reimar Döffinger LGTM [...] -- Michael G

Re: [FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

2014-09-02 Thread Reimar Döffinger
On Tue, Sep 02, 2014 at 09:28:27PM +0200, wm4 wrote: > I don't see anything wrong in the patch (well, maybe you should switch > the code to the "goto fail;" idiom). I was just wondering whether there > was a specific reason for this. Did it fail on a certain system? Btw. while I did not test it, a

Re: [FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

2014-09-02 Thread wm4
On Tue, 2 Sep 2014 21:54:36 +0200 Reimar Döffinger wrote: > On Tue, Sep 02, 2014 at 09:28:27PM +0200, wm4 wrote: > > I don't see anything wrong in the patch (well, maybe you should switch > > the code to the "goto fail;" idiom). I was just wondering whether there > > was a specific reason for thi

Re: [FFmpeg-devel] [FFmpeg-cvslog] 8svx: Return proper error codes

2014-09-02 Thread Clément Bœsch
On Tue, Sep 02, 2014 at 09:54:31PM +0200, Gabriel Dume wrote: > ffmpeg | branch: master | Gabriel Dume | Mon Sep 1 > 15:18:57 2014 -0400| [74512f7e369da40e1148c92b58cd8e59f7737b8f] | committer: > Diego Biurrun > > 8svx: Return proper error codes > > Signed-off-by: Diego Biurrun > > > http:/

Re: [FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

2014-09-02 Thread Reimar Döffinger
On Tue, Sep 02, 2014 at 09:54:36PM +0200, Reimar Döffinger wrote: > On Tue, Sep 02, 2014 at 09:28:27PM +0200, wm4 wrote: > > I don't see anything wrong in the patch (well, maybe you should switch > > the code to the "goto fail;" idiom). I was just wondering whether there > > was a specific reason f

Re: [FFmpeg-devel] [PATCH 1/4] avformat/assdec: UTF-16 support

2014-09-02 Thread Clément Bœsch
On Tue, Sep 02, 2014 at 08:56:09PM +0200, wm4 wrote: > Use the UTF-16 BOM to detect UTF-16 encoding. Convert the file contents > to UTF-8 on the fly using FFTextReader, which acts as converting wrapper > around AVIOContext. It also can work on a static buffer, needed for > format probing. The FFTex

[FFmpeg-devel] [PATCH] Fix vf_cropdetect returning negative rectangles

2014-09-02 Thread hjiodjf 97xgw46
The cropdetect filter is prone to reporting negative-sized rectangles, particularly for dark images. This patch adjusts the limits of the filter loops, preventing the left/right and top/bottom offsets from crossing each other, so that such a zero-sized rectangle is reported instead of a negative on

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
On 09/02/2014 07:41 PM, Reimar Döffinger wrote: On Tue, Sep 02, 2014 at 05:03:56PM +0200, Michael Niedermayer wrote: On Tue, Sep 02, 2014 at 01:52:24PM +0200, Jörg Krause wrote: Am 02.09.2014 12:40 schrieb Michael Niedermayer: On Tue, Sep 02, 2014 at 12:33:26PM +0200, Jörg Krause wrote: Add

Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

2014-09-02 Thread Reimar Döffinger
On Tue, Sep 02, 2014 at 01:13:27PM -0700, Peter Kasting wrote: > On Sat, Aug 30, 2014 at 2:21 AM, wm4 wrote: > > I'd > > expect it rather to hide bugs than to expose them. For example, it > > could make a static analyzer with value range analysis stop working, > > because the casts will basically

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread Reimar Döffinger
On Tue, Sep 02, 2014 at 11:31:39PM +0200, Jörg Krause wrote: > The maintainers of the musl C library states that looking for __GLIBC__ or > __UCLIBC__ and making assumptions about the implemented feature set is not > the best way. Instead should be inspected for the specification > of the feature

[FFmpeg-devel] [PATCH]Print bits_per_raw_sample for ffprobe -show_streams

2014-09-02 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #3919 for me. Please comment, Carl Eugen diff --git a/ffprobe.c b/ffprobe.c index 2d48070..34c7f1e 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -2170,6 +2170,7 @@ static int show_stream(WriterContext *w, AVFormatContext *fmt_ctx, int stream_id else

Re: [FFmpeg-devel] [PATCH 2/4] avformat/srtdec: UTF-16 support

2014-09-02 Thread Clément Bœsch
On Tue, Sep 02, 2014 at 08:56:10PM +0200, wm4 wrote: > --- > libavformat/srtdec.c| 22 +++-- > libavformat/subtitles.c | 51 > +++-- > libavformat/subtitles.h | 33 +--- > 3 files changed, 91 insertions(+)

[FFmpeg-devel] [PATCH 1/4] ffv1dec: Avoid unnecessarily large stack usage and copies.

2014-09-02 Thread Reimar Döffinger
Ideally the compiler could figure this out on its own, but it seems it can't. An alternative that would avoid the messy explicit memcpy would be to use a sub-struct for the parts that should be preserved, which can then simply be assigned. Signed-off-by: Reimar Döffinger --- libavcodec/ffv1dec.c

[FFmpeg-devel] [PATCH 2/4] huffyuvdec: avoid large stack use.

2014-09-02 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/huffyuvdec.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c index 1df77e0..d661328 100644 --- a/libavcodec/huffyuvdec.c +++ b/libavcodec/huffyuvdec.c @@ -115,9 +11

[FFmpeg-devel] [PATCH 3/4] libswresample: Avoid needlessly large on-stack array.

2014-09-02 Thread Reimar Döffinger
We only actually use a tiny part of it. Signed-off-by: Reimar Döffinger --- libswresample/rematrix.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libswresample/rematrix.c b/libswresample/rematrix.c index bf2abcf..60b8caf 100644 --- a/libswresample/rematrix.c +++ b/l

Re: [FFmpeg-devel] [PATCH 3/4] avformat/samidec: UTF-16 support

2014-09-02 Thread Clément Bœsch
On Tue, Sep 02, 2014 at 08:56:11PM +0200, wm4 wrote: > ff_smil_extract_next_chunk() is still used by RealText. > --- > libavformat/samidec.c | 17 ++--- > libavformat/subtitles.c | 15 --- > libavformat/subtitles.h | 5 + > 3 files changed, 27 insertions(+), 10 delet

[FFmpeg-devel] [PATCH 4/4] svq1enc: remove pointless array element.

2014-09-02 Thread Reimar Döffinger
Not sure it was meant to be used for something at some point though. Signed-off-by: Reimar Döffinger --- libavcodec/svq1enc.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c index af18d38..850630f 100644 --- a/libavcodec/svq1

Re: [FFmpeg-devel] [PATCH 4/4] avformat/realtextdec: UTF-16 support

2014-09-02 Thread Clément Bœsch
On Tue, Sep 02, 2014 at 08:56:12PM +0200, wm4 wrote: > Also remove ff_smil_extract_next_chunk - this was the last user of it. > --- > libavformat/realtextdec.c | 17 ++--- > libavformat/subtitles.c | 9 - > libavformat/subtitles.h | 5 - > 3 files changed, 10 insertio

[FFmpeg-devel] [PATCH]Print the actual bit depth for audio if it is different from the sample_fmt bit depth

2014-09-02 Thread Carl Eugen Hoyos
Hi! Attached patch makes avcodec_string() output for audio more similar to video with unexpected bit depth. Please comment, Carl Eugen diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 9d3fcfd..dfc1a04 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -2978,6 +2978,9 @@ void a

Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

2014-09-02 Thread wm4
On Fri, 29 Aug 2014 15:44:34 -0700 Peter Kasting wrote: > From 1c94e78d2b2037d492ea5abb3edb7960c8e98a1d Mon Sep 17 00:00:00 2001 > From: Peter Kasting > Date: Fri, 29 Aug 2014 15:31:41 -0700 > Subject: [PATCH] Fix MSVC warnings about possible value truncation. Tried to review it. Here's why pat

[FFmpeg-devel] [PATCH] web/download: Update Linux Static Build links

2014-09-02 Thread Lou Logan
* Remove Burek's builds These have been halted since 16 July. Burek has been notified several times, but I have recieved no response. Link will be re-added if activity resumes. * Add reference to 32-bit builds to relaxed's link Thanks to relaxed for quickly volunteering to provide 32-bit builds, a

Re: [FFmpeg-devel] [PATCH 1/4] avformat/assdec: UTF-16 support

2014-09-02 Thread wm4
On Tue, 2 Sep 2014 23:18:02 +0200 Clément Bœsch wrote: > On Tue, Sep 02, 2014 at 08:56:09PM +0200, wm4 wrote: > > Use the UTF-16 BOM to detect UTF-16 encoding. Convert the file contents > > to UTF-8 on the fly using FFTextReader, which acts as converting wrapper > > around AVIOContext. It also ca

[FFmpeg-devel] [PATCH] vorbisenc: avoid large stack allocation.

2014-09-02 Thread Reimar Döffinger
Code is only used during initialization, so malloc/free should be fine to use. Signed-off-by: Reimar Döffinger --- libavcodec/vorbisenc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/vorbisenc.c b/libavcodec/vorbisenc.c index 0fb7190..0f78d95 100644 --- a

Re: [FFmpeg-devel] [PATCH 1/4] ffv1dec: Avoid unnecessarily large stack usage and copies.

2014-09-02 Thread Reimar Döffinger
On Wed, Sep 03, 2014 at 12:01:52AM +0200, Reimar Döffinger wrote: > Ideally the compiler could figure this out on its own, > but it seems it can't. > An alternative that would avoid the messy explicit memcpy > would be to use a sub-struct for the parts that should > be preserved, which can then sim

Re: [FFmpeg-devel] [PATCH] web/download: Update Linux Static Build links

2014-09-02 Thread Carl Eugen Hoyos
Lou Logan lrcd.com> writes: > + href="http://johnvansickle.com/ffmpeg/";>32-bit and > +64-bit for kernel 2.6.32 and above Please push if what you write is correct. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmp

Re: [FFmpeg-devel] [PATCH 2/4] avformat/srtdec: UTF-16 support

2014-09-02 Thread wm4
On Tue, 2 Sep 2014 23:54:51 +0200 Clément Bœsch wrote: > On Tue, Sep 02, 2014 at 08:56:10PM +0200, wm4 wrote: > > --- > > libavformat/srtdec.c| 22 +++-- > > libavformat/subtitles.c | 51 > > +++-- > > libavformat/subtitles.h | 33

Re: [FFmpeg-devel] [PATCH 3/4] avformat/samidec: UTF-16 support

2014-09-02 Thread wm4
On Wed, 3 Sep 2014 00:03:04 +0200 Clément Bœsch wrote: > On Tue, Sep 02, 2014 at 08:56:11PM +0200, wm4 wrote: > > ff_smil_extract_next_chunk() is still used by RealText. > > --- > > libavformat/samidec.c | 17 ++--- > > libavformat/subtitles.c | 15 --- > > libavformat/

Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

2014-09-02 Thread wm4
On Tue, 2 Sep 2014 23:43:33 +0200 Reimar Döffinger wrote: > On Tue, Sep 02, 2014 at 01:13:27PM -0700, Peter Kasting wrote: > > On Sat, Aug 30, 2014 at 2:21 AM, wm4 wrote: > > > I'd > > > expect it rather to hide bugs than to expose them. For example, it > > > could make a static analyzer with va

Re: [FFmpeg-devel] [PATCH 2/4] huffyuvdec: avoid large stack use.

2014-09-02 Thread wm4
On Wed, 3 Sep 2014 00:01:53 +0200 Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/huffyuvdec.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c > index 1df77e0..d661328 10064

Re: [FFmpeg-devel] [PATCH] SSE2 version of vf_idet's filter_line()

2014-09-02 Thread Pascal Massimino
Michael, On Tue, Sep 2, 2014 at 9:39 AM, Michael Niedermayer wrote: > On Tue, Sep 02, 2014 at 05:13:08PM +0200, Pascal Massimino wrote: > > Hi, > > > > Much faster. > > An example (time ffmpeg -i ... -vf idet -f null /dev/null) > > Raw C: user 25.007s > > MMX:user 16.818s > > MMXEXT

Re: [FFmpeg-devel] Request for testing

2014-09-02 Thread James Darnley
On 2014-09-02 21:25, James Darnley wrote: > On 2014-09-02 20:39, Kelly Anderson wrote: >> TESTacodec-flac-comp-5 >> TESTacodec-flac-24-comp-5 > >> tests/Makefile:192: recipe for target 'fate-acodec-flac-24-comp-5' failed >> make: *** [fate-acodec-flac-24-comp-5] Error 1 > > Thanks. Good

Re: [FFmpeg-devel] [PATCH] web/download: Update Linux Static Build links

2014-09-02 Thread Lou Logan
On Tue, 2 Sep 2014 22:36:35 + (UTC), Carl Eugen Hoyos wrote: > Please push if what you write is correct. > > Thank you, Carl Eugen Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] SSE2 version of vf_idet's filter_line()

2014-09-02 Thread James Darnley
On 2014-09-02 17:13, Pascal Massimino wrote: > %macro DECLARE_VAR 2 > %define %1 %2 > %define %1d %2d > %endmacro > > ;; Mappings for common variables > DECLARE_VAR index, r5 > DECLARE_VAR total, r4 > DECLARE_VAR parallel_width, r6 I suggest you leave these up to the cglobal macro > DE

Re: [FFmpeg-devel] FFmpeg 2.4

2014-09-02 Thread Marcus Johnson
Hmm it worked for me, but I'll check it out. On Tue, Sep 2, 2014 at 12:22 PM, Michael Niedermayer wrote: > On Tue, Sep 02, 2014 at 08:05:56AM -0400, Marcus Johnson wrote: > > Alright, probably a bad place to post this, but I made a few cosmetic > > changes to the dts decoder, the first replaces

Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

2014-09-02 Thread wm4
On Tue, 2 Sep 2014 16:34:58 -0700 Peter Kasting wrote: > On Tue, Sep 2, 2014 at 3:19 PM, wm4 wrote: > > > Here's why patches like these are bad: they're > > HUGE. Reviewing them takes a lot of time, and the result is > > questionable. How are we going to do v2 of this patch? And v3 etc.? > > Pr

Re: [FFmpeg-devel] [PATCHv2] doc/demuxers: document gif demuxer

2014-09-02 Thread Timothy Gu
On Aug 31, 2014 3:16 PM, "Lou Logan" wrote: > +@item ignore_loop > +GIF files can be set to loop infinitely or up to a certain number of > +times. can contain information to loop... "Can be set" sounds like settable from a ffmpeg command. > + > +If @option{ignore_loop} is set to 1, then the l

[FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

2014-09-02 Thread Kieran Kunhya
Patch not sent to ML so couldn't review: Why have you only changed the code to favour DESC_types and not other types? Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] patch for x32 for libpostproc

2014-09-02 Thread Thorsten Glaser
Hi, as discussed in IRC, I was trying to minimal-invasively port libpostproc (the Debian source package) to x32¹. I could not test it (for lack of a stand-alone test program) yet, but at least I got it to build. As requested, the patch I used is attached. It’s not optimal as the arch could use th

Re: [FFmpeg-devel] Reintroducing FFmpeg to Debian

2014-09-02 Thread Vittorio Giovara
On Fri, Aug 29, 2014 at 1:17 PM, Michael Niedermayer wrote: > also please dont remove ffmpeg-devel from the CC > I had missed that you removed it so my reply went just to debian-devel > full quote left below for ffmpeg-devel, no further inline comments Sorry about that. Last time I tried having a

Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

2014-09-02 Thread wm4
On Tue, 2 Sep 2014 16:57:02 -0700 Peter Kasting wrote: > On Tue, Sep 2, 2014 at 4:46 PM, wm4 wrote: > > > > I tried not to "just plaster things with casts", but as I said, I was > > > counting on review feedback to help me understand where changes would be > > > fixing real problems or hiding r

Re: [FFmpeg-devel] [PATCH] SSE2 version of vf_idet's filter_line()

2014-09-02 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 03:49:14PM -0700, Pascal Massimino wrote: > Michael, > > > On Tue, Sep 2, 2014 at 9:39 AM, Michael Niedermayer > wrote: > > > On Tue, Sep 02, 2014 at 05:13:08PM +0200, Pascal Massimino wrote: > > > Hi, > > > > > > Much faster. > > > An example (time ffmpeg -i ... -vf ide

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 11:49:47PM +0200, Reimar Döffinger wrote: [...] > reason that configure is already too slow. ccache + --tempprefix + dash instead of bash should help a bit [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 3

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread James Darnley
On 2014-09-03 02:13, Michael Niedermayer wrote: > On Tue, Sep 02, 2014 at 11:49:47PM +0200, Reimar Döffinger wrote: > [...] > >> reason that configure is already too slow. > > ccache + --tempprefix + dash instead of bash should help a bit Tell that to Windows! Okay trying dash did reduce the 10

Re: [FFmpeg-devel] [FFmpeg-cvslog] 8svx: Return proper error codes

2014-09-02 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 10:03:39PM +0200, Clément Bœsch wrote: > On Tue, Sep 02, 2014 at 09:54:31PM +0200, Gabriel Dume wrote: > > ffmpeg | branch: master | Gabriel Dume | Mon Sep > > 1 15:18:57 2014 -0400| [74512f7e369da40e1148c92b58cd8e59f7737b8f] | > > committer: Diego Biurrun > > > > 8svx:

  1   2   >