[FFmpeg-devel] [PATCH 1/3] x86/hevc_deblock: remove some unnecessary instructions

2014-07-29 Thread James Almer
Signed-off-by: James Almer --- libavcodec/x86/hevc_deblock.asm | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/x86/hevc_deblock.asm b/libavcodec/x86/hevc_deblock.asm index e38181d..cfa7c48 100644 --- a/libavcodec/x86/hevc_deblock.asm +++ b/libavcodec/x86

[FFmpeg-devel] [PATCH 2/3] x86/hevc_deblock: improve luma functions register allocation

2014-07-29 Thread James Almer
Signed-off-by: James Almer --- libavcodec/x86/hevc_deblock.asm | 88 - 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/libavcodec/x86/hevc_deblock.asm b/libavcodec/x86/hevc_deblock.asm index cfa7c48..d6e8806 100644 --- a/libavcodec/x86/hevc_

[FFmpeg-devel] [PATCH 3/3] x86/hevc_deblock: add add ff_hevc_[hv]_loop_filter_luma_{8, 10, 12}_avx

2014-07-29 Thread James Almer
~5% faster than SSSE3 Signed-off-by: James Almer --- libavcodec/x86/hevc_deblock.asm | 10 +- libavcodec/x86/hevcdsp_init.c | 30 ++ 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/hevc_deblock.asm b/libavcodec/x86/hevc_deblock.

Re: [FFmpeg-devel] rectification filter

2014-07-29 Thread Clément Bœsch
On Tue, Jul 29, 2014 at 08:04:50AM +0200, Daniel Oberhoff wrote: > Updated patch: > > From 204a8da14f92fcdefe63dda341261bdd25d6ce87 Mon Sep 17 00:00:00 2001 > From: Daniel Oberhoff > Date: Mon, 28 Jul 2014 23:58:12 +0200 > Subject: [PATCH] added rectification filter > > --- > libavfilter/Makefi

Re: [FFmpeg-devel] rectification filter

2014-07-29 Thread Carl Eugen Hoyos
Daniel Oberhoff gmail.com> writes: > OBJS-$(CONFIG_ZOOMPAN_FILTER)+= vf_zoompan.o > +OBJS-$(CONFIG_RECTIFICATION_FILTER) += vf_rectification.o > REGISTER_FILTER(ZOOMPAN,zoompan,vf); > +REGISTER_FILTER(RECTIFICATION, rectification, vf); Keep t

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-29 Thread Clément Bœsch
On Thu, Jul 24, 2014 at 03:39:42PM +0200, Nicolas George wrote: > Messaages are passed as frames with a negative format code, Messages* > only to filter that declare supporting them. > The only message for now is EOF; this mechanism augments > the current mechanism based on request_frame() return

Re: [FFmpeg-devel] [RFC]Add int64_t probesize2 to AVFormatContext

2014-07-29 Thread Carl Eugen Hoyos
Oliver Fromme fromme.com> writes: > > http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/104257/focus=140297 > > That thread seems to center on DVD playback with ffplay, > including menu navigation. > My goal is to enable ffmpeg to be able read one title > from a DVD and encode it. I didn'

Re: [FFmpeg-devel] rectification filter

2014-07-29 Thread James Darnley
On 2014-07-29 07:41, Daniel Oberhoff wrote: > First off thanks for taking the time to review. > > Am 29.07.2014 um 01:16 schrieb Carl Eugen Hoyos : > >> Daniel Oberhoff gmail.com> writes: >> >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms o

Re: [FFmpeg-devel] rectification filter

2014-07-29 Thread Daniel Oberhoff
On Jul 29, 2014, at 11:56 AM, James Darnley wrote: > On 2014-07-29 07:41, Daniel Oberhoff wrote: >> First off thanks for taking the time to review. >> >> Am 29.07.2014 um 01:16 schrieb Carl Eugen Hoyos : >> >>> Daniel Oberhoff gmail.com> writes: >>> + * This program is free software; yo

Re: [FFmpeg-devel] [RFC]Add int64_t probesize2 to AVFormatContext

2014-07-29 Thread Michael Niedermayer
On Sun, Jul 27, 2014 at 10:52:26PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Some DVD dumps contain subtitles that start after more than 2G, > attached patch should allow to specify sufficiently large > values for -probesize. > > Please review, Carl Eugen > doc/APIchanges |4 +

Re: [FFmpeg-devel] [PATCH 1/3] x86/hevc_deblock: remove some unnecessary instructions

2014-07-29 Thread Michael Niedermayer
On Tue, Jul 29, 2014 at 04:30:11AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/x86/hevc_deblock.asm | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 2/3] x86/hevc_deblock: improve luma functions register allocation

2014-07-29 Thread Michael Niedermayer
On Tue, Jul 29, 2014 at 04:30:12AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/x86/hevc_deblock.asm | 88 > - > 1 file changed, 44 insertions(+), 44 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF21

Re: [FFmpeg-devel] [PATCH 3/3] x86/hevc_deblock: add add ff_hevc_[hv]_loop_filter_luma_{8, 10, 12}_avx

2014-07-29 Thread Michael Niedermayer
On Tue, Jul 29, 2014 at 04:30:13AM -0300, James Almer wrote: > ~5% faster than SSSE3 > > Signed-off-by: James Almer > --- > libavcodec/x86/hevc_deblock.asm | 10 +- > libavcodec/x86/hevcdsp_init.c | 30 ++ > 2 files changed, 39 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] FFmpeg OPW

2014-07-29 Thread Michael Niedermayer
On Mon, Jul 28, 2014 at 05:46:33PM -0400, Reynaldo H. Verdejo Pinochet wrote: > Following up, this is a patch for web/news kickstarting the fundraiser > for OPW. OK to commit? > > Once posted, it would be great if you can set aside 2 minutes to > tweet/blogpost/whatever about it so it gets noticed

Re: [FFmpeg-devel] [PATCH 3/7] avformat/hlsenc: fix segmentation issues

2014-07-29 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 10:57:43AM +0200, Nicolas Martyanoff wrote: > - Select a reference stream (the first video stream, or the first audio > stream if there is no video stream) instead of using the PTS of any video > stream. > > - Control the segment length using the time since the last seg

Re: [FFmpeg-devel] [PATCH 4/7] avformat/hlsenc: do not regenerate the playlist for each segment

2014-07-29 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 10:57:44AM +0200, Nicolas Martyanoff wrote: > Since we need all segments to find out the target duration, we can only > generate the playlist after writing all segments. > > There is no need to rewrite the segment list every time we create a new > segment file. doesnt this

Re: [FFmpeg-devel] [PATCH 2/7] avformat/hlsenc: make the code easier to read

2014-07-29 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 10:57:42AM +0200, Nicolas Martyanoff wrote: > Before adding new features, I read the code and cleaned it. The main issue was > abstruse identifier names. > > The behaviour of the muxer is *not* modified, by this patch, this is only > cosmetic. If this is not the case, it is

Re: [FFmpeg-devel] [PATCH 3/7] avformat/hlsenc: fix segmentation issues

2014-07-29 Thread Michael Niedermayer
On Tue, Jul 29, 2014 at 03:40:54PM +0200, Michael Niedermayer wrote: [...] > > @@ -289,7 +321,7 @@ static int hls_write_header(AVFormatContext *ctx) > > > > ret = avformat_write_header(hls->ctx, NULL); > > if (ret < 0) > > -return ret; > > +goto fail; > > > > retu

Re: [FFmpeg-devel] [PATCH] Deprecate AFD field and add AFD as side-data

2014-07-29 Thread Michael Niedermayer
On Tue, Jul 29, 2014 at 12:14:03AM +0100, Kieran Kunhya wrote: > --- > doc/APIchanges|4 > libavcodec/avcodec.h |5 - > libavcodec/mpeg12dec.c| 21 - > libavcodec/version.h |5 - > libavfilter/vf_showinfo.c |3 +++ > liba

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-29 Thread Nicolas George
Le primidi 11 thermidor, an CCXXII, Clément Bœsch a écrit : > What other kind of messages do you have in mind? I had thought about something to handle timestamps discontinuities / lost frames, but not very deeply. > "messages" sounds very user specific though. Like, it makes almost believe > that

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-29 Thread Clément Bœsch
On Tue, Jul 29, 2014 at 05:14:22PM +0200, Nicolas George wrote: > Le primidi 11 thermidor, an CCXXII, Clément Bœsch a écrit : > > What other kind of messages do you have in mind? > > I had thought about something to handle timestamps discontinuities / lost > frames, but not very deeply. > > > "me

[FFmpeg-devel] [PATCH] mxfdec: add missing "const" to array declaration.

2014-07-29 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 4d2a506..03f3df7 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -992,7 +992,7 @@ static const MXFCodecUL

[FFmpeg-devel] [PATCH] movdec: remove nonsensical snprintf.

2014-07-29 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavformat/mov.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 6a9af69..7b1dbb2 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -119,15 +119,13 @@ static int mov_metadata_gnre(MOVCo

[FFmpeg-devel] [PATCH 2/3] dict.c: minor simplification.

2014-07-29 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavutil/dict.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index 66a0773..2cd67e8 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -90,10 +90,9 @@ int av_dict_set(AVDictionary **pm, const

[FFmpeg-devel] [PATCH 1/3] dict.c: Free non-strduped av_dict_set arguments on error.

2014-07-29 Thread Reimar Döffinger
Unfortunately this was not explicitly documented and thus might be very risky. But basically all uses I saw in FFmpeg had a memleak in these cases. Signed-off-by: Reimar Döffinger --- libavutil/dict.c | 9 +++-- libavutil/dict.h | 2 ++ 2 files changed, 9 insertions(+), 2 deletions(-) diff

[FFmpeg-devel] [PATCH 3/3] dict.c: empty dictionaries should be a NULL pointer.

2014-07-29 Thread Reimar Döffinger
Ensure this is even the case if they are empty because we failed adding the first entry. Signed-off-by: Reimar Döffinger --- libavutil/dict.c | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/dict.c b/libavutil/dict.c index 2cd67e8..9063a57 100644 --- a/libavutil/dict.c +++ b/lib

Re: [FFmpeg-devel] [PATCH] mxfdec: add missing "const" to array declaration.

2014-07-29 Thread Michael Niedermayer
On Tue, Jul 29, 2014 at 09:25:33PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavformat/mxfdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness

Re: [FFmpeg-devel] [PATCH] movdec: remove nonsensical snprintf.

2014-07-29 Thread Michael Niedermayer
On Tue, Jul 29, 2014 at 09:25:46PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavformat/mov.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human being will ev

Re: [FFmpeg-devel] [PATCH 2/3] dict.c: minor simplification.

2014-07-29 Thread Michael Niedermayer
On Tue, Jul 29, 2014 at 09:26:49PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavutil/dict.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Why not whip the teac

Re: [FFmpeg-devel] [PATCH 1/3] dict.c: Free non-strduped av_dict_set arguments on error.

2014-07-29 Thread Michael Niedermayer
On Tue, Jul 29, 2014 at 09:26:48PM +0200, Reimar Döffinger wrote: > Unfortunately this was not explicitly documented and thus > might be very risky. > But basically all uses I saw in FFmpeg had a memleak in these > cases. > > Signed-off-by: Reimar Döffinger > --- > libavutil/dict.c | 9 +++--

[FFmpeg-devel] [PATCH] web: remove projects page and associated dingleberries

2014-07-29 Thread Lou Logan
Alexander Strasser added a redirect on the web server, so this page is no longer needed. The current projects page is located on the wiki: https://trac.ffmpeg.org/wiki/Projects Signed-off-by: Lou Logan --- src/projects | 5 - src/projects_js| 0 src/projects_title | 1 - 3 files c

Re: [FFmpeg-devel] [PATCH] web: remove projects page and associated dingleberries

2014-07-29 Thread Michael Niedermayer
On Tue, Jul 29, 2014 at 12:58:04PM -0800, Lou Logan wrote: > Alexander Strasser added a redirect on the web server, so this page is > no longer needed. > > The current projects page is located on the wiki: > https://trac.ffmpeg.org/wiki/Projects > > Signed-off-by: Lou Logan > --- > src/projects

[FFmpeg-devel] [PATCH] x86/hevc_deblock: use existing x86util transpose macro in chroma_{10, 12}

2014-07-29 Thread James Almer
Cosmetic change. No measurable difference in speed. Signed-off-by: James Almer --- libavcodec/x86/hevc_deblock.asm | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/libavcodec/x86/hevc_deblock.asm b/libavcodec/x86/hevc_deblock.asm index 2d4353a..5951e

Re: [FFmpeg-devel] [PATCH] web: remove projects page and associated dingleberries

2014-07-29 Thread James Darnley
On 2014-07-29 22:58, Lou Logan wrote: > dingleberries Are you sure you want to use that word? http://www.urbandictionary.com/define.php?term=dingleberry signature.asc Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@f

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: fix register count usage

2014-07-29 Thread Michael Niedermayer
On Mon, Jul 28, 2014 at 08:01:35PM +0200, Christophe Gisquet wrote: > With patch. > hevc_mc.asm | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > 4d42e469f9d69329e4a0d5fb23a4d6a3a0aedcf7 > 0010-x86-hevc_mc-fix-register-count-usage.patch > From 0b5d56a563df7e

Re: [FFmpeg-devel] [PATCH] web: remove projects page and associated dingleberries

2014-07-29 Thread Lou Logan
On Tue, 29 Jul 2014 23:09:30 +0200, James Darnley wrote: > Are you sure you want to use that word? It's also used to mean "extra stuff" or similar, but I suppose I could have used something more sober. Anyway, pushed for better or for worse. ___ ffmpeg

Re: [FFmpeg-devel] (no subject)

2014-07-29 Thread wm4
On Tue, 29 Jul 2014 10:45:43 +0200 (CEST) Oliver Fromme wrote: > Carl Eugen Hoyos wrote: > > Oliver Fromme fromme.com> writes: > > > > > That's why I appreciate the patch very much > > > that Carl Eugen has created. > > > > Did you test the patch? > > I think it will not get applied wit

Re: [FFmpeg-devel] [RFC]Add int64_t probesize2 to AVFormatContext

2014-07-29 Thread wm4
On Mon, 28 Jul 2014 10:43:13 +0200 Nicolas George wrote: > Le decadi 10 thermidor, an CCXXII, Eli Kara a écrit : > > It would solve the problem for DVDs with structure, which is probably what > > most people have when they rip a DVD. > > Certainly. But the other scenarios where the user only hav

Re: [FFmpeg-devel] [RFC]Add int64_t probesize2 to AVFormatContext

2014-07-29 Thread wm4
On Mon, 28 Jul 2014 17:21:34 +0200 Nicolas George wrote: > Le decadi 10 thermidor, an CCXXII, Oliver Fromme a écrit : > > Ah! Thank you very much for pointing me to the concat demuxer. > > I wasn't aware that it can be (ab)used to declare the presence > > of streams in an input file. I will def

Re: [FFmpeg-devel] rectification filter

2014-07-29 Thread wm4
On Tue, 29 Jul 2014 00:31:48 +0200 Daniel Oberhoff wrote: > Hello, > > In the last days I effectively rewrote the rectification filter found in the > frei0r suite as a libavfilter video filter and would like to submit this to > ffmpeg. It probably needs some cleanup, which I will do by checkin

Re: [FFmpeg-devel] [PATCH 2/4] lavfi/buffersrc: add add av_buffersrc_close().

2014-07-29 Thread wm4
On Thu, 24 Jul 2014 15:49:33 +0200 Nicolas George wrote: > Le sextidi 6 thermidor, an CCXXII, wm4 a écrit : > > No, you can't do this. > > Yes, I can. > > > It breaks compatibility with Libav; > > No, it does not. Removing it would break compatibility. Deprecating it does > nothing. > > > als

Re: [FFmpeg-devel] [PATCH 2/4] lavfi/buffersrc: add add av_buffersrc_close().

2014-07-29 Thread Nicolas George
Le duodi 12 thermidor, an CCXXII, wm4 a écrit : > I asked for the reason of the API change. What's the purpose of the API > change, if the "deprecated" method is supported forever anyway? What's the purpose of deprecating gets() in favour of fgets() if the deprecated function is supported forever

Re: [FFmpeg-devel] rectification filter

2014-07-29 Thread Daniel Oberhoff
Am 30.07.2014 um 00:08 schrieb wm4 : > On Tue, 29 Jul 2014 00:31:48 +0200 > Daniel Oberhoff wrote: > >> Hello, >> >> In the last days I effectively rewrote the rectification filter found in the >> frei0r suite as a libavfilter video filter and would like to submit this to >> ffmpeg. It proba

Re: [FFmpeg-devel] [PATCH 2/4] lavfi/buffersrc: add add av_buffersrc_close().

2014-07-29 Thread wm4
On Wed, 30 Jul 2014 00:13:38 +0200 Nicolas George wrote: > Le duodi 12 thermidor, an CCXXII, wm4 a écrit : > > I asked for the reason of the API change. What's the purpose of the API > > change, if the "deprecated" method is supported forever anyway? > > What's the purpose of deprecating gets()

[FFmpeg-devel] [PATCH 1/2] avutil/frame: add av_frame_side_data_name()

2014-07-29 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/frame.c | 14 ++ libavutil/frame.h |5 + 2 files changed, 19 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index fdfbc46..2c62922 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -672,3 +672,17 @@

[FFmpeg-devel] [PATCH 2/2] ffprobe: print some basic information about avframe side data

2014-07-29 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- ffprobe.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/ffprobe.c b/ffprobe.c index 1329466..114da50 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -123,6 +123,8 @@ typedef enum { SECTION_ID_FRAME, SECTION_

Re: [FFmpeg-devel] [PATCH] ffprobe: print some basic information about avframe side data

2014-07-29 Thread Michael Niedermayer
On Tue, Jul 01, 2014 at 07:20:13PM +0200, Clément Bœsch wrote: > On Tue, Jul 01, 2014 at 05:50:11PM +0200, Michael Niedermayer wrote: > > On Mon, Jun 30, 2014 at 06:37:45PM +0200, Clément Bœsch wrote: > > > On Mon, Jun 30, 2014 at 04:16:17AM +0200, Michael Niedermayer wrote: > > > > Signed-off-by:

[FFmpeg-devel] [PATCH] add m4b to list of ipod playable files

2014-07-29 Thread Gerion Entrup
m4b is the extension used by iDevices to detect audiobooks. --- libavformat/movenc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 4b9a4f1..2bb6be1 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -895,8 +

Re: [FFmpeg-devel] [PATCH] add m4b to list of ipod playable files

2014-07-29 Thread Michael Niedermayer
On Wed, Jul 30, 2014 at 02:20:30AM +0200, Gerion Entrup wrote: > m4b is the extension used by iDevices to detect audiobooks. > --- > libavformat/movenc.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF13