[FFmpeg-devel] [PATCH] avfilter/biquads: avoid clipping when using floating type

I think clipping isn't needed when using floating type. Thanks From 3ffce13b5b118d84b724f2aec342baa6536271da Mon Sep 17 00:00:00 2001 From: Muhammad Faiz Date: Thu, 17 Jul 2014 10:49:04 +0700 Subject: [PATCH] avfilter/biquads: avoid clipping when using floating type --- libavfilter/af_biquads.c

[FFmpeg-devel] A few filter questions

Good day, I'm currently working on a video signature filter for ffmpeg. This allows you to fingerprint videos. This fingerprint is built up of 9mb/s of bits or 2-3 mb/s bits compressed. In this context a few questions come into my mind: - Should I print this whole bitstream to stdout/stderr at

Re: [FFmpeg-devel] A few filter questions

On Thu, Jul 17, 2014 at 12:33:41PM +0200, Gerion Entrup wrote: > Good day, > > I'm currently working on a video signature filter for ffmpeg. This allows you > to > fingerprint videos. Oh, nice. > This fingerprint is built up of 9mb/s of bits or 2-3 mb/s bits compressed. > > In this context a

Re: [FFmpeg-devel] [PATCH] lavu/eval: add clip function

On date Monday 2014-07-07 20:58:50 +0200, Michael Niedermayer encoded: > On Fri, Jul 04, 2014 at 04:40:50PM +0200, Stefano Sabatini wrote: [...] > > Subject: [PATCH] lavu/eval: add clip function > > > > TODO: bump micro > > --- > > doc/utils.texi | 3 +++ > > libavutil/eval.c| 14 ++

Re: [FFmpeg-devel] [PATCH 1/2] drawtext: add expansion function eif()

On date Sunday 2014-07-06 13:46:31 +0300, Andrey Utkin encoded: > 2014-07-05 16:19 GMT+03:00 Nicolas George : > > Le sextidi 16 messidor, an CCXXII, Andrey Utkin a écrit : > >> +@item eif > > > > I find the name obscure. Where does it come from? > > Yes, it is somewhat obscure. It comes from "expr

Re: [FFmpeg-devel] [PATCH 2/2 v2] drawtext: add fontcolor_expr

On date Saturday 2014-07-05 11:59:35 +0200, Stefano Sabatini encoded: > On date Friday 2014-07-04 21:54:53 +0300, Andrey Utkin encoded: > > An option for fontcolor, dynamically evaluated > > --- > > doc/filters.texi | 16 > > libavfilter/vf_drawtext.c | 26 +++

Re: [FFmpeg-devel] [PATCH] avformat/dv: implement fallback in dv_extract_pack()

On Jul 16, 2014, at 10:57 PM, Michael Niedermayer wrote: > Fixes Ticket2340 > Fixes Ticket2341 I tested with the samples from tickets 2340 and 2341. In both cases the patch fixes the originally reported issue. Thanks! Dave Rice ___ ffmpeg-devel mailin

[FFmpeg-devel] [PATCH] lavf/segment: only use reference frames for computing the segment end time

This avoids a systematic overestimate of the segments duration when there are several streams. Fix trac ticket #3724. --- libavformat/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 3de4623..7c3a3c5 100644 --- a/lib

Re: [FFmpeg-devel] [PATCH] avformat/dv: implement fallback in dv_extract_pack()

On Thu, Jul 17, 2014 at 07:37:58AM -0400, Dave Rice wrote: > On Jul 16, 2014, at 10:57 PM, Michael Niedermayer wrote: > > > Fixes Ticket2340 > > Fixes Ticket2341 > > I tested with the samples from tickets 2340 and 2341. In both cases the patch > fixes the originally reported issue. Thanks! app

Re: [FFmpeg-devel] [PATCH] lavf/segment: only use reference frames for computing the segment end time

On Thu, Jul 17, 2014 at 02:53:43PM +0200, Stefano Sabatini wrote: > This avoids a systematic overestimate of the segments duration when there > are several streams. > > Fix trac ticket #3724. > --- > libavformat/segment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) probably ok [...]

Re: [FFmpeg-devel] Issue 3052

Hi, - Mail original - > On Wed, Jul 16, 2014 at 05:40:35PM +0200, Benoit Fouet wrote: > > > > > > - Mail original - > > > Hi, > > > > > > I had a look at https://trac.ffmpeg.org/ticket/3052. > > > The issue is that the last frame duration is lost. Is there any > > > reason why t

Re: [FFmpeg-devel] Issue 3052

L'octidi 28 messidor, an CCXXII, Michael Niedermayer a écrit : > again, i suspect this is not updated by filters currently You are right, the filters do not update them currently. I believe changing that policy would not be a convenient way of solving that issue: the duration information raises c

Re: [FFmpeg-devel] A few filter questions

Am Donnerstag 17 Juli 2014, 13:00:13 schrieb Clément Bœsch: > On Thu, Jul 17, 2014 at 12:33:41PM +0200, Gerion Entrup wrote: > > Good day, > > > > I'm currently working on a video signature filter for ffmpeg. This allows > > you to fingerprint videos. > > Oh, nice. > > > This fingerprint is buil

Re: [FFmpeg-devel] [PATCH] lavf/segment: only use reference frames for computing the segment end time

On date Thursday 2014-07-17 16:25:26 +0200, Michael Niedermayer encoded: > On Thu, Jul 17, 2014 at 02:53:43PM +0200, Stefano Sabatini wrote: > > This avoids a systematic overestimate of the segments duration when there > > are several streams. > > > > Fix trac ticket #3724. > > --- > > libavforma

Re: [FFmpeg-devel] A few filter questions

On Thu, Jul 17, 2014 at 04:56:08PM +0200, Gerion Entrup wrote: [...] > > Also, you still have the string metadata possibility (git grep SET_META > > libavfilter). > Hmm, thank you, I will take a look at it. If I see it right, it is used to > fill > a dictionary per frame with some kind of data? >

Re: [FFmpeg-devel] [PATCH] lavfi: check refcount before merging.

Le septidi 27 messidor, an CCXXII, Michael Niedermayer a écrit : > LGTM Thanks. Then please merge the following commits from my tree: a65c0a3 lavd/x11grab: disable drawing mouse without XFixes. 36fbe3c lavd/x11grab: change error code for unsupported visuals. 16c6795 lavd/x11grab: check 32-bits co

Re: [FFmpeg-devel] A few filter questions

Le nonidi 29 messidor, an CCXXII, Clément Bœsch a écrit : > We add a discussion several time for real time with that filter. If we do > a 2-pass, that's simply because it's "more efficient". Typically, doing > some live normalization can be done easily (we had patches for this): > ebur128 already a

[FFmpeg-devel] [PATCH] lavf/segment: sanitize segment end time in case last packet didn't have a defined duration

In particular, avoids to set segments with a 0 duration (e.g. segment with a single reference frame for which duration is undefined). --- libavformat/segment.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index db932f7..33a5558 100644 ---

[FFmpeg-devel] [PATCH] lavf/segment: do not allow to create segments with no key-frames

Fix trac ticket #3749. --- libavformat/segment.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 72bf5e0..db932f7 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -94,7 +94,8 @@ typedef struct

Re: [FFmpeg-devel] [PATCH] lavfi: check refcount before merging.

On Thu, Jul 17, 2014 at 06:30:40PM +0200, Nicolas George wrote: > Le septidi 27 messidor, an CCXXII, Michael Niedermayer a écrit : > > LGTM > > Thanks. Then please merge the following commits from my tree: > > a65c0a3 lavd/x11grab: disable drawing mouse without XFixes. > 36fbe3c lavd/x11grab: cha

Re: [FFmpeg-devel] [PATCH 1/3] lavd/x11grab: disable drawing mouse without XFixes.

Le septidi 27 messidor, an CCXXII, Michael Niedermayer a écrit : > LGTM You just merged this series. Thanks. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpe

[FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

Hi! Attached patch fixes ticket #3777 for me, analyzed by Oliver Fromme. Please comment, Carl Eugen diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 8335388..cdef6d9 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -138,6 +138,7 @@ static void mp3_parse_info_tag(AVFor

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

Le nonidi 29 messidor, an CCXXII, Carl Eugen Hoyos a écrit : > Hi! > > Attached patch fixes ticket #3777 for me, analyzed by Oliver Fromme. > > Please comment, Carl Eugen > diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c > index 8335388..cdef6d9 100644 > --- a/libavformat/mp3dec.c > +++

[FFmpeg-devel] [PATCH] Introduce avio_dump_contents() and use it in lavd/lavfi.c

This is a replacement for previously proposed API av_bprint_fd_contents(). Side-effect: lavfi input device now accepts any URL as "graph_file" option value. --- libavdevice/lavfi.c | 30 +++--- libavformat/avio.h| 8 libavformat/aviobuf.c | 16 ++

Re: [FFmpeg-devel] [PATCH 1/2] drawtext: add expansion function eif()

Damn, was just going to resubmit :( However, the only change was to add more comprehensive alias "expr_int_format". Do you think it's worth to submit such addition? -- Andrey Utkin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/

Re: [FFmpeg-devel] [PATCH 1/2] drawtext: add expansion function eif()

On date Thursday 2014-07-17 23:38:42 +0300, Andrey Utkin encoded: > Damn, was just going to resubmit :( However, the only change was to > add more comprehensive alias "expr_int_format". Do you think it's > worth to submit such addition? Sure. Also since the patch was committed just today, feel fre

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

On Thursday 17 July 2014 09:41:40 pm Nicolas George wrote: > Le nonidi 29 messidor, an CCXXII, Carl Eugen Hoyos a écrit : > > Hi! > > > > Attached patch fixes ticket #3777 for me, analyzed by Oliver Fromme. > > > > Please comment, Carl Eugen > > > > diff --git a/libavformat/mp3dec.c b/libavformat/m

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

On Thursday 17 July 2014 09:41:40 pm Nicolas George wrote: > Le nonidi 29 messidor, an CCXXII, Carl Eugen Hoyos a écrit : > > > > Attached patch fixes ticket #3777 for me, analyzed by Oliver > > Fromme. > I would suggest to avoid floating point arithmetic if possible. > Possibly something like

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

Le nonidi 29 messidor, an CCXXII, Carl Eugen Hoyos a écrit : > > if (... && min - tolerance < 2 * tolerance) ^^^ ^^^ This bit was a leftover from a slightly different version I tried at first, it was wrong. > > I also find this version easier to understand. > > Thank

[FFmpeg-devel] [PATCH] lavfi/drawtext: add alias "expr_int_format" to expansion function "eif"

--- doc/filters.texi | 2 +- libavfilter/vf_drawtext.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 8cde277..a7919a3 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -3916,7 +3916,7 @@ example the text size is not

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: add alias "expr_int_format" to expansion function "eif"

Le decadi 30 messidor, an CCXXII, Andrey Utkin a écrit : > --- > doc/filters.texi | 2 +- > libavfilter/vf_drawtext.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) IMHO, since the function was added extremely recently, it is ok to just change the name. May I suggest: forma

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: add alias "expr_int_format" to expansion function "eif"

2014-07-18 1:05 GMT+03:00 Nicolas George : > Le decadi 30 messidor, an CCXXII, Andrey Utkin a écrit : >> --- >> doc/filters.texi | 2 +- >> libavfilter/vf_drawtext.c | 3 ++- >> 2 files changed, 3 insertions(+), 2 deletions(-) > > IMHO, since the function was added extremely recently, it

[FFmpeg-devel] [PATCH] oss_audio: check all ioctl() return codes

Also uses a macro to simplify. Signed-off-by: Timothy Gu --- Found with clang's static analyzer. --- libavdevice/oss_audio.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/libavdevice/oss_audio.c b/libavdevice/oss_audio.c index 734e565..3c5065c 10

[FFmpeg-devel] [PATCH] ffplay: remove dead code

Signed-off-by: Timothy Gu --- ffplay.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ffplay.c b/ffplay.c index af0e199..8abbeae 100644 --- a/ffplay.c +++ b/ffplay.c @@ -775,8 +775,6 @@ static void blend_subrect(AVPicture *dst, const AVSubtitleRect *rect, int imgw, lum[0] = AL

[FFmpeg-devel] [PATCH 1/2] proresenc_anatoliy: use tables in proresdata.c instead of redefining them

Signed-off-by: Timothy Gu --- libavcodec/Makefile | 4 ++-- libavcodec/proresenc_anatoliy.c | 43 ++--- 2 files changed, 16 insertions(+), 31 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 307ad22..e3f75f5 100644 --- a/l

[FFmpeg-devel] [PATCH 2/2] proresenc: move profile handling to global avcodec options

This allows users to use the two encoders with the same syntax. Signed-off-by: Timothy Gu --- libavcodec/avcodec.h| 5 + libavcodec/options_table.h | 5 + libavcodec/proresenc_anatoliy.c | 5 - libavcodec/proresenc_kostya.c | 44 +

Re: [FFmpeg-devel] [Updated PATCH 2/4] armv6: Accelerate ff_fft_calc for general case (nbits != 4)

On Fri, Jul 11, 2014 at 11:32:08AM +0100, Ben Avison wrote: > The previous implementation targeted DTS Coherent Acoustics, which only > requires nbits == 4 (fft16()). This case was (and still is) linked directly > rather than being indirected through ff_fft_calc_vfp(), but now the full > range from

[FFmpeg-devel] [PATCH] hevc: propagate error code from set_sps()

Signed-off-by: Timothy Gu --- libavcodec/hevc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index afb2baa..d3108d7 100644 --- a/libavcodec/hevc.c +++ b/libavcodec/hevc.c @@ -3299,7 +3299,8 @@ static int hevc_update_thread_context(AVC

Re: [FFmpeg-devel] [PATCH 1/2] proresenc_anatoliy: use tables in proresdata.c instead of redefining them

On Thu, Jul 17, 2014 at 06:04:06PM -0700, Timothy Gu wrote: > Signed-off-by: Timothy Gu > --- > libavcodec/Makefile | 4 ++-- > libavcodec/proresenc_anatoliy.c | 43 > ++--- > 2 files changed, 16 insertions(+), 31 deletions(-) it appears this mak

[FFmpeg-devel] [PATCH 3/4] smacker: remove dead code

Signed-off-by: Timothy Gu --- libavcodec/smacker.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c index 644beb3..518bdad 100644 --- a/libavcodec/smacker.c +++ b/libavcodec/smacker.c @@ -438,7 +438,6 @@ static int decode_frame(AVCodecContext *avctx

[FFmpeg-devel] [PATCH 2/4] kerndeint: remove dead assignments

Signed-off-by: Timothy Gu --- libavfilter/vf_kerndeint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_kerndeint.c b/libavfilter/vf_kerndeint.c index 1f8e091..5130208 100644 --- a/libavfilter/vf_kerndeint.c +++ b/libavfilter/vf_kerndeint.c @@ -154,10 +154,

[FFmpeg-devel] [PATCH 1/4] mpeg: remove unused assignment

Signed-off-by: Timothy Gu --- libavformat/mpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index c53bab3..5891cea 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -204,8 +204,8 @@ static long mpegps_psm_parse(MpegDemuxCo

[FFmpeg-devel] [PATCH 4/4] a64multienc: remove dead assignment

Signed-off-by: Timothy Gu --- libavcodec/a64multienc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/a64multienc.c b/libavcodec/a64multienc.c index 3067774..9760298 100644 --- a/libavcodec/a64multienc.c +++ b/libavcodec/a64multienc.c @@ -351,7 +351,6 @@ static int a64multi_encode_

Re: [FFmpeg-devel] [PATCH 2/2] proresenc: move profile handling to global avcodec options

On Thu, Jul 17, 2014 at 06:04:07PM -0700, Timothy Gu wrote: > This allows users to use the two encoders with the same syntax. > > Signed-off-by: Timothy Gu > --- > libavcodec/avcodec.h| 5 + > libavcodec/options_table.h | 5 + > libavcodec/proresenc_anatoliy.c | 5 ---

[FFmpeg-devel] [PATCH 1/2] alpha/idctdsp: move disabled cruft out of dsputil

Signed-off-by: James Almer --- libavcodec/alpha/dsputil_alpha.c | 72 libavcodec/alpha/idctdsp_alpha.c | 72 2 files changed, 72 insertions(+), 72 deletions(-) diff --git a/libavcodec/alpha/dsputil_alpha.c b/libavc

[FFmpeg-devel] [PATCH 2/2] alpha/me_cmp: move code out of dsputil

Signed-off-by: James Almer --- Untested. libavcodec/alpha/Makefile | 5 ++- libavcodec/alpha/dsputil_alpha.c | 40 -- libavcodec/alpha/dsputil_alpha.h | 32 - .../alpha/{motion_est_alpha.c => me_cmp

Re: [FFmpeg-devel] [PATCH 2/4] kerndeint: remove dead assignments

On Thu, Jul 17, 2014 at 07:25:41PM -0700, Timothy Gu wrote: > Signed-off-by: Timothy Gu > --- > libavfilter/vf_kerndeint.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wise

Re: [FFmpeg-devel] [PATCH 4/4] a64multienc: remove dead assignment

On Thu, Jul 17, 2014 at 07:25:43PM -0700, Timothy Gu wrote: > Signed-off-by: Timothy Gu > --- > libavcodec/a64multienc.c | 1 - > 1 file changed, 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always

Re: [FFmpeg-devel] [PATCH 1/2] alpha/idctdsp: move disabled cruft out of dsputil

On Thu, Jul 17, 2014 at 11:45:34PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/alpha/dsputil_alpha.c | 72 > > libavcodec/alpha/idctdsp_alpha.c | 72 > > 2 files changed, 72 insertion

Re: [FFmpeg-devel] [PATCH 2/2] alpha/me_cmp: move code out of dsputil

On Thu, Jul 17, 2014 at 11:45:35PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > Untested. > > libavcodec/alpha/Makefile | 5 ++- > libavcodec/alpha/dsputil_alpha.c | 40 > -- > libavcodec/alpha/dsputil_alpha.h

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: add alias "expr_int_format" to expansion function "eif"

On date Friday 2014-07-18 01:00:40 +0300, Andrey Utkin encoded: > --- > doc/filters.texi | 2 +- > libavfilter/vf_drawtext.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index 8cde277..a7919a3 100644 > --- a/doc/filter

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: add alias "expr_int_format" to expansion function "eif"

On Fri, Jul 18, 2014 at 12:05:42AM +0200, Nicolas George wrote: > Le decadi 30 messidor, an CCXXII, Andrey Utkin a écrit : > > --- > > doc/filters.texi | 2 +- > > libavfilter/vf_drawtext.c | 3 ++- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > IMHO, since the function was add