Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-28 Thread Dennis Mungai
On Fri, Mar 29, 2019, 00:16 Yufei He wrote: > On 03/28/2019 04:18 PM, Dennis Mungai wrote: > > On Thu, 28 Mar 2019 at 22:40, Nicolas George wrote: > > > >> No need to Cc me, I am subscribed to the list. > >> > >> Yufei He (12019-03-28): > >>> In windows, we need provide the interface library mvM

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-28 Thread Yufei He
On 03/28/2019 04:18 PM, Dennis Mungai wrote: > On Thu, 28 Mar 2019 at 22:40, Nicolas George wrote: > >> No need to Cc me, I am subscribed to the list. >> >> Yufei He (12019-03-28): >>> In windows, we need provide the interface library mvM264.lib to our >>> customers so that they can build. But dri

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-28 Thread Dennis Mungai
On Thu, 28 Mar 2019 at 22:40, Nicolas George wrote: > No need to Cc me, I am subscribed to the list. > > Yufei He (12019-03-28): > > In windows, we need provide the interface library mvM264.lib to our > > customers so that they can build. But driver installation of the card > > does not have the

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-28 Thread Thomas Volkert
On 28.03.2019 13:40, Yufei He wrote: > On 03/27/2019 11:35 AM, Nicolas George wrote: > > Yufei He (12019-03-27): > > > Here is the fixed patch for a new H.264 codec with Matrox M264 card. > > It calls the default library from the card's driver installation. > Please review. > > > > You are still us

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-28 Thread Nicolas George
No need to Cc me, I am subscribed to the list. Yufei He (12019-03-28): > In windows, we need provide the interface library mvM264.lib to our > customers so that they can build. But driver installation of the card > does not have the interface library. It just install mvM264.dll. > > We call dlope

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-28 Thread Yufei He
On 03/28/2019 10:00 AM, Jean-Baptiste Kempf wrote: > > On Thu, 28 Mar 2019, at 13:41, Yufei He wrote: >> In windows, we need provide the interface library mvM264.lib to our >> customers so that they can build. But driver installation of the card >> does not have the interface library. It just insta

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-28 Thread Carl Eugen Hoyos
2019-03-28 13:40 GMT+01:00, Yufei He : > In windows, we need provide the interface library mvM264.lib And you should. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vis

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-28 Thread Jean-Baptiste Kempf
On Thu, 28 Mar 2019, at 13:41, Yufei He wrote: > In windows, we need provide the interface library mvM264.lib to our > customers so that they can build. But driver installation of the card > does not have the interface library. It just install mvM264.dll. Why does mvM264.dll return 0 Google Se

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-28 Thread Yufei He
On 03/27/2019 11:35 AM, Nicolas George wrote: Yufei He (12019-03-27): Here is the fixed patch for a new H.264 codec with Matrox M264 card. It calls the default library from the card's driver installation. Please review. You are still using programmatic dynamic linking instead of normal dynam

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-27 Thread Carl Eugen Hoyos
2019-03-27 16:30 GMT+01:00, Yufei He : > Here is the fixed patch for a new H.264 codec with Matrox > M264 card. Please do not send another version of this patch that doesn't add the non-free requirement in configure (or open-source your library). Carl Eugen __

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-27 Thread Nicolas George
Yufei He (12019-03-27): > Here is the fixed patch for a new H.264 codec with Matrox M264 card. > > It calls the default library from the card's driver installation. > Please review. You are still using programmatic dynamic linking instead of normal dynamic linking, and you have not given a good r

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-17 Thread Tomas Härdin
fre 2019-03-15 klockan 18:45 +0100 skrev Nicolas George: > Yufei He (12019-03-15): > > I did not find a better way to make this work. > > It exists: make your client libraries GPL-compatible. I second this /Tomas ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-15 Thread Michael Niedermayer
On Thu, Mar 14, 2019 at 05:55:41PM +, Yufei He wrote: > Hi > > Here is the patch for a new H.264 codec with Matrox m264 card. > > Please review. > > Thanks. > > Yufei. > > > Changelog |1 > configure |2 > libavcodec/Makefile |2 > libavcod

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-15 Thread Marton Balint
On Fri, 15 Mar 2019, Ronald S. Bultje wrote: Hi guys, On Thu, Mar 14, 2019 at 1:55 PM Yufei He wrote: Hi Here is the patch for a new H.264 codec with Matrox m264 card. I want to bring up again that this library is closed-source. I don't think FFmpeg should link to closed-source softwar

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-15 Thread Ronald S. Bultje
Hi, On Fri, Mar 15, 2019 at 2:19 PM BIGLER Don (Framatome) < don.big...@framatome.com> wrote: > >Yufei He (12019-03-15): > >> I did not find a better way to make this work. > > >It exists: make your client libraries GPL-compatible. > > Or alternatively creating open-source headers that allow the

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-15 Thread BIGLER Don (Framatome)
>Yufei He (12019-03-15): >> I did not find a better way to make this work. >It exists: make your client libraries GPL-compatible. Or alternatively creating open-source headers that allow the m264 drivers to be used similar to NVidia's Video Codec SDK: https://github.com/FFmpeg/nv-codec-headers h

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-15 Thread Nicolas George
Yufei He (12019-03-15): > I did not find a better way to make this work. It exists: make your client libraries GPL-compatible. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-15 Thread Yufei He
Hi Jean-Baptiste Sorry for the complexity and confusion to so many people involved on this new patch. We have been working on this for 4 months because some of our big customers on internet business have been asking Matrox to make our M264 card to support FFmpeg on h.264 transcoding, esp on 4k

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-15 Thread Jean-Baptiste Kempf
On Fri, 15 Mar 2019, at 15:02, Tomas Härdin wrote: > > +#ifdef _WIN32 > > +lib_handle = dlopen("mvM264Ffmpeg.dll", RTLD_LAZY); > > +#else    > > +lib_handle = dlopen("libmvM264Ffmpeg.so", RTLD_LAZY); > > +#endif > > Still dlopen() I see. You should link to these libraries prope

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-15 Thread Ronald S. Bultje
Hi guys, On Thu, Mar 14, 2019 at 1:55 PM Yufei He wrote: > Hi > > Here is the patch for a new H.264 codec with Matrox m264 card. > I want to bring up again that this library is closed-source. I don't think FFmpeg should link to closed-source software in its public mainline version. Matrox is ob

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-15 Thread Tomas Härdin
tor 2019-03-14 klockan 17:55 + skrev Yufei He: > Hi > > Here is the patch for a new H.264 codec with Matrox m264 card. > > Please review. > --- a/libavcodec/codec_desc.c > +++ b/libavcodec/codec_desc.c > @@ -1705,7 +1705,6 @@ static const AVCodecDescriptor > codec_descriptors[] = { >    

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-03-11 Thread Michael Niedermayer
On Mon, Mar 11, 2019 at 01:28:18PM -0400, Ronald S. Bultje wrote: > Hi, > > On Mon, Mar 11, 2019 at 12:21 PM Soft Works wrote: > > > > From: Nicolas George > > > > > > Yufei He (12019-03-11): > > > > Matrox M264 is similar to other hardware codecs. > > > > > > > > I saw amf_load_library and nven

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-03-11 Thread Ronald S. Bultje
Hi, On Mon, Mar 11, 2019 at 12:21 PM Soft Works wrote: > > From: Nicolas George > > > > Yufei He (12019-03-11): > > > Matrox M264 is similar to other hardware codecs. > > > > > > I saw amf_load_library and nvenc_load_library in ffmpeg. > > > > Past practices do not constitute precedents. > > > >

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-03-11 Thread Jean-Baptiste Kempf
On Mon, 11 Mar 2019, at 17:46, Soft Works wrote: > I still wonder why recent discussions are often referring to GPL even > though ffmpeg is released under LGPL. Because LGPL is a derivative of the GPL, unfortunately. And there are a lot more jurisprudence on the GPL, than on the LGPL. And LGPL ha

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-03-11 Thread Soft Works
> From: Jean-Baptiste Kempf > > On Mon, 11 Mar 2019, at 17:21, Soft Works wrote: > > While I don’t care much about Matrox, I’m a bit surprised about the > > recent sounds here. Should we expect ffmpeg to drop most hw > > accelerations, then? > > Absolutely not. I very glad to hear that :-) > > I

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-03-11 Thread Jean-Baptiste Kempf
On Mon, 11 Mar 2019, at 17:21, Soft Works wrote: > While I don’t care much about Matrox, I’m a bit surprised about the > recent sounds here. Should we expect ffmpeg to drop most hw > accelerations, then? Absolutely not. > IANAL, but aren’t drivers clearly considered to be system components? Sur

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-03-11 Thread Soft Works
> From: Nicolas George > > Yufei He (12019-03-11): > > Matrox M264 is similar to other hardware codecs. > > > > I saw amf_load_library and nvenc_load_library in ffmpeg. > > Past practices do not constitute precedents. > > > We got a lot customers using ffmpeg and they want to use Matrox M264 to do

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-03-11 Thread Nicolas George
Yufei He (12019-03-11): > Matrox M264 is similar to other hardware codecs. > > I saw amf_load_library and nvenc_load_library in ffmpeg. Past practices do not constitute precedents. > We got a lot customers using ffmpeg and they want to use Matrox M264 to do > transcoding. If you make the drive

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-03-11 Thread Yufei He
Hi Carl Matrox M264 is similar to other hardware codecs. I saw amf_load_library and nvenc_load_library in ffmpeg. Matrox M264 is the same. We got a lot customers using ffmpeg and they want to use Matrox M264 to do transcoding. Thanks a lot. Yufei. static int amf_load_library(AVCodecContext

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-03-11 Thread Carl Eugen Hoyos
2019-03-11 11:57 GMT+01:00, Ronald S. Bultje : > - How do we set up a fate station with m264 support? We do not test any external libraries with fate. [...] > - How do we test that it still works after we make innocent > changes to some API? Same as so far: We remove the feature that isn't upd

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-03-11 Thread Ronald S. Bultje
Hi, On Mon, Mar 11, 2019 at 4:53 AM Moritz Barsnick wrote: > On Mon, Mar 11, 2019 at 01:59:47 +0100, Carl Eugen Hoyos wrote: > > The library needs non-free in configure and please > > use dynamic linking, not loading at run-time. > > There is also no indication whatsoever where to get mvM264Ffmp

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-03-11 Thread Moritz Barsnick
On Mon, Mar 11, 2019 at 01:59:47 +0100, Carl Eugen Hoyos wrote: > The library needs non-free in configure and please > use dynamic linking, not loading at run-time. There is also no indication whatsoever where to get mvM264Ffmpeg.dll and libmvM264Ffmpeg.so from. No-one can even attempt to run (or

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-03-10 Thread Carl Eugen Hoyos
2019-02-25 21:41 GMT+01:00, Yufei He : > Please review this one. The library needs non-free in configure and please use dynamic linking, not loading at run-time. Please find out what top-posting means and avoid it here, Carl Eugen ___ ffmpeg-devel mail

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-02-26 Thread Tomas Härdin
tis 2019-02-26 klockan 14:26 + skrev Yufei He: > Hi Tomas > > Thanks for the review. > > My codec is a hardware codec, it depends an dynamic library that goes  > with the M264 card. > > The way it works will be: > > 1>Our customers buy the card and install the drivers of it. > > 2>They Com

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-02-26 Thread Nicolas George
Yufei He (12019-02-26): > My codec is a hardware codec, it depends an dynamic library that goes > with the M264 card. > > The way it works will be: > > 1>Our customers buy the card and install the drivers of it. > > 2>They Compile ffmpeg. > > 3>Call ffmpeg with codec option of m264. > > That'

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-02-26 Thread Yufei He
Hi Moritz It's the first time that I send patch to ffmpeg, for sure I don't know a lot of things for ffmpeg. Thanks a lot for your detailed review. I'll read the doc and fix the issues you said. Yufei. On 02/25/2019 04:21 PM, Moritz Barsnick wrote: > Hi Yufei, > before providing large patche

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-02-26 Thread Yufei He
Hi Tomas Thanks for the review. My codec is a hardware codec, it depends an dynamic library that goes with the M264 card. The way it works will be: 1>Our customers buy the card and install the drivers of it. 2>They Compile ffmpeg. 3>Call ffmpeg with codec option of m264. That's why I use dl

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-02-25 Thread Moritz Barsnick
Hi Yufei, before providing large patches here, do read this mailing list and the ffmpeg codebase for a while. It will help you to understand the process, and to understand how ffmpeg's sources are organized. I'm sure you missed this: https://www.ffmpeg.org/developer.html Read all of it thoroughly

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-02-25 Thread Tomas Härdin
Hi > +void convert_to_annexb(unsigned char * dest, unsigned long > data_size) > +{ > + unsigned char *current = dest; > + union > + { > + unsigned char by4[4]; > + uint32_t length; > + } union_u32_byte; > + > + while ((dest + data_size) > (current + 4)) > + { > + if((

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-02-25 Thread Nicolas George
Yufei He (12019-02-25): > From 7dd17409a22858f3c18d832c301fb904508dea3b Mon Sep 17 00:00:00 2001 > From: yhe > Date: Mon, 25 Feb 2019 14:38:21 -0500 > Subject: [PATCH] M264 codec support Quick comments. They are in no way to be taken as any kind of endorsement for the patch. > > --- > .vscode