Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-18 Thread Andreas Rheinhardt
Martin Storsjö: > On Sun, 17 Mar 2024, Rémi Denis-Courmont wrote: > >> Obviously not. Imported libraries are only there to resolve missing >> symbols. > > Sure - but if resolving the missing symbols brings in those conflicting > object files, there's not much to do about it. If the static library

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-18 Thread Martin Storsjö
On Sun, 17 Mar 2024, Rémi Denis-Courmont wrote: Obviously not. Imported libraries are only there to resolve missing symbols. Sure - but if resolving the missing symbols brings in those conflicting object files, there's not much to do about it. If the static library contains dec_init in a sta

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-17 Thread Rémi Denis-Courmont
Le 17 mars 2024 18:21:23 GMT-07:00, Timo Rothenpieler a écrit : >On 18.03.2024 01:32, Rémi Denis-Courmont wrote: >> >> >> Le 17 mars 2024 14:13:18 GMT-07:00, Timo Rothenpieler >> a écrit : >>> On 17.03.2024 18:37, Rémi Denis-Courmont wrote: Le 17 mars 2024 10:29:39 GMT-07:0

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-17 Thread Timo Rothenpieler
On 18.03.2024 01:32, Rémi Denis-Courmont wrote: Le 17 mars 2024 14:13:18 GMT-07:00, Timo Rothenpieler a écrit : On 17.03.2024 18:37, Rémi Denis-Courmont wrote: Le 17 mars 2024 10:29:39 GMT-07:00, Andreas Rheinhardt a écrit : Rémi Denis-Courmont: Le 16 mars 2024 13:58:23 GMT-07:00, J

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-17 Thread Rémi Denis-Courmont
Le 17 mars 2024 14:13:18 GMT-07:00, Timo Rothenpieler a écrit : >On 17.03.2024 18:37, Rémi Denis-Courmont wrote: >> >> >> Le 17 mars 2024 10:29:39 GMT-07:00, Andreas Rheinhardt >> a écrit : >>> Rémi Denis-Courmont: Le 16 mars 2024 13:58:23 GMT-07:00, James Almer a éc

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-17 Thread Helmut K. C. Tessarek
I fixed it on my dev machine by renaming the function in libbluray and creating a new lib. I still think that this is a temporary hack and should be fixed properly. I've opened an issue with libbluray, so I hope that I'll get a reply at one point. I'm still not entirely sure who actually has

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-17 Thread Timo Rothenpieler
On 17.03.2024 18:37, Rémi Denis-Courmont wrote: Le 17 mars 2024 10:29:39 GMT-07:00, Andreas Rheinhardt a écrit : Rémi Denis-Courmont: Le 16 mars 2024 13:58:23 GMT-07:00, James Almer a écrit : Seems the conflict comes from https://code.videolan.org/videolan/libbluray/-/blob/master/src/li

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-17 Thread Helmut K. C. Tessarek
On 2024-03-17 08:10, Timo Rothenpieler wrote It only breaks when statically linking. The symbol is not exported by libbr. In this case the only fix is to use a prefix in libbr, and who knows whether they will do that. I opened an issue with them but haven't received a reply yet. Just rename

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-17 Thread Rémi Denis-Courmont
Le 17 mars 2024 10:29:39 GMT-07:00, Andreas Rheinhardt a écrit : >Rémi Denis-Courmont: >> >> >> Le 16 mars 2024 13:58:23 GMT-07:00, James Almer a écrit : Seems the conflict comes from https://code.videolan.org/videolan/libbluray/-/blob/master/src/libbluray/disc/dec.c?ref_type=heads

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-17 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > > > Le 16 mars 2024 13:58:23 GMT-07:00, James Almer a écrit : >>> Seems the conflict comes from >>> https://code.videolan.org/videolan/libbluray/-/blob/master/src/libbluray/disc/dec.c?ref_type=heads#L287 >>> and >>> https://github.com/FFmpeg/FFmpeg/commit/c4de5778bceab3c

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-17 Thread Rémi Denis-Courmont
Le 16 mars 2024 13:58:23 GMT-07:00, James Almer a écrit : >> Seems the conflict comes from >> https://code.videolan.org/videolan/libbluray/-/blob/master/src/libbluray/disc/dec.c?ref_type=heads#L287 >> and >> https://github.com/FFmpeg/FFmpeg/commit/c4de5778bceab3c15f1239f1f16816749a7fd3b6 >> >

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-17 Thread Timo Rothenpieler
On 17.03.2024 09:05, Gnattu OC via ffmpeg-devel wrote: Can you try to change the `BD_PRIVATE` to `__attribute__((visibility("hidden")))` in the line defines `dec_init` src/libbluray/disc/dec.h then recompile libbluray to see if it fixes the linking issue? It only breaks when statically linkin

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-17 Thread Gnattu OC via ffmpeg-devel
Can you try to change the `BD_PRIVATE` to `__attribute__((visibility("hidden")))` in the line defines `dec_init` src/libbluray/disc/dec.h then recompile libbluray to see if it fixes the linking issue? > On Mar 17, 2024, at 05:09, Helmut K. C. Tessarek wrote: > > Hi, > > On 2024-03-16 10:26,

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-16 Thread Helmut K. C. Tessarek
Hi, On 2024-03-16 10:26, Christopher Degawa wrote: Seems the conflict comes from https://code.videolan.org/videolan/libbluray/-/blob/master/src/libbluray/disc/dec.c?ref_type=heads#L287 and https://github.com/FFmpeg/FFmpeg/commit/c4de5778bceab3c15f1239f1f16816749a7fd3b6 Perhaps you could also

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-16 Thread James Almer
On 3/16/2024 11:26 AM, Christopher Degawa wrote: On Sat, Mar 16, 2024 at 09:08 Gnattu OC via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: If you are using Xcode >= 15 then you will need to add `-Wl,-ld_classic` to LDFLAGS. During configure you will also need to set `--host-ldflags='-Wl,-ld_c

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-16 Thread Helmut K. C. Tessarek
Hello, On 2024-03-16 10:07, Gnattu OC via ffmpeg-devel wrote: If you are using Xcode >= 15 then you will need to add `-Wl,-ld_classic` to LDFLAGS. I've already been using it since I switched to Xcode 15. Cheers, K. C. -- regards Helmut K. C. Tessarek KeyID 0x172380A011EF4944

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-16 Thread Christopher Degawa
On Sat, Mar 16, 2024 at 09:08 Gnattu OC via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > If you are using Xcode >= 15 then you will need to add `-Wl,-ld_classic` > to LDFLAGS. During configure you will also need to set > `--host-ldflags='-Wl,-ld_classic’`. > > > On Mar 16, 2024, at 09:04, Hel

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-16 Thread Gnattu OC via ffmpeg-devel
If you are using Xcode >= 15 then you will need to add `-Wl,-ld_classic` to LDFLAGS. During configure you will also need to set `--host-ldflags='-Wl,-ld_classic’`. > On Mar 16, 2024, at 09:04, Helmut K. C. Tessarek wrote: > > Hello, > > It's me again - the dude who compiles ffmpeg for macOS.